Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: buildroot@buildroot.org, Andy Yan <andyshrk@163.com>,
	Andy Yan <andyshrk@gmail.com>
Subject: Re: [Buildroot] [PATCH v2 1/1] package: Add iotools package
Date: Sat, 26 Oct 2024 14:47:48 +0200	[thread overview]
Message-ID: <20241026144748.09d6b892@windsurf> (raw)
In-Reply-To: <20240927183553.2866682-1-andriy.shevchenko@linux.intel.com>

On Fri, 27 Sep 2024 21:34:59 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> The iotools package provides a set of simple command line tools which
> allow access to hardware device registers. Supported register interfaces
> include PCI, IO, memory mapped IO, SMBus, CPUID, and MSR. Also included
> are some utilities which allow for simple arithmetic, logical, and other
> operations.
> 
> If you ever have to debug hardware, you could probably use these tools.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---

Applied to master after doing some tweaks:

- Used STATIC=1/STATIC=0 to achieve the proper behavior with regard to
  BR2_STATIC_LIBS

- Use the canonical $(INSTALL) incantation for the installation step

One thing that isn't super nice is your handling of the DEBUG variable.
Ideally in Buildroot we would want neither DEBUG=0 nor DEBUG=1, but
"don't do anything and let Buildroot pass the CFLAGS it wants".

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2024-10-26 12:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27 18:34 [Buildroot] [PATCH v2 1/1] package: Add iotools package Andy Shevchenko
2024-09-28  9:10 ` Andy Yan
2024-09-30 17:36   ` Andy Shevchenko
2024-10-14 15:38 ` Andy Shevchenko
2024-10-14 17:00   ` Aaron Sierra
2024-10-16 13:54     ` Andy Shevchenko
2024-10-26 12:47 ` Thomas Petazzoni via buildroot [this message]
2024-10-28  7:57   ` Andy Shevchenko
2024-10-28  8:26     ` Thomas Petazzoni via buildroot
2024-10-31 17:25       ` Andy Shevchenko
2024-10-31 17:33         ` Thomas Petazzoni via buildroot
  -- strict thread matches above, loose matches on Subject: below --
2024-10-14 17:55 Vincent Fazio
2024-10-16 13:52 ` Andy Shevchenko
     [not found]   ` <1929b27b55e.1242e8abc627480.7414881916261699452@bubbl-tek.com>
2024-10-18 11:52     ` Andy Shevchenko
2024-10-18 11:54       ` Andy Shevchenko
2024-10-21 15:59       ` Aaron Sierra
2024-10-24 20:30         ` Aaron Sierra
2024-10-31 17:25           ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241026144748.09d6b892@windsurf \
    --to=buildroot@buildroot.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andyshrk@163.com \
    --cc=andyshrk@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox