Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Aaron Sierra <aaron@bubbl-tek.com>
Cc: Vincent Fazio <vfazio@xes-inc.com>, Andy Yan <andyshrk@163.com>,
	buildroot <buildroot@buildroot.org>,
	Andy Yan <andyshrk@gmail.com>
Subject: Re: [Buildroot] [PATCH v2 1/1] package: Add iotools package
Date: Thu, 31 Oct 2024 19:25:57 +0200	[thread overview]
Message-ID: <ZyO9pdGiQ8Wpvscb@smile.fi.intel.com> (raw)
In-Reply-To: <192c0393182.d05ea8bb202213.1651339018002716691@bubbl-tek.com>

On Thu, Oct 24, 2024 at 03:30:26PM -0500, Aaron Sierra wrote:
> > On Mon, 21 Oct 2024 10:59:13 -0500 Aaron Sierra  wrote:
> >
>  > Be on the lookout for contributions to your repository that address my remaining concerns. 
> 
> I've posted a pull request to your Github repo, https://github.com/andy-shev/iotools/pull/5,
> that expands the runtime (and project) documentation, while adding support for symlink
> installation in a cross-build environment.

Thank you!
I just reviewed it, in general looks very good. Only few comments to address.

-- 
With Best Regards,
Andy Shevchenko


_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-10-31 17:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-14 17:55 [Buildroot] [PATCH v2 1/1] package: Add iotools package Vincent Fazio
2024-10-16 13:52 ` Andy Shevchenko
     [not found]   ` <1929b27b55e.1242e8abc627480.7414881916261699452@bubbl-tek.com>
2024-10-18 11:52     ` Andy Shevchenko
2024-10-18 11:54       ` Andy Shevchenko
2024-10-21 15:59       ` Aaron Sierra
2024-10-24 20:30         ` Aaron Sierra
2024-10-31 17:25           ` Andy Shevchenko [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-09-27 18:34 Andy Shevchenko
2024-09-28  9:10 ` Andy Yan
2024-09-30 17:36   ` Andy Shevchenko
2024-10-14 15:38 ` Andy Shevchenko
2024-10-14 17:00   ` Aaron Sierra
2024-10-16 13:54     ` Andy Shevchenko
2024-10-26 12:47 ` Thomas Petazzoni via buildroot
2024-10-28  7:57   ` Andy Shevchenko
2024-10-28  8:26     ` Thomas Petazzoni via buildroot
2024-10-31 17:25       ` Andy Shevchenko
2024-10-31 17:33         ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZyO9pdGiQ8Wpvscb@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=aaron@bubbl-tek.com \
    --cc=andyshrk@163.com \
    --cc=andyshrk@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=vfazio@xes-inc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox