Re: [Buildroot] [PATCH v2 1/1] package: Add iotools package

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Mon, Oct 14, 2024 at 05:55:46PM +0000, Vincent Fazio wrote:
> Aaron, Andy,
> > From: buildroot <buildroot-bounces@buildroot.org> On Behalf Of Aaron
> > Sierra
> > Sent: Monday, October 14, 2024 12:01 PM
> > ---- On Mon, 14 Oct 2024 10:38:22 -0500 Andy Shevchenko  wrote ---
> > Can this be pulled eventually? Or is there any comment I have to address?

> > 2. It would be nice if the package populated command symlinks in the target
> > filesystem. That could be done in a number of way, like using an explicit list of
> > commands maintained in the package Makefile (iotools.mk) or adding a host-
> > build dependency and leveraging the --list-cmds output to get the list of
> > embedded commands for linking.
> 
> Caveat lector, I have not reviewed your patch or the sources in a while.
> 
> WRT to this comment, I have this note from when we ported it:
> 
> # we can't run make install because the symlink installation executes the binary
> # which isn't guaranteed to work in cross-compile scenarios
> define IOTOOLS_INSTALL_TARGET_CMDS
>     $(INSTALL) -D -m 0755 $(@D)/iotools $(TARGET_DIR)/usr/sbin/
> 
>     for link in $( IOTOOLS_LINKS); do \
>         ln -sf iotools $(TARGET_DIR)/usr/sbin/$$link; \
>     done
> endef
> 
> We then earlier in the mk file define the tools per platform, akin to:

I deliberately won't populate those links. The naming is so generic
that it's a real chance to get a collision with all pain of splitting it
in the configuration what links we create and what not and what to do
with those that may collide.

TL;DR: no, I don't think it's a good idea.

-- 
With Best Regards,
Andy Shevchenko


_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot