Re: [Buildroot] [PATCH 1/1] package/sane-airscan: add new package.

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Guillaume,

I have applied your patch, after doing a few fixes. See below.

On Tue, 25 Mar 2025 09:11:36 -0400
Guillaume Chaye <guillaume.chaye@zeetim.com> wrote:

> Signed-off-by: Guillaume Chaye <guillaume.chaye@zeetim.com>

First, I have changed the commit title to:

	package/sane-airscan: new package

which is our canonical commit title when new packages are introduced.
Also no final dot at the end of the commit title.


> diff --git a/package/sane-airscan/Config.in b/package/sane-airscan/Config.in
> new file mode 100644
> index 0000000000..4f4a0ac7cc
> --- /dev/null
> +++ b/package/sane-airscan/Config.in
> @@ -0,0 +1,20 @@
> +config BR2_PACKAGE_SANE_AIRSCAN
> +	bool "sane-airscan"
> +	select BR2_PACKAGE_DBUS
> +	select BR2_PACKAGE_SANE_BACKENDS
> +	select BR2_PACKAGE_AVAHI
> +	select BR2_PACKAGE_GNUTLS
> +	select BR2_PACKAGE_LIBXML2
> +	select BR2_PACKAGE_JPEG
> +	select BR2_PACKAGE_LIBPNG
> +	select BR2_PACKAGE_TIFF

I've sorted alphabetically. Also, I added a comment on dbus dependency,
because it wasn't clear why it was needed, and I selected
BR2_PACKAGE_AVAHI_DAEMON which is needed to get the avahi-client
library, which in turn is a requirement for sane-airscan.

> +
> +	help
> +	  SANE backend for AirScan (eSCL) and WSD document scanners
> +
> +	  https://github.com/alexpevzner/sane-airscan

This URL should be the last line of the help text, so I fixed that.

> +
> +	  Similar to how most modern network printers support
> +	  "driverless" printing, using the universal vendor-neutral
> +	  printing protocol, many modern network scanners and MFPs
> +	  support "driverless" scanning.
> diff --git a/package/sane-airscan/sane-airscan.mk b/package/sane-airscan/sane-airscan.mk
> new file mode 100644
> index 0000000000..d5d86d9145
> --- /dev/null
> +++ b/package/sane-airscan/sane-airscan.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# sane-airscan
> +#
> +################################################################################
> +
> +SANE_AIRSCAN_VERSION = 0.99.33
> +SANE_AIRSCAN_SITE = $(call github,alexpevzner,sane-airscan,$(SANE_AIRSCAN_VERSION))
> +SANE_AIRSCAN_DEPENDENCIES=  dbus sane-backends avahi gnutls libxml2 jpeg libpng tiff

I sorted this alphabetically, and dropped dbus, which isn't a build
time dependency of sane-airscan. Enabling dbus is needed to get avahi
to build avahi-client, but that's avahi's business.

> +SANE_AIRSCAN_LICENSE = GPLv2

GPLv2 isn't a valid license code in Buildroot, it's GPL-2.0. But the
license is actually GPL-2.0+, and with some exception, so I changed to:

SANE_AIRSCAN_LICENSE = GPL-2.0+-with-exception

and applied. Thanks for your contribution!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot