Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/sane-airscan: add new package.
@ 2025-03-25 13:11 Guillaume Chaye
  2025-04-23 20:50 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 2+ messages in thread
From: Guillaume Chaye @ 2025-03-25 13:11 UTC (permalink / raw)
  To: buildroot; +Cc: Eric Le Bihan, Julien Olivain, Guillaume Chaye

Signed-off-by: Guillaume Chaye <guillaume.chaye@zeetim.com>
---
 DEVELOPERS                             |  3 +++
 package/Config.in                      |  1 +
 package/sane-airscan/Config.in         | 20 ++++++++++++++++++++
 package/sane-airscan/sane-airscan.hash |  3 +++
 package/sane-airscan/sane-airscan.mk   | 13 +++++++++++++
 5 files changed, 40 insertions(+)
 create mode 100644 package/sane-airscan/Config.in
 create mode 100644 package/sane-airscan/sane-airscan.hash
 create mode 100644 package/sane-airscan/sane-airscan.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index c080608bcf..cdf6aff997 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1354,6 +1354,9 @@ F:	package/python-rpi-ws281x/
 F:	package/python-wtforms/
 F:	package/rpi-rgb-led-matrix/
 
+N:	Guillaume Chaye
+F:	package/sane-airscan/
+
 N:	Guillaume William Brs <guillaume.bressaix@gmail.com>
 F:	package/libnids/
 F:	package/libxcrypt/
diff --git a/package/Config.in b/package/Config.in
index d8751fc19f..21b38515a8 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -610,6 +610,7 @@ endmenu
 	source "package/rtl8821au/Config.in"
 	source "package/rtl8821cu/Config.in"
 	source "package/rtl8822cs/Config.in"
+	source "package/sane-airscan/Config.in"
 	source "package/sane-backends/Config.in"
 	source "package/sdparm/Config.in"
 	source "package/sedutil/Config.in"
diff --git a/package/sane-airscan/Config.in b/package/sane-airscan/Config.in
new file mode 100644
index 0000000000..4f4a0ac7cc
--- /dev/null
+++ b/package/sane-airscan/Config.in
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_SANE_AIRSCAN
+	bool "sane-airscan"
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_SANE_BACKENDS
+	select BR2_PACKAGE_AVAHI
+	select BR2_PACKAGE_GNUTLS
+	select BR2_PACKAGE_LIBXML2
+	select BR2_PACKAGE_JPEG
+	select BR2_PACKAGE_LIBPNG
+	select BR2_PACKAGE_TIFF
+
+	help
+	  SANE backend for AirScan (eSCL) and WSD document scanners
+
+	  https://github.com/alexpevzner/sane-airscan
+
+	  Similar to how most modern network printers support
+	  "driverless" printing, using the universal vendor-neutral
+	  printing protocol, many modern network scanners and MFPs
+	  support "driverless" scanning.
diff --git a/package/sane-airscan/sane-airscan.hash b/package/sane-airscan/sane-airscan.hash
new file mode 100644
index 0000000000..40fb84e32d
--- /dev/null
+++ b/package/sane-airscan/sane-airscan.hash
@@ -0,0 +1,3 @@
+# Locally computed
+sha256  647f41f84f9bce743c796ca84c1fda67e519968fab407490c28fd0cc6d7ac485  sane-airscan-0.99.33.tar.gz
+sha256  a2631c1b81992bd6f66db6be8b009ed7e3e998d1e2db4de497fa82d65011d373  LICENSE
diff --git a/package/sane-airscan/sane-airscan.mk b/package/sane-airscan/sane-airscan.mk
new file mode 100644
index 0000000000..d5d86d9145
--- /dev/null
+++ b/package/sane-airscan/sane-airscan.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# sane-airscan
+#
+################################################################################
+
+SANE_AIRSCAN_VERSION = 0.99.33
+SANE_AIRSCAN_SITE = $(call github,alexpevzner,sane-airscan,$(SANE_AIRSCAN_VERSION))
+SANE_AIRSCAN_DEPENDENCIES=  dbus sane-backends avahi gnutls libxml2 jpeg libpng tiff
+SANE_AIRSCAN_LICENSE = GPLv2
+SANE_AIRSCAN_LICENSE_FILES = LICENSE
+
+$(eval $(meson-package))
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/sane-airscan: add new package.
  2025-03-25 13:11 [Buildroot] [PATCH 1/1] package/sane-airscan: add new package Guillaume Chaye
@ 2025-04-23 20:50 ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-04-23 20:50 UTC (permalink / raw)
  To: Guillaume Chaye; +Cc: buildroot, Eric Le Bihan, Julien Olivain

Hello Guillaume,

I have applied your patch, after doing a few fixes. See below.

On Tue, 25 Mar 2025 09:11:36 -0400
Guillaume Chaye <guillaume.chaye@zeetim.com> wrote:

> Signed-off-by: Guillaume Chaye <guillaume.chaye@zeetim.com>

First, I have changed the commit title to:

	package/sane-airscan: new package

which is our canonical commit title when new packages are introduced.
Also no final dot at the end of the commit title.


> diff --git a/package/sane-airscan/Config.in b/package/sane-airscan/Config.in
> new file mode 100644
> index 0000000000..4f4a0ac7cc
> --- /dev/null
> +++ b/package/sane-airscan/Config.in
> @@ -0,0 +1,20 @@
> +config BR2_PACKAGE_SANE_AIRSCAN
> +	bool "sane-airscan"
> +	select BR2_PACKAGE_DBUS
> +	select BR2_PACKAGE_SANE_BACKENDS
> +	select BR2_PACKAGE_AVAHI
> +	select BR2_PACKAGE_GNUTLS
> +	select BR2_PACKAGE_LIBXML2
> +	select BR2_PACKAGE_JPEG
> +	select BR2_PACKAGE_LIBPNG
> +	select BR2_PACKAGE_TIFF

I've sorted alphabetically. Also, I added a comment on dbus dependency,
because it wasn't clear why it was needed, and I selected
BR2_PACKAGE_AVAHI_DAEMON which is needed to get the avahi-client
library, which in turn is a requirement for sane-airscan.

> +
> +	help
> +	  SANE backend for AirScan (eSCL) and WSD document scanners
> +
> +	  https://github.com/alexpevzner/sane-airscan

This URL should be the last line of the help text, so I fixed that.

> +
> +	  Similar to how most modern network printers support
> +	  "driverless" printing, using the universal vendor-neutral
> +	  printing protocol, many modern network scanners and MFPs
> +	  support "driverless" scanning.
> diff --git a/package/sane-airscan/sane-airscan.mk b/package/sane-airscan/sane-airscan.mk
> new file mode 100644
> index 0000000000..d5d86d9145
> --- /dev/null
> +++ b/package/sane-airscan/sane-airscan.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# sane-airscan
> +#
> +################################################################################
> +
> +SANE_AIRSCAN_VERSION = 0.99.33
> +SANE_AIRSCAN_SITE = $(call github,alexpevzner,sane-airscan,$(SANE_AIRSCAN_VERSION))
> +SANE_AIRSCAN_DEPENDENCIES=  dbus sane-backends avahi gnutls libxml2 jpeg libpng tiff

I sorted this alphabetically, and dropped dbus, which isn't a build
time dependency of sane-airscan. Enabling dbus is needed to get avahi
to build avahi-client, but that's avahi's business.

> +SANE_AIRSCAN_LICENSE = GPLv2

GPLv2 isn't a valid license code in Buildroot, it's GPL-2.0. But the
license is actually GPL-2.0+, and with some exception, so I changed to:

SANE_AIRSCAN_LICENSE = GPL-2.0+-with-exception

and applied. Thanks for your contribution!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-04-23 20:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-25 13:11 [Buildroot] [PATCH 1/1] package/sane-airscan: add new package Guillaume Chaye
2025-04-23 20:50 ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox