* [Buildroot] [PATCH v4 2/4] boot/xilinx-prebuilt: add segmented config support
2025-05-19 8:36 [Buildroot] [PATCH v4 1/4] boot/xilinx-prebuilt: change versal pdi file permissions Neal Frager via buildroot
@ 2025-05-19 8:36 ` Neal Frager via buildroot
2025-05-19 8:36 ` [Buildroot] [PATCH v4 3/4] board/versal: change pdi filename to boot.pdi Neal Frager via buildroot
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Neal Frager via buildroot @ 2025-05-19 8:36 UTC (permalink / raw)
To: buildroot
Cc: ibai.erkiaga-elorza, luca.ceresoli, brandon.maier, ju.o,
thomas.petazzoni, Neal Frager, fabio.caccamo, romain.naour,
michal.simek, arnout
AMD has created a new segmented configuration for Versal products. It splits
the Vivado hardware design into two PDI files, one containing the minimal
required configuration for the DDR and booting the processors, and a second PDI
file which contains the rest of the FPGA design and can be loaded at run-time
via U-boot or Linux.
The file names generated when using the Vivado Segmented Configuration are as
follows:
<design>_boot.pdi - Minimal DDR and PS config for booting
<design>_pld.pdi - Remainder of FPGA design to be loaded at run-time
Since two PDI files will be included in the XSA file when using Segmented
Configuration, the xilinx-prebuilt package needs to be updated to support
this feature.
For Buildroot purposes, the <design>_boot.pdi is the file that needs to be
included in the boot.bin for booting the processors, so this patch checks
for a file named *boot*.pdi which will indicate that Segmented Configuration
is being used and will make sure to use the <design>_boot.pdi file and not
the <design>_pld.pdi file when generating the boot.bin image.
If no pdi files contain the word "boot" in the filename, it can be assumed
that Segmented Configuration is not being used, so the single file *.pdi
method is the appropriate one for this case, and this patch is thus
backwards compatible with prior designs not using Segmented Configuration.
Also, Segmented Configuration is going to become the default mode for Versal
products, so the xilinx-prebuilt github location will also soon have two PDI
files for each board. For this reason, this patch is also handling Segmented
Configuration for files downloaded from the xilinx-prebuilt repo.
For further information about the AMD Segmented Configuration, please see the
github tutorial below.
https://github.com/Xilinx/Vivado-Design-Tutorials/tree/2024.2/Versal/Boot_and_Config/Segmented_Configuration
Signed-off-by: Neal Frager <neal.frager@amd.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
V1->V2:
- $(@D) is not available in time for wildcard evaluation outside of shell
script, so moved the wildcard functions into the install scripts
V2->V3:
- Moved if statement inside of $(INSTALL) commands to make the code easier
to read.
- Changed wildcards to more specific name "*_boot.pdi".
- Changed pdi file permissions to 0644.
V3->V4:
- No changes
---
boot/xilinx-prebuilt/xilinx-prebuilt.mk | 36 ++++++++++++++++++-------
1 file changed, 26 insertions(+), 10 deletions(-)
diff --git a/boot/xilinx-prebuilt/xilinx-prebuilt.mk b/boot/xilinx-prebuilt/xilinx-prebuilt.mk
index 72273f0d2f..4d1dfc5ca0 100644
--- a/boot/xilinx-prebuilt/xilinx-prebuilt.mk
+++ b/boot/xilinx-prebuilt/xilinx-prebuilt.mk
@@ -28,9 +28,6 @@ XILINX_PREBUILT_BOARD = $(call qstrip,$(BR2_TARGET_XILINX_PREBUILT_BOARD))
XILINX_PREBUILT_BOARD_DIR = $(@D)/$(XILINX_PREBUILT_BOARD)-$(XILINX_PREBUILT_FAMILY)
ifeq ($(BR2_TARGET_XILINX_PREBUILT_VERSAL),y)
-# We need the *.pdi glob, because the file has different names for the
-# different boards, but there is only one, and it has to be named
-# vpl_gen_fixed.pdi when installed.
ifeq ($(BR2_TARGET_XILINX_PREBUILT_VERSAL_XSA),y)
XILINX_PREBUILT_PLM = $(@D)/pdi_files/gen_files/plm.elf
# Unlike the psmfw.elf file for Xilinx development boards,
@@ -39,11 +36,33 @@ XILINX_PREBUILT_PLM = $(@D)/pdi_files/gen_files/plm.elf
# so to support current and future AMD Vivado versions, the filename
# psm*fw.elf is used.
XILINX_PREBUILT_PSMFW = $(@D)/pdi_files/static_files/psm*fw.elf
-XILINX_PREBUILT_PDI = $(@D)/*.pdi
+# We need the *.pdi glob, because the file has different names for the
+# different boards, and it has to be named vpl_gen_fixed.pdi when installed.
+# If Segmented Configuration is used, there will be two pdi files and we need
+# the file that has "_boot.pdi" in the filename.
+define XILINX_PREBUILT_INSTALL_VERSAL_XSA_BOOT_PDI
+ $(INSTALL) -D -m 0644 \
+ $(if $(wildcard $(@D)/*_boot.pdi), \
+ $(@D)/*_boot.pdi, \
+ $(@D)/*.pdi \
+ ) \
+ $(BINARIES_DIR)/vpl_gen_fixed.pdi
+endef
else # BR2_TARGET_XILINX_PREBUILT_VERSAL_XSA
XILINX_PREBUILT_PLM = $(XILINX_PREBUILT_BOARD_DIR)/plm.elf
XILINX_PREBUILT_PSMFW = $(XILINX_PREBUILT_BOARD_DIR)/psmfw.elf
-XILINX_PREBUILT_PDI = $(XILINX_PREBUILT_BOARD_DIR)/*.pdi
+# We need the *.pdi glob, because the file has different names for the
+# different boards, and it has to be named vpl_gen_fixed.pdi when installed.
+# If Segmented Configuration is used, there will be two pdi files and we need
+# the file that has "_boot.pdi" in the filename.
+define XILINX_PREBUILT_INSTALL_VERSAL_BOOT_PDI
+ $(INSTALL) -D -m 0644 \
+ $(if $(wildcard $(XILINX_PREBUILT_BOARD_DIR)/*_boot.pdi), \
+ $(XILINX_PREBUILT_BOARD_DIR)/*_boot.pdi, \
+ $(XILINX_PREBUILT_BOARD_DIR)/*.pdi \
+ ) \
+ $(BINARIES_DIR)/vpl_gen_fixed.pdi
+endef
endif # BR2_TARGET_XILINX_PREBUILT_VERSAL_XSA
ifneq ($(BR2_TARGET_XILINX_EMBEDDEDSW_VERSAL_PLM),y)
@@ -60,10 +79,6 @@ define XILINX_PREBUILT_INSTALL_VERSAL_PSMFW
endef
endif # !BR2_TARGET_XILINX_EMBEDDEDSW_VERSAL_PSMFW
-define XILINX_PREBUILT_INSTALL_VERSAL_PDI
- $(INSTALL) -D -m 0644 $(XILINX_PREBUILT_PDI) \
- $(BINARIES_DIR)/vpl_gen_fixed.pdi
-endef
else # BR2_TARGET_XILINX_PREBUILT_VERSAL
ifneq ($(BR2_TARGET_XILINX_EMBEDDEDSW_ZYNQMP_PMUFW),y)
define XILINX_PREBUILT_INSTALL_ZYNQMP_PMUFW
@@ -76,7 +91,8 @@ endif # BR2_TARGET_XILINX_PREBUILT_VERSAL
define XILINX_PREBUILT_INSTALL_IMAGES_CMDS
$(XILINX_PREBUILT_INSTALL_VERSAL_PLM)
$(XILINX_PREBUILT_INSTALL_VERSAL_PSMFW)
- $(XILINX_PREBUILT_INSTALL_VERSAL_PDI)
+ $(XILINX_PREBUILT_INSTALL_VERSAL_BOOT_PDI)
+ $(XILINX_PREBUILT_INSTALL_VERSAL_XSA_BOOT_PDI)
$(XILINX_PREBUILT_INSTALL_ZYNQMP_PMUFW)
endef
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Buildroot] [PATCH v4 3/4] board/versal: change pdi filename to boot.pdi
2025-05-19 8:36 [Buildroot] [PATCH v4 1/4] boot/xilinx-prebuilt: change versal pdi file permissions Neal Frager via buildroot
2025-05-19 8:36 ` [Buildroot] [PATCH v4 2/4] boot/xilinx-prebuilt: add segmented config support Neal Frager via buildroot
@ 2025-05-19 8:36 ` Neal Frager via buildroot
2025-05-19 8:36 ` [Buildroot] [PATCH v4 4/4] boot/xilinx-prebuilt: install pld.pdi to target Neal Frager via buildroot
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Neal Frager via buildroot @ 2025-05-19 8:36 UTC (permalink / raw)
To: buildroot
Cc: ibai.erkiaga-elorza, luca.ceresoli, brandon.maier, ju.o,
thomas.petazzoni, Neal Frager, fabio.caccamo, romain.naour,
michal.simek, arnout
With the Segmented Configuration, the Versal PDI files will have new names:
<design>_boot.pdi - Minimal DDR and PS config for booting
<design>_pld.pdi - Remainder of FPGA design to be loaded at run-time
Since this will be the new default, this patch aligns the Buildroot file
naming by replacing the obscure vpl_gen_fixed.pdi filename with a simpler
boot.pdi filename.
Signed-off-by: Neal Frager <neal.frager@amd.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
V1->V2:
- Rebased due to changes in first patch of series
V2->V3:
- Rebased due to changes in first patch of series
V3->V4:
- No changes
---
board/versal/post-image.sh | 2 +-
boot/xilinx-prebuilt/xilinx-prebuilt.mk | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/board/versal/post-image.sh b/board/versal/post-image.sh
index 22367d5028..b5ce2e3f0c 100755
--- a/board/versal/post-image.sh
+++ b/board/versal/post-image.sh
@@ -17,7 +17,7 @@ cat <<-__HEADER_EOF > "${BINARIES_DIR}/bootgen.bif"
the_ROM_image:
{
image {
- { type=bootimage, file=${BINARIES_DIR}/vpl_gen_fixed.pdi }
+ { type=bootimage, file=${BINARIES_DIR}/boot.pdi }
{ type=bootloader, file=${BINARIES_DIR}/plm.elf }
{ core=psm, file=${BINARIES_DIR}/psmfw.elf }
}
diff --git a/boot/xilinx-prebuilt/xilinx-prebuilt.mk b/boot/xilinx-prebuilt/xilinx-prebuilt.mk
index 4d1dfc5ca0..05dc9aebe8 100644
--- a/boot/xilinx-prebuilt/xilinx-prebuilt.mk
+++ b/boot/xilinx-prebuilt/xilinx-prebuilt.mk
@@ -37,7 +37,7 @@ XILINX_PREBUILT_PLM = $(@D)/pdi_files/gen_files/plm.elf
# psm*fw.elf is used.
XILINX_PREBUILT_PSMFW = $(@D)/pdi_files/static_files/psm*fw.elf
# We need the *.pdi glob, because the file has different names for the
-# different boards, and it has to be named vpl_gen_fixed.pdi when installed.
+# different boards, and it has to be named boot.pdi when installed.
# If Segmented Configuration is used, there will be two pdi files and we need
# the file that has "_boot.pdi" in the filename.
define XILINX_PREBUILT_INSTALL_VERSAL_XSA_BOOT_PDI
@@ -46,13 +46,13 @@ define XILINX_PREBUILT_INSTALL_VERSAL_XSA_BOOT_PDI
$(@D)/*_boot.pdi, \
$(@D)/*.pdi \
) \
- $(BINARIES_DIR)/vpl_gen_fixed.pdi
+ $(BINARIES_DIR)/boot.pdi
endef
else # BR2_TARGET_XILINX_PREBUILT_VERSAL_XSA
XILINX_PREBUILT_PLM = $(XILINX_PREBUILT_BOARD_DIR)/plm.elf
XILINX_PREBUILT_PSMFW = $(XILINX_PREBUILT_BOARD_DIR)/psmfw.elf
# We need the *.pdi glob, because the file has different names for the
-# different boards, and it has to be named vpl_gen_fixed.pdi when installed.
+# different boards, and it has to be named boot.pdi when installed.
# If Segmented Configuration is used, there will be two pdi files and we need
# the file that has "_boot.pdi" in the filename.
define XILINX_PREBUILT_INSTALL_VERSAL_BOOT_PDI
@@ -61,7 +61,7 @@ define XILINX_PREBUILT_INSTALL_VERSAL_BOOT_PDI
$(XILINX_PREBUILT_BOARD_DIR)/*_boot.pdi, \
$(XILINX_PREBUILT_BOARD_DIR)/*.pdi \
) \
- $(BINARIES_DIR)/vpl_gen_fixed.pdi
+ $(BINARIES_DIR)/boot.pdi
endef
endif # BR2_TARGET_XILINX_PREBUILT_VERSAL_XSA
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Buildroot] [PATCH v4 4/4] boot/xilinx-prebuilt: install pld.pdi to target
2025-05-19 8:36 [Buildroot] [PATCH v4 1/4] boot/xilinx-prebuilt: change versal pdi file permissions Neal Frager via buildroot
2025-05-19 8:36 ` [Buildroot] [PATCH v4 2/4] boot/xilinx-prebuilt: add segmented config support Neal Frager via buildroot
2025-05-19 8:36 ` [Buildroot] [PATCH v4 3/4] board/versal: change pdi filename to boot.pdi Neal Frager via buildroot
@ 2025-05-19 8:36 ` Neal Frager via buildroot
2025-05-19 15:39 ` Luca Ceresoli via buildroot
2025-05-19 15:41 ` [Buildroot] [PATCH v4 1/4] boot/xilinx-prebuilt: change versal pdi file permissions Luca Ceresoli via buildroot
2025-06-09 19:51 ` Julien Olivain
4 siblings, 1 reply; 8+ messages in thread
From: Neal Frager via buildroot @ 2025-05-19 8:36 UTC (permalink / raw)
To: buildroot
Cc: ibai.erkiaga-elorza, luca.ceresoli, brandon.maier, ju.o,
thomas.petazzoni, Neal Frager, fabio.caccamo, romain.naour,
michal.simek, arnout
With the Versal Segmented Configuration, it is possible to load a PL bitstream
at run-time using the Linux fpgautil application. Whenever Segmented
Configuration is used, both the boot.pdi and pld.pdi files will be available
to Buildroot. For this reason, this patch improves the user experience by
installing the pld.pdi file to the target file system for run-time loading
whenever Versal Segemented Configuration is used.
If the fpgautil application is available in the target file system, it can
be used for loading the pld.pdi using the target command below.
fpgautil -b /lib/firmware/xilinx/*_pld.pdi
The source code for the fpgautil application can be found here:
https://github.com/Xilinx/meta-xilinx/blob/master/meta-xilinx-core/recipes-bsp/fpga-manager-script/files/fpgautil.c
Along with usage details:
https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/1188397412/Solution+Versal+PL+Programming
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
V1->V2:
- New to patch series
V2->V3:
- Changed wildcards to more specific name "*_pld.pdi".
- Changed install directory for _pld.pdi to $(TARGET_DIR)/lib/firmware/xilinx
to match Yocto default location.
- Changed pdi file permissions to 0644.
V3->V4:
- added Kconfig option to enable this feature
---
boot/xilinx-prebuilt/Config.in | 9 ++++++++
boot/xilinx-prebuilt/xilinx-prebuilt.mk | 30 ++++++++++++++++++++++++-
2 files changed, 38 insertions(+), 1 deletion(-)
diff --git a/boot/xilinx-prebuilt/Config.in b/boot/xilinx-prebuilt/Config.in
index b95df5cbf4..b127097c7e 100644
--- a/boot/xilinx-prebuilt/Config.in
+++ b/boot/xilinx-prebuilt/Config.in
@@ -63,6 +63,15 @@ config BR2_TARGET_XILINX_PREBUILT_VERSAL_XSA_LOCATION
endif # BR2_TARGET_XILINX_PREBUILT_VERSAL_XSA
+config BR2_TARGET_XILINX_PREBUILT_VERSAL_PLD_PDI
+ bool "install versal pld.pdi"
+ depends on BR2_TARGET_XILINX_PREBUILT_VERSAL
+ help
+ When using the Versal Segmented Configuration, there is a
+ pld.pdi file containing the FPGA bitstream which can be
+ loaded at run-time. By enabling this option, the pld.pdi
+ will be installed to the target /lib/firmware/xilinx dir.
+
config BR2_TARGET_XILINX_PREBUILT_FAMILY
string
default "zynqmp" if BR2_TARGET_XILINX_PREBUILT_ZYNQMP
diff --git a/boot/xilinx-prebuilt/xilinx-prebuilt.mk b/boot/xilinx-prebuilt/xilinx-prebuilt.mk
index 05dc9aebe8..62b60b88fa 100644
--- a/boot/xilinx-prebuilt/xilinx-prebuilt.mk
+++ b/boot/xilinx-prebuilt/xilinx-prebuilt.mk
@@ -19,7 +19,6 @@ XILINX_PREBUILT_LICENSE = MIT
XILINX_PREBUILT_LICENSE_FILES = LICENSE
endif # BR2_TARGET_XILINX_PREBUILT_VERSAL_XSA
-XILINX_PREBUILT_INSTALL_TARGET = NO
XILINX_PREBUILT_INSTALL_IMAGES = YES
XILINX_PREBUILT_FAMILY = $(call qstrip,$(BR2_TARGET_XILINX_PREBUILT_FAMILY))
@@ -48,6 +47,18 @@ define XILINX_PREBUILT_INSTALL_VERSAL_XSA_BOOT_PDI
) \
$(BINARIES_DIR)/boot.pdi
endef
+
+ifeq ($(BR2_TARGET_XILINX_PREBUILT_VERSAL_PLD_PDI),y)
+# Install pld.pdi in target file system for run-time loading when using
+# Versal Segmented Configuration.
+define XILINX_PREBUILT_INSTALL_VERSAL_XSA_PLD_PDI
+ $(if $(wildcard $(@D)/*_pld.pdi),
+ mkdir -p $(TARGET_DIR)/lib/firmware/xilinx && \
+ $(INSTALL) -D -m 0644 $(@D)/*_pld.pdi \
+ $(TARGET_DIR)/lib/firmware/xilinx
+ )
+endef
+endif # BR2_TARGET_XILINX_PREBUILT_VERSAL_PLD_PDI
else # BR2_TARGET_XILINX_PREBUILT_VERSAL_XSA
XILINX_PREBUILT_PLM = $(XILINX_PREBUILT_BOARD_DIR)/plm.elf
XILINX_PREBUILT_PSMFW = $(XILINX_PREBUILT_BOARD_DIR)/psmfw.elf
@@ -63,6 +74,18 @@ define XILINX_PREBUILT_INSTALL_VERSAL_BOOT_PDI
) \
$(BINARIES_DIR)/boot.pdi
endef
+
+ifeq ($(BR2_TARGET_XILINX_PREBUILT_VERSAL_PLD_PDI),y)
+# Install pld.pdi in target file system for run-time loading when using
+# Versal Segmented Configuration.
+define XILINX_PREBUILT_INSTALL_VERSAL_PLD_PDI
+ $(if $(wildcard $(XILINX_PREBUILT_BOARD_DIR)/*_pld.pdi),
+ mkdir -p $(TARGET_DIR)/lib/firmware/xilinx && \
+ $(INSTALL) -D -m 0644 $(XILINX_PREBUILT_BOARD_DIR)/*_pld.pdi \
+ $(TARGET_DIR)/lib/firmware/xilinx
+ )
+endef
+endif # BR2_TARGET_XILINX_PREBUILT_VERSAL_PLD_PDI
endif # BR2_TARGET_XILINX_PREBUILT_VERSAL_XSA
ifneq ($(BR2_TARGET_XILINX_EMBEDDEDSW_VERSAL_PLM),y)
@@ -96,4 +119,9 @@ define XILINX_PREBUILT_INSTALL_IMAGES_CMDS
$(XILINX_PREBUILT_INSTALL_ZYNQMP_PMUFW)
endef
+define XILINX_PREBUILT_INSTALL_TARGET_CMDS
+ $(XILINX_PREBUILT_INSTALL_VERSAL_PLD_PDI)
+ $(XILINX_PREBUILT_INSTALL_VERSAL_XSA_PLD_PDI)
+endef
+
$(eval $(generic-package))
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH v4 4/4] boot/xilinx-prebuilt: install pld.pdi to target
2025-05-19 8:36 ` [Buildroot] [PATCH v4 4/4] boot/xilinx-prebuilt: install pld.pdi to target Neal Frager via buildroot
@ 2025-05-19 15:39 ` Luca Ceresoli via buildroot
0 siblings, 0 replies; 8+ messages in thread
From: Luca Ceresoli via buildroot @ 2025-05-19 15:39 UTC (permalink / raw)
To: Neal Frager
Cc: ibai.erkiaga-elorza, arnout, brandon.maier, ju.o,
thomas.petazzoni, buildroot, fabio.caccamo, romain.naour,
michal.simek
On Mon, 19 May 2025 09:36:31 +0100
Neal Frager <neal.frager@amd.com> wrote:
> With the Versal Segmented Configuration, it is possible to load a PL bitstream
> at run-time using the Linux fpgautil application. Whenever Segmented
> Configuration is used, both the boot.pdi and pld.pdi files will be available
> to Buildroot. For this reason, this patch improves the user experience by
> installing the pld.pdi file to the target file system for run-time loading
> whenever Versal Segemented Configuration is used.
>
> If the fpgautil application is available in the target file system, it can
> be used for loading the pld.pdi using the target command below.
>
> fpgautil -b /lib/firmware/xilinx/*_pld.pdi
>
> The source code for the fpgautil application can be found here:
> https://github.com/Xilinx/meta-xilinx/blob/master/meta-xilinx-core/recipes-bsp/fpga-manager-script/files/fpgautil.c
>
> Along with usage details:
> https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/1188397412/Solution+Versal+PL+Programming
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH v4 1/4] boot/xilinx-prebuilt: change versal pdi file permissions
2025-05-19 8:36 [Buildroot] [PATCH v4 1/4] boot/xilinx-prebuilt: change versal pdi file permissions Neal Frager via buildroot
` (2 preceding siblings ...)
2025-05-19 8:36 ` [Buildroot] [PATCH v4 4/4] boot/xilinx-prebuilt: install pld.pdi to target Neal Frager via buildroot
@ 2025-05-19 15:41 ` Luca Ceresoli via buildroot
2025-05-19 15:51 ` Frager, Neal via buildroot
2025-06-09 19:51 ` Julien Olivain
4 siblings, 1 reply; 8+ messages in thread
From: Luca Ceresoli via buildroot @ 2025-05-19 15:41 UTC (permalink / raw)
To: Neal Frager
Cc: ibai.erkiaga-elorza, arnout, brandon.maier, ju.o,
thomas.petazzoni, buildroot, fabio.caccamo, romain.naour,
michal.simek
On Mon, 19 May 2025 09:36:28 +0100
Neal Frager <neal.frager@amd.com> wrote:
> The versal vpl_gen_fixed.pdi file is not a target executable, so the file
> permissions should be 644 instead of 755.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
^^^^^^^^^^^^^^^^^^^^^^^^^^
False, I haven't reviewed this patch because this is the first time you
send it.
However I did so now, I'm OK with the content, and you can keep my
R-by line.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Buildroot] [PATCH v4 1/4] boot/xilinx-prebuilt: change versal pdi file permissions
2025-05-19 15:41 ` [Buildroot] [PATCH v4 1/4] boot/xilinx-prebuilt: change versal pdi file permissions Luca Ceresoli via buildroot
@ 2025-05-19 15:51 ` Frager, Neal via buildroot
0 siblings, 0 replies; 8+ messages in thread
From: Frager, Neal via buildroot @ 2025-05-19 15:51 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Erkiaga Elorza, Ibai, arnout@mind.be, brandon.maier@collins.com,
ju.o@free.fr, thomas.petazzoni@bootlin.com,
buildroot@buildroot.org, Caccamo, Fabio, romain.naour@smile.fr,
Simek, Michal
[AMD Official Use Only - AMD Internal Distribution Only]
> The versal vpl_gen_fixed.pdi file is not a target executable, so the file
> permissions should be 644 instead of 755.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
> False, I haven't reviewed this patch because this is the first time you
> send it.
> However I did so now, I'm OK with the content, and you can keep my
> R-by line.
Hi Luca,
Sorry for assuming. Thanks for reviewing and making it correct.
Best regards,
Neal Frager
AMD
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH v4 1/4] boot/xilinx-prebuilt: change versal pdi file permissions
2025-05-19 8:36 [Buildroot] [PATCH v4 1/4] boot/xilinx-prebuilt: change versal pdi file permissions Neal Frager via buildroot
` (3 preceding siblings ...)
2025-05-19 15:41 ` [Buildroot] [PATCH v4 1/4] boot/xilinx-prebuilt: change versal pdi file permissions Luca Ceresoli via buildroot
@ 2025-06-09 19:51 ` Julien Olivain
4 siblings, 0 replies; 8+ messages in thread
From: Julien Olivain @ 2025-06-09 19:51 UTC (permalink / raw)
To: Neal Frager
Cc: buildroot, ibai.erkiaga-elorza, luca.ceresoli, brandon.maier,
thomas.petazzoni, fabio.caccamo, romain.naour, michal.simek,
arnout
On 19/05/2025 10:36, Neal Frager via buildroot wrote:
> The versal vpl_gen_fixed.pdi file is not a target executable, so the
> file
> permissions should be 644 instead of 755.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Series applied to next, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread