* [Buildroot] [PATCH] package/bash: don't use append-assignment where unneeded
@ 2025-08-11 15:26 Yann E. MORIN via buildroot
2025-08-16 21:05 ` Thomas Petazzoni via buildroot
2025-08-21 19:20 ` Thomas Perale via buildroot
0 siblings, 2 replies; 3+ messages in thread
From: Yann E. MORIN via buildroot @ 2025-08-11 15:26 UTC (permalink / raw)
To: buildroot; +Cc: Yann E. MORIN
For the first, unconditional assignment, there is no reason to use
append-assignment; it can even be misleading.
Fixes: b367ca32e53a774c174899e44c77ed1d128cbcdc
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
package/bash/bash.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/bash/bash.mk b/package/bash/bash.mk
index 84f581da79..2747802592 100644
--- a/package/bash/bash.mk
+++ b/package/bash/bash.mk
@@ -17,7 +17,7 @@ BASH_CONF_OPTS = \
--with-installed-readline \
--without-bash-malloc
-BASH_CONF_ENV += \
+BASH_CONF_ENV = \
ac_cv_rl_prefix="$(STAGING_DIR)" \
ac_cv_rl_version="$(READLINE_VERSION)" \
bash_cv_getcwd_malloc=yes \
--
2.47.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/bash: don't use append-assignment where unneeded
2025-08-11 15:26 [Buildroot] [PATCH] package/bash: don't use append-assignment where unneeded Yann E. MORIN via buildroot
@ 2025-08-16 21:05 ` Thomas Petazzoni via buildroot
2025-08-21 19:20 ` Thomas Perale via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-08-16 21:05 UTC (permalink / raw)
To: Yann E. MORIN via buildroot; +Cc: Yann E. MORIN
On Mon, 11 Aug 2025 17:26:50 +0200
"Yann E. MORIN via buildroot" <buildroot@buildroot.org> wrote:
> For the first, unconditional assignment, there is no reason to use
> append-assignment; it can even be misleading.
>
> Fixes: b367ca32e53a774c174899e44c77ed1d128cbcdc
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
> package/bash/bash.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/bash: don't use append-assignment where unneeded
2025-08-11 15:26 [Buildroot] [PATCH] package/bash: don't use append-assignment where unneeded Yann E. MORIN via buildroot
2025-08-16 21:05 ` Thomas Petazzoni via buildroot
@ 2025-08-21 19:20 ` Thomas Perale via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Perale via buildroot @ 2025-08-21 19:20 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Thomas Perale, buildroot
In reply of:
> For the first, unconditional assignment, there is no reason to use
> append-assignment; it can even be misleading.
>
> Fixes: b367ca32e53a774c174899e44c77ed1d128cbcdc
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Applied to 2025.02.x & 2025.05.x. Thanks
> ---
> package/bash/bash.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/bash/bash.mk b/package/bash/bash.mk
> index 84f581da79..2747802592 100644
> --- a/package/bash/bash.mk
> +++ b/package/bash/bash.mk
> @@ -17,7 +17,7 @@ BASH_CONF_OPTS = \
> --with-installed-readline \
> --without-bash-malloc
>
> -BASH_CONF_ENV += \
> +BASH_CONF_ENV = \
> ac_cv_rl_prefix="$(STAGING_DIR)" \
> ac_cv_rl_version="$(READLINE_VERSION)" \
> bash_cv_getcwd_malloc=yes \
> --
> 2.47.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-21 19:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-11 15:26 [Buildroot] [PATCH] package/bash: don't use append-assignment where unneeded Yann E. MORIN via buildroot
2025-08-16 21:05 ` Thomas Petazzoni via buildroot
2025-08-21 19:20 ` Thomas Perale via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox