[Buildroot] [PATCH] package/bash: don't use append-assignment where unneeded

[Buildroot] [PATCH] package/bash: don't use append-assignment where unneeded

[Yann E. MORIN via buildroot]

For the first, unconditional assignment, there is no reason to use
append-assignment; it can even be misleading.

Fixes: b367ca32e53a774c174899e44c77ed1d128cbcdc

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
 package/bash/bash.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/bash/bash.mk b/package/bash/bash.mk
index 84f581da79..2747802592 100644
--- a/package/bash/bash.mk
+++ b/package/bash/bash.mk
@@ -17,7 +17,7 @@ BASH_CONF_OPTS = \
 	--with-installed-readline \
 	--without-bash-malloc
 
-BASH_CONF_ENV += \
+BASH_CONF_ENV = \
 	ac_cv_rl_prefix="$(STAGING_DIR)" \
 	ac_cv_rl_version="$(READLINE_VERSION)" \
 	bash_cv_getcwd_malloc=yes \
-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/bash: don't use append-assignment where unneeded

[Thomas Petazzoni via buildroot]

On Mon, 11 Aug 2025 17:26:50 +0200
"Yann E. MORIN via buildroot" <buildroot@buildroot.org> wrote:

> For the first, unconditional assignment, there is no reason to use
> append-assignment; it can even be misleading.
> 
> Fixes: b367ca32e53a774c174899e44c77ed1d128cbcdc
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
>  package/bash/bash.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/bash: don't use append-assignment where unneeded

[Thomas Perale via buildroot]

In reply of:
> For the first, unconditional assignment, there is no reason to use
> append-assignment; it can even be misleading.
> 
> Fixes: b367ca32e53a774c174899e44c77ed1d128cbcdc
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>

Applied to 2025.02.x & 2025.05.x. Thanks

> ---
>  package/bash/bash.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/bash/bash.mk b/package/bash/bash.mk
> index 84f581da79..2747802592 100644
> --- a/package/bash/bash.mk
> +++ b/package/bash/bash.mk
> @@ -17,7 +17,7 @@ BASH_CONF_OPTS = \
>  	--with-installed-readline \
>  	--without-bash-malloc
>  
> -BASH_CONF_ENV += \
> +BASH_CONF_ENV = \
>  	ac_cv_rl_prefix="$(STAGING_DIR)" \
>  	ac_cv_rl_version="$(READLINE_VERSION)" \
>  	bash_cv_getcwd_malloc=yes \
> -- 
> 2.47.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot