[Buildroot] [PATCH/next 1/2] package/libsidplayfp: new package

[Buildroot] [PATCH/next 1/2] package/libsidplayfp: new package

[Bernd Kuhls]

Replaces libsidplay2 as dependency in mpd 0.24.0:
https://github.com/MusicPlayerDaemon/MPD/blob/v0.24.6/NEWS#L125
https://github.com/MusicPlayerDaemon/MPD/commit/7e2538e07a80bd12baf2e7c328e7d1a64eb434f9

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/Config.in                      |  1 +
 package/libsidplayfp/Config.in         | 13 +++++++++++++
 package/libsidplayfp/libsidplayfp.hash |  3 +++
 package/libsidplayfp/libsidplayfp.mk   | 20 ++++++++++++++++++++
 4 files changed, 37 insertions(+)
 create mode 100644 package/libsidplayfp/Config.in
 create mode 100644 package/libsidplayfp/libsidplayfp.hash
 create mode 100644 package/libsidplayfp/libsidplayfp.mk

diff --git a/package/Config.in b/package/Config.in
index 92b72194e3..1c80b779fc 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1559,6 +1559,7 @@ menu "Audio/Sound"
 	source "package/libreplaygain/Config.in"
 	source "package/libsamplerate/Config.in"
 	source "package/libsidplay2/Config.in"
+	source "package/libsidplayfp/Config.in"
 	source "package/libsilk/Config.in"
 	source "package/libsndfile/Config.in"
 	source "package/libsoundtouch/Config.in"
diff --git a/package/libsidplayfp/Config.in b/package/libsidplayfp/Config.in
new file mode 100644
index 0000000000..43841173b1
--- /dev/null
+++ b/package/libsidplayfp/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_LIBSIDPLAYFP
+	bool "libsidplayfp"
+	depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  libsidplayfp is a C64 music player library which integrates
+	  the reSID SID chip emulation into a cycle-based emulator
+	  environment, constantly aiming to improve emulation of the
+	  C64 system and the SID chips.
+
+	  https://github.com/libsidplayfp/libsidplayfp
+
+comment "libsidplayfp needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/libsidplayfp/libsidplayfp.hash b/package/libsidplayfp/libsidplayfp.hash
new file mode 100644
index 0000000000..880c31ee28
--- /dev/null
+++ b/package/libsidplayfp/libsidplayfp.hash
@@ -0,0 +1,3 @@
+# Locally computed
+sha256  7c6ab283fda53d34973fa266fc3809e16964dd8ccb7edcc11516ef5e3f66b3cd  libsidplayfp-2.15.2.tar.gz
+sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
diff --git a/package/libsidplayfp/libsidplayfp.mk b/package/libsidplayfp/libsidplayfp.mk
new file mode 100644
index 0000000000..3aeeb19013
--- /dev/null
+++ b/package/libsidplayfp/libsidplayfp.mk
@@ -0,0 +1,20 @@
+################################################################################
+#
+# libsidplayfp
+#
+################################################################################
+
+LIBSIDPLAYFP_VERSION = 2.15.2
+LIBSIDPLAYFP_SITE = https://github.com/libsidplayfp/libsidplayfp/releases/download/v$(LIBSIDPLAYFP_VERSION)
+LIBSIDPLAYFP_LICENSE = GPL-2.0+
+LIBSIDPLAYFP_LICENSE_FILES = COPYING
+LIBSIDPLAYFP_INSTALL_STAGING = YES
+
+ifeq ($(BR2_PACKAGE_LIBGCRYPT),y)
+LIBSIDPLAYFP_CONF_OPTS += --with-gcrypt
+LIBSIDPLAYFP_DEPENDENCIES += libgcrypt
+else
+LIBSIDPLAYFP_CONF_OPTS += --without-gcrypt
+endif
+
+$(eval $(autotools-package))
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH/next 2/2] package/mpd: switch from libsidplay2 to libsidplayfp

[Bernd Kuhls]

Buildroot commit 25af5a3b3aa3480ee10158e55c280d675430442a bumped mpd to
0.24 which switched C64 SID support from libsidplay2 to libsidplayfp:
https://github.com/MusicPlayerDaemon/MPD/blob/v0.24.6/NEWS#L125
https://github.com/MusicPlayerDaemon/MPD/commit/7e2538e07a80bd12baf2e7c328e7d1a64eb434f9

Fixes a build error not recorded by autobuilders:

Run-time dependency libsidplayfp found: NO (tried pkgconfig and cmake)

output/build/mpd-0.24.6/src/decoder/plugins/meson.build:161:17: ERROR:
 Dependency "libsidplayfp" not found, tried pkgconfig and cmake

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/mpd/Config.in | 2 +-
 package/mpd/mpd.mk    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/mpd/Config.in b/package/mpd/Config.in
index 48b8c914fa..066f53c24b 100644
--- a/package/mpd/Config.in
+++ b/package/mpd/Config.in
@@ -159,7 +159,7 @@ config BR2_PACKAGE_MPD_OPUS
 
 config BR2_PACKAGE_MPD_SIDPLAY
 	bool "sidplay"
-	select BR2_PACKAGE_LIBSIDPLAY2
+	select BR2_PACKAGE_LIBSIDPLAYFP
 	help
 	  Enable C64 SID support.
 
diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
index ff6f08ba65..2dcaed8439 100644
--- a/package/mpd/mpd.mk
+++ b/package/mpd/mpd.mk
@@ -281,7 +281,7 @@ MPD_CONF_OPTS += -Dshout=disabled
 endif
 
 ifeq ($(BR2_PACKAGE_MPD_SIDPLAY),y)
-MPD_DEPENDENCIES += libsidplay2
+MPD_DEPENDENCIES += libsidplayfp
 MPD_CONF_OPTS += -Dsidplay=enabled
 else
 MPD_CONF_OPTS += -Dsidplay=disabled
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH/next 2/2] package/mpd: switch from libsidplay2 to libsidplayfp

[Andreas Ziegler]

Hi Bernd,

Thank you for fixing this; it completely escaped my notice.

On 2025-12-05 19:30, Bernd Kuhls wrote:
> Buildroot commit 25af5a3b3aa3480ee10158e55c280d675430442a bumped mpd to
> 0.24 which switched C64 SID support from libsidplay2 to libsidplayfp:
> https://github.com/MusicPlayerDaemon/MPD/blob/v0.24.6/NEWS#L125
> https://github.com/MusicPlayerDaemon/MPD/commit/7e2538e07a80bd12baf2e7c328e7d1a64eb434f9
> 
> Fixes a build error not recorded by autobuilders:
> 
> Run-time dependency libsidplayfp found: NO (tried pkgconfig and cmake)
> 
> output/build/mpd-0.24.6/src/decoder/plugins/meson.build:161:17: ERROR:
>  Dependency "libsidplayfp" not found, tried pkgconfig and cmake
> 
Acked-by: Andreas Ziegler <br025@umbiko.net>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/mpd/Config.in | 2 +-
>  package/mpd/mpd.mk    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/mpd/Config.in b/package/mpd/Config.in
> index 48b8c914fa..066f53c24b 100644
> --- a/package/mpd/Config.in
> +++ b/package/mpd/Config.in

<...>

Kind regards,
Andreas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH/next 1/2] package/libsidplayfp: new package

[Thomas Petazzoni via buildroot]

Hello Bernd,

On Fri,  5 Dec 2025 20:30:56 +0100
Bernd Kuhls <bernd@kuhls.net> wrote:

> Replaces libsidplay2 as dependency in mpd 0.24.0:
> https://github.com/MusicPlayerDaemon/MPD/blob/v0.24.6/NEWS#L125
> https://github.com/MusicPlayerDaemon/MPD/commit/7e2538e07a80bd12baf2e7c328e7d1a64eb434f9
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/Config.in                      |  1 +
>  package/libsidplayfp/Config.in         | 13 +++++++++++++
>  package/libsidplayfp/libsidplayfp.hash |  3 +++
>  package/libsidplayfp/libsidplayfp.mk   | 20 ++++++++++++++++++++
>  4 files changed, 37 insertions(+)
>  create mode 100644 package/libsidplayfp/Config.in
>  create mode 100644 package/libsidplayfp/libsidplayfp.hash
>  create mode 100644 package/libsidplayfp/libsidplayfp.mk

Thanks for your patch!

Could you add an entry in the DEVELOPERS file for this new package?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH/next 1/2] package/libsidplayfp: new package

[Andreas Ziegler]

Hi Bernd, Thomas, all

On 2025-12-05 19:30, Bernd Kuhls wrote:
> Replaces libsidplay2 as dependency in mpd 0.24.0:
> https://github.com/MusicPlayerDaemon/MPD/blob/v0.24.6/NEWS#L125
> https://github.com/MusicPlayerDaemon/MPD/commit/7e2538e07a80bd12baf2e7c328e7d1a64eb434f9

Apart from mpd, there are only two other packages depending on 
libsidplay2:

~/buildroot$ grep libsidplay2 package/*/*.mk
package/kodi-audiodecoder-sidplay/kodi-audiodecoder-sidplay.mk:KODI_AUDIODECODER_SIDPLAY_DEPENDENCIES 
= host-pkgconf kodi libsidplay2
package/libsidplay2/libsidplay2.mk:# libsidplay2
package/mpd/mpd.mk:MPD_DEPENDENCIES += libsidplay2
package/vlc/vlc.mk:VLC_DEPENDENCIES += libsidplay2

Should we patch them and drop libsidplay2 completely? Libsidplayfp seems 
to be better maintaned. I can offer help.

> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/Config.in                      |  1 +
>  package/libsidplayfp/Config.in         | 13 +++++++++++++
>  package/libsidplayfp/libsidplayfp.hash |  3 +++
>  package/libsidplayfp/libsidplayfp.mk   | 20 ++++++++++++++++++++
>  4 files changed, 37 insertions(+)
>  create mode 100644 package/libsidplayfp/Config.in
>  create mode 100644 package/libsidplayfp/libsidplayfp.hash
>  create mode 100644 package/libsidplayfp/libsidplayfp.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 92b72194e3..1c80b779fc 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1559,6 +1559,7 @@ menu "Audio/Sound"
>  	source "package/libreplaygain/Config.in"
>  	source "package/libsamplerate/Config.in"
>  	source "package/libsidplay2/Config.in"
> +	source "package/libsidplayfp/Config.in"
>  	source "package/libsilk/Config.in"
>  	source "package/libsndfile/Config.in"
>  	source "package/libsoundtouch/Config.in"
> diff --git a/package/libsidplayfp/Config.in 
> b/package/libsidplayfp/Config.in
> new file mode 100644
> index 0000000000..43841173b1
> --- /dev/null
> +++ b/package/libsidplayfp/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_LIBSIDPLAYFP
> +	bool "libsidplayfp"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	help
> +	  libsidplayfp is a C64 music player library which integrates
> +	  the reSID SID chip emulation into a cycle-based emulator
> +	  environment, constantly aiming to improve emulation of the
> +	  C64 system and the SID chips.
> +
> +	  https://github.com/libsidplayfp/libsidplayfp
> +
> +comment "libsidplayfp needs a toolchain w/ C++"
> +	depends on !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/libsidplayfp/libsidplayfp.hash 
> b/package/libsidplayfp/libsidplayfp.hash
> new file mode 100644
> index 0000000000..880c31ee28
> --- /dev/null
> +++ b/package/libsidplayfp/libsidplayfp.hash
> @@ -0,0 +1,3 @@
> +# Locally computed
> +sha256  
> 7c6ab283fda53d34973fa266fc3809e16964dd8ccb7edcc11516ef5e3f66b3cd  
> libsidplayfp-2.15.2.tar.gz
> +sha256  
> 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  
> COPYING
> diff --git a/package/libsidplayfp/libsidplayfp.mk 
> b/package/libsidplayfp/libsidplayfp.mk
> new file mode 100644
> index 0000000000..3aeeb19013
> --- /dev/null
> +++ b/package/libsidplayfp/libsidplayfp.mk
> @@ -0,0 +1,20 @@
> +################################################################################
> +#
> +# libsidplayfp
> +#
> +################################################################################
> +
> +LIBSIDPLAYFP_VERSION = 2.15.2
> +LIBSIDPLAYFP_SITE = 
> https://github.com/libsidplayfp/libsidplayfp/releases/download/v$(LIBSIDPLAYFP_VERSION)
> +LIBSIDPLAYFP_LICENSE = GPL-2.0+
> +LIBSIDPLAYFP_LICENSE_FILES = COPYING
> +LIBSIDPLAYFP_INSTALL_STAGING = YES
> +
> +ifeq ($(BR2_PACKAGE_LIBGCRYPT),y)
> +LIBSIDPLAYFP_CONF_OPTS += --with-gcrypt
> +LIBSIDPLAYFP_DEPENDENCIES += libgcrypt
> +else
> +LIBSIDPLAYFP_CONF_OPTS += --without-gcrypt
> +endif
> +
> +$(eval $(autotools-package))
> --
> 2.47.3

Kind regards,
Andreas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot