Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/4] package/janet: add host variant
@ 2025-12-20 17:34 Francois Perrad via buildroot
  2025-12-20 17:34 ` [Buildroot] [PATCH 2/4] package/jmp: new host package Francois Perrad via buildroot
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Francois Perrad via buildroot @ 2025-12-20 17:34 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/janet/janet.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/janet/janet.mk b/package/janet/janet.mk
index cf4113fb1..4e904e7b0 100644
--- a/package/janet/janet.mk
+++ b/package/janet/janet.mk
@@ -28,3 +28,4 @@ JANET_CONF_OPTS += -Dsingle_threaded=true
 endif
 
 $(eval $(meson-package))
+$(eval $(host-meson-package))
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/4] package/jmp: new host package
  2025-12-20 17:34 [Buildroot] [PATCH 1/4] package/janet: add host variant Francois Perrad via buildroot
@ 2025-12-20 17:34 ` Francois Perrad via buildroot
  2025-12-27 22:05   ` Thomas Petazzoni via buildroot
  2025-12-20 17:34 ` [Buildroot] [PATCH 3/4] package/janet: new infrastructure Francois Perrad via buildroot
  2025-12-20 17:34 ` [Buildroot] [PATCH 4/4] package/janet-spork: new package Francois Perrad via buildroot
  2 siblings, 1 reply; 7+ messages in thread
From: Francois Perrad via buildroot @ 2025-12-20 17:34 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 DEVELOPERS                                    |  1 +
 ...er-command-with-BR-toolchain-wrapper.patch | 27 +++++++++++++++++++
 package/jpm/jpm.hash                          |  3 +++
 package/jpm/jpm.mk                            | 25 +++++++++++++++++
 4 files changed, 56 insertions(+)
 create mode 100644 package/jpm/0001-fix-linker-command-with-BR-toolchain-wrapper.patch
 create mode 100644 package/jpm/jpm.hash
 create mode 100644 package/jpm/jpm.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 5c9eb94f5..5ac155572 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1172,6 +1172,7 @@ F:	package/dado/
 F:	package/ficl/
 F:	package/graphene/
 F:	package/janet/
+F:	package/jpm/
 F:	package/libgtk4/
 F:	package/libtomcrypt/
 F:	package/libtommath/
diff --git a/package/jpm/0001-fix-linker-command-with-BR-toolchain-wrapper.patch b/package/jpm/0001-fix-linker-command-with-BR-toolchain-wrapper.patch
new file mode 100644
index 000000000..4569a469d
--- /dev/null
+++ b/package/jpm/0001-fix-linker-command-with-BR-toolchain-wrapper.patch
@@ -0,0 +1,27 @@
+From 33982bbf739a3a4eb70cf18a0575d5106324873a Mon Sep 17 00:00:00 2001
+From: Francois Perrad <francois.perrad@gadz.org>
+Date: Mon, 20 Oct 2025 14:57:25 +0200
+Subject: [PATCH] fix linker command with BR toolchain-wrapper
+
+Upstream: N/A specific for Buildroot build
+Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
+---
+ jpm/cc.janet | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/jpm/cc.janet b/jpm/cc.janet
+index c5abdac..4ebb25c 100644
+--- a/jpm/cc.janet
++++ b/jpm/cc.janet
+@@ -110,7 +110,7 @@
+         (if (dyn :is-msvc)
+           (clexe-shell linker ;ldflags (string "/OUT:" target) ;objects
+                  (string (dyn:headerpath) "/janet.lib") ;dep-importlibs ;lflags)
+-          (shell linker ;cflags ;ldflags `-o` target ;objects ;lflags))))
++          (shell linker ;lflags `-o` target ;objects))))
+ 
+ (defn archive-c
+   "Link object files together to make a static library."
+-- 
+2.43.0
+
diff --git a/package/jpm/jpm.hash b/package/jpm/jpm.hash
new file mode 100644
index 000000000..c8259737f
--- /dev/null
+++ b/package/jpm/jpm.hash
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256  337c40d9b8c087b920202287b375c2962447218e8e127ce3a5a12e6e47ac6f16  jpm-1.1.0.tar.gz
+sha256  e2d2ae8360d95386af751ac7d1a3da36ea8ceb230e5f0eba7eb762547b1c58c9  LICENSE
diff --git a/package/jpm/jpm.mk b/package/jpm/jpm.mk
new file mode 100644
index 000000000..f6a20690d
--- /dev/null
+++ b/package/jpm/jpm.mk
@@ -0,0 +1,25 @@
+################################################################################
+#
+# jpm
+#
+################################################################################
+
+JPM_VERSION = 1.1.0
+JPM_SITE = $(call github,janet-lang,jpm,v$(JPM_VERSION))
+JPM_LICENSE = MIT
+JPM_LICENSE_FILES = LICENSE
+
+HOST_JPM_DEPENDENCIES = host-janet
+
+define HOST_JPM_INSTALL_CMDS
+	(cd $(@D); \
+		DESTDIR=$(HOST_DIR) \
+		PREFIX=/usr \
+		JANET_BINPATH=/usr/bin \
+		JANET_MODPATH=/usr/lib/janet \
+		JANET_MANPATH=/usr/share/man/man1 \
+		$(HOST_DIR)/bin/janet bootstrap.janet);
+	$(SED) 's|/usr/|$(HOST_DIR)/usr/|' $(HOST_DIR)/usr/bin/jpm
+endef
+
+$(eval $(host-generic-package))
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 3/4] package/janet: new infrastructure
  2025-12-20 17:34 [Buildroot] [PATCH 1/4] package/janet: add host variant Francois Perrad via buildroot
  2025-12-20 17:34 ` [Buildroot] [PATCH 2/4] package/jmp: new host package Francois Perrad via buildroot
@ 2025-12-20 17:34 ` Francois Perrad via buildroot
  2025-12-27 22:07   ` Thomas Petazzoni via buildroot
  2025-12-20 17:34 ` [Buildroot] [PATCH 4/4] package/janet-spork: new package Francois Perrad via buildroot
  2 siblings, 1 reply; 7+ messages in thread
From: Francois Perrad via buildroot @ 2025-12-20 17:34 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 DEVELOPERS                             |  1 +
 docs/manual/adding-packages-janet.adoc | 59 ++++++++++++++++
 docs/manual/adding-packages.adoc       |  2 +
 package/Makefile.in                    |  1 +
 package/pkg-janet.mk                   | 98 ++++++++++++++++++++++++++
 5 files changed, 161 insertions(+)
 create mode 100644 docs/manual/adding-packages-janet.adoc
 create mode 100644 package/pkg-janet.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 5ac155572..20c3550cc 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1194,6 +1194,7 @@ F:	package/netsurf/
 F:	package/perl*
 F:	package/pkg-perl.mk
 F:	package/pkg-luarocks.mk
+F:	package/pkg-janet.mk
 F:	package/quickjs/
 F:	package/rings/
 F:	package/tekui/
diff --git a/docs/manual/adding-packages-janet.adoc b/docs/manual/adding-packages-janet.adoc
new file mode 100644
index 000000000..3b39da7ba
--- /dev/null
+++ b/docs/manual/adding-packages-janet.adoc
@@ -0,0 +1,59 @@
+// -*- mode:doc; -*-
+// vim: set syntax=asciidoc:
+
+=== Infrastructure for Janet packages
+
+[[janet-package-tutorial]]
+
+==== +janet-package+ tutorial
+
+First, let's see how to write a +.mk+ file for a Janet package,
+with an example :
+
+----
+01: ################################################################################
+02: #
+03: # janet-foo
+04: #
+05: ################################################################################
+06:
+07: JANET_FOO_VERSION = 1.0.2
+08: JANET_FOO_DEPENDENCIES = libmad
+09: JANET_FOO_LICENSE = MIT
+10: JANET_FOO_LICENSE_FILES = LICENSE
+11:
+12: $(eval $(janet-package))
+----
+
+On line 7, we declare the version of the package.
+
+On line 8, we declare our dependencies against native libraries, so that they
+are built before the build process of our package starts.
+
+On lines 9-10, we specify the licensing terms for the package.
+
+Finally, on line 12, we invoke the +janet-package+
+macro that generates all the Makefile rules that actually allows the
+package to be built.
+
+[[janet-package-reference]]
+
+==== +janet-package+ reference
+
+As a policy, packages that provide Janet modules should all be
+named +janet-<something>+ in Buildroot.
+
+JPM (Janet Project Manager) is the build tool used by this infrastructure.
+
+The main macro of the Janet package infrastructure is +janet-package+:
+like +generic-package+ it works by defining a number of variables providing
+metadata information about the package, and then calling the +janet-package+
+macro.
+
+Just like the generic infrastructure, the Janet infrastructure works
+by defining a number of variables before calling the +janet-package+
+macro.
+
+All the package metadata information variables that exist in the
+xref:generic-package-reference[generic package infrastructure] also
+exist in the Janet infrastructure.
diff --git a/docs/manual/adding-packages.adoc b/docs/manual/adding-packages.adoc
index 10acae0b1..437271662 100644
--- a/docs/manual/adding-packages.adoc
+++ b/docs/manual/adding-packages.adoc
@@ -43,6 +43,8 @@ include::adding-packages-golang.adoc[]
 
 include::adding-packages-qmake.adoc[]
 
+include::adding-packages-janet.adoc[]
+
 include::adding-packages-kernel-module.adoc[]
 
 include::adding-packages-asciidoc.adoc[]
diff --git a/package/Makefile.in b/package/Makefile.in
index 5ebb5f9ba..bc4d0a7bb 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -474,3 +474,4 @@ include package/pkg-golang.mk
 include package/pkg-meson.mk
 include package/pkg-qmake.mk
 include package/pkg-cargo.mk
+include package/pkg-janet.mk
diff --git a/package/pkg-janet.mk b/package/pkg-janet.mk
new file mode 100644
index 000000000..e368faa40
--- /dev/null
+++ b/package/pkg-janet.mk
@@ -0,0 +1,98 @@
+################################################################################
+# Janet package infrastructure
+# see https://janet-lang.org/jpm/index.html (Janet Project Manager)
+#
+# This file implements an infrastructure that eases development of
+# package .mk files for Janet packages.
+#
+# See the Buildroot documentation for details on the usage of this
+# infrastructure
+#
+# In terms of implementation, this Janet infrastructure requires
+# the .mk file to only specify metadata information about the
+# package: name, version, etc.
+#
+################################################################################
+
+################################################################################
+# inner-janet-package -- defines how the configuration, compilation and
+# installation of a Janet package should be done, implements a few hooks to
+# tune the build process and calls the generic package infrastructure to
+# generate the necessary make targets
+#
+#  argument 1 is the lowercase package name
+#  argument 2 is the uppercase package name, including a HOST_ prefix
+#             for host packages
+#  argument 3 is the uppercase package name, without the HOST_ prefix
+#             for host packages
+#  argument 4 is the type (target or host)
+################################################################################
+
+define inner-janet-package
+
+$(2)_DEPENDENCIES += host-jpm janet
+
+#
+# Build step. Only define it if not already defined by the package .mk
+# file.
+#
+ifndef $(2)_BUILD_CMDS
+define $(2)_BUILD_CMDS
+	cd $$($(2)_SRCDIR) && \
+		$$(HOST_DIR)/bin/jpm build --verbose \
+			--ar=$$(TARGET_AR) \
+			--c++=$$(TARGET_CPP) \
+			--c++-link=$$(TARGET_CPP) \
+			--cc=$$(TARGET_CC) \
+			--cc-link=$$(TARGET_CC) \
+			--cflags="$$(TARGET_CFLAGS)" \
+			--cppflags="$$(TARGET_CPPFLAGS)" \
+			--headerpath="$$(STAGING_DIR)/usr/include" \
+			--ldflags=$$(TARGET_LDFLAGS) \
+			--libpath="$$(STAGING_DIR)/usr/lib" \
+			--modpath="$$(STAGING_DIR)/usr/lib/janet" \
+			--offline
+endef
+endif
+
+#
+# Staging installation step. Only define it if not already defined by
+# the package .mk file.
+#
+ifndef $(2)_INSTALL_STAGING_CMDS
+define $(2)_INSTALL_STAGING_CMDS
+	cd $$($(2)_SRCDIR) && \
+		$$(HOST_DIR)/bin/jpm install --verbose \
+			--binpath="$$(STAGING_DIR)/usr/bin" \
+			--manpath="$$(STAGING_DIR)/usr/share/man/man1" \
+			--modpath="$$(STAGING_DIR)/usr/lib/janet" \
+			--offline
+endef
+endif
+
+#
+# Target installation step. Only define it if not already defined by
+# the package .mk file.
+#
+ifndef $(2)_INSTALL_TARGET_CMDS
+define $(2)_INSTALL_TARGET_CMDS
+	cd $$($(2)_SRCDIR) && \
+		$$(HOST_DIR)/bin/jpm install --verbose \
+			--binpath="$$(TARGET_DIR)/usr/bin" \
+			--manpath="$$(TARGET_DIR)/usr/share/man/man1" \
+			--modpath="$$(TARGET_DIR)/usr/lib/janet" \
+			--offline
+endef
+endif
+
+# Call the generic package infrastructure to generate the necessary
+# make targets
+$(call inner-generic-package,$(1),$(2),$(3),$(4))
+
+endef
+
+################################################################################
+# janet-package -- the target generator macro for Janet packages
+################################################################################
+
+janet-package = $(call inner-janet-package,$(pkgname),$(call UPPERCASE,$(pkgname)),$(call UPPERCASE,$(pkgname)),target)
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 4/4] package/janet-spork: new package
  2025-12-20 17:34 [Buildroot] [PATCH 1/4] package/janet: add host variant Francois Perrad via buildroot
  2025-12-20 17:34 ` [Buildroot] [PATCH 2/4] package/jmp: new host package Francois Perrad via buildroot
  2025-12-20 17:34 ` [Buildroot] [PATCH 3/4] package/janet: new infrastructure Francois Perrad via buildroot
@ 2025-12-20 17:34 ` Francois Perrad via buildroot
  2025-12-27 22:11   ` Thomas Petazzoni via buildroot
  2 siblings, 1 reply; 7+ messages in thread
From: Francois Perrad via buildroot @ 2025-12-20 17:34 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 DEVELOPERS                                    |  2 +-
 package/Config.in                             |  5 ++++
 package/janet-spork/Config.in                 |  6 +++++
 package/janet-spork/janet-spork.hash          |  3 +++
 package/janet-spork/janet-spork.mk            | 12 +++++++++
 .../testing/tests/package/test_janet_spork.py | 26 +++++++++++++++++++
 6 files changed, 53 insertions(+), 1 deletion(-)
 create mode 100644 package/janet-spork/Config.in
 create mode 100644 package/janet-spork/janet-spork.hash
 create mode 100644 package/janet-spork/janet-spork.mk
 create mode 100644 support/testing/tests/package/test_janet_spork.py

diff --git a/DEVELOPERS b/DEVELOPERS
index 20c3550cc..1a5fb19d1 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1171,7 +1171,7 @@ F:	package/coxpcall/
 F:	package/dado/
 F:	package/ficl/
 F:	package/graphene/
-F:	package/janet/
+F:	package/janet*
 F:	package/jpm/
 F:	package/libgtk4/
 F:	package/libtomcrypt/
diff --git a/package/Config.in b/package/Config.in
index 83414b3e0..c2ade1f09 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -693,6 +693,11 @@ endif
 	source "package/guile/Config.in"
 	source "package/haserl/Config.in"
 	source "package/janet/Config.in"
+if BR2_PACKAGE_JANET
+menu "Janet libraries/modules"
+	source "package/janet-spork/Config.in"
+endmenu
+endif
 	source "package/jimtcl/Config.in"
 	source "package/lua/Config.in"
 	source "package/luainterpreter/Config.in"
diff --git a/package/janet-spork/Config.in b/package/janet-spork/Config.in
new file mode 100644
index 000000000..9a7261e26
--- /dev/null
+++ b/package/janet-spork/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_JANET_SPORK
+	bool "janet-spork"
+	help
+	  Various Janet utility modules - the official "Contrib" library.
+
+	  https://github.com/janet-lang/spork
diff --git a/package/janet-spork/janet-spork.hash b/package/janet-spork/janet-spork.hash
new file mode 100644
index 000000000..5c4d0358f
--- /dev/null
+++ b/package/janet-spork/janet-spork.hash
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256  0d3ae19b252997be1f1e0f5285a1340df53771f6c7ceb5d4bd9cb3501d6b3f25  janet-spork-1.1.1.tar.gz
+sha256  c92ff452e04f8c6f6c3727afc841fa85f92214a0214b41522d16a4b8143487f3  LICENSE
diff --git a/package/janet-spork/janet-spork.mk b/package/janet-spork/janet-spork.mk
new file mode 100644
index 000000000..db8f9de26
--- /dev/null
+++ b/package/janet-spork/janet-spork.mk
@@ -0,0 +1,12 @@
+################################################################################
+#
+# janet-spork
+#
+################################################################################
+
+JANET_SPORK_VERSION = 1.1.1
+JANET_SPORK_SITE = $(call github,janet-lang,spork,v$(JANET_SPORK_VERSION))
+JANET_SPORK_LICENSE = MIT
+JANET_SPORK_LICENSE_FILES = LICENSE
+
+$(eval $(janet-package))
diff --git a/support/testing/tests/package/test_janet_spork.py b/support/testing/tests/package/test_janet_spork.py
new file mode 100644
index 000000000..59a8380b3
--- /dev/null
+++ b/support/testing/tests/package/test_janet_spork.py
@@ -0,0 +1,26 @@
+import os
+
+import infra.basetest
+
+
+class TestJanetSpork(infra.basetest.BRTest):
+    config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
+        """
+        BR2_PACKAGE_JANET=y
+        BR2_PACKAGE_JANET_SPORK=y
+        BR2_TARGET_ROOTFS_CPIO=y
+        # BR2_TARGET_ROOTFS_TAR is not set
+        """
+
+    def login(self):
+        cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio")
+        self.emulator.boot(arch="armv7",
+                           kernel="builtin",
+                           options=["-initrd", cpio_file])
+        self.emulator.login()
+
+    def test_run(self):
+        self.login()
+        self.assertRunOk("janet --version")
+        self.assertRunOk("janet -l spork/version -e '(print text)'")  # spork/version.janet
+        self.assertRunOk("janet -l spork/zip -e '(compress :test)'")  # spork/zip.so
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 2/4] package/jmp: new host package
  2025-12-20 17:34 ` [Buildroot] [PATCH 2/4] package/jmp: new host package Francois Perrad via buildroot
@ 2025-12-27 22:05   ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-12-27 22:05 UTC (permalink / raw)
  To: Francois Perrad via buildroot; +Cc: buildroot

Hello François,

On Sat, 20 Dec 2025 18:34:10 +0100
Francois Perrad via buildroot <buildroot@buildroot.org> wrote:

> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

It is always nice to not have an empty commit log when adding new
packages, especially when what they are useful for is not super clear.

> diff --git a/package/jpm/0001-fix-linker-command-with-BR-toolchain-wrapper.patch b/package/jpm/0001-fix-linker-command-with-BR-toolchain-wrapper.patch
> new file mode 100644
> index 000000000..4569a469d
> --- /dev/null
> +++ b/package/jpm/0001-fix-linker-command-with-BR-toolchain-wrapper.patch
> @@ -0,0 +1,27 @@
> +From 33982bbf739a3a4eb70cf18a0575d5106324873a Mon Sep 17 00:00:00 2001
> +From: Francois Perrad <francois.perrad@gadz.org>
> +Date: Mon, 20 Oct 2025 14:57:25 +0200
> +Subject: [PATCH] fix linker command with BR toolchain-wrapper
> +
> +Upstream: N/A specific for Buildroot build
> +Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> +---
> + jpm/cc.janet | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/jpm/cc.janet b/jpm/cc.janet
> +index c5abdac..4ebb25c 100644
> +--- a/jpm/cc.janet
> ++++ b/jpm/cc.janet
> +@@ -110,7 +110,7 @@
> +         (if (dyn :is-msvc)
> +           (clexe-shell linker ;ldflags (string "/OUT:" target) ;objects
> +                  (string (dyn:headerpath) "/janet.lib") ;dep-importlibs ;lflags)
> +-          (shell linker ;cflags ;ldflags `-o` target ;objects ;lflags))))
> ++          (shell linker ;lflags `-o` target ;objects))))

What is the actual problem being fixed here? Having something not
upstreamable is clearly not nice for a brand new package.


> +define HOST_JPM_INSTALL_CMDS
> +	(cd $(@D); \
> +		DESTDIR=$(HOST_DIR) \
> +		PREFIX=/usr \

You should use:

		PREFIX=$(HOST_DIR)

> +		JANET_BINPATH=/usr/bin \
> +		JANET_MODPATH=/usr/lib/janet \
> +		JANET_MANPATH=/usr/share/man/man1 \
> +		$(HOST_DIR)/bin/janet bootstrap.janet);
> +	$(SED) 's|/usr/|$(HOST_DIR)/usr/|' $(HOST_DIR)/usr/bin/jpm

And hopefully this will allow to avoid this $(SED) ?

Note that $(HOST_DIR)/usr should no longer be used. Use $(HOST_DIR)
directly.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 3/4] package/janet: new infrastructure
  2025-12-20 17:34 ` [Buildroot] [PATCH 3/4] package/janet: new infrastructure Francois Perrad via buildroot
@ 2025-12-27 22:07   ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-12-27 22:07 UTC (permalink / raw)
  To: Francois Perrad via buildroot; +Cc: buildroot

Hello François,

On Sat, 20 Dec 2025 18:34:11 +0100
Francois Perrad via buildroot <buildroot@buildroot.org> wrote:

> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

How many Janet packages do you expect to add? We normally add a package
infra once we have 3-5 packages at least. Adding one for just one
package seems excessive, but perhaps you have many more packages to add
in the future?


> diff --git a/docs/manual/adding-packages-janet.adoc b/docs/manual/adding-packages-janet.adoc
> new file mode 100644
> index 000000000..3b39da7ba
> --- /dev/null
> +++ b/docs/manual/adding-packages-janet.adoc
> @@ -0,0 +1,59 @@
> +// -*- mode:doc; -*-
> +// vim: set syntax=asciidoc:
> +
> +=== Infrastructure for Janet packages
> +

Please add some intro about Janet here, what it is, etc. Clearly not
obvious.

But honestly aside for that it looks all good to me. I see they have
--offline option, which seems to imply that they thought about offline
builds, which is great.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 4/4] package/janet-spork: new package
  2025-12-20 17:34 ` [Buildroot] [PATCH 4/4] package/janet-spork: new package Francois Perrad via buildroot
@ 2025-12-27 22:11   ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-12-27 22:11 UTC (permalink / raw)
  To: Francois Perrad via buildroot; +Cc: buildroot

Hello,

On Sat, 20 Dec 2025 18:34:12 +0100
Francois Perrad via buildroot <buildroot@buildroot.org> wrote:

> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

What does this package actually provides? If I understand correctly,
janet-spork is like an utility library of some sort. What are you using
it for? For your own custom Janet-based application?

Are there some Janet-based applications that are available so that this
janet-package infrastructure can actually be used for something
_useful_ ?

But really aside from that the patch looks really good and clean.

Can you do a v2 adjusting the few comments on the rest of the series,
and providing a bit more background? Then we can go ahead and merge
this.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-12-27 22:11 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-20 17:34 [Buildroot] [PATCH 1/4] package/janet: add host variant Francois Perrad via buildroot
2025-12-20 17:34 ` [Buildroot] [PATCH 2/4] package/jmp: new host package Francois Perrad via buildroot
2025-12-27 22:05   ` Thomas Petazzoni via buildroot
2025-12-20 17:34 ` [Buildroot] [PATCH 3/4] package/janet: new infrastructure Francois Perrad via buildroot
2025-12-27 22:07   ` Thomas Petazzoni via buildroot
2025-12-20 17:34 ` [Buildroot] [PATCH 4/4] package/janet-spork: new package Francois Perrad via buildroot
2025-12-27 22:11   ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox