Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] package/log4cxx: fix ENABLE_ESMTP flag
@ 2026-02-11 14:32 Michael Nosthoff via buildroot
  2026-02-13 11:13 ` Julien Olivain via buildroot
  2026-05-04 14:47 ` Thomas Perale via buildroot
  0 siblings, 2 replies; 3+ messages in thread
From: Michael Nosthoff via buildroot @ 2026-02-11 14:32 UTC (permalink / raw)
  To: buildroot; +Cc: Thomas Petazzoni

commit cf686670b99ae0388b27867db64516c09b2de91f introduced a patch that
was later included in a release which made the usage of libesmtp
configurable. Later the switch was moved to the main CMakeLists.mk [0].

while the patch introduced the build flag LOG4CXX_ENABLE_ESMTP the
change to the .mk file used LOG4CXX_ENABLE_LIBESMTP.

So correct this.

Fixes:
CMake Warning:
  Manually-specified variables were not used by the project:
  LOG4CXX_ENABLE_LIBESMTP

[0] https://github.com/apache/logging-log4cxx/blob/rel/v1.3.1/CMakeLists.txt#L93

Signed-off-by: Michael Nosthoff <buildroot@heine.tech>

---

V2:
- use correct param name in commit message
- add reference to current CMakeLists.mk
---
 package/log4cxx/log4cxx.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/log4cxx/log4cxx.mk b/package/log4cxx/log4cxx.mk
index f4fb3854f3..57f9b1e844 100644
--- a/package/log4cxx/log4cxx.mk
+++ b/package/log4cxx/log4cxx.mk
@@ -23,10 +23,10 @@ LOG4CXX_DEPENDENCIES += boost
 endif
 
 ifeq ($(BR2_PACKAGE_LIBESMTP),y)
-LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_LIBESMTP=ON
+LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_ESMTP=ON
 LOG4CXX_DEPENDENCIES += libesmtp
 else
-LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_LIBESMTP=OFF
+LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_ESMTP=OFF
 endif
 
 ifeq ($(BR2_PACKAGE_UNIXODBC),y)
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH v2] package/log4cxx: fix ENABLE_ESMTP flag
  2026-02-11 14:32 [Buildroot] [PATCH v2] package/log4cxx: fix ENABLE_ESMTP flag Michael Nosthoff via buildroot
@ 2026-02-13 11:13 ` Julien Olivain via buildroot
  2026-05-04 14:47 ` Thomas Perale via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Julien Olivain via buildroot @ 2026-02-13 11:13 UTC (permalink / raw)
  To: Michael Nosthoff; +Cc: buildroot, Thomas Petazzoni

On 11/02/2026 15:32, Michael Nosthoff via buildroot wrote:
> commit cf686670b99ae0388b27867db64516c09b2de91f introduced a patch that
> was later included in a release which made the usage of libesmtp
> configurable. Later the switch was moved to the main CMakeLists.mk [0].
> 
> while the patch introduced the build flag LOG4CXX_ENABLE_ESMTP the
> change to the .mk file used LOG4CXX_ENABLE_LIBESMTP.
> 
> So correct this.
> 
> Fixes:
> CMake Warning:
>   Manually-specified variables were not used by the project:
>   LOG4CXX_ENABLE_LIBESMTP
> 
> [0] 
> https://github.com/apache/logging-log4cxx/blob/rel/v1.3.1/CMakeLists.txt#L93
> 
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>

Applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH v2] package/log4cxx: fix ENABLE_ESMTP flag
  2026-02-11 14:32 [Buildroot] [PATCH v2] package/log4cxx: fix ENABLE_ESMTP flag Michael Nosthoff via buildroot
  2026-02-13 11:13 ` Julien Olivain via buildroot
@ 2026-05-04 14:47 ` Thomas Perale via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Perale via buildroot @ 2026-05-04 14:47 UTC (permalink / raw)
  To: Michael Nosthoff; +Cc: Thomas Perale, buildroot

In reply of:
> commit cf686670b99ae0388b27867db64516c09b2de91f introduced a patch that
> was later included in a release which made the usage of libesmtp
> configurable. Later the switch was moved to the main CMakeLists.mk [0].
> 
> while the patch introduced the build flag LOG4CXX_ENABLE_ESMTP the
> change to the .mk file used LOG4CXX_ENABLE_LIBESMTP.
> 
> So correct this.
> 
> Fixes:
> CMake Warning:
>   Manually-specified variables were not used by the project:
>   LOG4CXX_ENABLE_LIBESMTP
> 
> [0] https://github.com/apache/logging-log4cxx/blob/rel/v1.3.1/CMakeLists.txt#L93
> 
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> 

Applied to 2025.02.x. Thanks

> ---
> 
> V2:
> - use correct param name in commit message
> - add reference to current CMakeLists.mk
> ---
>  package/log4cxx/log4cxx.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/log4cxx/log4cxx.mk b/package/log4cxx/log4cxx.mk
> index f4fb3854f3..57f9b1e844 100644
> --- a/package/log4cxx/log4cxx.mk
> +++ b/package/log4cxx/log4cxx.mk
> @@ -23,10 +23,10 @@ LOG4CXX_DEPENDENCIES += boost
>  endif
>  
>  ifeq ($(BR2_PACKAGE_LIBESMTP),y)
> -LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_LIBESMTP=ON
> +LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_ESMTP=ON
>  LOG4CXX_DEPENDENCIES += libesmtp
>  else
> -LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_LIBESMTP=OFF
> +LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_ESMTP=OFF
>  endif
>  
>  ifeq ($(BR2_PACKAGE_UNIXODBC),y)
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-05-04 14:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-11 14:32 [Buildroot] [PATCH v2] package/log4cxx: fix ENABLE_ESMTP flag Michael Nosthoff via buildroot
2026-02-13 11:13 ` Julien Olivain via buildroot
2026-05-04 14:47 ` Thomas Perale via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox