[Buildroot] [PATCH] package/kodi: propagate mariadb dependencies to BR2_PACKAGE_KODI_MYSQL

[Buildroot] [PATCH] package/kodi: propagate mariadb dependencies to BR2_PACKAGE_KODI_MYSQL

[Thomas Petazzoni via buildroot]

Even though kodi itself has architecture dependencies (expressed
through BR2_PACKAGE_KODI_ARCH_SUPPORTS, the option
BR2_PACKAGE_KODI_MYSQL selects BR2_PACKAGE_MARIADB, which has its own
architecture dependencies as well. Make sure to propagate those to
BR2_PACKAGE_KODI_MYSQL, which doesn't require adding a Config.in
comment as these are purely architecture dependencies.

We haven't replicate all dependencies of BR2_PACKAGE_MARIADB because
all the others are covered by the top-level BR2_PACKAGE_KODI, and
propagating them would require adding a Config.in comment for
BR2_PACKAGE_KODI_MYSQL.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
We don't have a super clear/strong policy on whether dependencies need
to be replicated to a sub-option when the package top-level option
already has them. I haven't done so in this case, but if people feel
like it should be done, I'll be happy to send an updated patch.
---
 package/kodi/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/kodi/Config.in b/package/kodi/Config.in
index 08a7caae2c..0b13136d82 100644
--- a/package/kodi/Config.in
+++ b/package/kodi/Config.in
@@ -202,6 +202,7 @@ comment "nfs support needs a toolchain w/ threads support"
 
 config BR2_PACKAGE_KODI_MYSQL
 	bool "mysql"
+	depends on BR2_TOOLCHAIN_HAS_ATOMIC || BR2_TOOLCHAIN_HAS_SYNC_8 # mariadb
 	select BR2_PACKAGE_MARIADB
 	help
 	  Enable MySQL support
-- 
2.55.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/kodi: propagate mariadb dependencies to BR2_PACKAGE_KODI_MYSQL

[Julien Olivain via buildroot]

On 13/09/2026 14:07, Thomas Petazzoni via buildroot wrote:
> Even though kodi itself has architecture dependencies (expressed
> through BR2_PACKAGE_KODI_ARCH_SUPPORTS, the option
> BR2_PACKAGE_KODI_MYSQL selects BR2_PACKAGE_MARIADB, which has its own
> architecture dependencies as well. Make sure to propagate those to
> BR2_PACKAGE_KODI_MYSQL, which doesn't require adding a Config.in
> comment as these are purely architecture dependencies.
> 
> We haven't replicate all dependencies of BR2_PACKAGE_MARIADB because
> all the others are covered by the top-level BR2_PACKAGE_KODI, and
> propagating them would require adding a Config.in comment for
> BR2_PACKAGE_KODI_MYSQL.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.

> ---
> We don't have a super clear/strong policy on whether dependencies need
> to be replicated to a sub-option when the package top-level option
> already has them. I haven't done so in this case, but if people feel
> like it should be done, I'll be happy to send an updated patch.

I think most packages are not replicating top-level options.
When there is replication, it is sometime due to leftovers
after changes. This is why I applied this patch.

If we decide another policy, we'll have to realign all package
sub-options anyway.

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/kodi: propagate mariadb dependencies to BR2_PACKAGE_KODI_MYSQL

[Thomas Petazzoni via buildroot]

On Sun, Sep 13, 2026 at 05:36:49PM +0200, Julien Olivain wrote:

> > We don't have a super clear/strong policy on whether dependencies need
> > to be replicated to a sub-option when the package top-level option
> > already has them. I haven't done so in this case, but if people feel
> > like it should be done, I'll be happy to send an updated patch.
> 
> I think most packages are not replicating top-level options.
> When there is replication, it is sometime due to leftovers
> after changes. This is why I applied this patch.

The concern I have with not replicating is that then it's easy to miss
re-adding dependency to sub-options when dependencies get removed from
the top-level option for $whatever reason.

And of course the concern with replicating is that it adds a whole lot
more of Config.in comments :)

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/kodi: propagate mariadb dependencies to BR2_PACKAGE_KODI_MYSQL

[Thomas Perale via buildroot]

In reply of:
> Even though kodi itself has architecture dependencies (expressed
> through BR2_PACKAGE_KODI_ARCH_SUPPORTS, the option
> BR2_PACKAGE_KODI_MYSQL selects BR2_PACKAGE_MARIADB, which has its own
> architecture dependencies as well. Make sure to propagate those to
> BR2_PACKAGE_KODI_MYSQL, which doesn't require adding a Config.in
> comment as these are purely architecture dependencies.
> 
> We haven't replicate all dependencies of BR2_PACKAGE_MARIADB because
> all the others are covered by the top-level BR2_PACKAGE_KODI, and
> propagating them would require adding a Config.in comment for
> BR2_PACKAGE_KODI_MYSQL.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to 2025.02.x & 2026.08.x. Thanks

> ---
> We don't have a super clear/strong policy on whether dependencies need
> to be replicated to a sub-option when the package top-level option
> already has them. I haven't done so in this case, but if people feel
> like it should be done, I'll be happy to send an updated patch.
> ---
>  package/kodi/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/kodi/Config.in b/package/kodi/Config.in
> index 08a7caae2c..0b13136d82 100644
> --- a/package/kodi/Config.in
> +++ b/package/kodi/Config.in
> @@ -202,6 +202,7 @@ comment "nfs support needs a toolchain w/ threads support"
>  
>  config BR2_PACKAGE_KODI_MYSQL
>  	bool "mysql"
> +	depends on BR2_TOOLCHAIN_HAS_ATOMIC || BR2_TOOLCHAIN_HAS_SYNC_8 # mariadb
>  	select BR2_PACKAGE_MARIADB
>  	help
>  	  Enable MySQL support
> -- 
> 2.55.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot