[Buildroot] [PATCH] package/pulseview: add missing 'select BR2_PACKAGE_QT5GUI'

[Buildroot] [PATCH] package/pulseview: add missing 'select BR2_PACKAGE_QT5GUI'

[Thomas Petazzoni via buildroot]

BR2_PACKAGE_PULSEVIEW selects BR2_PACKAGE_QT5BASE_PNG and
BR2_PACKAGE_QT5BASE_WIDGETS, which both depend on
BR2_PACKAGE_QT5BASE_GUI. It ends working because we also select
BR2_PACKAGE_QT5SVG, which selects BR2_PACKAGE_QT5BASE_GUI, so there is
no bug, but it's bit inconsistent to select sub-options that have a
"depends on" without selecting the option they depend on.

This not a bug fix, it has no functional implication.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/pulseview/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/pulseview/Config.in b/package/pulseview/Config.in
index b1f9dc25d7..b9dbd88c28 100644
--- a/package/pulseview/Config.in
+++ b/package/pulseview/Config.in
@@ -17,6 +17,7 @@ config BR2_PACKAGE_PULSEVIEW
 	select BR2_PACKAGE_LIBSIGROKCXX
 	select BR2_PACKAGE_QT5
 	select BR2_PACKAGE_QT5BASE
+	select BR2_PACKAGE_QT5BASE_GUI
 	select BR2_PACKAGE_QT5BASE_PNG
 	select BR2_PACKAGE_QT5BASE_WIDGETS
 	select BR2_PACKAGE_QT5SVG
-- 
2.55.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/pulseview: add missing 'select BR2_PACKAGE_QT5GUI'

[Julien Olivain via buildroot]

On 13/09/2026 18:08, Thomas Petazzoni via buildroot wrote:
> BR2_PACKAGE_PULSEVIEW selects BR2_PACKAGE_QT5BASE_PNG and
> BR2_PACKAGE_QT5BASE_WIDGETS, which both depend on
> BR2_PACKAGE_QT5BASE_GUI. It ends working because we also select
> BR2_PACKAGE_QT5SVG, which selects BR2_PACKAGE_QT5BASE_GUI, so there is
> no bug, but it's bit inconsistent to select sub-options that have a
> "depends on" without selecting the option they depend on.
> 
> This not a bug fix, it has no functional implication.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/pulseview: add missing 'select BR2_PACKAGE_QT5GUI'

[Thomas Perale via buildroot]

In reply of:
> BR2_PACKAGE_PULSEVIEW selects BR2_PACKAGE_QT5BASE_PNG and
> BR2_PACKAGE_QT5BASE_WIDGETS, which both depend on
> BR2_PACKAGE_QT5BASE_GUI. It ends working because we also select
> BR2_PACKAGE_QT5SVG, which selects BR2_PACKAGE_QT5BASE_GUI, so there is
> no bug, but it's bit inconsistent to select sub-options that have a
> "depends on" without selecting the option they depend on.
> 
> This not a bug fix, it has no functional implication.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to 2025.02.x & 2026.08.x. Thanks

> ---
>  package/pulseview/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/pulseview/Config.in b/package/pulseview/Config.in
> index b1f9dc25d7..b9dbd88c28 100644
> --- a/package/pulseview/Config.in
> +++ b/package/pulseview/Config.in
> @@ -17,6 +17,7 @@ config BR2_PACKAGE_PULSEVIEW
>  	select BR2_PACKAGE_LIBSIGROKCXX
>  	select BR2_PACKAGE_QT5
>  	select BR2_PACKAGE_QT5BASE
> +	select BR2_PACKAGE_QT5BASE_GUI
>  	select BR2_PACKAGE_QT5BASE_PNG
>  	select BR2_PACKAGE_QT5BASE_WIDGETS
>  	select BR2_PACKAGE_QT5SVG
> -- 
> 2.55.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot