[Buildroot] [PATCH 1/1] Allow svn tags and branches notation in $(PKG)_VERSION variable.

[Buildroot] [PATCH 1/1] Allow svn tags and branches notation in $(PKG)_VERSION variable.

[Raúl Sánchez Siles]

According to user manual "generic-package Reference" section, LIBFOO_VERSION
could refer to a branch or tag. This patch adds supports for this in the svn
method case for the repositories following the branches/tags/trunk layout.

Examples:
LIBFOO_VERSION = tags/v3.2.1
LIBFOO_SITE = svn://svn.server.net/myproject

LIBFOO2_VERSION = branches/featureA
LIBFOO2_SITE = http://svn.happyserver.net/theproject
LIBFOO2_SITE_METHOD = svn


Signed-off-by: Ra?l S?nchez Siles <rasasi78@gmail.com>
---
 docs/manual/adding-packages-generic.txt | 2 ++
 package/pkg-download.mk                 | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Allow-svn-tags-and-branches-notation-in-PKG-_VERSION.patch
Type: text/x-patch
Size: 1350 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130918/e022a560/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130918/e022a560/attachment.asc>

[Buildroot] [PATCH 1/1] Allow svn tags and branches notation in $(PKG)_VERSION variable.

[Thomas Petazzoni]

Dear Ra?l S?nchez Siles,

On Wed, 18 Sep 2013 07:11:43 +0200, Ra?l S?nchez Siles wrote:

> According to user manual "generic-package Reference" section, LIBFOO_VERSION
> could refer to a branch or tag. This patch adds supports for this in the svn
> method case for the repositories following the branches/tags/trunk layout.
> 
> Examples:
> LIBFOO_VERSION = tags/v3.2.1
> LIBFOO_SITE = svn://svn.server.net/myproject
> 
> LIBFOO2_VERSION = branches/featureA
> LIBFOO2_SITE = http://svn.happyserver.net/theproject
> LIBFOO2_SITE_METHOD = svn
> 
> Signed-off-by: Ra?l S?nchez Siles <rasasi78@gmail.com>

Hum, I am not sure. In the SVN world, a version is really a revision
number that you get with 'svn checkout -r'.

I believe to get a specific branch or tag with SVN, one should instead
use:

LIBFOO2_VERSION = <some revision number>
LIBFOO2_SITE = http://svn.happyserver.net/theproject/branches/featureA

I do understand the wish to make things 'like other VCS', but I am not
entirely convinced it's a good idea. But I can probably be convinced
with good arguments :)

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 1/1] Allow svn tags and branches notation in $(PKG)_VERSION variable.

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 Thomas> Hum, I am not sure. In the SVN world, a version is really a
 Thomas> revision number that you get with 'svn checkout -r'.

 Thomas> I believe to get a specific branch or tag with SVN, one should
 Thomas> instead use:

 Thomas> LIBFOO2_VERSION = <some revision number>
 Thomas> LIBFOO2_SITE = http://svn.happyserver.net/theproject/branches/featureA

 Thomas> I do understand the wish to make things 'like other VCS', but I am not
 Thomas> entirely convinced it's a good idea. But I can probably be convinced
 Thomas> with good arguments :)

Yes, I would also prefer to keep it as it is.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v2 1/1] Allow svn tags and branches notation in $(PKG)_VERSION variable.

[Raúl Sánchez Siles]

According to user manual "generic-package Reference" section, LIBFOO_VERSION
could refer to a branch or tag. This patch adds supports for this in the svn
method case for the repositories following the branches/tags/trunk layout.

Examples:
LIBFOO_VERSION = tags/v3.2.1
LIBFOO_SITE = svn://svn.server.net/myproject

LIBFOO2_VERSION = branches/featureA
LIBFOO2_SITE = http://svn.happyserver.net/theproject
LIBFOO2_SITE_METHOD = svn

Signed-off-by: Ra?l S?nchez Siles <rasasi78@gmail.com>
---
 docs/manual/adding-packages-generic.txt | 2 ++
 package/pkg-download.mk                 | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2-0001-Allow-svn-tags-and-branches-notation-in-PKG-_VERS.patch
Type: text/x-patch
Size: 1350 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130919/2165e8a1/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130919/2165e8a1/attachment.asc>

[Buildroot] [PATCH v2 0/1] Allow svn tags and branches notation in $(PKG)_VERSION variable.

[Raúl Sánchez Siles]

Hi:

  Even that I understand Tom's answer as a NAK, I decided to send a revision 
of the previous patch, just for the record. In this version the last modified 
svn revision for the tag (or branch) is retrieved (and exactly that).

  Maybe someone can come with better and acceptable ideas from the buildroot 
point of view.

  I still consider the key point is being able to encode the revision into the 
$(PKG)_SOURCE variable.

  Regards,

Ra?l S?nchez Siles (1):
  Allow svn tags and branches notation in $(PKG)_VERSION variable.

 docs/manual/adding-packages-generic.txt | 2 ++
 package/pkg-download.mk                 | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)

-- 
1.8.4.rc3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130919/05db55a5/attachment.asc>

[Buildroot] [PATCH v2 0/1] Allow svn tags and branches notation in $(PKG)_VERSION variable.

[Raúl Sánchez Siles]

  Sorry, I meant Peter.

El Jueves, 19 de septiembre de 2013 23:58:55 usted escribi?:
> Hi:
> 
>   Even that I understand Tom's answer as a NAK, I decided to send a revision 
-- 
     Ra?l S?nchez Siles
----->Proud Debian user<-----
Linux registered user #416098
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130920/c7bf7bff/attachment.asc>

[Buildroot] [PATCH v2 0/1] Allow svn tags and branches notation in $(PKG)_VERSION variable.

[Thomas Petazzoni]

Dear Ra?l S?nchez Siles,

On Thu, 19 Sep 2013 23:58:55 +0200, Ra?l S?nchez Siles wrote:

>   I still consider the key point is being able to encode the revision into the 
> $(PKG)_SOURCE variable.

I guess you meant "the key point is being able to encode the revision
into the $(PKG)_VERSION" variable. But I don't see why this is
important or useful, so could you explain why you believe it is
necessary?

For example, for Buildroot, doing:

LIBFOO2_VERSION = branches/featureA
LIBFOO2_SITE = http://svn.happyserver.net/theproject

is not recommended at all, because you don't know which version of
"featureA" you will be getting. One user may be fetching one revision,
and if another user builds the same Buildroot configuration a few days
later, it might be another revision with additional changes.

That's why you should instead use:

LIBFOO2_VERSION = <some revision number>
LIBFOO2_SITE = http://svn.happyserver.net/theproject/branches/featureA

What is the problem with doing this?

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com