* [Buildroot] [PATCH] force devtmpfs and inotify kernel option when udev is used as dev handler
@ 2014-01-08 13:48 Jérémy Rosen
2014-01-08 14:13 ` Danomi Manchego
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jérémy Rosen @ 2014-01-08 13:48 UTC (permalink / raw)
To: buildroot
Signed-off-by: J?r?my Rosen <jeremy.rosen@openwide.fr>
---
patch suggested by Thomas Petazzoni
I also added devtmpfs because it's documented as needed but wasn't enforced
---
linux/linux.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/linux/linux.mk b/linux/linux.mk
index fa8aa0c..2482952 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -185,6 +185,10 @@ define LINUX_CONFIGURE_CMDS
$(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
$(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV),
$(call KCONFIG_SET_OPT,CONFIG_UEVENT_HELPER_PATH,\"/sbin/mdev\",$(@D)/.config))
+ $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV),
+ $(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config)
+ $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
+ $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
$(if $(BR2_PACKAGE_KTAP),
$(call KCONFIG_ENABLE_OPT,CONFIG_DEBUG_FS,$(@D)/.config)
$(call KCONFIG_ENABLE_OPT,CONFIG_EVENT_TRACING,$(@D)/.config)
--
1.8.5.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] force devtmpfs and inotify kernel option when udev is used as dev handler
2014-01-08 13:48 [Buildroot] [PATCH] force devtmpfs and inotify kernel option when udev is used as dev handler Jérémy Rosen
@ 2014-01-08 14:13 ` Danomi Manchego
2014-01-08 15:42 ` Jeremy Rosen
2014-01-08 15:45 ` Thomas Petazzoni
2014-01-08 21:28 ` Peter Korsgaard
2 siblings, 1 reply; 6+ messages in thread
From: Danomi Manchego @ 2014-01-08 14:13 UTC (permalink / raw)
To: buildroot
J?r?my,
On Wed, Jan 8, 2014 at 8:48 AM, J?r?my Rosen <jeremy.rosen@openwide.fr> wrote:
> Signed-off-by: J?r?my Rosen <jeremy.rosen@openwide.fr>
>
> ---
> patch suggested by Thomas Petazzoni
>
> I also added devtmpfs because it's documented as needed but wasn't enforced
> ---
> linux/linux.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/linux/linux.mk b/linux/linux.mk
> index fa8aa0c..2482952 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -185,6 +185,10 @@ define LINUX_CONFIGURE_CMDS
> $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
> $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV),
> $(call KCONFIG_SET_OPT,CONFIG_UEVENT_HELPER_PATH,\"/sbin/mdev\",$(@D)/.config))
> + $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV),
> + $(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config)
The above INOTIFY line has an extra leading space compared with the other lines.
Danomi -
> + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
> $(if $(BR2_PACKAGE_KTAP),
> $(call KCONFIG_ENABLE_OPT,CONFIG_DEBUG_FS,$(@D)/.config)
> $(call KCONFIG_ENABLE_OPT,CONFIG_EVENT_TRACING,$(@D)/.config)
> --
> 1.8.5.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] force devtmpfs and inotify kernel option when udev is used as dev handler
2014-01-08 14:13 ` Danomi Manchego
@ 2014-01-08 15:42 ` Jeremy Rosen
0 siblings, 0 replies; 6+ messages in thread
From: Jeremy Rosen @ 2014-01-08 15:42 UTC (permalink / raw)
To: buildroot
good catch, i'll wait for more feedback (if any) and then resend
Cordialement
J?r?my Rosen
+33 (0)1 42 68 28 04
fight key loggers : write some perl using vim
Open Wide Ingenierie
23, rue Daviel
75012 Paris - France
www.openwide.fr
----- Mail original -----
> J?r?my,
>
> On Wed, Jan 8, 2014 at 8:48 AM, J?r?my Rosen
> <jeremy.rosen@openwide.fr> wrote:
> > Signed-off-by: J?r?my Rosen <jeremy.rosen@openwide.fr>
> >
> > ---
> > patch suggested by Thomas Petazzoni
> >
> > I also added devtmpfs because it's documented as needed but wasn't
> > enforced
> > ---
> > linux/linux.mk | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/linux/linux.mk b/linux/linux.mk
> > index fa8aa0c..2482952 100644
> > --- a/linux/linux.mk
> > +++ b/linux/linux.mk
> > @@ -185,6 +185,10 @@ define LINUX_CONFIGURE_CMDS
> > $(call
> > KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
> > $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV),
> > $(call
> > KCONFIG_SET_OPT,CONFIG_UEVENT_HELPER_PATH,\"/sbin/mdev\",$(@D)/.config))
> > + $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV),
> > + $(call
> > KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config)
>
> The above INOTIFY line has an extra leading space compared with the
> other lines.
>
> Danomi -
>
> > + $(call
> > KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
> > + $(call
> > KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
> > $(if $(BR2_PACKAGE_KTAP),
> > $(call
> > KCONFIG_ENABLE_OPT,CONFIG_DEBUG_FS,$(@D)/.config)
> > $(call
> > KCONFIG_ENABLE_OPT,CONFIG_EVENT_TRACING,$(@D)/.config)
> > --
> > 1.8.5.2
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] force devtmpfs and inotify kernel option when udev is used as dev handler
2014-01-08 13:48 [Buildroot] [PATCH] force devtmpfs and inotify kernel option when udev is used as dev handler Jérémy Rosen
2014-01-08 14:13 ` Danomi Manchego
@ 2014-01-08 15:45 ` Thomas Petazzoni
2014-01-09 8:03 ` Jeremy Rosen
2014-01-08 21:28 ` Peter Korsgaard
2 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2014-01-08 15:45 UTC (permalink / raw)
To: buildroot
Dear J?r?my Rosen,
On Wed, 8 Jan 2014 14:48:33 +0100, J?r?my Rosen wrote:
> + $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV),
> + $(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
These two last lines are not needed, we already have:
$(if $(BR2_ROOTFS_DEVICE_CREATION_STATIC),,
$(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
$(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
Note the two commas at the end of the first line. It means that when
BR2_ROOTFS_DEVICE_CREATION_STATIC is *NOT* enabled, then we enabled
devtmpfs and devtmpfs_mount.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] force devtmpfs and inotify kernel option when udev is used as dev handler
2014-01-08 13:48 [Buildroot] [PATCH] force devtmpfs and inotify kernel option when udev is used as dev handler Jérémy Rosen
2014-01-08 14:13 ` Danomi Manchego
2014-01-08 15:45 ` Thomas Petazzoni
@ 2014-01-08 21:28 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2014-01-08 21:28 UTC (permalink / raw)
To: buildroot
>>>>> "J?r?my" == J?r?my Rosen <jeremy.rosen@openwide.fr> writes:
> Signed-off-by: J?r?my Rosen <jeremy.rosen@openwide.fr>
> ---
> patch suggested by Thomas Petazzoni
> I also added devtmpfs because it's documented as needed but wasn't enforced
> ---
> linux/linux.mk | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/linux/linux.mk b/linux/linux.mk
> index fa8aa0c..2482952 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -185,6 +185,10 @@ define LINUX_CONFIGURE_CMDS
> $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
> $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV),
> $(call KCONFIG_SET_OPT,CONFIG_UEVENT_HELPER_PATH,\"/sbin/mdev\",$(@D)/.config))
> + $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV),
> + $(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
Committed with the indentation fixed and the unneeded devtmpfs handling
removed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] force devtmpfs and inotify kernel option when udev is used as dev handler
2014-01-08 15:45 ` Thomas Petazzoni
@ 2014-01-09 8:03 ` Jeremy Rosen
0 siblings, 0 replies; 6+ messages in thread
From: Jeremy Rosen @ 2014-01-09 8:03 UTC (permalink / raw)
To: buildroot
----- Mail original -----
> Dear J?r?my Rosen,
>
> On Wed, 8 Jan 2014 14:48:33 +0100, J?r?my Rosen wrote:
>
> > + $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV),
> > + $(call
> > KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config)
> > + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
> > + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
>
> These two last lines are not needed, we already have:
>
> $(if $(BR2_ROOTFS_DEVICE_CREATION_STATIC),,
> $(call
> KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
> $(call
> KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
>
> Note the two commas at the end of the first line. It means that when
> BR2_ROOTFS_DEVICE_CREATION_STATIC is *NOT* enabled, then we enabled
> devtmpfs and devtmpfs_mount.
>
geez, I hate make syntax :(
thx for the catch, someday i'll learn.
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-01-09 8:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-08 13:48 [Buildroot] [PATCH] force devtmpfs and inotify kernel option when udev is used as dev handler Jérémy Rosen
2014-01-08 14:13 ` Danomi Manchego
2014-01-08 15:42 ` Jeremy Rosen
2014-01-08 15:45 ` Thomas Petazzoni
2014-01-09 8:03 ` Jeremy Rosen
2014-01-08 21:28 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox