[Buildroot] [PATCH] Fix naming mismatch between directfb and kernel on "fusion" version numbers

[Buildroot] [PATCH] Fix naming mismatch between directfb and kernel on "fusion" version numbers

[Ulf Samuelsson]

directfb expects FUSION_API_MAJOR_PROVIDED and FUSION_API_MINOR_REQUIRED
At least some kernel versions provides FUSION_API_MAJOR and FUSION_API_MINOR
Since the expected names are not defined, directfb will break with the
error message:

"../../../lib/fusion/types.h:42:2: error: #error Major version of Fusion
Kernel Module too low! Upgrade your kernel."

This patch will set XXX_PROVIDED from XXX.


diff -urN directfb-1.4.1-0rig//lib/fusion/types.h
directfb-1.4.1/lib/fusion/types.h
--- directfb-1.4.1-0rig//lib/fusion/types.h    2009-06-02
18:47:23.000000000 +0200
+++ directfb-1.4.1/lib/fusion/types.h    2009-07-26 07:07:40.000000000 +0200
@@ -38,6 +38,19 @@
 #define FUSION_API_MAJOR_REQUIRED 8
 #define FUSION_API_MINOR_REQUIRED 0
 
+#if    !defined(FUSION_API_MAJOR_PROVIDED)
+#if    defined(FUSION_API_MAJOR)
+#define    FUSION_API_MAJOR_PROVIDED    FUSION_API_MAJOR
+#endif
+#endif
+
+#if    !defined(FUSION_API_MINOR_PROVIDED)
+#if    defined(FUSION_API_MINOR)
+#define    FUSION_API_MINOR_PROVIDED    FUSION_API_MINOR
+#endif
+#endif
+
+
 #if FUSION_API_MAJOR_REQUIRED > FUSION_API_MAJOR_PROVIDED
 #error Major version of Fusion Kernel Module too low! Upgrade your kernel.
 #else


BR
Ulf Samuelsson

[Buildroot] [PATCH] Fix naming mismatch between directfb and kernel on "fusion" version numbers

[Peter Korsgaard]

>>>>> "Ulf" == Ulf Samuelsson <ulf.samuelsson@atmel.com> writes:

 Ulf> directfb expects FUSION_API_MAJOR_PROVIDED and FUSION_API_MINOR_REQUIRED
 Ulf> At least some kernel versions provides FUSION_API_MAJOR and FUSION_API_MINOR
 Ulf> Since the expected names are not defined, directfb will break with the
 Ulf> error message:

 Ulf> "../../../lib/fusion/types.h:42:2: error: #error Major version of Fusion
 Ulf> Kernel Module too low! Upgrade your kernel."

 Ulf> This patch will set XXX_PROVIDED from XXX.

But aren't those kernel modules part of directfb? If not, does stuff
actually work (not just build) if you workaround this version
incompatibility? Wouldn't it make more sense to fix where the define
is set in the first place? Have you sent this by the directfb
developers?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] Fix naming mismatch between directfb and kernel on "fusion" version numbers

[Ulf Samuelsson]

Peter Korsgaard skrev:
>>>>>> "Ulf" == Ulf Samuelsson <ulf.samuelsson@atmel.com> writes:
>>>>>>             
>
>  Ulf> directfb expects FUSION_API_MAJOR_PROVIDED and FUSION_API_MINOR_REQUIRED
>  Ulf> At least some kernel versions provides FUSION_API_MAJOR and FUSION_API_MINOR
>  Ulf> Since the expected names are not defined, directfb will break with the
>  Ulf> error message:
>
>  Ulf> "../../../lib/fusion/types.h:42:2: error: #error Major version of Fusion
>  Ulf> Kernel Module too low! Upgrade your kernel."
>
>  Ulf> This patch will set XXX_PROVIDED from XXX.
>
> But aren't those kernel modules part of directfb? If not, does stuff
> actually work (not just build) if you workaround this version
> incompatibility? Wouldn't it make more sense to fix where the define
> is set in the first place? Have you sent this by the directfb
> developers?
>   
As far as I see, the major/minor version numbers provided
are the same as requested, but the naming is different.

BR
Ulf Samuelsson

[Buildroot] [PATCH] Fix naming mismatch between directfb and kernel on "fusion" version numbers

[Peter Korsgaard]

>>>>> "Ulf" == Ulf Samuelsson <ulf.samuelsson@atmel.com> writes:

Hi,

 >> But aren't those kernel modules part of directfb? If not, does
 >> stuff actually work (not just build) if you workaround this
 >> version incompatibility? Wouldn't it make more sense to fix where
 >> the define is set in the first place? Have you sent this by the
 >> directfb developers?
 >> 
 Ulf> As far as I see, the major/minor version numbers provided
 Ulf> are the same as requested, but the naming is different.

OK, what driver / setup exactly? Isn't the problem just that we need
to bump the linux-fusion package version?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] Fix naming mismatch between directfb and kernel on "fusion" version numbers

[Ulf Samuelsson]

Peter Korsgaard skrev:
>>>>>> "Ulf" == Ulf Samuelsson <ulf.samuelsson@atmel.com> writes:
> 
> Hi,
> 
>  >> But aren't those kernel modules part of directfb? If not, does
>  >> stuff actually work (not just build) if you workaround this
>  >> version incompatibility? Wouldn't it make more sense to fix where
>  >> the define is set in the first place? Have you sent this by the
>  >> directfb developers?
>  >> 
>  Ulf> As far as I see, the major/minor version numbers provided
>  Ulf> are the same as requested, but the naming is different.
> 
> OK, what driver / setup exactly? Isn't the problem just that we need
> to bump the linux-fusion package version?

The module is 8.0 and the requirement is 8.0
but since they use different defines it wont work.

It is really very simple

#define	A 8
#define B 8
#if A == B_PROVIDED
/* OK */
#else
#warning ""
#endif

The code should emit a warning if version A and B are not the same.
They are the same, but the warning will still occur,
since there is no definition of B_PROVIDED.

BR
Ulf Samuelsson

[Buildroot] [PATCH] Fix naming mismatch between directfb and kernel on "fusion" version numbers

[Peter Korsgaard]

>>>>> "Ulf" == Ulf Samuelsson <ulf.samuelsson@atmel.com> writes:

Hi,

 >> OK, what driver / setup exactly? Isn't the problem just that we need
 >> to bump the linux-fusion package version?

 Ulf> The module is 8.0 and the requirement is 8.0
 Ulf> but since they use different defines it wont work.

So why don't we just upgrade to linux-fusion-8.1.1 which has that typo
fixed instead?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] Fix naming mismatch between directfb and kernel on "fusion" version numbers

[Peter Korsgaard]

>>>>> "Ulf" == Ulf Samuelsson <ulf.samuelsson@atmel.com> writes:

 Ulf> The module is 8.0 and the requirement is 8.0
 Ulf> but since they use different defines it wont work.
 >> 
 >> So why don't we just upgrade to linux-fusion-8.1.1 which has that typo
 >> fixed instead?
 >> 

 Ulf> Be my guest.

*Beep* wrong answer. I'll forget about your patch then.

-- 
Bye, Peter Korsgaard