* [Buildroot] [PATCH] ti-utils: bump version and clean up
@ 2011-08-08 7:10 Yegor Yefremov
2011-08-09 11:28 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Yegor Yefremov @ 2011-08-08 7:10 UTC (permalink / raw)
To: buildroot
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
package/ti-utils/ti-utils.mk | 54 +++++++++++++++++++++++++++++++------------
1 file changed, 40 insertions(+), 14 deletions(-)
Index: b/package/ti-utils/ti-utils.mk
===================================================================
--- a/package/ti-utils/ti-utils.mk
+++ b/package/ti-utils/ti-utils.mk
@@ -4,26 +4,52 @@
#
#############################################################
-TI_UTILS_VERSION = fbceab8f228cff80fd29b830bb85a188c69def08
+TI_UTILS_VERSION = 06dbdb2727354b5f3ad7c723897f40051fddee49
TI_UTILS_SITE = git://github.com/gxk/ti-utils.git
TI_UTILS_DEPENDENCIES = libnl
-
+
define TI_UTILS_BUILD_CMDS
- $(MAKE1) NFSROOT="$(STAGING_DIR)" CC="$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS)" \
- -C $(@D) all
+ $(MAKE1) NFSROOT="$(STAGING_DIR)" \
+ CC="$(TARGET_CC) $(TARGET_CFLAGS) \
+ $(TARGET_LDFLAGS)" -C $(@D) all
endef
-
+
define TI_UTILS_INSTALL_TARGET_CMDS
- $(INSTALL) -m 0755 $(@D)/calibrator \
- $(TARGET_DIR)/usr/bin/calibrator
- $(INSTALL) -m 0755 $(@D)/scripts/go.sh \
- $(TARGET_DIR)/usr/bin/go.sh
+ mkdir -p $(TARGET_DIR)/usr/share/ti-utils/
+ mkdir -p $(TARGET_DIR)/usr/share/ti-utils/scripts
+ mkdir -p $(TARGET_DIR)/usr/share/ti-utils/ini_files
+ mkdir -p $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x
+ mkdir -p $(TARGET_DIR)/usr/share/ti-utils/ini_files/128x
+
+ $(INSTALL) -m 0755 $(@D)/calibrator \
+ $(TARGET_DIR)/usr/bin/calibrator
+ $(INSTALL) -m 0755 $(@D)/scripts/go.sh \
+ $(TARGET_DIR)/usr/share/ti-utils/scripts/go.sh
+
+ $(INSTALL) -m 0644 $(@D)/ini_files/127x/RFMD_S_3.5.ini \
+ $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x/RFMD_S_3.5.ini
+ $(INSTALL) -m 0644 $(@D)/ini_files/127x/TQS_D_1.0.ini \
+ $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x/TQS_D_1.0.ini
+ $(INSTALL) -m 0644 $(@D)/ini_files/127x/TQS_D_1.7.ini \
+ $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x/TQS_D_1.7.ini
+ $(INSTALL) -m 0644 $(@D)/ini_files/127x/TQS_S_2.5.ini \
+ $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x/TQS_S_2.5.ini
+ $(INSTALL) -m 0644 $(@D)/ini_files/127x/TQS_S_2.6.ini \
+ $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x/TQS_S_2.6.ini
+
+ $(INSTALL) -m 0644 $(@D)/ini_files/128x/RFMD_S_3.5.ini \
+ $(TARGET_DIR)/usr/share/ti-utils/ini_files/128x/RFMD_S_3.5.ini
+ $(INSTALL) -m 0644 $(@D)/ini_files/128x/TQS_D_1.0.ini \
+ $(TARGET_DIR)/usr/share/ti-utils/ini_files/128x/TQS_D_1.0.ini
+ $(INSTALL) -m 0644 $(@D)/ini_files/128x/TQS_D_1.7.ini \
+ $(TARGET_DIR)/usr/share/ti-utils/ini_files/128x/TQS_D_1.7.ini
+ $(INSTALL) -m 0644 $(@D)/ini_files/128x/TQS_S_2.6.ini \
+ $(TARGET_DIR)/usr/share/ti-utils/ini_files/128x/TQS_S_2.6.ini
endef
-
+
define TI_UTILS_UNINSTALL_TARGET_CMDS
- rm -f $(TARGET_DIR)/usr/bin/calibrator
- rm -f $(TARGET_DIR)/usr/bin/go.sh
+ rm -f $(TARGET_DIR)/usr/bin/calibrator
+ rm -fr $(TARGET_DIR)/usr/share/ti-utils
endef
-
+
$(eval $(call GENTARGETS,package,ti-utils))
-
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] ti-utils: bump version and clean up
2011-08-08 7:10 [Buildroot] [PATCH] ti-utils: bump version and clean up Yegor Yefremov
@ 2011-08-09 11:28 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2011-08-09 11:28 UTC (permalink / raw)
To: buildroot
>>>>> "Yegor" == Yegor Yefremov <yegor_sub1@visionsystems.de> writes:
Yegor> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Thanks, committed with some fixes (see below)
Yegor> -TI_UTILS_VERSION = fbceab8f228cff80fd29b830bb85a188c69def08
Yegor> +TI_UTILS_VERSION = 06dbdb2727354b5f3ad7c723897f40051fddee49
Yegor> TI_UTILS_SITE = git://github.com/gxk/ti-utils.git
Yegor> TI_UTILS_DEPENDENCIES = libnl
Yegor> -
Yegor> +
You have a lot of whitespace damage where you have added a space at the
beginning of each line.
Yegor> define TI_UTILS_BUILD_CMDS
Yegor> - $(MAKE1) NFSROOT="$(STAGING_DIR)" CC="$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS)" \
Yegor> - -C $(@D) all
Yegor> + $(MAKE1) NFSROOT="$(STAGING_DIR)" \
Yegor> + CC="$(TARGET_CC) $(TARGET_CFLAGS) \
Yegor> + $(TARGET_LDFLAGS)" -C $(@D) all
I prefer to indent the followup lines (like you do below) to make it
clear that it is part of the previous statement.
Yegor> endef
Yegor> -
Yegor> +
Yegor> define TI_UTILS_INSTALL_TARGET_CMDS
Yegor> - $(INSTALL) -m 0755 $(@D)/calibrator \
Yegor> - $(TARGET_DIR)/usr/bin/calibrator
Yegor> - $(INSTALL) -m 0755 $(@D)/scripts/go.sh \
Yegor> - $(TARGET_DIR)/usr/bin/go.sh
Yegor> + mkdir -p $(TARGET_DIR)/usr/share/ti-utils/
Yegor> + mkdir -p $(TARGET_DIR)/usr/share/ti-utils/scripts
Yegor> + mkdir -p $(TARGET_DIR)/usr/share/ti-utils/ini_files
Yegor> + mkdir -p $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x
Yegor> + mkdir -p $(TARGET_DIR)/usr/share/ti-utils/ini_files/128x
You can use install -D instead of these explicit mkdirs.
Yegor> +
Yegor> + $(INSTALL) -m 0755 $(@D)/calibrator \
Yegor> + $(TARGET_DIR)/usr/bin/calibrator
Yegor> + $(INSTALL) -m 0755 $(@D)/scripts/go.sh \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/scripts/go.sh
Yegor> +
Please keep lines < 80 chars.
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/127x/RFMD_S_3.5.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x/RFMD_S_3.5.ini
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/127x/TQS_D_1.0.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x/TQS_D_1.0.ini
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/127x/TQS_D_1.7.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x/TQS_D_1.7.ini
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/127x/TQS_S_2.5.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x/TQS_S_2.5.ini
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/127x/TQS_S_2.6.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x/TQS_S_2.6.ini
Yegor> +
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/128x/RFMD_S_3.5.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/128x/RFMD_S_3.5.ini
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/128x/TQS_D_1.0.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/128x/TQS_D_1.0.ini
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/128x/TQS_D_1.7.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/128x/TQS_D_1.7.ini
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/128x/TQS_S_2.6.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/128x/TQS_S_2.6.ini
Instead of all this we can just do:
cp -r $(@D)/ini_files $(TARGET_DIR)/usr/share/ti-utils
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-09 11:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-08 7:10 [Buildroot] [PATCH] ti-utils: bump version and clean up Yegor Yefremov
2011-08-09 11:28 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox