[Buildroot] 2012.08-rc3 skipping python modules during build

[Buildroot] 2012.08-rc3 skipping python modules during build

[Eric Seifert]

Hello, I have been using the stable 2012.05 build without issue and wanted
to try the latest rc3. I have a few extra python modules I have added to
the external python modules section. It seems in the latest rc3 is not
building them or even downloading the packages even though they are
selected in the menuconfig, they are just ignored. It works in the stable
2012.05 build. When I select one of the existing external modules such as
pthon-serial, it does get built.


Thanks,
Eric Seifert
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120828/edc77f03/attachment.html>

[Buildroot] 2012.08-rc3 skipping python modules during build

[Arnout Vandecappelle]

On 08/28/12 17:43, Eric Seifert wrote:
> Hello, I have been using the stable 2012.05 build without issue and wanted to try the latest rc3. I have a few extra
> python modules I have added to the external python modules section. It seems in the latest rc3 is not building them or
> even downloading the packages even though they are selected in the menuconfig, they are just ignored. It works in the
> stable 2012.05 build. When I select one of the existing external modules such as pthon-serial, it does get built.

  The package infrastructure has changed.  If you added a package ending with
$(eval $(call GENTARGETS))
it will be ignored.  Replace it with
$(eval $(call package-generic))

  (Note: this is just guesswork based on the limited information you gave.)

  Regards,
  Arnout
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] 2012.08-rc3 skipping python modules during build

[Thomas Petazzoni]

Le Tue, 28 Aug 2012 08:43:38 -0700,
Eric Seifert <eric.seifert@cyaninc.com> a ?crit :

> Hello, I have been using the stable 2012.05 build without issue and wanted
> to try the latest rc3. I have a few extra python modules I have added to
> the external python modules section. It seems in the latest rc3 is not
> building them or even downloading the packages even though they are
> selected in the menuconfig, they are just ignored. It works in the stable
> 2012.05 build. When I select one of the existing external modules such as
> pthon-serial, it does get built.

You aren't giving enough details to provide a final answer, but my
guess is that you should replace:

$(eval $(call GENTARGETS))

by

$(eval $(generic-package))

at the end of your Python external modules .mk files.

And also, you should submit those .mk files upstream if they correspond
to publicly available Python modules.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] 2012.08-rc3 skipping python modules during build

[Arnout Vandecappelle]

On 08/29/12 01:18, Thomas Petazzoni wrote:
> Le Tue, 28 Aug 2012 08:43:38 -0700,
> Eric Seifert<eric.seifert@cyaninc.com>  a ?crit :
>
>> Hello, I have been using the stable 2012.05 build without issue and wanted
>> to try the latest rc3. I have a few extra python modules I have added to
>> the external python modules section. It seems in the latest rc3 is not
>> building them or even downloading the packages even though they are
>> selected in the menuconfig, they are just ignored. It works in the stable
>> 2012.05 build. When I select one of the existing external modules such as
>> pthon-serial, it does get built.
>
> You aren't giving enough details to provide a final answer, but my
> guess is that you should replace:
>
> $(eval $(call GENTARGETS))
>
> by
>
> $(eval $(generic-package))
>
> at the end of your Python external modules .mk files.

  Maybe we should temporarily add something like

GENTARGETS = $$(error The GENTARGETS macro no longer exists; use $$$$(eval $$$$(generic-package)) or $$$$(eval 
$$$$(generic-host-package)))

  Regards,
  Arnout

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH] pkg-infra: warn about use of deprecated GENTARGETS

[Arnout Vandecappelle]

With the replacement of GENTARGETS by package-generic, there is a risk
that local packages don't work anymore without any indication of what
is wrong.  Therefore, generate an error message if the GENTARGETS,
AUTOTARGETS or CMAKETARGETS macro is still used.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

---
 package/Makefile.in |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/Makefile.in b/package/Makefile.in
index 6fad224..2502602 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -304,6 +304,12 @@ else
 SHARED_STATIC_LIBS_OPTS=--enable-static --enable-shared
 endif
 
+# Warn if a package uses the deprecated GENTARGETS macros.  This can be
+# removed again for BR-2012.11.
+GENTARGETS = $$(error The GENTARGETS macro no longer exists; use $$$$(eval $$$$(generic-package)) or $$$$(eval $$$$(host-generic-package)))
+AUTOTARGETS = $$(error The AUTOTARGETS macro no longer exists; use $$$$(eval $$$$(autotools-package)) or $$$$(eval $$$$(host-autotools-package)))
+CMAKETARGETS = $$(error The CMAKETARGETS macro no longer exists; use $$$$(eval $$$$(cmake-package)) or $$$$(eval $$$$(host-cmake-package)))
+
 include package/pkg-utils.mk
 include package/pkg-download.mk
 include package/pkg-autotools.mk
-- 
tg: (bc753d3..) t/gentargets-deprecated (depends on: master)

[Buildroot] [PATCH] pkg-infra: warn about use of deprecated GENTARGETS

[Arnout Vandecappelle]

On 08/29/12 02:37, Arnout Vandecappelle (Essensium/Mind) wrote:
> With the replacement of GENTARGETS by package-generic, there is a risk
> that local packages don't work anymore without any indication of what
> is wrong.  Therefore, generate an error message if the GENTARGETS,
> AUTOTARGETS or CMAKETARGETS macro is still used.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind)<arnout@mind.be>

  Note: this is for master, perhaps it can be left out of next.

  Note2: I only tested it with AUTOTARGETS.

  Regards,
  Arnout

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] 2012.08-rc3 skipping python modules during build

[Thomas Petazzoni]

Le Wed, 29 Aug 2012 02:35:43 +0200,
Arnout Vandecappelle <arnout@mind.be> a ?crit :

>   Maybe we should temporarily add something like
> 
> GENTARGETS = $$(error The GENTARGETS macro no longer exists; use $$$$(eval $$$$(generic-package)) or $$$$(eval 
> $$$$(generic-host-package)))

Care to send a patch for this (and the AUTOTARGETS, CMAKETARGETS as
well) ?

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] 2012.08-rc3 skipping python modules during build

[Eric Seifert]

Thanks Guys, that's the issue. I appreciate everyone's responsiveness! I
will submit the python module packages when I have worked out some issues
with them.

Thanks,
Eric Seifert

On Wed, Aug 29, 2012 at 4:54 AM, Thomas Petazzoni <
thomas.petazzoni@free-electrons.com> wrote:

> Le Wed, 29 Aug 2012 02:35:43 +0200,
> Arnout Vandecappelle <arnout@mind.be> a ?crit :
>
> >   Maybe we should temporarily add something like
> >
> > GENTARGETS = $$(error The GENTARGETS macro no longer exists; use
> $$$$(eval $$$$(generic-package)) or $$$$(eval
> > $$$$(generic-host-package)))
>
> Care to send a patch for this (and the AUTOTARGETS, CMAKETARGETS as
> well) ?
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120829/809577c1/attachment.html>

[Buildroot] 2012.08-rc3 skipping python modules during build

[Thomas Petazzoni]

Le Wed, 29 Aug 2012 08:36:29 -0700,
Eric Seifert <eric.seifert@cyaninc.com> a ?crit :

> Thanks Guys, that's the issue. I appreciate everyone's
> responsiveness! I will submit the python module packages when I have
> worked out some issues with them.

Excellent, thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] pkg-infra: warn about use of deprecated GENTARGETS

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 Arnout> With the replacement of GENTARGETS by package-generic, there is a risk
 Arnout> that local packages don't work anymore without any indication of what
 Arnout> is wrong.  Therefore, generate an error message if the GENTARGETS,
 Arnout> AUTOTARGETS or CMAKETARGETS macro is still used.

 Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Commmitted, thanks.

-- 
Bye, Peter Korsgaard