[Buildroot] Support for package liblog4c-localtime

[Buildroot] Support for package liblog4c-localtime

[Alexander Varnin]

Hello.
I've added package to buildroot to support liblog4c logging library (the 
version with localtime patch).
Please, include it in the main tree.
Alexander.

[Buildroot] Support for package liblog4c-localtime

[Alexander Varnin]

Sorry, forget to include patch file.

28.09.2012 20:18, Alexander Varnin ?????:
> Hello.
> I've added package to buildroot to support liblog4c logging library 
> (the version with localtime patch).
> Please, include it in the main tree.
> Alexander.
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-New-package-liblog4c-localtime.patch
Type: text/x-patch
Size: 2837 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120928/0f9342a3/attachment-0001.bin>

[Buildroot] Support for package liblog4c-localtime

[Thomas Petazzoni]

Dear Alexander Varnin,

On Fri, 28 Sep 2012 20:20:16 +0400, Alexander Varnin wrote:

> Sorry, forget to include patch file.

Please don't send patches as attached files, because we can't easily
comment on them. If you want to send patches properly, use the 'git
send-email' tool.

A few comments:

 * You're specifying a LIBLOG4C_SOURCE variable, but this variable is
   ignored because your LIBLOG4C_SITE starts with git://. You have to
   decide whether you want a tarball download (so LIBLOG4C_SOURCE
   should be a tarball name, and LIBLOG4C_SITE should be a http or ftp
   url) or if you want a Git download (so LIBLOG4C_SOURCE should not be
   set, and LIBLOG4C_SITE should point to a Git repository)

 * LIBLOG4C_INSTALL_STAGING should be set to YES. Your package is a
   library, and you are defining the <foo>_INSTALL_STAGING_CMDS
   variable.

 * Looking at https://github.com/rcmadruga/log4c-localtime, this
   package seems to use the autotools, so you should be using the
   autotools-package infrastructure, and most likely you don't need to
   define any of the LIBLOG4C_BUILD_CMDS, LIBLOG4C_INSTALL_STAGING_CMDS
   and LIBLOG4C_INSTALL_TARGET_CMDS variables.

 * There should not be a commented line in your
   <foo>_INSTALL_TARGET_CMDS variable. Ditto for <foo>_DEVICES and
   <foo>_PERMISSIONS.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] Support for package liblog4c-localtime

[Thomas Petazzoni]

Alexander,

On Sat, 29 Sep 2012 12:14:45 +0400, Alexander Varnin wrote:

> Thank you. I'll fix what you say, and send updated patch on monday.

Ok, great. Please keep the list in Cc when replying to me about
Buildroot things.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com