[Buildroot] [PATCH] New package liblog4c-localtime

Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed

* [Buildroot] [PATCH] New package liblog4c-localtime
@ 2012-10-04  9:08 Alexander Varnin
  2012-10-04  9:10 ` Alexander Varnin
  2012-10-05 19:47 ` Arnout Vandecappelle
  0 siblings, 2 replies; 11+ messages in thread
From: Alexander Varnin @ 2012-10-04  9:08 UTC (permalink / raw)
  To: buildroot

---
 package/Config.in                                |    1 +
 package/liblog4c-localtime/Config.in             |    9 +++++++++
 package/liblog4c-localtime/liblog4c-localtime.mk |   11 +++++++++++
 3 files changed, 21 insertions(+), 0 deletions(-)
 create mode 100644 package/liblog4c-localtime/Config.in
 create mode 100644 package/liblog4c-localtime/liblog4c-localtime.mk

diff --git a/package/Config.in b/package/Config.in
index 8a7c9c4..25752e5 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -387,6 +387,7 @@ source "package/lttng-libust/Config.in"
 source "package/orc/Config.in"
 source "package/poco/Config.in"
 source "package/startup-notification/Config.in"
+source "package/liblog4c-localtime/Config.in"
 endmenu
 
 menu "Text and terminal handling"
diff --git a/package/liblog4c-localtime/Config.in b/package/liblog4c-localtime/Config.in
new file mode 100644
index 0000000..58797be
--- /dev/null
+++ b/package/liblog4c-localtime/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_LIBLOG4C
+	bool "liblog4c-localtime"
+	help
+	  Log4c is a library of C for flexible logging to files, syslog 
+	  and other destinations.
+	  This version is with localtime patch, to make lib show times in
+	  local timezone.
+
+	  https://github.com/rcmadruga/log4c-localtime
diff --git a/package/liblog4c-localtime/liblog4c-localtime.mk b/package/liblog4c-localtime/liblog4c-localtime.mk
new file mode 100644
index 0000000..f0599c3
--- /dev/null
+++ b/package/liblog4c-localtime/liblog4c-localtime.mk
@@ -0,0 +1,11 @@
+ #############################################################
+ #
+ # liblog4c
+ #
+ #############################################################
+ LIBLOG4C_VERSION = 1.2.1
+ LIBLOG4C_SITE = git://github.com/rcmadruga/log4c-localtime.git
+ LIBLOG4C_INSTALL_STAGING = YES 
+
+ $(eval $(call AUTOTARGETS))
+
-- 
1.7.2.5

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [Buildroot] [PATCH] New package liblog4c-localtime
  2012-10-04  9:08 [Buildroot] [PATCH] New package liblog4c-localtime Alexander Varnin
@ 2012-10-04  9:10 ` Alexander Varnin
  2012-10-04  9:24   ` Samuel Martin
  2012-10-05 19:47 ` Arnout Vandecappelle
  1 sibling, 1 reply; 11+ messages in thread
From: Alexander Varnin @ 2012-10-04  9:10 UTC (permalink / raw)
  To: buildroot

Hello. I'm working on old buildroot version 2012.02.
For some reason, this package doesn't get include in build, even when i 
check config in menuconfig. What else should i have to do, to make 
package building?

04.10.2012 13:08, Alexander Varnin ?????:
> ---
>   package/Config.in                                |    1 +
>   package/liblog4c-localtime/Config.in             |    9 +++++++++
>   package/liblog4c-localtime/liblog4c-localtime.mk |   11 +++++++++++
>   3 files changed, 21 insertions(+), 0 deletions(-)
>   create mode 100644 package/liblog4c-localtime/Config.in
>   create mode 100644 package/liblog4c-localtime/liblog4c-localtime.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 8a7c9c4..25752e5 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -387,6 +387,7 @@ source "package/lttng-libust/Config.in"
>   source "package/orc/Config.in"
>   source "package/poco/Config.in"
>   source "package/startup-notification/Config.in"
> +source "package/liblog4c-localtime/Config.in"
>   endmenu
>   
>   menu "Text and terminal handling"
> diff --git a/package/liblog4c-localtime/Config.in b/package/liblog4c-localtime/Config.in
> new file mode 100644
> index 0000000..58797be
> --- /dev/null
> +++ b/package/liblog4c-localtime/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_LIBLOG4C
> +	bool "liblog4c-localtime"
> +	help
> +	  Log4c is a library of C for flexible logging to files, syslog
> +	  and other destinations.
> +	  This version is with localtime patch, to make lib show times in
> +	  local timezone.
> +
> +	  https://github.com/rcmadruga/log4c-localtime
> diff --git a/package/liblog4c-localtime/liblog4c-localtime.mk b/package/liblog4c-localtime/liblog4c-localtime.mk
> new file mode 100644
> index 0000000..f0599c3
> --- /dev/null
> +++ b/package/liblog4c-localtime/liblog4c-localtime.mk
> @@ -0,0 +1,11 @@
> + #############################################################
> + #
> + # liblog4c
> + #
> + #############################################################
> + LIBLOG4C_VERSION = 1.2.1
> + LIBLOG4C_SITE = git://github.com/rcmadruga/log4c-localtime.git
> + LIBLOG4C_INSTALL_STAGING = YES
> +
> + $(eval $(call AUTOTARGETS))
> +

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Buildroot] [PATCH] New package liblog4c-localtime
  2012-10-04  9:10 ` Alexander Varnin
@ 2012-10-04  9:24   ` Samuel Martin
  2012-10-04 13:36     ` Thomas Petazzoni
  0 siblings, 1 reply; 11+ messages in thread
From: Samuel Martin @ 2012-10-04  9:24 UTC (permalink / raw)
  To: buildroot

Hi Alexander,

2012/10/4 Alexander Varnin <fenixk19@mail.ru>:
> Hello. I'm working on old buildroot version 2012.02.
> For some reason, this package doesn't get include in build, even when i
> check config in menuconfig. What else should i have to do, to make package
> building?
>
> 04.10.2012 13:08, Alexander Varnin ?????:
>
[...]
>> diff --git a/package/liblog4c-localtime/liblog4c-localtime.mk
>> b/package/liblog4c-localtime/liblog4c-localtime.mk
>> new file mode 100644
>> index 0000000..f0599c3
>> --- /dev/null
>> +++ b/package/liblog4c-localtime/liblog4c-localtime.mk
>> @@ -0,0 +1,11 @@
>> + #############################################################
>> + #
>> + # liblog4c
>> + #
>> + #############################################################
>> + LIBLOG4C_VERSION = 1.2.1
>> + LIBLOG4C_SITE = git://github.com/rcmadruga/log4c-localtime.git
>> + LIBLOG4C_INSTALL_STAGING = YES
>> +
>> + $(eval $(call AUTOTARGETS))
>> +

The problem is the package name "liblog4c-localtime" does not match
the match the make target translation, which should be
"LIBLOG4C_LOCALTIME" instead of just "LIBLOG4C".

So, fix either the package name or the variables in the *.mk file,
then it should work.


Regards,

-- 
Sam

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Buildroot] [PATCH] New package liblog4c-localtime
  2012-10-04  9:24   ` Samuel Martin
@ 2012-10-04 13:36     ` Thomas Petazzoni
  0 siblings, 0 replies; 11+ messages in thread
From: Thomas Petazzoni @ 2012-10-04 13:36 UTC (permalink / raw)
  To: buildroot


On Thu, 4 Oct 2012 11:24:04 +0200, Samuel Martin wrote:

> >> + $(eval $(call AUTOTARGETS))

And also if you want us to apply this patch in the current Buildroot
version, this has to be changed to:

$(eval $(autotools-package))

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Buildroot] [PATCH] New package liblog4c-localtime
  2012-10-04  9:08 [Buildroot] [PATCH] New package liblog4c-localtime Alexander Varnin
  2012-10-04  9:10 ` Alexander Varnin
@ 2012-10-05 19:47 ` Arnout Vandecappelle
  1 sibling, 0 replies; 11+ messages in thread
From: Arnout Vandecappelle @ 2012-10-05 19:47 UTC (permalink / raw)
  To: buildroot

On 04/10/12 11:08, Alexander Varnin wrote:

  Add a Signed-off-by line for yourself.  This is a short way for you to
assert that you are entitled to contribute the patch under buildroot's
GPL license.  See  http://kerneltrap.org/files/Jeremy/DCO.txt for more
details.

> ---
>   package/Config.in                                |    1 +
>   package/liblog4c-localtime/Config.in             |    9 +++++++++
>   package/liblog4c-localtime/liblog4c-localtime.mk |   11 +++++++++++
>   3 files changed, 21 insertions(+), 0 deletions(-)
>   create mode 100644 package/liblog4c-localtime/Config.in
>   create mode 100644 package/liblog4c-localtime/liblog4c-localtime.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 8a7c9c4..25752e5 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -387,6 +387,7 @@ source "package/lttng-libust/Config.in"
>   source "package/orc/Config.in"
>   source "package/poco/Config.in"
>   source "package/startup-notification/Config.in"
> +source "package/liblog4c-localtime/Config.in"
>   endmenu
>
>   menu "Text and terminal handling"
> diff --git a/package/liblog4c-localtime/Config.in b/package/liblog4c-localtime/Config.in
> new file mode 100644
> index 0000000..58797be
> --- /dev/null
> +++ b/package/liblog4c-localtime/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_LIBLOG4C
> +	bool "liblog4c-localtime"
> +	help
> +	  Log4c is a library of C for flexible logging to files, syslog
> +	  and other destinations.
> +	  This version is with localtime patch, to make lib show times in
> +	  local timezone.
> +
> +	  https://github.com/rcmadruga/log4c-localtime

  Add the upstream URL as well: http://log4c.sourceforge.net/

> diff --git a/package/liblog4c-localtime/liblog4c-localtime.mk b/package/liblog4c-localtime/liblog4c-localtime.mk
> new file mode 100644
> index 0000000..f0599c3
> --- /dev/null
> +++ b/package/liblog4c-localtime/liblog4c-localtime.mk
> @@ -0,0 +1,11 @@
> + #############################################################
> + #
> + # liblog4c
> + #
> + #############################################################
> + LIBLOG4C_VERSION = 1.2.1
> + LIBLOG4C_SITE = git://github.com/rcmadruga/log4c-localtime.git

  There's also a tarball:
LIBLOG4C_LOCALTIME_VERSION = v1.0
LIBLOG4C_LOCALTIME_SITE    = https://github.com/rcmadruga/log4c-localtime/tarball/v$(LIBLOG4C_LOCALTIME_VERSION)

> + LIBLOG4C_INSTALL_STAGING = YES
> +
> + $(eval $(call AUTOTARGETS))
> +

  Spurious newline at the end.


  It looks like it requires expat, so you need "select BR2_PACKAGE_EXPAT"
to Config.in, and "LIBLOG4C_LOCALTIME_DEPENDENCIES = expat" in .mk.  You'll
probably also need --disable-expattest for cross-compilation.


  Regards,
  Arnout

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Buildroot] [PATCH] New package liblog4c-localtime
@ 2012-10-08  6:56 Alexander Varnin
  2012-10-09 20:29 ` Arnout Vandecappelle
  0 siblings, 1 reply; 11+ messages in thread
From: Alexander Varnin @ 2012-10-08  6:56 UTC (permalink / raw)
  To: buildroot

---
 package/Config.in                                |    1 +
 package/liblog4c-localtime/Config.in             |    9 +++++++++
 package/liblog4c-localtime/liblog4c-localtime.mk |   17 +++++++++++++++++
 3 files changed, 27 insertions(+), 0 deletions(-)
 create mode 100644 package/liblog4c-localtime/Config.in
 create mode 100644 package/liblog4c-localtime/liblog4c-localtime.mk

diff --git a/package/Config.in b/package/Config.in
index 8a7c9c4..25752e5 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -387,6 +387,7 @@ source "package/lttng-libust/Config.in"
 source "package/orc/Config.in"
 source "package/poco/Config.in"
 source "package/startup-notification/Config.in"
+source "package/liblog4c-localtime/Config.in"
 endmenu
 
 menu "Text and terminal handling"
diff --git a/package/liblog4c-localtime/Config.in b/package/liblog4c-localtime/Config.in
new file mode 100644
index 0000000..68feab5
--- /dev/null
+++ b/package/liblog4c-localtime/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_LIBLOG4C_LOCALTIME
+	bool "liblog4c-localtime"
+	help
+	  Log4c is a library of C for flexible logging to files, syslog 
+	  and other destinations.
+	  This version is with localtime patch, to make lib show times in
+	  local timezone.
+
+	  https://github.com/rcmadruga/log4c-localtime
diff --git a/package/liblog4c-localtime/liblog4c-localtime.mk b/package/liblog4c-localtime/liblog4c-localtime.mk
new file mode 100644
index 0000000..9936759
--- /dev/null
+++ b/package/liblog4c-localtime/liblog4c-localtime.mk
@@ -0,0 +1,17 @@
+ #############################################################
+ #
+ # liblog4c
+ #
+ #############################################################
+ LIBLOG4C_LOCALTIME_VERSION = 6b92bb84dad6f3f1a7cb97035e45f87bce5fa158
+ LIBLOG4C_LOCALTIME_SITE = git://github.com/rcmadruga/log4c-localtime.git
+ LIBLOG4C_LOCALTIME_INSTALL_STAGING = YES 
+
+ define LIBLOG4C_LOCALTIME_HOOK
+   chmod +x $(@D)/configure
+ endef
+
+ LIBLOG4C_LOCALTIME_PRE_CONFIGURE_HOOKS += LIBLOG4C_LOCALTIME_HOOK
+
+ $(eval $(autotools-package))
+
-- 
1.7.2.5

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [Buildroot] [PATCH] New package liblog4c-localtime
  2012-10-08  6:56 Alexander Varnin
@ 2012-10-09 20:29 ` Arnout Vandecappelle
  2012-10-11  9:17   ` Alexander Varnin
  0 siblings, 1 reply; 11+ messages in thread
From: Arnout Vandecappelle @ 2012-10-09 20:29 UTC (permalink / raw)
  To: buildroot

  [Alexander, your mail server refuses mail from me, so I'm sending my
comments only to the list; I already sent them last Friday, but
obviously you didn't see them.]

  [List: sorry for the double posting...]

On 04/10/12 11:08, Alexander Varnin wrote:

  Add a Signed-off-by line for yourself.  This is a short way for you to
assert that you are entitled to contribute the patch under buildroot's
GPL license.  See  http://kerneltrap.org/files/Jeremy/DCO.txt for more
details.

> ---
>   package/Config.in                                |    1 +
>   package/liblog4c-localtime/Config.in             |    9 +++++++++
>   package/liblog4c-localtime/liblog4c-localtime.mk |   11 +++++++++++
>   3 files changed, 21 insertions(+), 0 deletions(-)
>   create mode 100644 package/liblog4c-localtime/Config.in
>   create mode 100644 package/liblog4c-localtime/liblog4c-localtime.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 8a7c9c4..25752e5 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -387,6 +387,7 @@ source "package/lttng-libust/Config.in"
>   source "package/orc/Config.in"
>   source "package/poco/Config.in"
>   source "package/startup-notification/Config.in"
> +source "package/liblog4c-localtime/Config.in"
>   endmenu
>
>   menu "Text and terminal handling"
> diff --git a/package/liblog4c-localtime/Config.in b/package/liblog4c-localtime/Config.in
> new file mode 100644
> index 0000000..58797be
> --- /dev/null
> +++ b/package/liblog4c-localtime/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_LIBLOG4C
> +    bool "liblog4c-localtime"
> +    help
> +      Log4c is a library of C for flexible logging to files, syslog
> +      and other destinations.
> +      This version is with localtime patch, to make lib show times in
> +      local timezone.
> +
> +      https://github.com/rcmadruga/log4c-localtime

  Add the upstream URL as well: http://log4c.sourceforge.net/

> diff --git a/package/liblog4c-localtime/liblog4c-localtime.mk b/package/liblog4c-localtime/liblog4c-localtime.mk
> new file mode 100644
> index 0000000..f0599c3
> --- /dev/null
> +++ b/package/liblog4c-localtime/liblog4c-localtime.mk
> @@ -0,0 +1,11 @@
> + #############################################################
> + #
> + # liblog4c
> + #
> + #############################################################
> + LIBLOG4C_VERSION = 1.2.1
> + LIBLOG4C_SITE = git://github.com/rcmadruga/log4c-localtime.git

  There's also a tarball:
LIBLOG4C_LOCALTIME_VERSION = v1.0
LIBLOG4C_LOCALTIME_SITE    = https://github.com/rcmadruga/log4c-localtime/tarball/v$(LIBLOG4C_LOCALTIME_VERSION)

> + LIBLOG4C_INSTALL_STAGING = YES
> +
> + $(eval $(call AUTOTARGETS))
> +

  Spurious newline at the end.


  It looks like it requires expat, so you need "select BR2_PACKAGE_EXPAT"
to Config.in, and "LIBLOG4C_LOCALTIME_DEPENDENCIES = expat" in .mk.  You'll
probably also need --disable-expattest for cross-compilation.


  Regards,
  Arnout

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Buildroot] [PATCH] New package liblog4c-localtime
  2012-10-09 20:29 ` Arnout Vandecappelle
@ 2012-10-11  9:17   ` Alexander Varnin
  2012-10-11  9:20     ` Arnout Vandecappelle
  0 siblings, 1 reply; 11+ messages in thread
From: Alexander Varnin @ 2012-10-11  9:17 UTC (permalink / raw)
  To: buildroot

10.10.2012 00:29, Arnout Vandecappelle ?????:
> + $(eval $(call AUTOTARGETS)) 
Will this line work on newer versions of buildroot?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Buildroot] [PATCH] New package liblog4c-localtime
  2012-10-11  9:17   ` Alexander Varnin
@ 2012-10-11  9:20     ` Arnout Vandecappelle
  0 siblings, 0 replies; 11+ messages in thread
From: Arnout Vandecappelle @ 2012-10-11  9:20 UTC (permalink / raw)
  To: buildroot

On 11/10/12 11:17, Alexander Varnin wrote:
> 10.10.2012 00:29, Arnout Vandecappelle ?????:
>> + $(eval $(call AUTOTARGETS))
> Will this line work on newer versions of buildroot?

  No it won't, but Thomas already gave that comment so I didn't repeat it.

  Regards,
  Arnout
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Buildroot] [PATCH] New package liblog4c-localtime
@ 2012-10-11  9:34 Alexander Varnin
  2012-10-21 19:10 ` Peter Korsgaard
  0 siblings, 1 reply; 11+ messages in thread
From: Alexander Varnin @ 2012-10-11  9:34 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Alexander Varnin <fenixk19@mail.ru>
---
 package/Config.in                                |    1 +
 package/liblog4c-localtime/Config.in             |   10 ++++++++++
 package/liblog4c-localtime/liblog4c-localtime.mk |   18 ++++++++++++++++++
 3 files changed, 29 insertions(+), 0 deletions(-)
 create mode 100644 package/liblog4c-localtime/Config.in
 create mode 100644 package/liblog4c-localtime/liblog4c-localtime.mk

diff --git a/package/Config.in b/package/Config.in
index 8a7c9c4..25752e5 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -387,6 +387,7 @@ source "package/lttng-libust/Config.in"
 source "package/orc/Config.in"
 source "package/poco/Config.in"
 source "package/startup-notification/Config.in"
+source "package/liblog4c-localtime/Config.in"
 endmenu
 
 menu "Text and terminal handling"
diff --git a/package/liblog4c-localtime/Config.in b/package/liblog4c-localtime/Config.in
new file mode 100644
index 0000000..5e9b863
--- /dev/null
+++ b/package/liblog4c-localtime/Config.in
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_LIBLOG4C_LOCALTIME
+	bool "liblog4c-localtime"
+	help
+	  Log4c is a library of C for flexible logging to files, syslog 
+	  and other destinations.
+	  This version is with localtime patch, to make lib show times in
+	  local timezone.
+
+	  https://github.com/rcmadruga/log4c-localtime
+          http://log4c.sourceforge.net/
diff --git a/package/liblog4c-localtime/liblog4c-localtime.mk b/package/liblog4c-localtime/liblog4c-localtime.mk
new file mode 100644
index 0000000..0aedec8
--- /dev/null
+++ b/package/liblog4c-localtime/liblog4c-localtime.mk
@@ -0,0 +1,18 @@
+ #############################################################
+ #
+ # liblog4c
+ #
+ #############################################################
+ LIBLOG4C_LOCALTIME_VERSION = 1.0
+ LIBLOG4C_LOCALTIME_SITE    = https://github.com/rcmadruga/log4c-localtime/tarball/v$(LIBLOG4C_LOCALTIME_VERSION) 
+ LIBLOG4C_LOCALTIME_INSTALL_STAGING = YES
+ LIBLOG4C_LOCALTIME_CONF_OPT = --disable-expattest
+ LIBLOG4C_LOCALTIME_DEPENDENCIES = expat
+
+ define LIBLOG4C_LOCALTIME_HOOK
+   chmod +x $(@D)/configure
+ endef
+
+ LIBLOG4C_LOCALTIME_PRE_CONFIGURE_HOOKS += LIBLOG4C_LOCALTIME_HOOK
+
+ $(eval $(autotools-package))
-- 
1.7.2.5

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [Buildroot] [PATCH] New package liblog4c-localtime
  2012-10-11  9:34 Alexander Varnin
@ 2012-10-21 19:10 ` Peter Korsgaard
  0 siblings, 0 replies; 11+ messages in thread
From: Peter Korsgaard @ 2012-10-21 19:10 UTC (permalink / raw)
  To: buildroot

>>>>> "Alexander" == Alexander Varnin <fenixk19@mail.ru> writes:

 Alexander> Signed-off-by: Alexander Varnin <fenixk19@mail.ru>

Thanks, committed with minor fixes (see below).

 Alexander> +++ b/package/liblog4c-localtime/Config.in
 Alexander> @@ -0,0 +1,10 @@
 Alexander> +config BR2_PACKAGE_LIBLOG4C_LOCALTIME
 Alexander> +	bool "liblog4c-localtime"

You forgot to select BR2_PACKAGE_EXPAT.

 Alexander> +	help
 Alexander> +	  Log4c is a library of C for flexible logging to files, syslog 

Please no trailing spaces.

 Alexander> +	  and other destinations.
 Alexander> +	  This version is with localtime patch, to make lib show times in
 Alexander> +	  local timezone.
 Alexander> +
 Alexander> +	  https://github.com/rcmadruga/log4c-localtime
 Alexander> +          http://log4c.sourceforge.net/

This should be indented with <tab><space><space> like the rest.

 Alexander> diff --git a/package/liblog4c-localtime/liblog4c-localtime.mk b/package/liblog4c-localtime/liblog4c-localtime.mk
 Alexander> new file mode 100644
 Alexander> index 0000000..0aedec8
 Alexander> --- /dev/null
 Alexander> +++ b/package/liblog4c-localtime/liblog4c-localtime.mk
 Alexander> @@ -0,0 +1,18 @@
 Alexander> + #############################################################
 Alexander> + #
 Alexander> + # liblog4c
 Alexander> + #
 Alexander> + #############################################################
 Alexander> + LIBLOG4C_LOCALTIME_VERSION = 1.0
 Alexander> + LIBLOG4C_LOCALTIME_SITE    = https://github.com/rcmadruga/log4c-localtime/tarball/v$(LIBLOG4C_LOCALTIME_VERSION) 

Please no trailing spaces.

 Alexander> + LIBLOG4C_LOCALTIME_INSTALL_STAGING = YES
 Alexander> + LIBLOG4C_LOCALTIME_CONF_OPT = --disable-expattest
 Alexander> + LIBLOG4C_LOCALTIME_DEPENDENCIES = expat
 Alexander> +
 Alexander> + define LIBLOG4C_LOCALTIME_HOOK
 Alexander> +   chmod +x $(@D)/configure
 Alexander> + endef
 Alexander> +
 Alexander> + LIBLOG4C_LOCALTIME_PRE_CONFIGURE_HOOKS += LIBLOG4C_LOCALTIME_HOOK

Please don't indent this. I renamed this hook to
LIBLOG4C_LOCALTIME_FIX_CONFIGURE_PERMS to make it clear what it does.


-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2012-10-21 19:10 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-04  9:08 [Buildroot] [PATCH] New package liblog4c-localtime Alexander Varnin
2012-10-04  9:10 ` Alexander Varnin
2012-10-04  9:24   ` Samuel Martin
2012-10-04 13:36     ` Thomas Petazzoni
2012-10-05 19:47 ` Arnout Vandecappelle
  -- strict thread matches above, loose matches on Subject: below --
2012-10-08  6:56 Alexander Varnin
2012-10-09 20:29 ` Arnout Vandecappelle
2012-10-11  9:17   ` Alexander Varnin
2012-10-11  9:20     ` Arnout Vandecappelle
2012-10-11  9:34 Alexander Varnin
2012-10-21 19:10 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox