[Buildroot] [PATCH 2/2 v3] xtensa: support configurable processor configurations

[Arnout Vandecappelle <arnout@mind.be>]

On 11/10/12 01:20, Chris Zankel wrote:
> Xtensa is a configurable processor architecture, which allows to define
> additional instructions and registers. The required variant specific
> information for the toolchain is delivered in an 'overlay' file, which
> needs to be 'untarred' to the corresponding directories after the
> source is installed and patched.
> This patch provides support for binutils, gcc, and gdb with a very
> limited changes to the build scripts. These additions are only executed
> for the Xtensa architecture and have no effect on other architectures.
>
> Signed-off-by: Chris Zankel<chris@zankel.net>
>
> diff --git a/arch/Config.in.xtensa b/arch/Config.in.xtensa
> new file mode 100644
> index 0000000..61c0235
> --- /dev/null
> +++ b/arch/Config.in.xtensa
> @@ -0,0 +1,30 @@
> +choice
> +	prompt "Target ABI"
> +	depends on BR2_xtensa
> +	default BR2_xtensa_fsf
> +config BR2_xtensa_custom
> +	bool "Custom Xtensa processor configuration"
> +config BR2_xtensa_fsf
> +	bool "fsf - Default configuration"
> +endchoice

  Put empty lines between the different config options.

  All config names should be in capitals - the only exception is the
arch name itself (i.e. BR2_xtensa, but BR2_XTENSA_FSF).

> +
> +config BR2_xtensa_custom_name
> +	string "Custom Xtensa processor configuration anme"

  anme -> name

> +	depends on BR2_xtensa_custom
> +	default ""
> +	help
> +	  Name given to a custom Xtensa processor configuration.
> +
> +config BR2_xtensa_core_name
> +	string
> +	default BR2_xtensa_custom_name	if BR2_xtensa_custom
> +	default ""			if BR2_xtensa_fsf

  Minor detail: missing "depends on BR2_xtensa".

  Perhaps it's better to move the condition to a
if BR2_xtensa
...
endif
around the entire file.  Thomas has a patch lined up to move all
the conditions outside of the Config.in.*

> +
> +config BR2_xtensa_overlay_dir
> +	string "Overlay directory for custom configuration"
> +	depends on BR2_xtensa_custom
> +	default ""
> +	help
> +	  Provide a directory path that contains the overlay files
> +	  for the custom configuration. The path is based on the
> +	  buildroot top directory.

  based on -> relative to

  I don't find this explanation sufficient. First of all, it should
mention that that directory should contain tar files. Second, it
would help if you could explain where the tar files are supposed
to come from (I guess they're generated by some Xtensa tool).


  Regards,
  Arnout

[snip]

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F