From: Chris Zankel <chris@zankel.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2 v3] xtensa: support configurable processor configurations
Date: Mon, 12 Nov 2012 15:45:47 -0800 [thread overview]
Message-ID: <50A18A2B.1050102@zankel.net> (raw)
In-Reply-To: <50A16B1E.8030703@mind.be>
On 11/12/2012 01:33 PM, Arnout Vandecappelle wrote:
>
> Perhaps it's better to move the condition to a
> if BR2_xtensa
> ...
> endif
> around the entire file. Thomas has a patch lined up to move all
> the conditions outside of the Config.in.*
>> It seems Xtensa would be the only one that uses that scheme, so maybe
>> wait for the generic patch from Thomas?
> I don't think so. Then it means more work for Thomas to refresh his
> patch. There will be a merge conflict anyway between the two, but
> with the condition outside the file the conflict will be small.
>
> That said, Peter hasn't merged Thomas's patch even though I acked
> it, so maybe he has some fundamental objection to the principle.
> Or maybe it's just because I didn't test it.
I guess I don't understand what that patch does, i.e. where is the
'if...endif'? Could you maybe point to the patch?
Thanks,
-Chris
next prev parent reply other threads:[~2012-11-12 23:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-10 0:20 [Buildroot] [PATCH 2/2 v3] xtensa: support configurable processor configurations Chris Zankel
2012-11-10 0:51 ` Arnout Vandecappelle
2012-11-12 21:28 ` Chris Zankel
2012-11-12 21:33 ` Arnout Vandecappelle
2012-11-12 23:45 ` Chris Zankel [this message]
2012-11-13 20:29 ` Arnout Vandecappelle
2012-11-13 21:01 ` Chris Zankel
2012-11-13 21:44 ` Thomas Petazzoni
2012-11-13 21:54 ` Chris Zankel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A18A2B.1050102@zankel.net \
--to=chris@zankel.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox