[Buildroot] [PATCH 2/2 v3] xtensa: support configurable processor configurations

[Chris Zankel <chris@zankel.net>]

Hi Arnout,

On 11/09/2012 04:51 PM, Arnout Vandecappelle wrote:
> On 11/10/12 01:20, Chris Zankel wrote:
>> +config BR2_xtensa_custom
>> +	bool "Custom Xtensa processor configuration"
>> +config BR2_xtensa_fsf
>> +	bool "fsf - Default configuration"
>> +endchoice
>   Put empty lines between the different config options.
Done.
>   All config names should be in capitals - the only exception is the
> arch name itself (i.e. BR2_xtensa, but BR2_XTENSA_FSF).
To give you some background, 'fsf' describes the default configuration
used in the various toolchain packages (gcc, buildroot, etc.). The idea
is to append the name of the processor configuration (for example,
dc232b), so to follow other architectures, I think it would be best to
keep lower-case for processor names, and upper case for other options.

For the case above, it would look like this:

config BR_XTENSA_CUSTOM
...

config BR_xtensa_fsf
...

config BR_xtensa_dc232b
...

etc.

I actually think that this makes a nice distinction between processor
names and buildroot configuration options.


>> +
>> +config BR2_xtensa_custom_name
>> +	string "Custom Xtensa processor configuration anme"
>   anme -> name
Done
>
>> +	depends on BR2_xtensa_custom
>> +	default ""
>> +	help
>> +	  Name given to a custom Xtensa processor configuration.
>> +
>> +config BR2_xtensa_core_name
>> +	string
>> +	default BR2_xtensa_custom_name	if BR2_xtensa_custom
>> +	default ""			if BR2_xtensa_fsf
>   Minor detail: missing "depends on BR2_xtensa".
Done.
>   Perhaps it's better to move the condition to a
> if BR2_xtensa
> ...
> endif
> around the entire file.  Thomas has a patch lined up to move all
> the conditions outside of the Config.in.*
It seems Xtensa would be the only one that uses that scheme, so maybe
wait for the generic patch from Thomas?

>> +
>> +config BR2_xtensa_overlay_dir
>> +	string "Overlay directory for custom configuration"
>> +	depends on BR2_xtensa_custom
>> +	default ""
>> +	help
>> +	  Provide a directory path that contains the overlay files
>> +	  for the custom configuration. The path is based on the
>> +	  buildroot top directory.
>   based on -> relative to
>
>   I don't find this explanation sufficient. First of all, it should
> mention that that directory should contain tar files. Second, it
> would help if you could explain where the tar files are supposed
> to come from (I guess they're generated by some Xtensa tool).
Made some additions, and will send a new set of patches in a bit...

-Chris