Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] Adding yavta (Yet Another V4L2 Test Application) as a package
@ 2013-01-09 12:29 kpa_info at yahoo.fr
  2013-01-09 12:29 ` [Buildroot] [PATCH 2/2] Adding media-ctl " kpa_info at yahoo.fr
  2013-01-09 15:59 ` [Buildroot] [PATCH 1/2] Adding yavta (Yet Another V4L2 Test Application) " Thomas Petazzoni
  0 siblings, 2 replies; 8+ messages in thread
From: kpa_info at yahoo.fr @ 2013-01-09 12:29 UTC (permalink / raw)
  To: buildroot

From: Patrick Gerber <kpa_info@yahoo.fr>


Signed-off-by: Patrick Gerber <kpa_info@yahoo.fr>
---
 package/multimedia/Config.in       |    1 +
 package/multimedia/yavta/Config.in |    4 ++++
 package/multimedia/yavta/yavta.mk  |   21 +++++++++++++++++++++
 3 files changed, 26 insertions(+)
 create mode 100644 package/multimedia/yavta/Config.in
 create mode 100644 package/multimedia/yavta/yavta.mk

diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in
index 273d9bc..da558ca 100644
--- a/package/multimedia/Config.in
+++ b/package/multimedia/Config.in
@@ -24,4 +24,5 @@ source "package/multimedia/pulseaudio/Config.in"
 source "package/multimedia/tidsp-binaries/Config.in"
 source "package/multimedia/vorbis-tools/Config.in"
 source "package/multimedia/wavpack/Config.in"
+source "package/multimedia/yavta/Config.in"
 endmenu
diff --git a/package/multimedia/yavta/Config.in b/package/multimedia/yavta/Config.in
new file mode 100644
index 0000000..3cca5c1
--- /dev/null
+++ b/package/multimedia/yavta/Config.in
@@ -0,0 +1,4 @@
+config BR2_PACKAGE_YAVTA
+	bool "yavta"
+	help
+	  Yet Another V4L2 Test Application
diff --git a/package/multimedia/yavta/yavta.mk b/package/multimedia/yavta/yavta.mk
new file mode 100644
index 0000000..1aa5574
--- /dev/null
+++ b/package/multimedia/yavta/yavta.mk
@@ -0,0 +1,20 @@
+#############################################################
+#
+# yavta
+#
+#############################################################
+
+YAVTA_VERSION = 82ff2efdb9787737b9f21b6f4759f077c827b238
+YAVTA_SITE = git://git.ideasonboard.org/yavta.git
+YAVTA_LICENSE = GPLv2
+YAVTA_LICENSE_FILES = COPYING.GPL
+
+define YAVTA_BUILD_CMDS
+$(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS)"
+endef
+
+define YAVTA_INSTALL_TARGET_CMDS
+install -m 0755 -D $(@D)/yavta $(TARGET_DIR)/usr/bin/yavta
+endef
+
+$(eval $(generic-package)) 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH 2/2] Adding media-ctl as a package
  2013-01-09 12:29 [Buildroot] [PATCH 1/2] Adding yavta (Yet Another V4L2 Test Application) as a package kpa_info at yahoo.fr
@ 2013-01-09 12:29 ` kpa_info at yahoo.fr
  2013-01-09 16:02   ` Thomas Petazzoni
  2013-01-09 15:59 ` [Buildroot] [PATCH 1/2] Adding yavta (Yet Another V4L2 Test Application) " Thomas Petazzoni
  1 sibling, 1 reply; 8+ messages in thread
From: kpa_info at yahoo.fr @ 2013-01-09 12:29 UTC (permalink / raw)
  To: buildroot

From: Patrick Gerber <kpa_info@yahoo.fr>


Signed-off-by: Patrick Gerber <kpa_info@yahoo.fr>
---
 package/Config.in              |    1 +
 package/media-ctl/Config.in    |    4 ++++
 package/media-ctl/media-ctl.mk |   18 ++++++++++++++++++
 3 files changed, 23 insertions(+)
 create mode 100644 package/media-ctl/Config.in
 create mode 100644 package/media-ctl/media-ctl.mk

diff --git a/package/Config.in b/package/Config.in
index bd1db6b..2f3b601 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -245,6 +245,7 @@ source "package/lshw/Config.in"
 source "package/lsuio/Config.in"
 source "package/lvm2/Config.in"
 source "package/mdadm/Config.in"
+source "package/media-ctl/Config.in"
 source "package/memtester/Config.in"
 source "package/minicom/Config.in"
 source "package/nanocom/Config.in"
diff --git a/package/media-ctl/Config.in b/package/media-ctl/Config.in
new file mode 100644
index 0000000..9fb888c
--- /dev/null
+++ b/package/media-ctl/Config.in
@@ -0,0 +1,4 @@
+config BR2_PACKAGE_MEDIA_CTL
+	bool "media-ctl"
+	help
+	  Media controller control application
diff --git a/package/media-ctl/media-ctl.mk b/package/media-ctl/media-ctl.mk
new file mode 100644
index 0000000..3c35278
--- /dev/null
+++ b/package/media-ctl/media-ctl.mk
@@ -0,0 +1,18 @@
+#############################################################
+#
+# media-ctl
+#
+#############################################################
+
+MEDIA_CTL_VERSION = ac40b79f002a2315f909548614ccd2d408da25b7
+MEDIA_CTL_SITE = git://git.ideasonboard.org/media-ctl.git
+MEDIA_CTL_INSTALL_STAGING = YES
+MEDIA_CTL_LICENSE = GPLv2
+MEDIA_CTL_LICENSE_FILES = COPYING.LIB
+
+MEDIA_CTL_AUTORECONF = YES
+MEDIA_CTL_AUTORECONF_OPT = --install
+MEDIA_CTL_CONF_OPT = --with-kernel-headers=$(STAGING_DIR)/usr/include
+MEDIA_CTL_DEPENDENCIES = host-pkgconf
+
+$(eval $(autotools-package))
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH 1/2] Adding yavta (Yet Another V4L2 Test Application) as a package
  2013-01-09 12:29 [Buildroot] [PATCH 1/2] Adding yavta (Yet Another V4L2 Test Application) as a package kpa_info at yahoo.fr
  2013-01-09 12:29 ` [Buildroot] [PATCH 2/2] Adding media-ctl " kpa_info at yahoo.fr
@ 2013-01-09 15:59 ` Thomas Petazzoni
  2013-01-10 10:21   ` Patrick
  1 sibling, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2013-01-09 15:59 UTC (permalink / raw)
  To: buildroot

Dear kpa_info at yahoo.fr,

It looks pretty good! I have a few comments below.

On Wed,  9 Jan 2013 13:29:53 +0100, kpa_info at yahoo.fr wrote:
> From: Patrick Gerber <kpa_info@yahoo.fr>
> 
> 
> Signed-off-by: Patrick Gerber <kpa_info@yahoo.fr>
> ---
>  package/multimedia/Config.in       |    1 +
>  package/multimedia/yavta/Config.in |    4 ++++
>  package/multimedia/yavta/yavta.mk  |   21 +++++++++++++++++++++
>  3 files changed, 26 insertions(+)
>  create mode 100644 package/multimedia/yavta/Config.in
>  create mode 100644 package/multimedia/yavta/yavta.mk
> 
> diff --git a/package/multimedia/Config.in
> b/package/multimedia/Config.in index 273d9bc..da558ca 100644
> --- a/package/multimedia/Config.in
> +++ b/package/multimedia/Config.in
> @@ -24,4 +24,5 @@ source "package/multimedia/pulseaudio/Config.in"
>  source "package/multimedia/tidsp-binaries/Config.in"
>  source "package/multimedia/vorbis-tools/Config.in"
>  source "package/multimedia/wavpack/Config.in"
> +source "package/multimedia/yavta/Config.in"
>  endmenu
> diff --git a/package/multimedia/yavta/Config.in
> b/package/multimedia/yavta/Config.in new file mode 100644
> index 0000000..3cca5c1
> --- /dev/null
> +++ b/package/multimedia/yavta/Config.in
> @@ -0,0 +1,4 @@
> +config BR2_PACKAGE_YAVTA
> +	bool "yavta"
> +	help
> +	  Yet Another V4L2 Test Application

Here, we want a empty line, and then the upstream URL of the
corresponding project.

See
http://buildroot.org/downloads/manual/manual.html#_literal_config_in_literal_file.


> +YAVTA_VERSION = 82ff2efdb9787737b9f21b6f4759f077c827b238
> +YAVTA_SITE = git://git.ideasonboard.org/yavta.git
> +YAVTA_LICENSE = GPLv2
> +YAVTA_LICENSE_FILES = COPYING.GPL
> +
> +define YAVTA_BUILD_CMDS
> +$(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS)"

This line could be intended with one tab, and could be written as
follows:

	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)

TARGET_CONFIGURE_OPTS contains the proper CC and CFLAGS definitions.

> +endef
> +
> +define YAVTA_INSTALL_TARGET_CMDS
> +install -m 0755 -D $(@D)/yavta $(TARGET_DIR)/usr/bin/yavta

Indentation, and install -> $(INSTALL)

	$(INSTALL) -m 0755 -D $(@D)/yavta $(TARGET_DIR)/usr/bin/yavta

> +endef
> +
> +$(eval $(generic-package)) 

Otherwise, looks good!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH 2/2] Adding media-ctl as a package
  2013-01-09 12:29 ` [Buildroot] [PATCH 2/2] Adding media-ctl " kpa_info at yahoo.fr
@ 2013-01-09 16:02   ` Thomas Petazzoni
  2013-01-10 10:24     ` Patrick
  0 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2013-01-09 16:02 UTC (permalink / raw)
  To: buildroot

Dear kpa_info at yahoo.fr,

On Wed,  9 Jan 2013 13:29:54 +0100, kpa_info at yahoo.fr wrote:
> +config BR2_PACKAGE_MEDIA_CTL
> +	bool "media-ctl"
> +	help
> +	  Media controller control application

One empty newline + upstream URL of the project (even if it's just a
http link to the Git repository). And also the description seems a bit
short, since it does not only contains an application, but also a
library, no?

> diff --git a/package/media-ctl/media-ctl.mk
> b/package/media-ctl/media-ctl.mk new file mode 100644
> index 0000000..3c35278
> --- /dev/null
> +++ b/package/media-ctl/media-ctl.mk
> @@ -0,0 +1,18 @@
> +#############################################################
> +#
> +# media-ctl
> +#
> +#############################################################
> +
> +MEDIA_CTL_VERSION = ac40b79f002a2315f909548614ccd2d408da25b7
> +MEDIA_CTL_SITE = git://git.ideasonboard.org/media-ctl.git
> +MEDIA_CTL_INSTALL_STAGING = YES
> +MEDIA_CTL_LICENSE = GPLv2

The license is LGPLv2.1+.

> +MEDIA_CTL_LICENSE_FILES = COPYING.LIB
> +
> +MEDIA_CTL_AUTORECONF = YES
> +MEDIA_CTL_AUTORECONF_OPT = --install

Are you sure this AUTORECONF_OPT is needed? If so, then please add a
comment before this line that explains why.

> +MEDIA_CTL_CONF_OPT = --with-kernel-headers=$(STAGING_DIR)/usr/include
> +MEDIA_CTL_DEPENDENCIES = host-pkgconf
> +
> +$(eval $(autotools-package))

Otherwise, looks good, thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH 1/2] Adding yavta (Yet Another V4L2 Test Application) as a package
  2013-01-09 15:59 ` [Buildroot] [PATCH 1/2] Adding yavta (Yet Another V4L2 Test Application) " Thomas Petazzoni
@ 2013-01-10 10:21   ` Patrick
  2013-01-10 10:28     ` Thomas Petazzoni
  0 siblings, 1 reply; 8+ messages in thread
From: Patrick @ 2013-01-10 10:21 UTC (permalink / raw)
  To: buildroot

On 01/09/2013 04:59 PM, Thomas Petazzoni wrote:
> Dear kpa_info at yahoo.fr,
>
> It looks pretty good! I have a few comments below.
>
> On Wed,  9 Jan 2013 13:29:53 +0100, kpa_info at yahoo.fr wrote:
>> From: Patrick Gerber <kpa_info@yahoo.fr>
>>
>>
>> Signed-off-by: Patrick Gerber <kpa_info@yahoo.fr>
>> ---
>>   package/multimedia/Config.in       |    1 +
>>   package/multimedia/yavta/Config.in |    4 ++++
>>   package/multimedia/yavta/yavta.mk  |   21 +++++++++++++++++++++
>>   3 files changed, 26 insertions(+)
>>   create mode 100644 package/multimedia/yavta/Config.in
>>   create mode 100644 package/multimedia/yavta/yavta.mk
>>
>> diff --git a/package/multimedia/Config.in
>> b/package/multimedia/Config.in index 273d9bc..da558ca 100644
>> --- a/package/multimedia/Config.in
>> +++ b/package/multimedia/Config.in
>> @@ -24,4 +24,5 @@ source "package/multimedia/pulseaudio/Config.in"
>>   source "package/multimedia/tidsp-binaries/Config.in"
>>   source "package/multimedia/vorbis-tools/Config.in"
>>   source "package/multimedia/wavpack/Config.in"
>> +source "package/multimedia/yavta/Config.in"
>>   endmenu
>> diff --git a/package/multimedia/yavta/Config.in
>> b/package/multimedia/yavta/Config.in new file mode 100644
>> index 0000000..3cca5c1
>> --- /dev/null
>> +++ b/package/multimedia/yavta/Config.in
>> @@ -0,0 +1,4 @@
>> +config BR2_PACKAGE_YAVTA
>> +	bool "yavta"
>> +	help
>> +	  Yet Another V4L2 Test Application
>
> Here, we want a empty line, and then the upstream URL of the
> corresponding project.
>
> See
> http://buildroot.org/downloads/manual/manual.html#_literal_config_in_literal_file.
>
>
>> +YAVTA_VERSION = 82ff2efdb9787737b9f21b6f4759f077c827b238
>> +YAVTA_SITE = git://git.ideasonboard.org/yavta.git
>> +YAVTA_LICENSE = GPLv2
>> +YAVTA_LICENSE_FILES = COPYING.GPL
>> +
>> +define YAVTA_BUILD_CMDS
>> +$(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS)"
>
> This line could be intended with one tab, and could be written as
> follows:
>
> 	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
>
> TARGET_CONFIGURE_OPTS contains the proper CC and CFLAGS definitions.
>
>> +endef
>> +
>> +define YAVTA_INSTALL_TARGET_CMDS
>> +install -m 0755 -D $(@D)/yavta $(TARGET_DIR)/usr/bin/yavta
>
> Indentation, and install -> $(INSTALL)
>
> 	$(INSTALL) -m 0755 -D $(@D)/yavta $(TARGET_DIR)/usr/bin/yavta
>
>> +endef
>> +
>> +$(eval $(generic-package))
>
> Otherwise, looks good!
>
> Thomas
>

Dear Thomas,

Please find below the new version of the patch according to your comments.

Patrick


From: Patrick Gerber <kpa_info@yahoo.fr>


Signed-off-by: Patrick Gerber <kpa_info@yahoo.fr>
---
  package/multimedia/Config.in       |    1 +
  package/multimedia/yavta/Config.in |    4 ++++
  package/multimedia/yavta/yavta.mk  |   21 +++++++++++++++++++++
  3 files changed, 26 insertions(+)
  create mode 100644 package/multimedia/yavta/Config.in
  create mode 100644 package/multimedia/yavta/yavta.mk

diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in
index 273d9bc..da558ca 100644
--- a/package/multimedia/Config.in
+++ b/package/multimedia/Config.in
@@ -24,4 +24,5 @@ source "package/multimedia/pulseaudio/Config.in"
  source "package/multimedia/tidsp-binaries/Config.in"
  source "package/multimedia/vorbis-tools/Config.in"
  source "package/multimedia/wavpack/Config.in"
+source "package/multimedia/yavta/Config.in"
  endmenu
diff --git a/package/multimedia/yavta/Config.in 
b/package/multimedia/yavta/Config.in
new file mode 100644
index 0000000..3cca5c1
--- /dev/null
+++ b/package/multimedia/yavta/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_YAVTA
+	bool "yavta"
+	help
+	  Yet Another V4L2 Test Application
+
+	  http://git.ideasonboard.org/yavta.git		
diff --git a/package/multimedia/yavta/yavta.mk 
b/package/multimedia/yavta/yavta.mk
new file mode 100644
index 0000000..1aa5574
--- /dev/null
+++ b/package/multimedia/yavta/yavta.mk
@@ -0,0 +1,20 @@
+#############################################################
+#
+# yavta
+#
+#############################################################
+
+YAVTA_VERSION = 82ff2efdb9787737b9f21b6f4759f077c827b238
+YAVTA_SITE = git://git.ideasonboard.org/yavta.git
+YAVTA_LICENSE = GPLv2
+YAVTA_LICENSE_FILES = COPYING.GPL
+
+define YAVTA_BUILD_CMDS
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
+endef
+
+define YAVTA_INSTALL_TARGET_CMDS
+	$(INSTALL) -m 0755 -D $(@D)/yavta $(TARGET_DIR)/usr/bin/yavta
+endef
+
+$(eval $(generic-package))
-- 1.7.9.5

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH 2/2] Adding media-ctl as a package
  2013-01-09 16:02   ` Thomas Petazzoni
@ 2013-01-10 10:24     ` Patrick
  0 siblings, 0 replies; 8+ messages in thread
From: Patrick @ 2013-01-10 10:24 UTC (permalink / raw)
  To: buildroot

On 01/09/2013 05:02 PM, Thomas Petazzoni wrote:
> Dear kpa_info at yahoo.fr,
>
> On Wed,  9 Jan 2013 13:29:54 +0100, kpa_info at yahoo.fr wrote:
>> +config BR2_PACKAGE_MEDIA_CTL
>> +	bool "media-ctl"
>> +	help
>> +	  Media controller control application
>
> One empty newline + upstream URL of the project (even if it's just a
> http link to the Git repository). And also the description seems a bit
> short, since it does not only contains an application, but also a
> library, no?
>
>> diff --git a/package/media-ctl/media-ctl.mk
>> b/package/media-ctl/media-ctl.mk new file mode 100644
>> index 0000000..3c35278
>> --- /dev/null
>> +++ b/package/media-ctl/media-ctl.mk
>> @@ -0,0 +1,18 @@
>> +#############################################################
>> +#
>> +# media-ctl
>> +#
>> +#############################################################
>> +
>> +MEDIA_CTL_VERSION = ac40b79f002a2315f909548614ccd2d408da25b7
>> +MEDIA_CTL_SITE = git://git.ideasonboard.org/media-ctl.git
>> +MEDIA_CTL_INSTALL_STAGING = YES
>> +MEDIA_CTL_LICENSE = GPLv2
>
> The license is LGPLv2.1+.
>
>> +MEDIA_CTL_LICENSE_FILES = COPYING.LIB
>> +
>> +MEDIA_CTL_AUTORECONF = YES
>> +MEDIA_CTL_AUTORECONF_OPT = --install
>
> Are you sure this AUTORECONF_OPT is needed? If so, then please add a
> comment before this line that explains why.
>
>> +MEDIA_CTL_CONF_OPT = --with-kernel-headers=$(STAGING_DIR)/usr/include
>> +MEDIA_CTL_DEPENDENCIES = host-pkgconf
>> +
>> +$(eval $(autotools-package))
>
> Otherwise, looks good, thanks!
>
> Thomas
>

Dear Thomas,

Please find below the new version of the patch according to your comments.

Patrick



From: Patrick Gerber <kpa_info@yahoo.fr>


Signed-off-by: Patrick Gerber <kpa_info@yahoo.fr>
---
  package/Config.in              |    1 +
  package/media-ctl/Config.in    |    4 ++++
  package/media-ctl/media-ctl.mk |   18 ++++++++++++++++++
  3 files changed, 23 insertions(+)
  create mode 100644 package/media-ctl/Config.in
  create mode 100644 package/media-ctl/media-ctl.mk

diff --git a/package/Config.in b/package/Config.in
index bd1db6b..2f3b601 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -245,6 +245,7 @@ source "package/lshw/Config.in"
  source "package/lsuio/Config.in"
  source "package/lvm2/Config.in"
  source "package/mdadm/Config.in"
+source "package/media-ctl/Config.in"
  source "package/memtester/Config.in"
  source "package/minicom/Config.in"
  source "package/nanocom/Config.in"
diff --git a/package/media-ctl/Config.in b/package/media-ctl/Config.in
new file mode 100644
index 0000000..9fb888c
--- /dev/null
+++ b/package/media-ctl/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_MEDIA_CTL
+	bool "media-ctl"
+	help
+	  Media controller control application
+
+	  http://git.ideasonboard.org/media-ctl.git
diff --git a/package/media-ctl/media-ctl.mk b/package/media-ctl/media-ctl.mk
new file mode 100644
index 0000000..3c35278
--- /dev/null
+++ b/package/media-ctl/media-ctl.mk
@@ -0,0 +1,17 @@
+#############################################################
+#
+# media-ctl
+#
+#############################################################
+
+MEDIA_CTL_VERSION = ac40b79f002a2315f909548614ccd2d408da25b7
+MEDIA_CTL_SITE = git://git.ideasonboard.org/media-ctl.git
+MEDIA_CTL_INSTALL_STAGING = YES
+MEDIA_CTL_LICENSE = LGPLv2.1+
+MEDIA_CTL_LICENSE_FILES = COPYING.LIB
+
+MEDIA_CTL_AUTORECONF = YES
+MEDIA_CTL_CONF_OPT = --with-kernel-headers=$(STAGING_DIR)/usr/include
+MEDIA_CTL_DEPENDENCIES = host-pkgconf
+
+$(eval $(autotools-package))
-- 1.7.9.5

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH 1/2] Adding yavta (Yet Another V4L2 Test Application) as a package
  2013-01-10 10:21   ` Patrick
@ 2013-01-10 10:28     ` Thomas Petazzoni
  2013-01-10 10:43       ` Patrick
  0 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2013-01-10 10:28 UTC (permalink / raw)
  To: buildroot

Dear Patrick,

On Thu, 10 Jan 2013 11:21:25 +0100, Patrick wrote:

> Please find below the new version of the patch according to your comments.

Thanks. Can you send them "for real", as you did for the initial
version? This way, the maintainer will be able to take them. Ideally,
change the patch title:

git send-email --to buildroot at uclibc.org --subject-prefix="PATCH v2" HEAD~2

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH 1/2] Adding yavta (Yet Another V4L2 Test Application) as a package
  2013-01-10 10:28     ` Thomas Petazzoni
@ 2013-01-10 10:43       ` Patrick
  0 siblings, 0 replies; 8+ messages in thread
From: Patrick @ 2013-01-10 10:43 UTC (permalink / raw)
  To: buildroot

On 01/10/2013 11:28 AM, Thomas Petazzoni wrote:
> Dear Patrick,
>
> On Thu, 10 Jan 2013 11:21:25 +0100, Patrick wrote:
>
>> Please find below the new version of the patch according to your comments.
>
> Thanks. Can you send them "for real", as you did for the initial
> version? This way, the maintainer will be able to take them. Ideally,
> change the patch title:
>
> git send-email --to buildroot at uclibc.org --subject-prefix="PATCH v2" HEAD~2
>
> Thanks,
>
> Thomas
>

Yep !

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2013-01-10 10:43 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-09 12:29 [Buildroot] [PATCH 1/2] Adding yavta (Yet Another V4L2 Test Application) as a package kpa_info at yahoo.fr
2013-01-09 12:29 ` [Buildroot] [PATCH 2/2] Adding media-ctl " kpa_info at yahoo.fr
2013-01-09 16:02   ` Thomas Petazzoni
2013-01-10 10:24     ` Patrick
2013-01-09 15:59 ` [Buildroot] [PATCH 1/2] Adding yavta (Yet Another V4L2 Test Application) " Thomas Petazzoni
2013-01-10 10:21   ` Patrick
2013-01-10 10:28     ` Thomas Petazzoni
2013-01-10 10:43       ` Patrick

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox