Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] initrd isn't needed for iso9660 when initramfs is used
@ 2013-08-22  5:09 Assaf Inbal
  2013-08-22  5:09 ` [Buildroot] [PATCH] iso9660 fs: no need to copy initrd when using initramfs Assaf Inbal
  2013-08-22  5:56 ` [Buildroot] initrd isn't needed for iso9660 when initramfs is used Arnout Vandecappelle
  0 siblings, 2 replies; 4+ messages in thread
From: Assaf Inbal @ 2013-08-22  5:09 UTC (permalink / raw)
  To: buildroot

I'm not entirely sure of this patch.
The problem is that, while initrd isn't needed when initramfs is used, the
default menu for grub always includes the initrd directive and will fail to load
when it's missing.
Perhaps we should have two grub menus? Or create it during build?
Any ideas?

Thanks,
Assaf

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] iso9660 fs: no need to copy initrd when using initramfs
  2013-08-22  5:09 [Buildroot] initrd isn't needed for iso9660 when initramfs is used Assaf Inbal
@ 2013-08-22  5:09 ` Assaf Inbal
  2013-08-22  5:56 ` [Buildroot] initrd isn't needed for iso9660 when initramfs is used Arnout Vandecappelle
  1 sibling, 0 replies; 4+ messages in thread
From: Assaf Inbal @ 2013-08-22  5:09 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Assaf Inbal <shmuelzon@gmail.com>
---
 fs/iso9660/iso9660.mk |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/iso9660/iso9660.mk b/fs/iso9660/iso9660.mk
index 317314a..12ab9eb 100644
--- a/fs/iso9660/iso9660.mk
+++ b/fs/iso9660/iso9660.mk
@@ -21,7 +21,9 @@ $(BINARIES_DIR)/rootfs.iso9660: host-cdrkit host-fakeroot linux rootfs-cpio grub
 	cp $(GRUB_DIR)/stage2/stage2_eltorito $(ISO9660_TARGET_DIR)/boot/grub/
 	cp $(ISO9660_BOOT_MENU) $(ISO9660_TARGET_DIR)/boot/grub/menu.lst
 	cp $(LINUX_IMAGE_PATH) $(ISO9660_TARGET_DIR)/kernel
-	cp $(BINARIES_DIR)/rootfs.cpio$(ISO9660_CPIO_EXT-y) $(ISO9660_TARGET_DIR)/initrd
+	if [ "$(BR2_TARGET_ROOTFS_INITRAMFS)" != "y" ]; then \
+	  cp $(BINARIES_DIR)/rootfs.cpio$(ISO9660_CPIO_EXT-y) $(ISO9660_TARGET_DIR)/initrd; \
+	fi
 	# Use fakeroot to pretend all target binaries are owned by root
 	rm -f $(FAKEROOT_SCRIPT)
 	echo "chown -R 0:0 $(ISO9660_TARGET_DIR)" >> $(FAKEROOT_SCRIPT)
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] initrd isn't needed for iso9660 when initramfs is used
  2013-08-22  5:09 [Buildroot] initrd isn't needed for iso9660 when initramfs is used Assaf Inbal
  2013-08-22  5:09 ` [Buildroot] [PATCH] iso9660 fs: no need to copy initrd when using initramfs Assaf Inbal
@ 2013-08-22  5:56 ` Arnout Vandecappelle
  2013-08-22  8:42   ` Assaf Inbal
  1 sibling, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2013-08-22  5:56 UTC (permalink / raw)
  To: buildroot

On 22/08/13 07:09, Assaf Inbal wrote:
> I'm not entirely sure of this patch.
> The problem is that, while initrd isn't needed when initramfs is used, the
> default menu for grub always includes the initrd directive and will fail to load
> when it's missing.

  Why do you want to use iso9660 with an initramfs? initramfs is only 
really useful for boat loaders that have a problem with passing an 
initrd, e.g. network boot.


  Regards,
  Arnout

> Perhaps we should have two grub menus? Or create it during build?
> Any ideas?
>
> Thanks,
> Assaf
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] initrd isn't needed for iso9660 when initramfs is used
  2013-08-22  5:56 ` [Buildroot] initrd isn't needed for iso9660 when initramfs is used Arnout Vandecappelle
@ 2013-08-22  8:42   ` Assaf Inbal
  0 siblings, 0 replies; 4+ messages in thread
From: Assaf Inbal @ 2013-08-22  8:42 UTC (permalink / raw)
  To: buildroot

Hey,

 Why do you want to use iso9660 with an initramfs? initramfs is only really
> useful for boat loaders that have a problem with passing an initrd, e.g.
> network boot.
>

Can't give you a real answer for that :)
I was basically playing around with a few things and didn't understand why
initrd was always included.
Feel free to disregard this patch.

Good day,
Assaf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130822/4b298588/attachment-0001.html>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-08-22  8:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-22  5:09 [Buildroot] initrd isn't needed for iso9660 when initramfs is used Assaf Inbal
2013-08-22  5:09 ` [Buildroot] [PATCH] iso9660 fs: no need to copy initrd when using initramfs Assaf Inbal
2013-08-22  5:56 ` [Buildroot] initrd isn't needed for iso9660 when initramfs is used Arnout Vandecappelle
2013-08-22  8:42   ` Assaf Inbal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox