From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv7 2/5] core: introduce the BR2_EXTERNAL variable
Date: Thu, 05 Dec 2013 23:43:40 +0100 [thread overview]
Message-ID: <52A1019C.9090605@mind.be> (raw)
In-Reply-To: <1386270673-16051-3-git-send-email-thomas.petazzoni@free-electrons.com>
On 05/12/13 20:11, Thomas Petazzoni wrote:
> +BR2_EXTERNAL_FILE = $(BASE_DIR)/.br-external
> +-include $(BR2_EXTERNAL_FILE)
> +ifeq ($(BR2_EXTERNAL),)
> + override BR2_EXTERNAL = support/dummy-external
> + $(shell rm -f $(BR2_EXTERNAL_FILE))
> +else
> + $(shell echo BR2_EXTERNAL ?= $(BR2_EXTERNAL) > $(BR2_EXTERNAL_FILE))
> +endif
Huh, did I write this? AFAIK we don't normally indent inside make
conditionals... And if we did, it would be with tabs.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-12-05 22:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 19:11 [Buildroot] [PATCHv7 0/5] Keeping customizations outside the Buildroot tree with BR2_EXTERNAL Thomas Petazzoni
2013-12-05 19:11 ` [Buildroot] [PATCHv7 1/5] manual: fix manual generation in preparation for BR2_EXTERNAL support Thomas Petazzoni
2013-12-05 19:11 ` [Buildroot] [PATCHv7 2/5] core: introduce the BR2_EXTERNAL variable Thomas Petazzoni
2013-12-05 19:42 ` Samuel Martin
2013-12-05 22:43 ` Arnout Vandecappelle [this message]
2013-12-05 19:11 ` [Buildroot] [PATCHv7 3/5] core: allow external Config.in/makefile code to be integrated Thomas Petazzoni
2013-12-05 19:43 ` Samuel Martin
2013-12-08 21:48 ` Peter Korsgaard
2013-12-05 19:11 ` [Buildroot] [PATCHv7 4/5] core: allow external defconfigs to be used Thomas Petazzoni
2013-12-05 19:45 ` Samuel Martin
2013-12-05 19:11 ` [Buildroot] [PATCHv7 5/5] docs/manual: add explanations about BR2_EXTERNAL Thomas Petazzoni
2013-12-05 19:41 ` Samuel Martin
2013-12-06 10:04 ` Ryan Barnett
2013-12-08 22:01 ` Peter Korsgaard
2013-12-08 22:02 ` [Buildroot] [PATCHv7 0/5] Keeping customizations outside the Buildroot tree with BR2_EXTERNAL Peter Korsgaard
2013-12-10 7:18 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A1019C.9090605@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox