From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv7 3/5] core: allow external Config.in/makefile code to be integrated
Date: Sun, 08 Dec 2013 22:48:39 +0100 [thread overview]
Message-ID: <87bo0r9fpk.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1386270673-16051-4-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Thu, 5 Dec 2013 20:11:11 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> This commit allows the BR2_EXTERNAL directory to contain Config.in and
> Makefile code, which gets integrated into the Buildroot build logic:
> - Buildroot automatically includes the $BR2_EXTERNAL/Config.in in the
> top-level configuration menu.
> - Buildroot automatically includes the BR2_EXTERNAL/external.mk in
> the build logic, so it can for example be used to include other .mk
> files that define package recipes.
> This is typically intended to be used to create target packages in the
> BR2_EXTERNAL directory, but can also be used for bootloaders, host
> packages, or other custom make logic.
> We also add a dummy Config.in file in support/dummy-external/ to
> ensure that the source "$BR2_EXTERNAL/Config.in" line will point to an
> existing file even when BR2_EXTERNAL is not used by the user.
[snip]
> diff --git a/Config.in b/Config.in
> index ea060bc..12d36b5 100644
> --- a/Config.in
> +++ b/Config.in
> @@ -492,3 +492,5 @@ source "boot/Config.in"
> source "package/Config.in.host"
> source "Config.in.legacy"
> +
> +source "$BR2_EXTERNAL/Config.in"
Should we perhaps add a comment before or put this inside a 'menu' so it
is clear that these things are NOT part of Buildroot and people
shouldn't ask the buildroot list for support for them?
Having a comment / empty menu when this isn't use is a bit annoying, but
we could perhaps use:
depends on BR2_EXTERNAL != "support/dummy-external"
I haven't tested if that works though.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-12-08 21:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 19:11 [Buildroot] [PATCHv7 0/5] Keeping customizations outside the Buildroot tree with BR2_EXTERNAL Thomas Petazzoni
2013-12-05 19:11 ` [Buildroot] [PATCHv7 1/5] manual: fix manual generation in preparation for BR2_EXTERNAL support Thomas Petazzoni
2013-12-05 19:11 ` [Buildroot] [PATCHv7 2/5] core: introduce the BR2_EXTERNAL variable Thomas Petazzoni
2013-12-05 19:42 ` Samuel Martin
2013-12-05 22:43 ` Arnout Vandecappelle
2013-12-05 19:11 ` [Buildroot] [PATCHv7 3/5] core: allow external Config.in/makefile code to be integrated Thomas Petazzoni
2013-12-05 19:43 ` Samuel Martin
2013-12-08 21:48 ` Peter Korsgaard [this message]
2013-12-05 19:11 ` [Buildroot] [PATCHv7 4/5] core: allow external defconfigs to be used Thomas Petazzoni
2013-12-05 19:45 ` Samuel Martin
2013-12-05 19:11 ` [Buildroot] [PATCHv7 5/5] docs/manual: add explanations about BR2_EXTERNAL Thomas Petazzoni
2013-12-05 19:41 ` Samuel Martin
2013-12-06 10:04 ` Ryan Barnett
2013-12-08 22:01 ` Peter Korsgaard
2013-12-08 22:02 ` [Buildroot] [PATCHv7 0/5] Keeping customizations outside the Buildroot tree with BR2_EXTERNAL Peter Korsgaard
2013-12-10 7:18 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo0r9fpk.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox