From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv7 5/5] docs/manual: add explanations about BR2_EXTERNAL
Date: Sun, 08 Dec 2013 23:01:31 +0100 [thread overview]
Message-ID: <877gbf9f44.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1386270673-16051-6-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Thu, 5 Dec 2013 20:11:13 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> This commit updates the manual to add details on how to use the
> BR2_EXTERNAL feature.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
I'm no native speaker, but there's a few things I think sound odd:
> +[[outside-br-custom]]
> +Keeping customization outside Buildroot
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I think it should be 'customizations'
> +
> +The Buildroot community recommends and encourages upstreaming to the
> +official Buildroot version the packages and board supports that are
> +written by developers. However, it is sometimes not possible or
> +desirable because some of these packages or board supports are highly
> +specific or proprietary.
And 'board support', not supports.
Committed with that fixed (and the missing + as pointed out by Samuel),
thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-12-08 22:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 19:11 [Buildroot] [PATCHv7 0/5] Keeping customizations outside the Buildroot tree with BR2_EXTERNAL Thomas Petazzoni
2013-12-05 19:11 ` [Buildroot] [PATCHv7 1/5] manual: fix manual generation in preparation for BR2_EXTERNAL support Thomas Petazzoni
2013-12-05 19:11 ` [Buildroot] [PATCHv7 2/5] core: introduce the BR2_EXTERNAL variable Thomas Petazzoni
2013-12-05 19:42 ` Samuel Martin
2013-12-05 22:43 ` Arnout Vandecappelle
2013-12-05 19:11 ` [Buildroot] [PATCHv7 3/5] core: allow external Config.in/makefile code to be integrated Thomas Petazzoni
2013-12-05 19:43 ` Samuel Martin
2013-12-08 21:48 ` Peter Korsgaard
2013-12-05 19:11 ` [Buildroot] [PATCHv7 4/5] core: allow external defconfigs to be used Thomas Petazzoni
2013-12-05 19:45 ` Samuel Martin
2013-12-05 19:11 ` [Buildroot] [PATCHv7 5/5] docs/manual: add explanations about BR2_EXTERNAL Thomas Petazzoni
2013-12-05 19:41 ` Samuel Martin
2013-12-06 10:04 ` Ryan Barnett
2013-12-08 22:01 ` Peter Korsgaard [this message]
2013-12-08 22:02 ` [Buildroot] [PATCHv7 0/5] Keeping customizations outside the Buildroot tree with BR2_EXTERNAL Peter Korsgaard
2013-12-10 7:18 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gbf9f44.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox