* [Buildroot] [PATCH] gst1-plugins-bad: add missing opencv ml module dependency
@ 2014-03-05 22:55 Samuel Martin
2014-03-06 9:57 ` Vicente Olivert Riera
2014-03-06 17:25 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Samuel Martin @ 2014-03-05 22:55 UTC (permalink / raw)
To: buildroot
gst1-plugins-bad source code does include the old-style global opencv
header "opencv/cv.h", which includes headers from the core, imgproc,
video, features2d, flann, calib3d, objdetect and legacy modules.
However, the legacy module, in addition to headers from some of the
previously listed modules, also includes headers from the ml module.
Thus, the ml module must be selected to be able to build the legacy
one, so the gst-plugins-bad's opencv plugin.
Fixes:
http://autobuild.buildroot.net/results/d02/d02e1843ef90f4b40c99e3b23eddf376f827d46e/
Signed-off-by: Samuel Martin <s.martin49@gmail.com>
---
package/gstreamer1/gst1-plugins-bad/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in b/package/gstreamer1/gst1-plugins-bad/Config.in
index 0685322..2c5c290 100644
--- a/package/gstreamer1/gst1-plugins-bad/Config.in
+++ b/package/gstreamer1/gst1-plugins-bad/Config.in
@@ -434,6 +434,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_OPENCV
select BR2_PACKAGE_OPENCV_LIB_FLANN
select BR2_PACKAGE_OPENCV_LIB_IMGPROC
select BR2_PACKAGE_OPENCV_LIB_LEGACY
+ select BR2_PACKAGE_OPENCV_LIB_ML
select BR2_PACKAGE_OPENCV_LIB_OBJDETECT
select BR2_PACKAGE_OPENCV_LIB_VIDEO
help
--
1.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] gst1-plugins-bad: add missing opencv ml module dependency
2014-03-05 22:55 [Buildroot] [PATCH] gst1-plugins-bad: add missing opencv ml module dependency Samuel Martin
@ 2014-03-06 9:57 ` Vicente Olivert Riera
2014-03-06 10:31 ` Thomas Petazzoni
2014-03-06 10:35 ` Samuel Martin
2014-03-06 17:25 ` Thomas Petazzoni
1 sibling, 2 replies; 6+ messages in thread
From: Vicente Olivert Riera @ 2014-03-06 9:57 UTC (permalink / raw)
To: buildroot
On 03/05/2014 10:55 PM, Samuel Martin wrote:
> gst1-plugins-bad source code does include the old-style global opencv
> header "opencv/cv.h", which includes headers from the core, imgproc,
> video, features2d, flann, calib3d, objdetect and legacy modules.
>
> However, the legacy module, in addition to headers from some of the
> previously listed modules, also includes headers from the ml module.
>
> Thus, the ml module must be selected to be able to build the legacy
> one, so the gst-plugins-bad's opencv plugin.
>
> Fixes:
> http://autobuild.buildroot.net/results/d02/d02e1843ef90f4b40c99e3b23eddf376f827d46e/
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
> package/gstreamer1/gst1-plugins-bad/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in b/package/gstreamer1/gst1-plugins-bad/Config.in
> index 0685322..2c5c290 100644
> --- a/package/gstreamer1/gst1-plugins-bad/Config.in
> +++ b/package/gstreamer1/gst1-plugins-bad/Config.in
> @@ -434,6 +434,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_OPENCV
> select BR2_PACKAGE_OPENCV_LIB_FLANN
> select BR2_PACKAGE_OPENCV_LIB_IMGPROC
> select BR2_PACKAGE_OPENCV_LIB_LEGACY
> + select BR2_PACKAGE_OPENCV_LIB_ML
> select BR2_PACKAGE_OPENCV_LIB_OBJDETECT
> select BR2_PACKAGE_OPENCV_LIB_VIDEO
> help
>
Maybe your BR tree wasn't up to date in the moment to write this patch.
Look at this:
http://git.buildroot.net/buildroot/commit/?id=3324f4e8b69ab49783a233b27c9b2edeecedb5ce
--
Vincent
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] gst1-plugins-bad: add missing opencv ml module dependency
2014-03-06 9:57 ` Vicente Olivert Riera
@ 2014-03-06 10:31 ` Thomas Petazzoni
2014-03-06 10:34 ` Vicente Olivert Riera
2014-03-06 10:35 ` Samuel Martin
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2014-03-06 10:31 UTC (permalink / raw)
To: buildroot
Dear Vicente Olivert Riera,
On Thu, 6 Mar 2014 09:57:37 +0000, Vicente Olivert Riera wrote:
> On 03/05/2014 10:55 PM, Samuel Martin wrote:
> > gst1-plugins-bad source code does include the old-style global opencv
> > header "opencv/cv.h", which includes headers from the core, imgproc,
> > video, features2d, flann, calib3d, objdetect and legacy modules.
> >
> > However, the legacy module, in addition to headers from some of the
> > previously listed modules, also includes headers from the ml module.
> >
> > Thus, the ml module must be selected to be able to build the legacy
> > one, so the gst-plugins-bad's opencv plugin.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/d02/d02e1843ef90f4b40c99e3b23eddf376f827d46e/
> >
> > Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> > ---
> > package/gstreamer1/gst1-plugins-bad/Config.in | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in b/package/gstreamer1/gst1-plugins-bad/Config.in
> > index 0685322..2c5c290 100644
> > --- a/package/gstreamer1/gst1-plugins-bad/Config.in
> > +++ b/package/gstreamer1/gst1-plugins-bad/Config.in
> > @@ -434,6 +434,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_OPENCV
> > select BR2_PACKAGE_OPENCV_LIB_FLANN
> > select BR2_PACKAGE_OPENCV_LIB_IMGPROC
> > select BR2_PACKAGE_OPENCV_LIB_LEGACY
> > + select BR2_PACKAGE_OPENCV_LIB_ML
> > select BR2_PACKAGE_OPENCV_LIB_OBJDETECT
> > select BR2_PACKAGE_OPENCV_LIB_VIDEO
> > help
> >
>
> Maybe your BR tree wasn't up to date in the moment to write this patch.
> Look at this:
>
> http://git.buildroot.net/buildroot/commit/?id=3324f4e8b69ab49783a233b27c9b2edeecedb5ce
And? Samuel is just adding one more line here, in addition to the lines
you added in the commit you're pointing at.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] gst1-plugins-bad: add missing opencv ml module dependency
2014-03-06 10:31 ` Thomas Petazzoni
@ 2014-03-06 10:34 ` Vicente Olivert Riera
0 siblings, 0 replies; 6+ messages in thread
From: Vicente Olivert Riera @ 2014-03-06 10:34 UTC (permalink / raw)
To: buildroot
On 03/06/2014 10:31 AM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Thu, 6 Mar 2014 09:57:37 +0000, Vicente Olivert Riera wrote:
>> On 03/05/2014 10:55 PM, Samuel Martin wrote:
>>> gst1-plugins-bad source code does include the old-style global opencv
>>> header "opencv/cv.h", which includes headers from the core, imgproc,
>>> video, features2d, flann, calib3d, objdetect and legacy modules.
>>>
>>> However, the legacy module, in addition to headers from some of the
>>> previously listed modules, also includes headers from the ml module.
>>>
>>> Thus, the ml module must be selected to be able to build the legacy
>>> one, so the gst-plugins-bad's opencv plugin.
>>>
>>> Fixes:
>>> http://autobuild.buildroot.net/results/d02/d02e1843ef90f4b40c99e3b23eddf376f827d46e/
>>>
>>> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
>>> ---
>>> package/gstreamer1/gst1-plugins-bad/Config.in | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in b/package/gstreamer1/gst1-plugins-bad/Config.in
>>> index 0685322..2c5c290 100644
>>> --- a/package/gstreamer1/gst1-plugins-bad/Config.in
>>> +++ b/package/gstreamer1/gst1-plugins-bad/Config.in
>>> @@ -434,6 +434,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_OPENCV
>>> select BR2_PACKAGE_OPENCV_LIB_FLANN
>>> select BR2_PACKAGE_OPENCV_LIB_IMGPROC
>>> select BR2_PACKAGE_OPENCV_LIB_LEGACY
>>> + select BR2_PACKAGE_OPENCV_LIB_ML
>>> select BR2_PACKAGE_OPENCV_LIB_OBJDETECT
>>> select BR2_PACKAGE_OPENCV_LIB_VIDEO
>>> help
>>>
>>
>> Maybe your BR tree wasn't up to date in the moment to write this patch.
>> Look at this:
>>
>> http://git.buildroot.net/buildroot/commit/?id=3324f4e8b69ab49783a233b27c9b2edeecedb5ce
>
> And? Samuel is just adding one more line here, in addition to the lines
> you added in the commit you're pointing at.
>
> Thomas
>
You are right, sorry.
--
Vincent
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] gst1-plugins-bad: add missing opencv ml module dependency
2014-03-06 9:57 ` Vicente Olivert Riera
2014-03-06 10:31 ` Thomas Petazzoni
@ 2014-03-06 10:35 ` Samuel Martin
1 sibling, 0 replies; 6+ messages in thread
From: Samuel Martin @ 2014-03-06 10:35 UTC (permalink / raw)
To: buildroot
Hi Vincente,
On Thu, Mar 6, 2014 at 10:57 AM, Vicente Olivert Riera
<Vincent.Riera@imgtec.com> wrote:
> On 03/05/2014 10:55 PM, Samuel Martin wrote:
>>
>> gst1-plugins-bad source code does include the old-style global opencv
>> header "opencv/cv.h", which includes headers from the core, imgproc,
>> video, features2d, flann, calib3d, objdetect and legacy modules.
>>
>> However, the legacy module, in addition to headers from some of the
>> previously listed modules, also includes headers from the ml module.
>>
>> Thus, the ml module must be selected to be able to build the legacy
>> one, so the gst-plugins-bad's opencv plugin.
>>
>> Fixes:
>>
>> http://autobuild.buildroot.net/results/d02/d02e1843ef90f4b40c99e3b23eddf376f827d46e/
>>
>> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
>> ---
>> package/gstreamer1/gst1-plugins-bad/Config.in | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in
>> b/package/gstreamer1/gst1-plugins-bad/Config.in
>> index 0685322..2c5c290 100644
>> --- a/package/gstreamer1/gst1-plugins-bad/Config.in
>> +++ b/package/gstreamer1/gst1-plugins-bad/Config.in
>> @@ -434,6 +434,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_OPENCV
>> select BR2_PACKAGE_OPENCV_LIB_FLANN
>> select BR2_PACKAGE_OPENCV_LIB_IMGPROC
>> select BR2_PACKAGE_OPENCV_LIB_LEGACY
>> + select BR2_PACKAGE_OPENCV_LIB_ML
>> select BR2_PACKAGE_OPENCV_LIB_OBJDETECT
>> select BR2_PACKAGE_OPENCV_LIB_VIDEO
>> help
>>
>
> Maybe your BR tree wasn't up to date in the moment to write this patch. Look
> at this:
>
> http://git.buildroot.net/buildroot/commit/?id=3324f4e8b69ab49783a233b27c9b2edeecedb5ce
The worktree was up-to-date and includes this commit.
It's just an opencv module interdependency problem, see this opencv
configure log [1], the legacy module is "disabled by dependency"
because the ml one is disabled.
I've post a patch fixing this issue [2] in another series.
[1] http://code.bulix.org/oxmmde-85789
[2] http://patchwork.ozlabs.org/patch/320821/
Regards,
--
Samuel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] gst1-plugins-bad: add missing opencv ml module dependency
2014-03-05 22:55 [Buildroot] [PATCH] gst1-plugins-bad: add missing opencv ml module dependency Samuel Martin
2014-03-06 9:57 ` Vicente Olivert Riera
@ 2014-03-06 17:25 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2014-03-06 17:25 UTC (permalink / raw)
To: buildroot
Dear Samuel Martin,
On Wed, 5 Mar 2014 23:55:30 +0100, Samuel Martin wrote:
> gst1-plugins-bad source code does include the old-style global opencv
> header "opencv/cv.h", which includes headers from the core, imgproc,
> video, features2d, flann, calib3d, objdetect and legacy modules.
>
> However, the legacy module, in addition to headers from some of the
> previously listed modules, also includes headers from the ml module.
>
> Thus, the ml module must be selected to be able to build the legacy
> one, so the gst-plugins-bad's opencv plugin.
>
> Fixes:
> http://autobuild.buildroot.net/results/d02/d02e1843ef90f4b40c99e3b23eddf376f827d46e/
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
> package/gstreamer1/gst1-plugins-bad/Config.in | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-03-06 17:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-05 22:55 [Buildroot] [PATCH] gst1-plugins-bad: add missing opencv ml module dependency Samuel Martin
2014-03-06 9:57 ` Vicente Olivert Riera
2014-03-06 10:31 ` Thomas Petazzoni
2014-03-06 10:34 ` Vicente Olivert Riera
2014-03-06 10:35 ` Samuel Martin
2014-03-06 17:25 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox