[Buildroot] [PATCH v3 1/1] manual/configure.txt: fix typo

[Buildroot] [PATCH v3 1/1] manual/configure.txt: fix typo

[Jerzy Grzegorek]

Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
---
v3:
 - rebase on top of the master
v2:
 - remove only one backslash

 docs/manual/configure.txt |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/manual/configure.txt b/docs/manual/configure.txt
index c1c9477..ee5e65e 100644
--- a/docs/manual/configure.txt
+++ b/docs/manual/configure.txt
@@ -100,7 +100,7 @@ most important ones allow to:
    toolchain should have largefile support (i.e. support for files
    larger than 2 GB on 32 bits systems), IPv6 support, RPC support
    (used mainly for NFS), wide-char support, locale support (for
-   internationalization), C\++ support or thread support. Depending on
+   internationalization), C++ support or thread support. Depending on
    which options you choose, the number of userspace applications and
    libraries visible in Buildroot menus will change: many applications
    and libraries require certain toolchain options to be enabled. Most
@@ -165,7 +165,7 @@ Then, you have three solutions to use an external toolchain:
   prefix+ and +External toolchain C library+ options. Then, you have
   to tell Buildroot what your external toolchain supports. If your
   external toolchain uses the 'glibc' library, you only have to tell
-  whether your toolchain supports C++ or not and whether it has
+  whether your toolchain supports C\++ or not and whether it has
   built-in RPC support. If your external toolchain uses the 'uClibc'
   library, then you have to tell Buildroot if it supports largefile,
   IPv6, RPC, wide-char, locale, program invocation, threads and
-- 
1.7.9.5

[Buildroot] [PATCH v3 1/1] manual/configure.txt: fix typo

[Arnout Vandecappelle]

On 03/04/14 23:21, Jerzy Grzegorek wrote:
> Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>

 Could you add to the commit log _why_ this is a typo? You're removing a
backslash in one place and adding it in another place, so it is not at
all obvious why this is the correct thing to do. In fact, it's not a
typo, it's a formatting error.

 Regards,
 Arnout

> ---
> v3:
>  - rebase on top of the master
> v2:
>  - remove only one backslash
> 
>  docs/manual/configure.txt |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/manual/configure.txt b/docs/manual/configure.txt
> index c1c9477..ee5e65e 100644
> --- a/docs/manual/configure.txt
> +++ b/docs/manual/configure.txt
> @@ -100,7 +100,7 @@ most important ones allow to:
>     toolchain should have largefile support (i.e. support for files
>     larger than 2 GB on 32 bits systems), IPv6 support, RPC support
>     (used mainly for NFS), wide-char support, locale support (for
> -   internationalization), C\++ support or thread support. Depending on
> +   internationalization), C++ support or thread support. Depending on
>     which options you choose, the number of userspace applications and
>     libraries visible in Buildroot menus will change: many applications
>     and libraries require certain toolchain options to be enabled. Most
> @@ -165,7 +165,7 @@ Then, you have three solutions to use an external toolchain:
>    prefix+ and +External toolchain C library+ options. Then, you have
>    to tell Buildroot what your external toolchain supports. If your
>    external toolchain uses the 'glibc' library, you only have to tell
> -  whether your toolchain supports C++ or not and whether it has
> +  whether your toolchain supports C\++ or not and whether it has
>    built-in RPC support. If your external toolchain uses the 'uClibc'
>    library, then you have to tell Buildroot if it supports largefile,
>    IPv6, RPC, wide-char, locale, program invocation, threads and
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH v3 1/1] manual/configure.txt: fix typo

[Thomas De Schampheleire]

Hi,

On Fri, Apr 4, 2014 at 7:59 AM, Arnout Vandecappelle <arnout@mind.be> wrote:
> On 03/04/14 23:21, Jerzy Grzegorek wrote:
>> Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
>
>  Could you add to the commit log _why_ this is a typo? You're removing a
> backslash in one place and adding it in another place, so it is not at
> all obvious why this is the correct thing to do. In fact, it's not a
> typo, it's a formatting error.
>

I think that C++ can always be written unescaped, unless it is
enclosed in a 'preformatted-text' statement. Normally this is achieved
with + signs, but +C+++ is not valid. That's why, in
adding-packages-directory.txt, I used:

* C++ support
** Dependency symbol: +BR2_INSTALL_LIBSTDCPP+
** Comment string: `C++`

If there are other cases where escaping is needed, this should indeed
be clearly mentioned in the commit message.

Best regards,
Thomas

[Buildroot] [PATCH v3 1/1] manual/configure.txt: fix typo

[Jerzy Grzegorek]

Hi Arnout,

Thanks for the feedback.

> On 03/04/14 23:21, Jerzy Grzegorek wrote:
>> Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
>   Could you add to the commit log _why_ this is a typo? You're removing a
> backslash in one place and adding it in another place, so it is not at
> all obvious why this is the correct thing to do. In fact, it's not a
> typo, it's a formatting error.

There is an extra backslash in the latest stable release buildroot 2014.02
documentation (html and pdf); have a look at:
http://buildroot.uclibc.org/downloads/manual/manual.html#_cross_compilation_toolchain
manual/configure.txt (buildroot 2014.02)
"...
   whether your toolchain supports C\+\+ or not and whether it has
..."

I posted a patch to remove this backslash (C\+\+ --> C\++), but in the 
meantime after
my discussion with Thomas P. (I suppose Thomas misunderstood me) he made
commit 082dec8ce440236b1477e568f0965f05ad241adb

So:
my patch v3 = 'revert commit of Thomas' + 'my patch v2'
commit of Thomas:
commit 082dec8ce440236b1477e568f0965f05ad241adb
my patch v2:
http://lists.busybox.net/pipermail/buildroot/2014-March/093207.html

Regards,
Jerzy

>
>   Regards,
>   Arnout
>
>> ---
>> v3:
>>   - rebase on top of the master
>> v2:
>>   - remove only one backslash
>>
>>   docs/manual/configure.txt |    4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/docs/manual/configure.txt b/docs/manual/configure.txt
>> index c1c9477..ee5e65e 100644
>> --- a/docs/manual/configure.txt
>> +++ b/docs/manual/configure.txt
>> @@ -100,7 +100,7 @@ most important ones allow to:
>>      toolchain should have largefile support (i.e. support for files
>>      larger than 2 GB on 32 bits systems), IPv6 support, RPC support
>>      (used mainly for NFS), wide-char support, locale support (for
>> -   internationalization), C\++ support or thread support. Depending on
>> +   internationalization), C++ support or thread support. Depending on
>>      which options you choose, the number of userspace applications and
>>      libraries visible in Buildroot menus will change: many applications
>>      and libraries require certain toolchain options to be enabled. Most
>> @@ -165,7 +165,7 @@ Then, you have three solutions to use an external toolchain:
>>     prefix+ and +External toolchain C library+ options. Then, you have
>>     to tell Buildroot what your external toolchain supports. If your
>>     external toolchain uses the 'glibc' library, you only have to tell
>> -  whether your toolchain supports C++ or not and whether it has
>> +  whether your toolchain supports C\++ or not and whether it has
>>     built-in RPC support. If your external toolchain uses the 'uClibc'
>>     library, then you have to tell Buildroot if it supports largefile,
>>     IPv6, RPC, wide-char, locale, program invocation, threads and
>>
>