[Buildroot] Enabling readline support in wpa_cli

[Buildroot] Enabling readline support in wpa_cli

[Oscar Hellström]

Hi,

I wanted readline support in my wpa_cli, so I created the attached patch. This patch enables readline support if readline is selected separately. I'm not sure if this is the preferred way to do it, or if there should be an option, but it's how openssl is support is selected. The patch was created and tested in bouldroot-2013.08. I created a patch against git HEAD, but I haven't been able to test that one... I include both versions here if anyone's interested.

Kind regards
Oscar Hellstr?m

[cid:image003.jpg at 01CF1D9A.E7C218A0]
Oscar Hellstr?m
Embedded Product Developer

+46 734 41 81 12
oscar.hellstrom at vinnter.se<mailto:oscar.hellstrom@vinnter.se>
Lync: oshe at vinngroup.net
LinkedIn<http://www.linkedin.com/in/oscarh>

Vinnter AB
Alfred Wigelius V?g 10
412 72 G?teborg, Sweden
www.vinnter.se<http://www.vinnter.se/>

[cid:image004.jpg at 01CF1D9A.E7C218A0]

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140512/7b3c7cc1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.jpg
Type: image/jpeg
Size: 2083 bytes
Desc: image001.jpg
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140512/7b3c7cc1/attachment.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.jpg
Type: image/jpeg
Size: 1432 bytes
Desc: image002.jpg
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140512/7b3c7cc1/attachment-0001.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: buildroot-2013.08-wpa_cli-readline.patch
Type: application/octet-stream
Size: 884 bytes
Desc: buildroot-2013.08-wpa_cli-readline.patch
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140512/7b3c7cc1/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: buildroot-2014-05-12-wpa_cli-readline.patch
Type: application/octet-stream
Size: 561 bytes
Desc: buildroot-2014-05-12-wpa_cli-readline.patch
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140512/7b3c7cc1/attachment-0001.obj>

[Buildroot] Enabling readline support in wpa_cli

[Oscar Hellström]

I should probably have added the readline dependency as well, right?

/Oscar

From: buildroot-bounces@busybox.net [mailto:buildroot-bounces at busybox.net] On Behalf Of Oscar Hellstr?m
Sent: den 12 maj 2014 15:55
To: buildroot at busybox.net
Subject: [Buildroot] Enabling readline support in wpa_cli

Hi,

I wanted readline support in my wpa_cli, so I created the attached patch. This patch enables readline support if readline is selected separately. I'm not sure if this is the preferred way to do it, or if there should be an option, but it's how openssl is support is selected. The patch was created and tested in bouldroot-2013.08. I created a patch against git HEAD, but I haven't been able to test that one... I include both versions here if anyone's interested.

Kind regards
Oscar Hellstr?m

[cid:image003.jpg at 01CF1D9A.E7C218A0]
Oscar Hellstr?m
Embedded Product Developer

+46 734 41 81 12
oscar.hellstrom at vinnter.se<mailto:oscar.hellstrom@vinnter.se>
Lync: oshe at vinngroup.net<mailto:oshe@vinngroup.net>
LinkedIn<http://www.linkedin.com/in/oscarh>

Vinnter AB
Alfred Wigelius V?g 10
412 72 G?teborg, Sweden
www.vinnter.se<http://www.vinnter.se/>

[cid:image004.jpg at 01CF1D9A.E7C218A0]

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140512/c9825ea1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.jpg
Type: image/jpeg
Size: 2083 bytes
Desc: image001.jpg
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140512/c9825ea1/attachment.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.jpg
Type: image/jpeg
Size: 1432 bytes
Desc: image002.jpg
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140512/c9825ea1/attachment-0001.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: buildroot-2013.08-wpa_cli-readline.patch
Type: application/octet-stream
Size: 929 bytes
Desc: buildroot-2013.08-wpa_cli-readline.patch
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140512/c9825ea1/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: buildroot-2014-05-12-wpa_cli-readline.patch
Type: application/octet-stream
Size: 603 bytes
Desc: buildroot-2014-05-12-wpa_cli-readline.patch
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140512/c9825ea1/attachment-0001.obj>

[Buildroot] Enabling readline support in wpa_cli

[Gustavo Zacarias]

On 05/12/2014 11:16 AM, Oscar Hellstr?m wrote:

> I should probably have added the readline dependency as well, right?

Hi.
You mean adding a Config.in select? That's not necessary, we usually
handle these "details" automatically like you've already did in your
patch, otherwise it's (possibly) just making the target size bigger for
an option that wouldn't be used.
Could you resend your last patch (based on current git) with
git-send-email and a SoB line for proper attribution?
Thanks.

[Buildroot] Enabling readline support in wpa_cli

[Arnout Vandecappelle]

On 12/05/14 16:16, Oscar Hellstr?m wrote:
> I should probably have added the readline dependency as well, right?
> 

 Indeed, you should have something like

ifeq ($(BR2_PACKAGE_READLINE),y)
BR2_PACKAGE_WPA_SUPPLICANT_DEPENDENCIES += readline
...
endif


 BTW, a patch like this would typically has as subject:

wpa_supplicant: enable readline support in wpa_cli


 BTW 2: on this list, the policy is not to top-post, but to reply below the
relevant quoted text (like I was doing here).


 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F