[Buildroot] [PATCH 1/1] Fix barebox compilation issue with 64bit kernel

[Buildroot] [PATCH 1/1] Fix barebox compilation issue with 64bit kernel

[Lahoudere Fabien]

Signed-off-by: Lahoudere Fabien <fabienlahoudere.pro@gmail.com>
---
 boot/barebox/barebox.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/boot/barebox/barebox.mk b/boot/barebox/barebox.mk
index 0fb7cec..626ff9a 100644
--- a/boot/barebox/barebox.mk
+++ b/boot/barebox/barebox.mk
@@ -41,6 +41,8 @@ endif
 
 ifeq ($(KERNEL_ARCH),i386)
 BAREBOX_ARCH = x86
+else ifeq ($(KERNEL_ARCH),x86_64)
+BAREBOX_ARCH = x86
 else ifeq ($(KERNEL_ARCH),powerpc)
 BAREBOX_ARCH = ppc
 else
-- 
2.1.4

[Buildroot] [PATCH 1/1] Fix barebox compilation issue with 64bit kernel

[Thomas Petazzoni]

Dear Lahoudere Fabien,

On Tue,  3 Mar 2015 13:27:53 +0100, Lahoudere Fabien wrote:
> Signed-off-by: Lahoudere Fabien <fabienlahoudere.pro@gmail.com>

This should normally be:

	Signed-off-by: <first name> <last name> <email>

> ---
>  boot/barebox/barebox.mk | 2 ++
>  1 file changed, 2 insertions(+)

This looks good but the commit log could be improved:

	barebox: fix compilation on x86-64 architecture

	Barebox uses KERNEL_ARCH to derive BAREBOX_ARCH, but doesn't
	currently handle the case of the x86-64 architecture. In this
	case KERNEL_ARCH is x86_64, but BAREBOX_ARCH should be x86
	nonetheless.

The commit title should almost always look like:

	<pkg>: <description>

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] Fix barebox compilation issue with 64bit kernel

[Fabien Lahoudere]

Hello

Thank you for the correction.
I will rework my patch but I have questions:
- If I change the title, and submit a new patch, what happened to the
old one in the patchwork?
- Is it necessary to prefix the new title with "PATCH v2"?

Fabien

Le 03/03/2015 14:31, Thomas Petazzoni a ?crit :
> Dear Lahoudere Fabien,
>
> On Tue,  3 Mar 2015 13:27:53 +0100, Lahoudere Fabien wrote:
>> Signed-off-by: Lahoudere Fabien <fabienlahoudere.pro@gmail.com>
> This should normally be:
>
> 	Signed-off-by: <first name> <last name> <email>
>
>> ---
>>   boot/barebox/barebox.mk | 2 ++
>>   1 file changed, 2 insertions(+)
> This looks good but the commit log could be improved:
>
> 	barebox: fix compilation on x86-64 architecture
>
> 	Barebox uses KERNEL_ARCH to derive BAREBOX_ARCH, but doesn't
> 	currently handle the case of the x86-64 architecture. In this
> 	case KERNEL_ARCH is x86_64, but BAREBOX_ARCH should be x86
> 	nonetheless.
>
> The commit title should almost always look like:
>
> 	<pkg>: <description>
>
> Thanks,
>
> Thomas