* [Buildroot] [PATCH] package/gdb: gdb 7.9 fix uClibc build whitout MMU
@ 2015-04-10 21:45 Romain Naour
2015-04-11 18:24 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Romain Naour @ 2015-04-10 21:45 UTC (permalink / raw)
To: buildroot
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
.../0001-gdbserver-fix-uClibc-whithout-MMU.patch | 38 ++++++++++++++++++++++
1 file changed, 38 insertions(+)
create mode 100644 package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch
diff --git a/package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch b/package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch
new file mode 100644
index 0000000..23486a3
--- /dev/null
+++ b/package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch
@@ -0,0 +1,38 @@
+From d3988abfa6bb97dbcad3a0ff0961e920ce84b00c Mon Sep 17 00:00:00 2001
+From: Romain Naour <romain.naour@openwide.fr>
+Date: Fri, 10 Apr 2015 22:58:07 +0200
+Subject: [PATCH] gdbserver: fix uClibc whithout MMU.
+
+Since commit d86d4aafd4fa22fa4cccb83253fb187b03f97f48, the pid
+must be retrieved from current_thread.
+
+The change has not been made in the function linux_read_offsets().
+
+Fixes:
+http://autobuild.buildroot.net/results/9e4/9e4df085319e346803c26c65478accb27eb950ae/build-end.log
+
+Signed-off-by: Romain Naour <romain.naour@openwide.fr>
+
+Conflicts:
+ gdb/gdbserver/linux-low.c
+---
+ gdb/gdbserver/linux-low.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
+index 4d19c87..23f012d 100644
+--- a/gdb/gdbserver/linux-low.c
++++ b/gdb/gdbserver/linux-low.c
+@@ -4933,7 +4933,8 @@ static int
+ linux_read_offsets (CORE_ADDR *text_p, CORE_ADDR *data_p)
+ {
+ unsigned long text, text_end, data;
+- int pid = lwpid_of (get_thread_lwp (current_thread));
++
++ int pid = lwpid_of (current_thread);
+
+ errno = 0;
+
+--
+1.9.3
+
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Buildroot] [PATCH] package/gdb: gdb 7.9 fix uClibc build whitout MMU
2015-04-10 21:45 [Buildroot] [PATCH] package/gdb: gdb 7.9 fix uClibc build whitout MMU Romain Naour
@ 2015-04-11 18:24 ` Thomas Petazzoni
2015-04-12 12:52 ` Romain Naour
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2015-04-11 18:24 UTC (permalink / raw)
To: buildroot
Dear Romain Naour,
On Fri, 10 Apr 2015 23:45:05 +0200, Romain Naour wrote:
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> .../0001-gdbserver-fix-uClibc-whithout-MMU.patch | 38 ++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch
>
> diff --git a/package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch b/package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch
> new file mode 100644
> index 0000000..23486a3
> --- /dev/null
> +++ b/package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch
> @@ -0,0 +1,38 @@
> +From d3988abfa6bb97dbcad3a0ff0961e920ce84b00c Mon Sep 17 00:00:00 2001
> +From: Romain Naour <romain.naour@openwide.fr>
> +Date: Fri, 10 Apr 2015 22:58:07 +0200
> +Subject: [PATCH] gdbserver: fix uClibc whithout MMU.
> +
> +Since commit d86d4aafd4fa22fa4cccb83253fb187b03f97f48, the pid
> +must be retrieved from current_thread.
> +
> +The change has not been made in the function linux_read_offsets().
> +
> +Fixes:
> +http://autobuild.buildroot.net/results/9e4/9e4df085319e346803c26c65478accb27eb950ae/build-end.log
> +
> +Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> +
> +Conflicts:
> + gdb/gdbserver/linux-low.c
This Conflicts info is probably not needed.
> +---
> + gdb/gdbserver/linux-low.c | 3 ++-
> + 1 file changed, 2 insertions(+), 1 deletion(-)
> +
> +diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
> +index 4d19c87..23f012d 100644
> +--- a/gdb/gdbserver/linux-low.c
> ++++ b/gdb/gdbserver/linux-low.c
> +@@ -4933,7 +4933,8 @@ static int
> + linux_read_offsets (CORE_ADDR *text_p, CORE_ADDR *data_p)
> + {
> + unsigned long text, text_end, data;
> +- int pid = lwpid_of (get_thread_lwp (current_thread));
> ++
No need to add this empty line here.
> ++ int pid = lwpid_of (current_thread);
Can you respin a new version?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread* [Buildroot] [PATCH] package/gdb: gdb 7.9 fix uClibc build whitout MMU
2015-04-11 18:24 ` Thomas Petazzoni
@ 2015-04-12 12:52 ` Romain Naour
0 siblings, 0 replies; 3+ messages in thread
From: Romain Naour @ 2015-04-12 12:52 UTC (permalink / raw)
To: buildroot
Hi Thomas,
Le 11/04/2015 20:24, Thomas Petazzoni a ?crit :
> Dear Romain Naour,
>
> On Fri, 10 Apr 2015 23:45:05 +0200, Romain Naour wrote:
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
>> ---
>> .../0001-gdbserver-fix-uClibc-whithout-MMU.patch | 38 ++++++++++++++++++++++
>> 1 file changed, 38 insertions(+)
>> create mode 100644 package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch
>>
>> diff --git a/package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch b/package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch
>> new file mode 100644
>> index 0000000..23486a3
>> --- /dev/null
>> +++ b/package/gdb/7.9/0001-gdbserver-fix-uClibc-whithout-MMU.patch
>> @@ -0,0 +1,38 @@
>> +From d3988abfa6bb97dbcad3a0ff0961e920ce84b00c Mon Sep 17 00:00:00 2001
>> +From: Romain Naour <romain.naour@openwide.fr>
>> +Date: Fri, 10 Apr 2015 22:58:07 +0200
>> +Subject: [PATCH] gdbserver: fix uClibc whithout MMU.
>> +
>> +Since commit d86d4aafd4fa22fa4cccb83253fb187b03f97f48, the pid
>> +must be retrieved from current_thread.
>> +
>> +The change has not been made in the function linux_read_offsets().
>> +
>> +Fixes:
>> +http://autobuild.buildroot.net/results/9e4/9e4df085319e346803c26c65478accb27eb950ae/build-end.log
>> +
>> +Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> +
>> +Conflicts:
>> + gdb/gdbserver/linux-low.c
>
> This Conflicts info is probably not needed.
Ok
>
>> +---
>> + gdb/gdbserver/linux-low.c | 3 ++-
>> + 1 file changed, 2 insertions(+), 1 deletion(-)
>> +
>> +diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
>> +index 4d19c87..23f012d 100644
>> +--- a/gdb/gdbserver/linux-low.c
>> ++++ b/gdb/gdbserver/linux-low.c
>> +@@ -4933,7 +4933,8 @@ static int
>> + linux_read_offsets (CORE_ADDR *text_p, CORE_ADDR *data_p)
>> + {
>> + unsigned long text, text_end, data;
>> +- int pid = lwpid_of (get_thread_lwp (current_thread));
>> ++
>
> No need to add this empty line here.
It's a leftover after resolving the merge conflict...
>
>> ++ int pid = lwpid_of (current_thread);
>
> Can you respin a new version?
See http://patchwork.ozlabs.org/patch/460493/
Thanks,
Romain
>
> Thanks a lot!
>
> Thomas
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-12 12:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-10 21:45 [Buildroot] [PATCH] package/gdb: gdb 7.9 fix uClibc build whitout MMU Romain Naour
2015-04-11 18:24 ` Thomas Petazzoni
2015-04-12 12:52 ` Romain Naour
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox