* [Buildroot] [PATCH] sysvinit: build fixed for arm64 architectures
@ 2015-09-17 13:46 jpinto
2015-09-17 13:56 ` Baruch Siach
0 siblings, 1 reply; 3+ messages in thread
From: jpinto @ 2015-09-17 13:46 UTC (permalink / raw)
To: buildroot
sysvinit was not able to be built for arm64 architectures. This patch was made
to fix the problem.
Signed-off-by: Joao Pinto <jpinto@synopsys.com>
---
package/sysvinit/0001-fix-libcrypt-test.patch | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/package/sysvinit/0001-fix-libcrypt-test.patch b/package/sysvinit/0001-fix-libcrypt-test.patch
index 207270d..7233d38 100644
--- a/package/sysvinit/0001-fix-libcrypt-test.patch
+++ b/package/sysvinit/0001-fix-libcrypt-test.patch
@@ -1,17 +1,25 @@
Make the libcrypt test somewhat cross-compilation compliant
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+Signed-off-by: Joao Pinto <jpinto@synopsys.com>
Index: b/src/Makefile
===================================================================
--- a/src/Makefile
+++ b/src/Makefile
-@@ -78,7 +78,7 @@
+@@ -78,7 +78,14 @@
endif
# Additional libs for GNU libc.
-ifneq ($(wildcard /usr/lib*/libcrypt.a),)
++inc_additional_lib =
+ifneq ($(wildcard $(SYSROOT)/usr/lib*/libcrypt.a),)
++ inc_additional_lib = yes
++else ifneq ($(wildcard $(SYSROOT)/usr/lib*/aarch64*/libcrypt.a),)
++ inc_additional_lib = yes
++endif
++
++ifdef inc_additional_lib
SULOGINLIBS += -lcrypt
endif
--
1.8.1.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] sysvinit: build fixed for arm64 architectures
2015-09-17 13:46 [Buildroot] [PATCH] sysvinit: build fixed for arm64 architectures jpinto
@ 2015-09-17 13:56 ` Baruch Siach
2015-09-17 14:19 ` Joao Pinto
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2015-09-17 13:56 UTC (permalink / raw)
To: buildroot
Hi Joao,
On Thu, Sep 17, 2015 at 02:46:02PM +0100, jpinto wrote:
> sysvinit was not able to be built for arm64 architectures. This patch was made
> to fix the problem.
>
> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
> ---
> package/sysvinit/0001-fix-libcrypt-test.patch | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/package/sysvinit/0001-fix-libcrypt-test.patch b/package/sysvinit/0001-fix-libcrypt-test.patch
> index 207270d..7233d38 100644
> --- a/package/sysvinit/0001-fix-libcrypt-test.patch
> +++ b/package/sysvinit/0001-fix-libcrypt-test.patch
> @@ -1,17 +1,25 @@
> Make the libcrypt test somewhat cross-compilation compliant
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> +Signed-off-by: Joao Pinto <jpinto@synopsys.com>
>
> Index: b/src/Makefile
> ===================================================================
> --- a/src/Makefile
> +++ b/src/Makefile
> -@@ -78,7 +78,7 @@
> +@@ -78,7 +78,14 @@
> endif
>
> # Additional libs for GNU libc.
> -ifneq ($(wildcard /usr/lib*/libcrypt.a),)
> ++inc_additional_lib =
> +ifneq ($(wildcard $(SYSROOT)/usr/lib*/libcrypt.a),)
> ++ inc_additional_lib = yes
> ++else ifneq ($(wildcard $(SYSROOT)/usr/lib*/aarch64*/libcrypt.a),)
This looks to specific to that toolchain. Why not generalize
else ifneq ($(wildcard $(SYSROOT)/usr/lib*/*/libcrypt.a),)
?
baruch
> ++ inc_additional_lib = yes
> ++endif
> ++
> ++ifdef inc_additional_lib
> SULOGINLIBS += -lcrypt
> endif
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] sysvinit: build fixed for arm64 architectures
2015-09-17 13:56 ` Baruch Siach
@ 2015-09-17 14:19 ` Joao Pinto
0 siblings, 0 replies; 3+ messages in thread
From: Joao Pinto @ 2015-09-17 14:19 UTC (permalink / raw)
To: buildroot
Hi Baruch,
On 9/17/2015 2:56 PM, Baruch Siach wrote:
> Hi Joao,
>
> On Thu, Sep 17, 2015 at 02:46:02PM +0100, jpinto wrote:
>> sysvinit was not able to be built for arm64 architectures. This patch was made
>> to fix the problem.
>>
>> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
>> ---
>> package/sysvinit/0001-fix-libcrypt-test.patch | 10 +++++++++-
>> 1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/sysvinit/0001-fix-libcrypt-test.patch b/package/sysvinit/0001-fix-libcrypt-test.patch
>> index 207270d..7233d38 100644
>> --- a/package/sysvinit/0001-fix-libcrypt-test.patch
>> +++ b/package/sysvinit/0001-fix-libcrypt-test.patch
>> @@ -1,17 +1,25 @@
>> Make the libcrypt test somewhat cross-compilation compliant
>>
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> +Signed-off-by: Joao Pinto <jpinto@synopsys.com>
>>
>> Index: b/src/Makefile
>> ===================================================================
>> --- a/src/Makefile
>> +++ b/src/Makefile
>> -@@ -78,7 +78,7 @@
>> +@@ -78,7 +78,14 @@
>> endif
>>
>> # Additional libs for GNU libc.
>> -ifneq ($(wildcard /usr/lib*/libcrypt.a),)
>> ++inc_additional_lib =
>> +ifneq ($(wildcard $(SYSROOT)/usr/lib*/libcrypt.a),)
>> ++ inc_additional_lib = yes
>> ++else ifneq ($(wildcard $(SYSROOT)/usr/lib*/aarch64*/libcrypt.a),)
>
> This looks to specific to that toolchain. Why not generalize
>
> else ifneq ($(wildcard $(SYSROOT)/usr/lib*/*/libcrypt.a),)
>
> ?
Sounds like a good idea. Gonna send v2 patch in a sec.
>
> baruch
>
>> ++ inc_additional_lib = yes
>> ++endif
>> ++
>> ++ifdef inc_additional_lib
>> SULOGINLIBS += -lcrypt
>> endif
>
Joao
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-17 14:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-17 13:46 [Buildroot] [PATCH] sysvinit: build fixed for arm64 architectures jpinto
2015-09-17 13:56 ` Baruch Siach
2015-09-17 14:19 ` Joao Pinto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox