* [Buildroot] [PATCH 01/84 RFC] package/alsa-lib: move comment around, to keep proper indentation
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 02/84 RFC] package/gstreamer: " Yann E. MORIN
` (84 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
In Kconfig, when there is an item (lie a comment) between a symbol and
its dependees, then the indentation is not in effect.
Move the symbol to the top of the file to guarantee the indentation in
the menuconfig.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/alsa-lib/Config.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/alsa-lib/Config.in b/package/alsa-lib/Config.in
index a732c08..ebca265 100644
--- a/package/alsa-lib/Config.in
+++ b/package/alsa-lib/Config.in
@@ -1,3 +1,6 @@
+comment "alsa-lib needs a toolchain w/ threads"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS
+
config BR2_PACKAGE_ALSA_LIB
bool "alsa-lib"
# Temporary until
@@ -15,9 +18,6 @@ config BR2_PACKAGE_ALSA_LIB
http://www.alsa-project.org/
-comment "alsa-lib needs a toolchain w/ threads"
- depends on !BR2_TOOLCHAIN_HAS_THREADS
-
if BR2_PACKAGE_ALSA_LIB
config BR2_PACKAGE_ALSA_LIB_PYTHON
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 02/84 RFC] package/gstreamer: move comment around, to keep proper indentation
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 01/84 RFC] package/alsa-lib: move comment around, to keep proper indentation Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 03/84 RFC] package/gstreamer1: " Yann E. MORIN
` (83 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
In Kconfig, when there is an item (lie a comment) between a symbol and
its dependees, then the indentation is not in effect.
Move the symbol to the top of the file to guarantee the indentation in
the menuconfig.
In this case, it means the gstremaer plugins are not indented below the
main gstreamer prompt.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/gstreamer/gstreamer/Config.in | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/package/gstreamer/gstreamer/Config.in b/package/gstreamer/gstreamer/Config.in
index b833c96..eb1249a 100644
--- a/package/gstreamer/gstreamer/Config.in
+++ b/package/gstreamer/gstreamer/Config.in
@@ -1,3 +1,7 @@
+comment "gstreamer 0.10 needs a toolchain w/ wchar, threads"
+ depends on BR2_USE_MMU
+ depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+
config BR2_PACKAGE_GSTREAMER
bool "gstreamer 0.10"
depends on BR2_USE_WCHAR # glib2
@@ -30,7 +34,3 @@ config BR2_PACKAGE_GSTREAMER_PLUGIN_REGISTRY
the launch-time for a GStreamer application.
endif
-
-comment "gstreamer 0.10 needs a toolchain w/ wchar, threads"
- depends on BR2_USE_MMU
- depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 03/84 RFC] package/gstreamer1: move comment around, to keep proper indentation
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 01/84 RFC] package/alsa-lib: move comment around, to keep proper indentation Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 02/84 RFC] package/gstreamer: " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 04/84 RFC] package/nodejs: " Yann E. MORIN
` (82 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
In Kconfig, when there is an item (lie a comment) between a symbol and
its dependees, then the indentation is not in effect.
Move the symbol to the top of the file to guarantee the indentation in
the menuconfig.
In this case, it means the gstremaer1 plugins are not indented below the
main gstreamer1 prompt.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/gstreamer1/gstreamer1/Config.in | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/package/gstreamer1/gstreamer1/Config.in b/package/gstreamer1/gstreamer1/Config.in
index 0d8dd62..c13f041 100644
--- a/package/gstreamer1/gstreamer1/Config.in
+++ b/package/gstreamer1/gstreamer1/Config.in
@@ -1,3 +1,7 @@
+comment "gstreamer 1.x needs a toolchain w/ wchar, threads"
+ depends on BR2_USE_MMU
+ depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+
config BR2_PACKAGE_GSTREAMER1
bool "gstreamer 1.x"
depends on BR2_USE_WCHAR # glib2
@@ -49,7 +53,3 @@ config BR2_PACKAGE_GSTREAMER1_INSTALL_TOOLS
additional space on the target.
endif
-
-comment "gstreamer 1.x needs a toolchain w/ wchar, threads"
- depends on BR2_USE_MMU
- depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 04/84 RFC] package/nodejs: move comment around, to keep proper indentation
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (2 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 03/84 RFC] package/gstreamer1: " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 05/84 RFC] package/tcl: " Yann E. MORIN
` (81 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
In Kconfig, when there is an item (like a comment) between a symbol and
its dependees, then the indentation is not in effect.
Move the symbol to the top of the file to guarantee the indentation in
the menuconfig.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/nodejs/Config.in | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
index eb3aeec..008fbbf 100644
--- a/package/nodejs/Config.in
+++ b/package/nodejs/Config.in
@@ -1,3 +1,10 @@
+comment "nodejs needs a toolchain w/ C++, dynamic library, threads"
+ depends on BR2_USE_MMU
+ depends on BR2_arm || BR2_i386 || BR2_x86_64 || BR2_mipsel
+ depends on !BR2_MIPS_SOFT_FLOAT
+ depends on !BR2_ARM_CPU_ARMV4
+ depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
+
config BR2_PACKAGE_NODEJS
bool "nodejs"
depends on BR2_TOOLCHAIN_HAS_THREADS
@@ -17,13 +24,6 @@ config BR2_PACKAGE_NODEJS
http://nodejs.org/
-comment "nodejs needs a toolchain w/ C++, dynamic library, threads"
- depends on BR2_USE_MMU
- depends on BR2_arm || BR2_i386 || BR2_x86_64 || BR2_mipsel
- depends on !BR2_MIPS_SOFT_FLOAT
- depends on !BR2_ARM_CPU_ARMV4
- depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
-
if BR2_PACKAGE_NODEJS
# Starting with 0.12.x, on ARM, V8 (the JS engine)
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 05/84 RFC] package/tcl: move comment around, to keep proper indentation
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (3 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 04/84 RFC] package/nodejs: " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 06/84 RFC] package/udpcast: " Yann E. MORIN
` (80 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
In Kconfig, when there is an item (like a comment) between a symbol and
its dependees, then the indentation is not in effect.
Move the symbol to the top of the file to guarantee the indentation in
the menuconfig.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/tcl/Config.in | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/package/tcl/Config.in b/package/tcl/Config.in
index 63d1b25..f1fa054 100644
--- a/package/tcl/Config.in
+++ b/package/tcl/Config.in
@@ -1,3 +1,7 @@
+comment "tcl needs a toolchain w/ threads, dynamic library"
+ depends on BR2_USE_MMU
+ depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+
config BR2_PACKAGE_TCL
bool "tcl"
# fork()
@@ -11,10 +15,6 @@ config BR2_PACKAGE_TCL
http://www.tcl.tk
-comment "tcl needs a toolchain w/ threads, dynamic library"
- depends on BR2_USE_MMU
- depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
-
if BR2_PACKAGE_TCL
config BR2_PACKAGE_TCL_DEL_ENCODINGS
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 06/84 RFC] package/udpcast: move comment around, to keep proper indentation
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (4 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 05/84 RFC] package/tcl: " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 07/84 RFC] package/alsa-lib: use 'menuconfig' instad of 'config'+'menu' Yann E. MORIN
` (79 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
In Kconfig, when there is an item (lie a comment) between a symbol and
its dependees, then the indentation is not in effect.
Move the symbol to the top of the file to guarantee the indentation in
the menuconfig.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/udpcast/Config.in | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/package/udpcast/Config.in b/package/udpcast/Config.in
index 2f98610..0424db7 100644
--- a/package/udpcast/Config.in
+++ b/package/udpcast/Config.in
@@ -1,3 +1,7 @@
+comment "udpcast needs a toolchain w/ threads"
+ depends on BR2_USE_MMU
+ depends on !BR2_TOOLCHAIN_HAS_THREADS
+
config BR2_PACKAGE_UDPCAST
bool "udpcast"
depends on BR2_TOOLCHAIN_HAS_THREADS
@@ -8,10 +12,6 @@ config BR2_PACKAGE_UDPCAST
http://www.udpcast.linux.lu/
-comment "udpcast needs a toolchain w/ threads"
- depends on BR2_USE_MMU
- depends on !BR2_TOOLCHAIN_HAS_THREADS
-
if BR2_PACKAGE_UDPCAST
menu "udpcast tools selection"
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 07/84 RFC] package/alsa-lib: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (5 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 06/84 RFC] package/udpcast: " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 08/84 RFC] package/alsa-utils: use 'menuconfig' instead " Yann E. MORIN
` (78 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/alsa-lib/Config.in | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/package/alsa-lib/Config.in b/package/alsa-lib/Config.in
index ebca265..97e8489 100644
--- a/package/alsa-lib/Config.in
+++ b/package/alsa-lib/Config.in
@@ -1,7 +1,7 @@
comment "alsa-lib needs a toolchain w/ threads"
depends on !BR2_TOOLCHAIN_HAS_THREADS
-config BR2_PACKAGE_ALSA_LIB
+menuconfig BR2_PACKAGE_ALSA_LIB
bool "alsa-lib"
# Temporary until
# https://bugtrack.alsa-project.org/alsa-bug/view.php?id=4913
@@ -29,8 +29,6 @@ config BR2_PACKAGE_ALSA_LIB_PYTHON
in the target directory
http://www.alsa-project.org/
-menu "ALSA lib selection"
-
config BR2_PACKAGE_ALSA_LIB_DEVDIR
string "directory with ALSA device files"
default "/dev/snd"
@@ -77,6 +75,4 @@ config BR2_PACKAGE_ALSA_LIB_OLD_SYMBOLS
bool "old-symbols"
default y
-endmenu
-
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 08/84 RFC] package/alsa-utils: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (6 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 07/84 RFC] package/alsa-lib: use 'menuconfig' instad of 'config'+'menu' Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-30 23:03 ` Arnout Vandecappelle
2015-12-25 21:24 ` [Buildroot] [PATCH 09/84 RFC] package/angularjs: use 'menuconfig' instad " Yann E. MORIN
` (77 subsequent siblings)
85 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/alsa-utils/Config.in | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/package/alsa-utils/Config.in b/package/alsa-utils/Config.in
index a08743e..762fcdf 100644
--- a/package/alsa-utils/Config.in
+++ b/package/alsa-utils/Config.in
@@ -2,7 +2,7 @@ comment "alsa-utils needs a toolchain w/ threads"
depends on BR2_USE_MMU # fork
depends on !BR2_TOOLCHAIN_HAS_THREADS
-config BR2_PACKAGE_ALSA_UTILS
+menuconfig BR2_PACKAGE_ALSA_UTILS
bool "alsa-utils"
depends on BR2_USE_MMU # fork
depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
@@ -15,7 +15,8 @@ config BR2_PACKAGE_ALSA_UTILS
http://www.alsa-project.org/
if BR2_PACKAGE_ALSA_UTILS
-menu "ALSA utils selection"
+
+comment "ALSA utils selection"
config BR2_PACKAGE_ALSA_UTILS_ALSACONF
bool "alsaconf"
@@ -85,6 +86,4 @@ config BR2_PACKAGE_ALSA_UTILS_SPEAKER_TEST
select BR2_PACKAGE_ALSA_LIB_PCM
bool "speaker-test"
-endmenu
-
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 08/84 RFC] package/alsa-utils: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:24 ` [Buildroot] [PATCH 08/84 RFC] package/alsa-utils: use 'menuconfig' instead " Yann E. MORIN
@ 2015-12-30 23:03 ` Arnout Vandecappelle
2015-12-30 23:09 ` Yann E. MORIN
0 siblings, 1 reply; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-30 23:03 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:24, Yann E. MORIN wrote:
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/alsa-utils/Config.in | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/package/alsa-utils/Config.in b/package/alsa-utils/Config.in
> index a08743e..762fcdf 100644
> --- a/package/alsa-utils/Config.in
> +++ b/package/alsa-utils/Config.in
> @@ -2,7 +2,7 @@ comment "alsa-utils needs a toolchain w/ threads"
> depends on BR2_USE_MMU # fork
> depends on !BR2_TOOLCHAIN_HAS_THREADS
>
> -config BR2_PACKAGE_ALSA_UTILS
> +menuconfig BR2_PACKAGE_ALSA_UTILS
> bool "alsa-utils"
> depends on BR2_USE_MMU # fork
> depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
> @@ -15,7 +15,8 @@ config BR2_PACKAGE_ALSA_UTILS
> http://www.alsa-project.org/
>
> if BR2_PACKAGE_ALSA_UTILS
> -menu "ALSA utils selection"
> +
> +comment "ALSA utils selection"
I don't think this comment is needed. Also, why do you do it for alsa-utils but
not alsa-lib?
Regards,
Arnout
>
> config BR2_PACKAGE_ALSA_UTILS_ALSACONF
> bool "alsaconf"
> @@ -85,6 +86,4 @@ config BR2_PACKAGE_ALSA_UTILS_SPEAKER_TEST
> select BR2_PACKAGE_ALSA_LIB_PCM
> bool "speaker-test"
>
> -endmenu
> -
> endif
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 08/84 RFC] package/alsa-utils: use 'menuconfig' instead of 'config'+'menu'
2015-12-30 23:03 ` Arnout Vandecappelle
@ 2015-12-30 23:09 ` Yann E. MORIN
0 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-30 23:09 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2015-12-31 00:03 +0100, Arnout Vandecappelle spake thusly:
> On 25-12-15 22:24, Yann E. MORIN wrote:
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> > package/alsa-utils/Config.in | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/package/alsa-utils/Config.in b/package/alsa-utils/Config.in
> > index a08743e..762fcdf 100644
> > --- a/package/alsa-utils/Config.in
> > +++ b/package/alsa-utils/Config.in
> > @@ -2,7 +2,7 @@ comment "alsa-utils needs a toolchain w/ threads"
> > depends on BR2_USE_MMU # fork
> > depends on !BR2_TOOLCHAIN_HAS_THREADS
> >
> > -config BR2_PACKAGE_ALSA_UTILS
> > +menuconfig BR2_PACKAGE_ALSA_UTILS
> > bool "alsa-utils"
> > depends on BR2_USE_MMU # fork
> > depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
> > @@ -15,7 +15,8 @@ config BR2_PACKAGE_ALSA_UTILS
> > http://www.alsa-project.org/
> >
> > if BR2_PACKAGE_ALSA_UTILS
> > -menu "ALSA utils selection"
> > +
> > +comment "ALSA utils selection"
>
> I don't think this comment is needed.
I don't care about that comment either. ;-)
> Also, why do you do it for alsa-utils but
> not alsa-lib?
Because I skimmed through the menuconfig UI, seeeking those constructs,
and alsa-utils is very early, with alsa-lib much later, with a lot of
packages between the two, and I may have changed my mind in-between.
This does not really appear in the series, because I then rebased it and
re-ordered alphabetically on packages' names.
I agree that, when there is a single 'category', there's no need for a
comment. I will drop.
Thanks! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 09/84 RFC] package/angularjs: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (7 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 08/84 RFC] package/alsa-utils: use 'menuconfig' instead " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 10/84 RFC] package/angularjs: simplify modules selection Yann E. MORIN
` (76 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
... and change the modules 'menuconfig' to a simple 'config'
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/angularjs/Config.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/angularjs/Config.in b/package/angularjs/Config.in
index 2b563f7..206b3d8 100644
--- a/package/angularjs/Config.in
+++ b/package/angularjs/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_ANGULARJS
+menuconfig BR2_PACKAGE_ANGULARJS
bool "angularjs"
help
AngularJS web application framework.
@@ -7,7 +7,7 @@ config BR2_PACKAGE_ANGULARJS
if BR2_PACKAGE_ANGULARJS
-menuconfig BR2_ANGULARJS_MODULES
+config BR2_ANGULARJS_MODULES
bool "angularjs modules"
help
Select which modules to install. If disabled, all modules
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 10/84 RFC] package/angularjs: simplify modules selection
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (8 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 09/84 RFC] package/angularjs: use 'menuconfig' instad " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-30 23:27 ` Arnout Vandecappelle
2015-12-25 21:24 ` [Buildroot] [PATCH 11/84 RFC] package/collectd: use 'menuconfig' instead of 'config'+'menu' Yann E. MORIN
` (75 subsequent siblings)
85 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Remove the superfluous config option, and make all modules default to
'y', which provides exactly the same functionality.
simplify (and slightly beautofy) the handling of modules in the .mk:
since the modules' symbols are always meaningful now, we can get rid of
the else-clause, and always build the list of modules using the Kconfig
options.
Re-order the list alphabetically (message <-> message-format).
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/angularjs/Config.in | 35 +++++++++++++++++++++--------------
package/angularjs/angularjs.mk | 24 +++++++++++++++---------
2 files changed, 36 insertions(+), 23 deletions(-)
diff --git a/package/angularjs/Config.in b/package/angularjs/Config.in
index 206b3d8..ee1dbbf 100644
--- a/package/angularjs/Config.in
+++ b/package/angularjs/Config.in
@@ -7,16 +7,17 @@ menuconfig BR2_PACKAGE_ANGULARJS
if BR2_PACKAGE_ANGULARJS
-config BR2_ANGULARJS_MODULES
- bool "angularjs modules"
- help
- Select which modules to install. If disabled, all modules
- will be installed.
+# All the modules default to 'y' to keep backward-compatibility
+# Keep this list in sync and in the same (alphabetical) order as # the
+# one in angularjs.mk. However, always keep 'angular' first in the list.
-if BR2_ANGULARJS_MODULES
+config BR2_ANGULARJS_MODULE_ANGULAR
+ bool
+ default y
config BR2_ANGULARJS_MODULE_ANIMATE
bool "animate"
+ default y
help
The ngAnimate module provides support for CSS-based animations
(keyframes and transitions) as well as JavaScript-based animations
@@ -26,6 +27,7 @@ config BR2_ANGULARJS_MODULE_ANIMATE
config BR2_ANGULARJS_MODULE_ARIA
bool "aria"
+ default y
help
The ngAria module provides support for common ARIA attributes that
convey state or semantic information about the application for users
@@ -33,47 +35,52 @@ config BR2_ANGULARJS_MODULE_ARIA
config BR2_ANGULARJS_MODULE_COOKIES
bool "cookies"
+ default y
help
The ngCookies module provides a convenient wrapper for reading and
writing browser cookies.
-config BR2_ANGULARJS_MODULE_MESSAGE_FORMAT
- bool "message-format"
- help
- The ngMessageFormat module is used recognize MessageFormat extensions
- in interpolation expressions.
-
config BR2_ANGULARJS_MODULE_MESSAGES
bool "messages"
+ default y
help
The ngMessages module provides enhanced support for displaying
messages within templates (typically within forms or when rendering
message objects that return key/value data).
+config BR2_ANGULARJS_MODULE_MESSAGE_FORMAT
+ bool "message-format"
+ default y
+ help
+ The ngMessageFormat module is used recognize MessageFormat extensions
+ in interpolation expressions.
+
config BR2_ANGULARJS_MODULE_RESOURCE
bool "resource"
+ default y
help
The ngResource module provides interaction support with RESTful
services via the $resource service.
config BR2_ANGULARJS_MODULE_ROUTE
bool "route"
+ default y
help
The ngRoute module provides routing and deeplinking services and
directives for angular apps.
config BR2_ANGULARJS_MODULE_SANITIZE
bool "sanitize"
+ default y
help
The ngSanitize module provides functionality to sanitize HTML.
config BR2_ANGULARJS_MODULE_TOUCH
bool "touch"
+ default y
help
The ngTouch module provides touch events and other helpers for
touch-enabled devices. The implementation is based on jQuery Mobile
touch event handling (jquerymobile.com).
endif
-
-endif
diff --git a/package/angularjs/angularjs.mk b/package/angularjs/angularjs.mk
index 60dbdb6..20a129d 100644
--- a/package/angularjs/angularjs.mk
+++ b/package/angularjs/angularjs.mk
@@ -17,18 +17,24 @@ define ANGULARJS_EXTRACT_CMDS
rmdir $(@D)/angular-$(ANGULARJS_VERSION)
endef
-ANGULARJS_FILES = angular
+# This list mirrors the list of available modules from Config.in.
+# Keep this list in sync and in the same (alphabetical) order as the
+# one in Config.in. However, always keep 'angular' first in the list.
+ANGULARJS_MODULES = \
+ angular \
+ animate \
+ aria \
+ cookies \
+ messages \
+ message-format \
+ resource \
+ route \
+ sanitize \
+ touch
-ANGULARJS_MODULES = animate aria cookies message-format messages resource \
- route sanitize touch
-
-ifeq ($(BR2_ANGULARJS_MODULES),y)
-ANGULARJS_FILES += $(foreach mod,$(ANGULARJS_MODULES),\
+ANGULARJS_FILES = $(foreach mod,$(ANGULARJS_MODULES),\
$(if $(BR2_ANGULARJS_MODULE_$(call UPPERCASE,$(mod))),\
angular-$(mod)))
-else
-ANGULARJS_FILES += $(foreach mod,$(ANGULARJS_MODULES),angular-$(mod))
-endif
define ANGULARJS_INSTALL_TARGET_CMDS
$(foreach f,$(ANGULARJS_FILES),\
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 10/84 RFC] package/angularjs: simplify modules selection
2015-12-25 21:24 ` [Buildroot] [PATCH 10/84 RFC] package/angularjs: simplify modules selection Yann E. MORIN
@ 2015-12-30 23:27 ` Arnout Vandecappelle
2015-12-31 16:33 ` Yann E. MORIN
0 siblings, 1 reply; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-30 23:27 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:24, Yann E. MORIN wrote:
> Remove the superfluous config option, and make all modules default to
> 'y', which provides exactly the same functionality.
>
> simplify (and slightly beautofy) the handling of modules in the .mk:
> since the modules' symbols are always meaningful now, we can get rid of
> the else-clause, and always build the list of modules using the Kconfig
> options.
>
> Re-order the list alphabetically (message <-> message-format).
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/angularjs/Config.in | 35 +++++++++++++++++++++--------------
> package/angularjs/angularjs.mk | 24 +++++++++++++++---------
> 2 files changed, 36 insertions(+), 23 deletions(-)
>
> diff --git a/package/angularjs/Config.in b/package/angularjs/Config.in
> index 206b3d8..ee1dbbf 100644
> --- a/package/angularjs/Config.in
> +++ b/package/angularjs/Config.in
> @@ -7,16 +7,17 @@ menuconfig BR2_PACKAGE_ANGULARJS
>
> if BR2_PACKAGE_ANGULARJS
>
> -config BR2_ANGULARJS_MODULES
> - bool "angularjs modules"
> - help
> - Select which modules to install. If disabled, all modules
> - will be installed.
> +# All the modules default to 'y' to keep backward-compatibility
I don't think this comment is needed, because it will no longer be true in the
future.
> +# Keep this list in sync and in the same (alphabetical) order as # the
> +# one in angularjs.mk. However, always keep 'angular' first in the list.
I don't think this comment is needed either. We don't have something like that
at the top of package/Config.in for instance. And it's not that things stop to
work if it's not alphabetical.
>
> -if BR2_ANGULARJS_MODULES
> +config BR2_ANGULARJS_MODULE_ANGULAR
> + bool
> + default y
I don't like this part either, see below.
[snip]
> diff --git a/package/angularjs/angularjs.mk b/package/angularjs/angularjs.mk
> index 60dbdb6..20a129d 100644
> --- a/package/angularjs/angularjs.mk
> +++ b/package/angularjs/angularjs.mk
> @@ -17,18 +17,24 @@ define ANGULARJS_EXTRACT_CMDS
> rmdir $(@D)/angular-$(ANGULARJS_VERSION)
> endef
>
> -ANGULARJS_FILES = angular
I prefered it like this, with the angular bit always there and the rest added
by Kconfig options. Simpler than adding a dummy Kconfig option for angular itself.
Regards,
Arnout
> +# This list mirrors the list of available modules from Config.in.
> +# Keep this list in sync and in the same (alphabetical) order as the
> +# one in Config.in. However, always keep 'angular' first in the list.
> +ANGULARJS_MODULES = \
> + angular \
> + animate \
> + aria \
> + cookies \
> + messages \
> + message-format \
> + resource \
> + route \
> + sanitize \
> + touch
>
> -ANGULARJS_MODULES = animate aria cookies message-format messages resource \
> - route sanitize touch
> -
> -ifeq ($(BR2_ANGULARJS_MODULES),y)
> -ANGULARJS_FILES += $(foreach mod,$(ANGULARJS_MODULES),\
> +ANGULARJS_FILES = $(foreach mod,$(ANGULARJS_MODULES),\
> $(if $(BR2_ANGULARJS_MODULE_$(call UPPERCASE,$(mod))),\
> angular-$(mod)))
> -else
> -ANGULARJS_FILES += $(foreach mod,$(ANGULARJS_MODULES),angular-$(mod))
> -endif
>
> define ANGULARJS_INSTALL_TARGET_CMDS
> $(foreach f,$(ANGULARJS_FILES),\
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 10/84 RFC] package/angularjs: simplify modules selection
2015-12-30 23:27 ` Arnout Vandecappelle
@ 2015-12-31 16:33 ` Yann E. MORIN
0 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-31 16:33 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2015-12-31 00:27 +0100, Arnout Vandecappelle spake thusly:
> On 25-12-15 22:24, Yann E. MORIN wrote:
> > Remove the superfluous config option, and make all modules default to
> > 'y', which provides exactly the same functionality.
> >
> > simplify (and slightly beautofy) the handling of modules in the .mk:
> > since the modules' symbols are always meaningful now, we can get rid of
> > the else-clause, and always build the list of modules using the Kconfig
> > options.
> >
> > Re-order the list alphabetically (message <-> message-format).
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> > package/angularjs/Config.in | 35 +++++++++++++++++++++--------------
> > package/angularjs/angularjs.mk | 24 +++++++++++++++---------
> > 2 files changed, 36 insertions(+), 23 deletions(-)
> >
> > diff --git a/package/angularjs/Config.in b/package/angularjs/Config.in
> > index 206b3d8..ee1dbbf 100644
> > --- a/package/angularjs/Config.in
> > +++ b/package/angularjs/Config.in
> > @@ -7,16 +7,17 @@ menuconfig BR2_PACKAGE_ANGULARJS
> >
> > if BR2_PACKAGE_ANGULARJS
> >
> > -config BR2_ANGULARJS_MODULES
> > - bool "angularjs modules"
> > - help
> > - Select which modules to install. If disabled, all modules
> > - will be installed.
> > +# All the modules default to 'y' to keep backward-compatibility
>
> I don't think this comment is needed, because it will no longer be true in the
> future.
>
> > +# Keep this list in sync and in the same (alphabetical) order as # the
> > +# one in angularjs.mk. However, always keep 'angular' first in the list.
>
> I don't think this comment is needed either. We don't have something like that
> at the top of package/Config.in for instance. And it's not that things stop to
> work if it's not alphabetical.
>
> >
> > -if BR2_ANGULARJS_MODULES
> > +config BR2_ANGULARJS_MODULE_ANGULAR
> > + bool
> > + default y
>
> I don't like this part either, see below.
>
> [snip]
>
> > diff --git a/package/angularjs/angularjs.mk b/package/angularjs/angularjs.mk
> > index 60dbdb6..20a129d 100644
> > --- a/package/angularjs/angularjs.mk
> > +++ b/package/angularjs/angularjs.mk
> > @@ -17,18 +17,24 @@ define ANGULARJS_EXTRACT_CMDS
> > rmdir $(@D)/angular-$(ANGULARJS_VERSION)
> > endef
> >
> > -ANGULARJS_FILES = angular
>
> I prefered it like this, with the angular bit always there and the rest added
> by Kconfig options. Simpler than adding a dummy Kconfig option for angular itself.
I was not 100% sure either, so I'll revert it.
Thanks! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 11/84 RFC] package/collectd: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (9 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 10/84 RFC] package/angularjs: simplify modules selection Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 12/84 RFC] package/gd: use 'menuconfig' instad " Yann E. MORIN
` (74 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Since there were multiple sub-menus, keep their prompts as a comment, to
properly separate all famillies of plugins.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/collectd/Config.in | 21 ++++++---------------
1 file changed, 6 insertions(+), 15 deletions(-)
diff --git a/package/collectd/Config.in b/package/collectd/Config.in
index 5cdb24e..8e65c20 100644
--- a/package/collectd/Config.in
+++ b/package/collectd/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_COLLECTD
+menuconfig BR2_PACKAGE_COLLECTD
bool "collectd"
# Uses fork()
depends on BR2_USE_MMU
@@ -13,7 +13,7 @@ config BR2_PACKAGE_COLLECTD
if BR2_PACKAGE_COLLECTD
-menu "match plugins"
+comment "match plugins"
config BR2_PACKAGE_COLLECTD_EMPTY_COUNTER
bool "empty counter"
@@ -39,9 +39,8 @@ config BR2_PACKAGE_COLLECTD_VALUE
bool "value"
help
Select values by their data sources' values.
-endmenu
-menu "misc plugins"
+comment "misc plugins"
config BR2_PACKAGE_COLLECTD_AGGREGATION
bool "aggregation"
@@ -86,9 +85,7 @@ config BR2_PACKAGE_COLLECTD_THRESHOLD
Checks values against configured thresholds and creates notifications
if values are out of bounds.
-endmenu
-
-menu "read plugins"
+comment "read plugins"
comment "Select at least one for collectd to be useful"
@@ -455,9 +452,7 @@ config BR2_PACKAGE_COLLECTD_ZOOKEEPER
help
Read data from Zookeeper's MNTR command.
-endmenu
-
-menu "target plugins"
+comment "target plugins"
config BR2_PACKAGE_COLLECTD_NOTIFICATION
bool "notification"
@@ -479,9 +474,7 @@ config BR2_PACKAGE_COLLECTD_SET
help
Set (overwrite) entire parts of an identifier.
-endmenu
-
-menu "write plugins"
+comment "write plugins"
comment "Select at least one for collectd to be useful"
@@ -550,8 +543,6 @@ config BR2_PACKAGE_COLLECTD_WRITETSDB
Sends data OpenTSDB, a scalable no master, no shared state time
series database.
-endmenu
-
endif
comment "collectd needs a toolchain w/ threads, dynamic library"
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 12/84 RFC] package/gd: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (10 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 11/84 RFC] package/collectd: use 'menuconfig' instead of 'config'+'menu' Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-30 23:32 ` Arnout Vandecappelle
2015-12-25 21:24 ` [Buildroot] [PATCH 13/84 RFC] package/gpsd: use 'menuconfig' instead " Yann E. MORIN
` (73 subsequent siblings)
85 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/gd/Config.in | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/package/gd/Config.in b/package/gd/Config.in
index e838635..1f466d2 100644
--- a/package/gd/Config.in
+++ b/package/gd/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_GD
+menuconfig BR2_PACKAGE_GD
bool "gd"
help
GD is a graphics library. It allows your code to quickly
@@ -12,7 +12,7 @@ config BR2_PACKAGE_GD
if BR2_PACKAGE_GD
-menu "gd tools"
+comment "gd tools"
config BR2_PACKAGE_GD_ANNOTATE
bool "annotate"
@@ -57,6 +57,4 @@ config BR2_PACKAGE_GD_WEBPNG
bool "webpng"
select BR2_PACKAGE_LIBPNG
-endmenu
-
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 12/84 RFC] package/gd: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:24 ` [Buildroot] [PATCH 12/84 RFC] package/gd: use 'menuconfig' instad " Yann E. MORIN
@ 2015-12-30 23:32 ` Arnout Vandecappelle
0 siblings, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-30 23:32 UTC (permalink / raw)
To: buildroot
In the subject: instad -> instead.
Regards,
Arnout
On 25-12-15 22:24, Yann E. MORIN wrote:
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/gd/Config.in | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/package/gd/Config.in b/package/gd/Config.in
> index e838635..1f466d2 100644
> --- a/package/gd/Config.in
> +++ b/package/gd/Config.in
> @@ -1,4 +1,4 @@
> -config BR2_PACKAGE_GD
> +menuconfig BR2_PACKAGE_GD
> bool "gd"
> help
> GD is a graphics library. It allows your code to quickly
> @@ -12,7 +12,7 @@ config BR2_PACKAGE_GD
>
> if BR2_PACKAGE_GD
>
> -menu "gd tools"
> +comment "gd tools"
>
> config BR2_PACKAGE_GD_ANNOTATE
> bool "annotate"
> @@ -57,6 +57,4 @@ config BR2_PACKAGE_GD_WEBPNG
> bool "webpng"
> select BR2_PACKAGE_LIBPNG
>
> -endmenu
> -
> endif
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 13/84 RFC] package/gpsd: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (11 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 12/84 RFC] package/gd: use 'menuconfig' instad " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 14/84 RFC] package/jquery: include external plugins from jquery's Config.in Yann E. MORIN
` (72 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Since there were multiple sub-menus, their prompts are turned into
comments.
Some option were missing a prompt, so add one. Add separating lines
around options.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/gpsd/Config.in | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/package/gpsd/Config.in b/package/gpsd/Config.in
index b4008eb..876ab9b 100644
--- a/package/gpsd/Config.in
+++ b/package/gpsd/Config.in
@@ -2,7 +2,7 @@ comment "gpsd needs a toolchain w/ threads, dynamic library"
depends on BR2_USE_MMU
depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
-config BR2_PACKAGE_GPSD
+menuconfig BR2_PACKAGE_GPSD
bool "gpsd"
# Uses fork()
depends on BR2_USE_MMU
@@ -25,7 +25,7 @@ config BR2_PACKAGE_GPSD_DEVICES
string "Where to look for GPSes"
default "/dev/ttyS1"
-menu "Features"
+comment "Features"
config BR2_PACKAGE_GPSD_CLIENT_DEBUG
bool "client debugging support"
@@ -50,36 +50,41 @@ config BR2_PACKAGE_GPSD_PPS
config BR2_PACKAGE_GPSD_USER
bool "GPSD privilege revocation user"
+
config BR2_PACKAGE_GPSD_USER_VALUE
- string ""
+ string "user to run as"
default "nobody"
depends on BR2_PACKAGE_GPSD_USER
config BR2_PACKAGE_GPSD_GROUP
bool "GPSD privilege revocation group"
+
config BR2_PACKAGE_GPSD_GROUP_VALUE
- string ""
+ string "group to run as"
default "nobody"
depends on BR2_PACKAGE_GPSD_GROUP
config BR2_PACKAGE_GPSD_FIXED_PORT_SPEED
bool "compile with fixed serial port speed"
+
config BR2_PACKAGE_GPSD_FIXED_PORT_SPEED_VALUE
- string ""
+ int "serial port speed"
default "9600"
depends on BR2_PACKAGE_GPSD_FIXED_PORT_SPEED
config BR2_PACKAGE_GPSD_MAX_CLIENT
bool "compile with limited maximum clients"
+
config BR2_PACKAGE_GPSD_MAX_CLIENT_VALUE
- string "compile with limited maximum clients"
+ int "maximum number of clients"
default "10"
depends on BR2_PACKAGE_GPSD_MAX_CLIENT
config BR2_PACKAGE_GPSD_MAX_DEV
bool "compile with maximum allowed devices"
+
config BR2_PACKAGE_GPSD_MAX_DEV_VALUE
- string "compile with maximum allowed devices"
+ int "maximum allowed devices"
default "2"
depends on BR2_PACKAGE_GPSD_MAX_DEV
@@ -94,9 +99,7 @@ config BR2_PACKAGE_GPSD_CONTROLSEND
config BR2_PACKAGE_GPSD_SQUELCH
bool "squelch gpsd_report and gpsd_hexdump to save cpu"
-endmenu
-
-menu "Protocols"
+comment "Protocols"
config BR2_PACKAGE_GPSD_AIVDM
bool "Aivdm"
@@ -231,6 +234,4 @@ config BR2_PACKAGE_GPSD_UBX
help
uBlox UBX binary support
-endmenu
-
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 14/84 RFC] package/jquery: include external plugins from jquery's Config.in
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (12 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 13/84 RFC] package/gpsd: use 'menuconfig' instead " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-30 23:45 ` Arnout Vandecappelle
2016-01-02 0:22 ` Arnout Vandecappelle
2015-12-25 21:24 ` [Buildroot] [PATCH 15/84 RFC] package/libdrm: move tests programs to the bottom Yann E. MORIN
` (71 subsequent siblings)
85 siblings, 2 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
... and make it a menuconfig instead of a 'config'+'menu'.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/Config.in | 12 ------------
package/jquery/Config.in | 17 ++++++++++++++++-
2 files changed, 16 insertions(+), 13 deletions(-)
diff --git a/package/Config.in b/package/Config.in
index dd44743..73a3ac8 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -951,18 +951,6 @@ menu "Javascript"
source "package/explorercanvas/Config.in"
source "package/flot/Config.in"
source "package/jquery/Config.in"
-if BR2_PACKAGE_JQUERY
-menu "External jQuery plugins"
- source "package/jquery-datetimepicker/Config.in"
- source "package/jquery-keyboard/Config.in"
- source "package/jquery-mobile/Config.in"
- source "package/jquery-sidebar/Config.in"
- source "package/jquery-sparkline/Config.in"
- source "package/jquery-ui/Config.in"
- source "package/jquery-ui-themes/Config.in"
- source "package/jquery-validation/Config.in"
-endmenu
-endif
source "package/jsmin/Config.in"
source "package/json-javascript/Config.in"
endmenu
diff --git a/package/jquery/Config.in b/package/jquery/Config.in
index 92f5604..3133702 100644
--- a/package/jquery/Config.in
+++ b/package/jquery/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_JQUERY
+menuconfig BR2_PACKAGE_JQUERY
bool "jQuery"
help
jQuery is a fast and concise JavaScript Library that
@@ -6,3 +6,18 @@ config BR2_PACKAGE_JQUERY
animating, and Ajax interactions for rapid web development.
http://jquery.com
+
+if BR2_PACKAGE_JQUERY
+
+comment "External jQuery plugins"
+
+source "package/jquery-datetimepicker/Config.in"
+source "package/jquery-keyboard/Config.in"
+source "package/jquery-mobile/Config.in"
+source "package/jquery-sidebar/Config.in"
+source "package/jquery-sparkline/Config.in"
+source "package/jquery-ui/Config.in"
+source "package/jquery-ui-themes/Config.in"
+source "package/jquery-validation/Config.in"
+
+endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 14/84 RFC] package/jquery: include external plugins from jquery's Config.in
2015-12-25 21:24 ` [Buildroot] [PATCH 14/84 RFC] package/jquery: include external plugins from jquery's Config.in Yann E. MORIN
@ 2015-12-30 23:45 ` Arnout Vandecappelle
2015-12-31 17:17 ` Yann E. MORIN
2016-01-02 0:22 ` Arnout Vandecappelle
1 sibling, 1 reply; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-30 23:45 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:24, Yann E. MORIN wrote:
> ... and make it a menuconfig instead of a 'config'+'menu'.
I don't agree with this change, because these are really separate packages, not
suboptions of the jquery package. Similar for python, where it is even more
obvious because as indicated by the symlink hack for python3.
Regards,
Arnout
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/Config.in | 12 ------------
> package/jquery/Config.in | 17 ++++++++++++++++-
> 2 files changed, 16 insertions(+), 13 deletions(-)
>
> diff --git a/package/Config.in b/package/Config.in
> index dd44743..73a3ac8 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -951,18 +951,6 @@ menu "Javascript"
> source "package/explorercanvas/Config.in"
> source "package/flot/Config.in"
> source "package/jquery/Config.in"
> -if BR2_PACKAGE_JQUERY
> -menu "External jQuery plugins"
> - source "package/jquery-datetimepicker/Config.in"
> - source "package/jquery-keyboard/Config.in"
> - source "package/jquery-mobile/Config.in"
> - source "package/jquery-sidebar/Config.in"
> - source "package/jquery-sparkline/Config.in"
> - source "package/jquery-ui/Config.in"
> - source "package/jquery-ui-themes/Config.in"
> - source "package/jquery-validation/Config.in"
> -endmenu
> -endif
> source "package/jsmin/Config.in"
> source "package/json-javascript/Config.in"
> endmenu
> diff --git a/package/jquery/Config.in b/package/jquery/Config.in
> index 92f5604..3133702 100644
> --- a/package/jquery/Config.in
> +++ b/package/jquery/Config.in
> @@ -1,4 +1,4 @@
> -config BR2_PACKAGE_JQUERY
> +menuconfig BR2_PACKAGE_JQUERY
> bool "jQuery"
> help
> jQuery is a fast and concise JavaScript Library that
> @@ -6,3 +6,18 @@ config BR2_PACKAGE_JQUERY
> animating, and Ajax interactions for rapid web development.
>
> http://jquery.com
> +
> +if BR2_PACKAGE_JQUERY
> +
> +comment "External jQuery plugins"
> +
> +source "package/jquery-datetimepicker/Config.in"
> +source "package/jquery-keyboard/Config.in"
> +source "package/jquery-mobile/Config.in"
> +source "package/jquery-sidebar/Config.in"
> +source "package/jquery-sparkline/Config.in"
> +source "package/jquery-ui/Config.in"
> +source "package/jquery-ui-themes/Config.in"
> +source "package/jquery-validation/Config.in"
> +
> +endif
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 14/84 RFC] package/jquery: include external plugins from jquery's Config.in
2015-12-30 23:45 ` Arnout Vandecappelle
@ 2015-12-31 17:17 ` Yann E. MORIN
2016-01-02 0:21 ` Arnout Vandecappelle
0 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-31 17:17 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2015-12-31 00:45 +0100, Arnout Vandecappelle spake thusly:
> On 25-12-15 22:24, Yann E. MORIN wrote:
> > ... and make it a menuconfig instead of a 'config'+'menu'.
>
> I don't agree with this change, because these are really separate packages, not
> suboptions of the jquery package. Similar for python, where it is even more
> obvious because as indicated by the symlink hack for python3.
That they are separate packages is irrelevant, to the _user_.
It makes sense for us, packagers and BR developpers, but it should not
have an impact on the user experience.
What is relevant to the user, is that they are jquery stuff, and they
don't even make sense without jquery. Whether they are "built-in" or
"external" modules should not be of his concerns.
And, as you argue, if they should be treated like "nornmal" packages,
why do we have them in a submenu?
Note also that what I propose here is what we already do for a few other
packages:
- Kodi
- freescale-imx
- matchbox
- nvidia-tegra23
- to a lesser extent, Qt5
Please have a look *as a user* to the menuconfig before and after this
series, and tell me you really prefer the previous layout. Yes, this new
one means we need to source packages "modules" (perl, php, python...)
from the package's own Config.in rather than from the /main/ Config.in,
but I do believe it is better in three ways:
- those "modules" are only meaningful in combination with the
corresponding package [0],
- it removes the (relative) complexity of the dependency knowledge out
of the main package/Config.in [1] and move it to the best location
where it can be handled, i.e. the package itself,
- the resulting menuconfig (UI) layout is more appealing to an end
user (IMHO).
[0] this implies the python/python3 symlink trick, yes.
[1] I would also like to get rid of the if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
from package/Config.in and move it to the packages themselves. Not
that we are not even consistent with that one either, like for
systemd or tovid.
So I will maintain this patch in the series, if at least to get more
feedback from others.
Thanks for your opinion! ;-)
(This reply is valid for all you other NAKs about this topic. ;-) )
Regards,
Yann E. MORIN.
> Regards,
> Arnout
>
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> > package/Config.in | 12 ------------
> > package/jquery/Config.in | 17 ++++++++++++++++-
> > 2 files changed, 16 insertions(+), 13 deletions(-)
> >
> > diff --git a/package/Config.in b/package/Config.in
> > index dd44743..73a3ac8 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -951,18 +951,6 @@ menu "Javascript"
> > source "package/explorercanvas/Config.in"
> > source "package/flot/Config.in"
> > source "package/jquery/Config.in"
> > -if BR2_PACKAGE_JQUERY
> > -menu "External jQuery plugins"
> > - source "package/jquery-datetimepicker/Config.in"
> > - source "package/jquery-keyboard/Config.in"
> > - source "package/jquery-mobile/Config.in"
> > - source "package/jquery-sidebar/Config.in"
> > - source "package/jquery-sparkline/Config.in"
> > - source "package/jquery-ui/Config.in"
> > - source "package/jquery-ui-themes/Config.in"
> > - source "package/jquery-validation/Config.in"
> > -endmenu
> > -endif
> > source "package/jsmin/Config.in"
> > source "package/json-javascript/Config.in"
> > endmenu
> > diff --git a/package/jquery/Config.in b/package/jquery/Config.in
> > index 92f5604..3133702 100644
> > --- a/package/jquery/Config.in
> > +++ b/package/jquery/Config.in
> > @@ -1,4 +1,4 @@
> > -config BR2_PACKAGE_JQUERY
> > +menuconfig BR2_PACKAGE_JQUERY
> > bool "jQuery"
> > help
> > jQuery is a fast and concise JavaScript Library that
> > @@ -6,3 +6,18 @@ config BR2_PACKAGE_JQUERY
> > animating, and Ajax interactions for rapid web development.
> >
> > http://jquery.com
> > +
> > +if BR2_PACKAGE_JQUERY
> > +
> > +comment "External jQuery plugins"
> > +
> > +source "package/jquery-datetimepicker/Config.in"
> > +source "package/jquery-keyboard/Config.in"
> > +source "package/jquery-mobile/Config.in"
> > +source "package/jquery-sidebar/Config.in"
> > +source "package/jquery-sparkline/Config.in"
> > +source "package/jquery-ui/Config.in"
> > +source "package/jquery-ui-themes/Config.in"
> > +source "package/jquery-validation/Config.in"
> > +
> > +endif
> >
>
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 14/84 RFC] package/jquery: include external plugins from jquery's Config.in
2015-12-31 17:17 ` Yann E. MORIN
@ 2016-01-02 0:21 ` Arnout Vandecappelle
0 siblings, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2016-01-02 0:21 UTC (permalink / raw)
To: buildroot
On 31-12-15 18:17, Yann E. MORIN wrote:
> Arnout, All,
>
> On 2015-12-31 00:45 +0100, Arnout Vandecappelle spake thusly:
>> On 25-12-15 22:24, Yann E. MORIN wrote:
>>> ... and make it a menuconfig instead of a 'config'+'menu'.
>>
>> I don't agree with this change, because these are really separate packages, not
>> suboptions of the jquery package. Similar for python, where it is even more
>> obvious because as indicated by the symlink hack for python3.
>
> That they are separate packages is irrelevant, to the _user_.
>
> It makes sense for us, packagers and BR developpers, but it should not
> have an impact on the user experience.
>
> What is relevant to the user, is that they are jquery stuff, and they
> don't even make sense without jquery. Whether they are "built-in" or
> "external" modules should not be of his concerns.
>
> And, as you argue, if they should be treated like "nornmal" packages,
> why do we have them in a submenu?
I've taken another look at the two versions, and basically what I had objection
with is the submenu itself (the existing one). However, removing the menu would
be even worse (overcrowding the menu above it.
So I'll go back through the NACK'ed patch and re-review them.
Regards,
Arnout
>
> Note also that what I propose here is what we already do for a few other
> packages:
> - Kodi
> - freescale-imx
> - matchbox
> - nvidia-tegra23
> - to a lesser extent, Qt5
>
> Please have a look *as a user* to the menuconfig before and after this
> series, and tell me you really prefer the previous layout. Yes, this new
> one means we need to source packages "modules" (perl, php, python...)
> from the package's own Config.in rather than from the /main/ Config.in,
> but I do believe it is better in three ways:
>
> - those "modules" are only meaningful in combination with the
> corresponding package [0],
>
> - it removes the (relative) compjquerylexity of the dependency knowledge out
> of the main package/Config.in [1] and move it to the best location
> where it can be handled, i.e. the package itself,
>
> - the resulting menuconfig (UI) layout is more appealing to an end
> user (IMHO).
>
> [0] this implies the python/python3 symlink trick, yes.
> [1] I would also like to get rid of the if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> from package/Config.in and move it to the packages themselves. Not
> that we are not even consistent with that one either, like for
> systemd or tovid.
>
> So I will maintain this patch in the series, if at least to get more
> feedback from others.
>
> Thanks for your opinion! ;-)
>
> (This reply is valid for all you other NAKs about this topic. ;-) )
>
> Regards,
> Yann E. MORIN.
>
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 14/84 RFC] package/jquery: include external plugins from jquery's Config.in
2015-12-25 21:24 ` [Buildroot] [PATCH 14/84 RFC] package/jquery: include external plugins from jquery's Config.in Yann E. MORIN
2015-12-30 23:45 ` Arnout Vandecappelle
@ 2016-01-02 0:22 ` Arnout Vandecappelle
1 sibling, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2016-01-02 0:22 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:24, Yann E. MORIN wrote:
> ... and make it a menuconfig instead of a 'config'+'menu'.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
> package/Config.in | 12 ------------
> package/jquery/Config.in | 17 ++++++++++++++++-
> 2 files changed, 16 insertions(+), 13 deletions(-)
>
> diff --git a/package/Config.in b/package/Config.in
> index dd44743..73a3ac8 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -951,18 +951,6 @@ menu "Javascript"
> source "package/explorercanvas/Config.in"
> source "package/flot/Config.in"
> source "package/jquery/Config.in"
> -if BR2_PACKAGE_JQUERY
> -menu "External jQuery plugins"
> - source "package/jquery-datetimepicker/Config.in"
> - source "package/jquery-keyboard/Config.in"
> - source "package/jquery-mobile/Config.in"
> - source "package/jquery-sidebar/Config.in"
> - source "package/jquery-sparkline/Config.in"
> - source "package/jquery-ui/Config.in"
> - source "package/jquery-ui-themes/Config.in"
> - source "package/jquery-validation/Config.in"
> -endmenu
> -endif
> source "package/jsmin/Config.in"
> source "package/json-javascript/Config.in"
> endmenu
> diff --git a/package/jquery/Config.in b/package/jquery/Config.in
> index 92f5604..3133702 100644
> --- a/package/jquery/Config.in
> +++ b/package/jquery/Config.in
> @@ -1,4 +1,4 @@
> -config BR2_PACKAGE_JQUERY
> +menuconfig BR2_PACKAGE_JQUERY
> bool "jQuery"
> help
> jQuery is a fast and concise JavaScript Library that
> @@ -6,3 +6,18 @@ config BR2_PACKAGE_JQUERY
> animating, and Ajax interactions for rapid web development.
>
> http://jquery.com
> +
> +if BR2_PACKAGE_JQUERY
> +
> +comment "External jQuery plugins"
> +
> +source "package/jquery-datetimepicker/Config.in"
> +source "package/jquery-keyboard/Config.in"
> +source "package/jquery-mobile/Config.in"
> +source "package/jquery-sidebar/Config.in"
> +source "package/jquery-sparkline/Config.in"
> +source "package/jquery-ui/Config.in"
> +source "package/jquery-ui-themes/Config.in"
> +source "package/jquery-validation/Config.in"
> +
> +endif
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 15/84 RFC] package/libdrm: move tests programs to the bottom
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (13 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 14/84 RFC] package/jquery: include external plugins from jquery's Config.in Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 16/84 RFC] package/libdrm: use 'menuconfig' instad of 'config'+'menu' Yann E. MORIN
` (70 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Tests programs are not that important; at least, they're probably less
important than the drivers selection.
Move it down to after the drivers selection.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/libdrm/Config.in | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/package/libdrm/Config.in b/package/libdrm/Config.in
index 445a85b..ad015f8 100644
--- a/package/libdrm/Config.in
+++ b/package/libdrm/Config.in
@@ -9,11 +9,6 @@ config BR2_PACKAGE_LIBDRM
if BR2_PACKAGE_LIBDRM
-config BR2_PACKAGE_LIBDRM_INSTALL_TESTS
- bool "Install test programs"
- help
- This option allows to install the libdrm test programs.
-
menu "DRM Drivers"
config BR2_PACKAGE_LIBDRM_INTEL
@@ -71,6 +66,11 @@ config BR2_PACKAGE_LIBDRM_TEGRA
endmenu
+config BR2_PACKAGE_LIBDRM_INSTALL_TESTS
+ bool "Install test programs"
+ help
+ This option allows to install the libdrm test programs.
+
endif
comment "libdrm needs a toolchain w/ threads"
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 16/84 RFC] package/libdrm: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (14 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 15/84 RFC] package/libdrm: move tests programs to the bottom Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-30 23:46 ` Arnout Vandecappelle
2015-12-25 21:24 ` [Buildroot] [PATCH 17/84 RFC] package/mono: use 'menuconfig' instead " Yann E. MORIN
` (69 subsequent siblings)
85 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Transform the menu prompt into a comment.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/libdrm/Config.in | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/package/libdrm/Config.in b/package/libdrm/Config.in
index ad015f8..9b75647 100644
--- a/package/libdrm/Config.in
+++ b/package/libdrm/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_LIBDRM
+menuconfig BR2_PACKAGE_LIBDRM
bool "libdrm"
select BR2_PACKAGE_LIBPTHREAD_STUBS
depends on BR2_TOOLCHAIN_HAS_THREADS # libpthread-stubs
@@ -9,7 +9,7 @@ config BR2_PACKAGE_LIBDRM
if BR2_PACKAGE_LIBDRM
-menu "DRM Drivers"
+comment "DRM Drivers"
config BR2_PACKAGE_LIBDRM_INTEL
bool "intel"
@@ -64,8 +64,6 @@ config BR2_PACKAGE_LIBDRM_TEGRA
help
Install NVIDIA Tegra driver using an experimental API.
-endmenu
-
config BR2_PACKAGE_LIBDRM_INSTALL_TESTS
bool "Install test programs"
help
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 16/84 RFC] package/libdrm: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:24 ` [Buildroot] [PATCH 16/84 RFC] package/libdrm: use 'menuconfig' instad of 'config'+'menu' Yann E. MORIN
@ 2015-12-30 23:46 ` Arnout Vandecappelle
0 siblings, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-30 23:46 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:24, Yann E. MORIN wrote:
> Transform the menu prompt into a comment.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/libdrm/Config.in | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/package/libdrm/Config.in b/package/libdrm/Config.in
> index ad015f8..9b75647 100644
> --- a/package/libdrm/Config.in
> +++ b/package/libdrm/Config.in
> @@ -1,4 +1,4 @@
> -config BR2_PACKAGE_LIBDRM
> +menuconfig BR2_PACKAGE_LIBDRM
> bool "libdrm"
> select BR2_PACKAGE_LIBPTHREAD_STUBS
> depends on BR2_TOOLCHAIN_HAS_THREADS # libpthread-stubs
> @@ -9,7 +9,7 @@ config BR2_PACKAGE_LIBDRM
>
> if BR2_PACKAGE_LIBDRM
>
> -menu "DRM Drivers"
> +comment "DRM Drivers"
Comment can be dropped.
Regards,
Arnout
>
> config BR2_PACKAGE_LIBDRM_INTEL
> bool "intel"
> @@ -64,8 +64,6 @@ config BR2_PACKAGE_LIBDRM_TEGRA
> help
> Install NVIDIA Tegra driver using an experimental API.
>
> -endmenu
> -
> config BR2_PACKAGE_LIBDRM_INSTALL_TESTS
> bool "Install test programs"
> help
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 17/84 RFC] package/mono: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (15 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 16/84 RFC] package/libdrm: use 'menuconfig' instad of 'config'+'menu' Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-30 23:48 ` Arnout Vandecappelle
2016-01-02 0:25 ` Arnout Vandecappelle
2015-12-25 21:24 ` [Buildroot] [PATCH 18/84 RFC] package/ncftp: use 'menuconfig' instad " Yann E. MORIN
` (68 subsequent siblings)
85 siblings, 2 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
This is a bit overkill, as there is only one sub-item. However, this
commit is not about judging whether it makes sense or not to have a
sub-menu, but to cleanup the 'config'+'menu' situation.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/Config.in | 5 -----
package/mono/Config.in | 8 +++++++-
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/package/Config.in b/package/Config.in
index 73a3ac8..4d2b763 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -539,11 +539,6 @@ endif
source "package/micropython-lib/Config.in"
source "package/moarvm/Config.in"
source "package/mono/Config.in"
-if BR2_PACKAGE_MONO
-menu "Mono libraries/modules"
- source "package/mono-gtksharp3/Config.in"
-endmenu
-endif
source "package/nodejs/Config.in"
source "package/perl/Config.in"
if BR2_PACKAGE_PERL
diff --git a/package/mono/Config.in b/package/mono/Config.in
index cf18a03..c00a3fa 100644
--- a/package/mono/Config.in
+++ b/package/mono/Config.in
@@ -3,7 +3,7 @@ config BR2_PACKAGE_MONO_ARCH_SUPPORTS
default y if (BR2_arm || BR2_armeb || BR2_i386 || BR2_mips || \
BR2_mipsel || BR2_powerpc || BR2_sparc || BR2_x86_64)
-config BR2_PACKAGE_MONO
+menuconfig BR2_PACKAGE_MONO
bool "mono"
depends on BR2_PACKAGE_MONO_ARCH_SUPPORTS
depends on BR2_TOOLCHAIN_HAS_THREADS
@@ -14,6 +14,12 @@ config BR2_PACKAGE_MONO
http://download.mono-project.com/sources/mono/
+if BR2_PACKAGE_MONO
+
+source "package/mono-gtksharp3/Config.in"
+
+endif
+
comment "mono needs a toolchain w/ threads, dynamic library"
depends on BR2_PACKAGE_MONO_ARCH_SUPPORTS
depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 17/84 RFC] package/mono: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:24 ` [Buildroot] [PATCH 17/84 RFC] package/mono: use 'menuconfig' instead " Yann E. MORIN
@ 2015-12-30 23:48 ` Arnout Vandecappelle
2016-01-02 0:25 ` Arnout Vandecappelle
1 sibling, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-30 23:48 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:24, Yann E. MORIN wrote:
> This is a bit overkill, as there is only one sub-item. However, this
> commit is not about judging whether it makes sense or not to have a
> sub-menu, but to cleanup the 'config'+'menu' situation.
NACK, like jquery.
Regards,
Arnout
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/Config.in | 5 -----
> package/mono/Config.in | 8 +++++++-
> 2 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/package/Config.in b/package/Config.in
> index 73a3ac8..4d2b763 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -539,11 +539,6 @@ endif
> source "package/micropython-lib/Config.in"
> source "package/moarvm/Config.in"
> source "package/mono/Config.in"
> -if BR2_PACKAGE_MONO
> -menu "Mono libraries/modules"
> - source "package/mono-gtksharp3/Config.in"
> -endmenu
> -endif
> source "package/nodejs/Config.in"
> source "package/perl/Config.in"
> if BR2_PACKAGE_PERL
> diff --git a/package/mono/Config.in b/package/mono/Config.in
> index cf18a03..c00a3fa 100644
> --- a/package/mono/Config.in
> +++ b/package/mono/Config.in
> @@ -3,7 +3,7 @@ config BR2_PACKAGE_MONO_ARCH_SUPPORTS
> default y if (BR2_arm || BR2_armeb || BR2_i386 || BR2_mips || \
> BR2_mipsel || BR2_powerpc || BR2_sparc || BR2_x86_64)
>
> -config BR2_PACKAGE_MONO
> +menuconfig BR2_PACKAGE_MONO
> bool "mono"
> depends on BR2_PACKAGE_MONO_ARCH_SUPPORTS
> depends on BR2_TOOLCHAIN_HAS_THREADS
> @@ -14,6 +14,12 @@ config BR2_PACKAGE_MONO
>
> http://download.mono-project.com/sources/mono/
>
> +if BR2_PACKAGE_MONO
> +
> +source "package/mono-gtksharp3/Config.in"
> +
> +endif
> +
> comment "mono needs a toolchain w/ threads, dynamic library"
> depends on BR2_PACKAGE_MONO_ARCH_SUPPORTS
> depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 17/84 RFC] package/mono: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:24 ` [Buildroot] [PATCH 17/84 RFC] package/mono: use 'menuconfig' instead " Yann E. MORIN
2015-12-30 23:48 ` Arnout Vandecappelle
@ 2016-01-02 0:25 ` Arnout Vandecappelle
1 sibling, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2016-01-02 0:25 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:24, Yann E. MORIN wrote:
> This is a bit overkill, as there is only one sub-item. However, this
> commit is not about judging whether it makes sense or not to have a
> sub-menu, but to cleanup the 'config'+'menu' situation.
Definitely overkill, since it is even empty when gtk3 isn't selected...
But as you say, that's not what this patch is about, so
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/Config.in | 5 -----
> package/mono/Config.in | 8 +++++++-
> 2 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/package/Config.in b/package/Config.in
> index 73a3ac8..4d2b763 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -539,11 +539,6 @@ endif
> source "package/micropython-lib/Config.in"
> source "package/moarvm/Config.in"
> source "package/mono/Config.in"
> -if BR2_PACKAGE_MONO
> -menu "Mono libraries/modules"
> - source "package/mono-gtksharp3/Config.in"
> -endmenu
> -endif
> source "package/nodejs/Config.in"
> source "package/perl/Config.in"
> if BR2_PACKAGE_PERL
> diff --git a/package/mono/Config.in b/package/mono/Config.in
> index cf18a03..c00a3fa 100644
> --- a/package/mono/Config.in
> +++ b/package/mono/Config.in
> @@ -3,7 +3,7 @@ config BR2_PACKAGE_MONO_ARCH_SUPPORTS
> default y if (BR2_arm || BR2_armeb || BR2_i386 || BR2_mips || \
> BR2_mipsel || BR2_powerpc || BR2_sparc || BR2_x86_64)
>
> -config BR2_PACKAGE_MONO
> +menuconfig BR2_PACKAGE_MONO
> bool "mono"
> depends on BR2_PACKAGE_MONO_ARCH_SUPPORTS
> depends on BR2_TOOLCHAIN_HAS_THREADS
> @@ -14,6 +14,12 @@ config BR2_PACKAGE_MONO
>
> http://download.mono-project.com/sources/mono/
>
> +if BR2_PACKAGE_MONO
> +
> +source "package/mono-gtksharp3/Config.in"
> +
> +endif
> +
> comment "mono needs a toolchain w/ threads, dynamic library"
> depends on BR2_PACKAGE_MONO_ARCH_SUPPORTS
> depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 18/84 RFC] package/ncftp: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (16 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 17/84 RFC] package/mono: use 'menuconfig' instead " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-30 23:48 ` Arnout Vandecappelle
2015-12-25 21:24 ` [Buildroot] [PATCH 19/84 RFC] package/nfs-utils: use 'menuconfig' instead " Yann E. MORIN
` (67 subsequent siblings)
85 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/ncftp/Config.in | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/package/ncftp/Config.in b/package/ncftp/Config.in
index 57586e7..736bea5 100644
--- a/package/ncftp/Config.in
+++ b/package/ncftp/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_NCFTP
+menuconfig BR2_PACKAGE_NCFTP
bool "ncftp"
# fork()
depends on BR2_USE_MMU
@@ -10,7 +10,7 @@ config BR2_PACKAGE_NCFTP
if BR2_PACKAGE_NCFTP
-menu "ncFTP tools selection"
+comment "tools selection"
config BR2_PACKAGE_NCFTP_GET
bool "NcFTPGet - command-line utility program"
@@ -32,6 +32,4 @@ config BR2_PACKAGE_NCFTP_BOOKMARKS
bool "NcFTPBookmarks - ncurses based Bookmark Editor"
select BR2_PACKAGE_NCURSES
-endmenu
-
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 18/84 RFC] package/ncftp: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:24 ` [Buildroot] [PATCH 18/84 RFC] package/ncftp: use 'menuconfig' instad " Yann E. MORIN
@ 2015-12-30 23:48 ` Arnout Vandecappelle
0 siblings, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-30 23:48 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:24, Yann E. MORIN wrote:
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/ncftp/Config.in | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/package/ncftp/Config.in b/package/ncftp/Config.in
> index 57586e7..736bea5 100644
> --- a/package/ncftp/Config.in
> +++ b/package/ncftp/Config.in
> @@ -1,4 +1,4 @@
> -config BR2_PACKAGE_NCFTP
> +menuconfig BR2_PACKAGE_NCFTP
> bool "ncftp"
> # fork()
> depends on BR2_USE_MMU
> @@ -10,7 +10,7 @@ config BR2_PACKAGE_NCFTP
>
> if BR2_PACKAGE_NCFTP
>
> -menu "ncFTP tools selection"
> +comment "tools selection"
Comment not needed.
Regards,
Arnout
>
> config BR2_PACKAGE_NCFTP_GET
> bool "NcFTPGet - command-line utility program"
> @@ -32,6 +32,4 @@ config BR2_PACKAGE_NCFTP_BOOKMARKS
> bool "NcFTPBookmarks - ncurses based Bookmark Editor"
> select BR2_PACKAGE_NCURSES
>
> -endmenu
> -
> endif
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 19/84 RFC] package/nfs-utils: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (17 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 18/84 RFC] package/ncftp: use 'menuconfig' instad " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 20/84 RFC] package/nodejs: " Yann E. MORIN
` (66 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/nfs-utils/Config.in | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/package/nfs-utils/Config.in b/package/nfs-utils/Config.in
index 1273092..7476fdb 100644
--- a/package/nfs-utils/Config.in
+++ b/package/nfs-utils/Config.in
@@ -2,7 +2,7 @@ comment "nfs-utils needs a toolchain w/ threads"
depends on BR2_USE_MMU
depends on !BR2_TOOLCHAIN_HAS_THREADS
-config BR2_PACKAGE_NFS_UTILS
+menuconfig BR2_PACKAGE_NFS_UTILS
bool "nfs-utils"
depends on BR2_TOOLCHAIN_HAS_THREADS # libtirpc, rpcbind
select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
@@ -15,8 +15,6 @@ config BR2_PACKAGE_NFS_UTILS
if BR2_PACKAGE_NFS_UTILS
-menu "NFS utilities selection"
-
config BR2_PACKAGE_NFS_UTILS_RPCDEBUG
bool "rpcdebug"
help
@@ -32,6 +30,4 @@ config BR2_PACKAGE_NFS_UTILS_RPC_RQUOTAD
help
NFS remote quota server
-endmenu
-
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 20/84 RFC] package/nodejs: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (18 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 19/84 RFC] package/nfs-utils: use 'menuconfig' instead " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-30 23:49 ` Arnout Vandecappelle
2015-12-25 21:24 ` [Buildroot] [PATCH 21/84 RFC] package/ola: " Yann E. MORIN
` (65 subsequent siblings)
85 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/nodejs/Config.in | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
index 008fbbf..000e0fb 100644
--- a/package/nodejs/Config.in
+++ b/package/nodejs/Config.in
@@ -5,7 +5,7 @@ comment "nodejs needs a toolchain w/ C++, dynamic library, threads"
depends on !BR2_ARM_CPU_ARMV4
depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
-config BR2_PACKAGE_NODEJS
+menuconfig BR2_PACKAGE_NODEJS
bool "nodejs"
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_INSTALL_LIBSTDCPP
@@ -62,7 +62,7 @@ config BR2_PACKAGE_NODEJS_VERSION_STRING
default "0.10.41" if BR2_PACKAGE_NODEJS_0_10_X
default "5.3.0" if BR2_PACKAGE_NODEJS_5_X
-menu "Module Selection"
+comment "Module Selection"
config BR2_PACKAGE_NODEJS_NPM
bool "NPM for the target"
@@ -118,6 +118,4 @@ config BR2_PACKAGE_NODEJS_MODULES_ADDITIONAL_DEPS
'libcurl' here, to ensure that buildroot builds the libcurl package,
and does so before building your node modules.
-endmenu
-
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 20/84 RFC] package/nodejs: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:24 ` [Buildroot] [PATCH 20/84 RFC] package/nodejs: " Yann E. MORIN
@ 2015-12-30 23:49 ` Arnout Vandecappelle
0 siblings, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-30 23:49 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:24, Yann E. MORIN wrote:
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/nodejs/Config.in | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
> index 008fbbf..000e0fb 100644
> --- a/package/nodejs/Config.in
> +++ b/package/nodejs/Config.in
> @@ -5,7 +5,7 @@ comment "nodejs needs a toolchain w/ C++, dynamic library, threads"
> depends on !BR2_ARM_CPU_ARMV4
> depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
>
> -config BR2_PACKAGE_NODEJS
> +menuconfig BR2_PACKAGE_NODEJS
> bool "nodejs"
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on BR2_INSTALL_LIBSTDCPP
> @@ -62,7 +62,7 @@ config BR2_PACKAGE_NODEJS_VERSION_STRING
> default "0.10.41" if BR2_PACKAGE_NODEJS_0_10_X
> default "5.3.0" if BR2_PACKAGE_NODEJS_5_X
>
> -menu "Module Selection"
> +comment "Module Selection"
Comment not needed.
Regards,
Arnout
>
> config BR2_PACKAGE_NODEJS_NPM
> bool "NPM for the target"
> @@ -118,6 +118,4 @@ config BR2_PACKAGE_NODEJS_MODULES_ADDITIONAL_DEPS
> 'libcurl' here, to ensure that buildroot builds the libcurl package,
> and does so before building your node modules.
>
> -endmenu
> -
> endif
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 21/84 RFC] package/ola: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (19 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 20/84 RFC] package/nodejs: " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 22/84 RFC] package/perl: " Yann E. MORIN
` (64 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Since there were multiple sub-menus, their prompts are turned into
comments.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/ola/Config.in | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/package/ola/Config.in b/package/ola/Config.in
index fd693de..fb96e11 100644
--- a/package/ola/Config.in
+++ b/package/ola/Config.in
@@ -3,7 +3,7 @@ comment "ola needs a toolchain w/ C++, threads, wchar, dynamic library"
|| !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64
-config BR2_PACKAGE_OLA
+menuconfig BR2_PACKAGE_OLA
bool "ola (open lighting architecture)"
select BR2_PACKAGE_PROTOBUF
select BR2_PACKAGE_UTIL_LINUX_LIBUUID
@@ -24,7 +24,7 @@ config BR2_PACKAGE_OLA
if BR2_PACKAGE_OLA
-menu "bindings and interface"
+comment "bindings and interface"
config BR2_PACKAGE_OLA_WEB
bool "http interface"
@@ -44,9 +44,7 @@ config BR2_PACKAGE_OLA_SLP
help
Build OLA with slp tools.
-endmenu
-
-menu "tests and examples"
+comment "tests and examples"
config BR2_PACKAGE_OLA_EXAMPLES
bool "examples"
@@ -60,9 +58,7 @@ config BR2_PACKAGE_OLA_RDM_TESTS
help
Build OLA RDM tests.
-endmenu
-
-menu "plugin selections"
+comment "plugin selections"
config BR2_PACKAGE_OLA_PLUGIN_E131
bool "acn E131"
@@ -132,6 +128,4 @@ config BR2_PACKAGE_OLA_PLUGIN_USBPRO
help
Build UsbPro plugin for OLA.
-endmenu
-
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 22/84 RFC] package/perl: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (20 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 21/84 RFC] package/ola: " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-30 23:53 ` Arnout Vandecappelle
2016-01-02 0:33 ` Arnout Vandecappelle
2015-12-25 21:24 ` [Buildroot] [PATCH 23/84 RFC] package/php: move list of extensions after interface selection Yann E. MORIN
` (63 subsequent siblings)
85 siblings, 2 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Move the perl library/modules inclusion to the perl's Config.in.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/Config.in | 47 -----------------------------------------------
package/perl/Config.in | 48 +++++++++++++++++++++++++++++++++++++++++++++++-
2 files changed, 47 insertions(+), 48 deletions(-)
diff --git a/package/Config.in b/package/Config.in
index 4d2b763..d65730a 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -541,53 +541,6 @@ endif
source "package/mono/Config.in"
source "package/nodejs/Config.in"
source "package/perl/Config.in"
-if BR2_PACKAGE_PERL
-menu "Perl libraries/modules"
- source "package/perl-crypt-openssl-random/Config.in"
- source "package/perl-crypt-openssl-rsa/Config.in"
- source "package/perl-datetime-tiny/Config.in"
- source "package/perl-db-file/Config.in"
- source "package/perl-digest-hmac/Config.in"
- source "package/perl-digest-sha1/Config.in"
- source "package/perl-encode-detect/Config.in"
- source "package/perl-encode-locale/Config.in"
- source "package/perl-file-listing/Config.in"
- source "package/perl-file-util/Config.in"
- source "package/perl-gd/Config.in"
- source "package/perl-gdgraph/Config.in"
- source "package/perl-gdtextutil/Config.in"
- source "package/perl-html-parser/Config.in"
- source "package/perl-html-tagset/Config.in"
- source "package/perl-http-cookies/Config.in"
- source "package/perl-http-daemon/Config.in"
- source "package/perl-http-date/Config.in"
- source "package/perl-http-message/Config.in"
- source "package/perl-http-negotiate/Config.in"
- source "package/perl-io-html/Config.in"
- source "package/perl-io-socket-ssl/Config.in"
- source "package/perl-json-tiny/Config.in"
- source "package/perl-libwww-perl/Config.in"
- source "package/perl-lwp-mediatypes/Config.in"
- source "package/perl-mail-dkim/Config.in"
- source "package/perl-mailtools/Config.in"
- source "package/perl-mime-base64/Config.in"
- source "package/perl-mojolicious/Config.in"
- source "package/perl-net-dns/Config.in"
- source "package/perl-net-http/Config.in"
- source "package/perl-net-ssleay/Config.in"
- source "package/perl-netaddr-ip/Config.in"
- source "package/perl-path-tiny/Config.in"
- source "package/perl-time-hires/Config.in"
- source "package/perl-timedate/Config.in"
- source "package/perl-try-tiny/Config.in"
- source "package/perl-uri/Config.in"
- source "package/perl-www-robotrules/Config.in"
- source "package/perl-xml-libxml/Config.in"
- source "package/perl-xml-namespacesupport/Config.in"
- source "package/perl-xml-sax/Config.in"
- source "package/perl-xml-sax-base/Config.in"
-endmenu
-endif
source "package/php/Config.in"
if BR2_PACKAGE_PHP
if !BR2_STATIC_LIBS
diff --git a/package/perl/Config.in b/package/perl/Config.in
index cdd5aab..635a6f8 100644
--- a/package/perl/Config.in
+++ b/package/perl/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_PERL
+menuconfig BR2_PACKAGE_PERL
bool "perl"
depends on BR2_USE_MMU # fork()
help
@@ -24,4 +24,50 @@ config BR2_PACKAGE_PERL_MODULES
Leave empty for all modules (as far as the external libraries
are available).
+comment "Perl libraries/modules"
+
+source "package/perl-crypt-openssl-random/Config.in"
+source "package/perl-crypt-openssl-rsa/Config.in"
+source "package/perl-datetime-tiny/Config.in"
+source "package/perl-db-file/Config.in"
+source "package/perl-digest-hmac/Config.in"
+source "package/perl-digest-sha1/Config.in"
+source "package/perl-encode-detect/Config.in"
+source "package/perl-encode-locale/Config.in"
+source "package/perl-file-listing/Config.in"
+source "package/perl-file-util/Config.in"
+source "package/perl-gd/Config.in"
+source "package/perl-gdgraph/Config.in"
+source "package/perl-gdtextutil/Config.in"
+source "package/perl-html-parser/Config.in"
+source "package/perl-html-tagset/Config.in"
+source "package/perl-http-cookies/Config.in"
+source "package/perl-http-daemon/Config.in"
+source "package/perl-http-date/Config.in"
+source "package/perl-http-message/Config.in"
+source "package/perl-http-negotiate/Config.in"
+source "package/perl-io-html/Config.in"
+source "package/perl-io-socket-ssl/Config.in"
+source "package/perl-json-tiny/Config.in"
+source "package/perl-libwww-perl/Config.in"
+source "package/perl-lwp-mediatypes/Config.in"
+source "package/perl-mail-dkim/Config.in"
+source "package/perl-mailtools/Config.in"
+source "package/perl-mime-base64/Config.in"
+source "package/perl-mojolicious/Config.in"
+source "package/perl-net-dns/Config.in"
+source "package/perl-net-http/Config.in"
+source "package/perl-net-ssleay/Config.in"
+source "package/perl-netaddr-ip/Config.in"
+source "package/perl-path-tiny/Config.in"
+source "package/perl-time-hires/Config.in"
+source "package/perl-timedate/Config.in"
+source "package/perl-try-tiny/Config.in"
+source "package/perl-uri/Config.in"
+source "package/perl-www-robotrules/Config.in"
+source "package/perl-xml-libxml/Config.in"
+source "package/perl-xml-namespacesupport/Config.in"
+source "package/perl-xml-sax/Config.in"
+source "package/perl-xml-sax-base/Config.in"
+
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 22/84 RFC] package/perl: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:24 ` [Buildroot] [PATCH 22/84 RFC] package/perl: " Yann E. MORIN
@ 2015-12-30 23:53 ` Arnout Vandecappelle
2016-01-02 0:33 ` Arnout Vandecappelle
1 sibling, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-30 23:53 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:24, Yann E. MORIN wrote:
> Move the perl library/modules inclusion to the perl's Config.in.
NACK, like jquery.
Regards,
Arnout
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/Config.in | 47 -----------------------------------------------
> package/perl/Config.in | 48 +++++++++++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 47 insertions(+), 48 deletions(-)
>
> diff --git a/package/Config.in b/package/Config.in
> index 4d2b763..d65730a 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -541,53 +541,6 @@ endif
> source "package/mono/Config.in"
> source "package/nodejs/Config.in"
> source "package/perl/Config.in"
> -if BR2_PACKAGE_PERL
> -menu "Perl libraries/modules"
> - source "package/perl-crypt-openssl-random/Config.in"
> - source "package/perl-crypt-openssl-rsa/Config.in"
> - source "package/perl-datetime-tiny/Config.in"
> - source "package/perl-db-file/Config.in"
> - source "package/perl-digest-hmac/Config.in"
> - source "package/perl-digest-sha1/Config.in"
> - source "package/perl-encode-detect/Config.in"
> - source "package/perl-encode-locale/Config.in"
> - source "package/perl-file-listing/Config.in"
> - source "package/perl-file-util/Config.in"
> - source "package/perl-gd/Config.in"
> - source "package/perl-gdgraph/Config.in"
> - source "package/perl-gdtextutil/Config.in"
> - source "package/perl-html-parser/Config.in"
> - source "package/perl-html-tagset/Config.in"
> - source "package/perl-http-cookies/Config.in"
> - source "package/perl-http-daemon/Config.in"
> - source "package/perl-http-date/Config.in"
> - source "package/perl-http-message/Config.in"
> - source "package/perl-http-negotiate/Config.in"
> - source "package/perl-io-html/Config.in"
> - source "package/perl-io-socket-ssl/Config.in"
> - source "package/perl-json-tiny/Config.in"
> - source "package/perl-libwww-perl/Config.in"
> - source "package/perl-lwp-mediatypes/Config.in"
> - source "package/perl-mail-dkim/Config.in"
> - source "package/perl-mailtools/Config.in"
> - source "package/perl-mime-base64/Config.in"
> - source "package/perl-mojolicious/Config.in"
> - source "package/perl-net-dns/Config.in"
> - source "package/perl-net-http/Config.in"
> - source "package/perl-net-ssleay/Config.in"
> - source "package/perl-netaddr-ip/Config.in"
> - source "package/perl-path-tiny/Config.in"
> - source "package/perl-time-hires/Config.in"
> - source "package/perl-timedate/Config.in"
> - source "package/perl-try-tiny/Config.in"
> - source "package/perl-uri/Config.in"
> - source "package/perl-www-robotrules/Config.in"
> - source "package/perl-xml-libxml/Config.in"
> - source "package/perl-xml-namespacesupport/Config.in"
> - source "package/perl-xml-sax/Config.in"
> - source "package/perl-xml-sax-base/Config.in"
> -endmenu
> -endif
> source "package/php/Config.in"
> if BR2_PACKAGE_PHP
> if !BR2_STATIC_LIBS
> diff --git a/package/perl/Config.in b/package/perl/Config.in
> index cdd5aab..635a6f8 100644
> --- a/package/perl/Config.in
> +++ b/package/perl/Config.in
> @@ -1,4 +1,4 @@
> -config BR2_PACKAGE_PERL
> +menuconfig BR2_PACKAGE_PERL
> bool "perl"
> depends on BR2_USE_MMU # fork()
> help
> @@ -24,4 +24,50 @@ config BR2_PACKAGE_PERL_MODULES
> Leave empty for all modules (as far as the external libraries
> are available).
>
> +comment "Perl libraries/modules"
> +
> +source "package/perl-crypt-openssl-random/Config.in"
> +source "package/perl-crypt-openssl-rsa/Config.in"
> +source "package/perl-datetime-tiny/Config.in"
> +source "package/perl-db-file/Config.in"
> +source "package/perl-digest-hmac/Config.in"
> +source "package/perl-digest-sha1/Config.in"
> +source "package/perl-encode-detect/Config.in"
> +source "package/perl-encode-locale/Config.in"
> +source "package/perl-file-listing/Config.in"
> +source "package/perl-file-util/Config.in"
> +source "package/perl-gd/Config.in"
> +source "package/perl-gdgraph/Config.in"
> +source "package/perl-gdtextutil/Config.in"
> +source "package/perl-html-parser/Config.in"
> +source "package/perl-html-tagset/Config.in"
> +source "package/perl-http-cookies/Config.in"
> +source "package/perl-http-daemon/Config.in"
> +source "package/perl-http-date/Config.in"
> +source "package/perl-http-message/Config.in"
> +source "package/perl-http-negotiate/Config.in"
> +source "package/perl-io-html/Config.in"
> +source "package/perl-io-socket-ssl/Config.in"
> +source "package/perl-json-tiny/Config.in"
> +source "package/perl-libwww-perl/Config.in"
> +source "package/perl-lwp-mediatypes/Config.in"
> +source "package/perl-mail-dkim/Config.in"
> +source "package/perl-mailtools/Config.in"
> +source "package/perl-mime-base64/Config.in"
> +source "package/perl-mojolicious/Config.in"
> +source "package/perl-net-dns/Config.in"
> +source "package/perl-net-http/Config.in"
> +source "package/perl-net-ssleay/Config.in"
> +source "package/perl-netaddr-ip/Config.in"
> +source "package/perl-path-tiny/Config.in"
> +source "package/perl-time-hires/Config.in"
> +source "package/perl-timedate/Config.in"
> +source "package/perl-try-tiny/Config.in"
> +source "package/perl-uri/Config.in"
> +source "package/perl-www-robotrules/Config.in"
> +source "package/perl-xml-libxml/Config.in"
> +source "package/perl-xml-namespacesupport/Config.in"
> +source "package/perl-xml-sax/Config.in"
> +source "package/perl-xml-sax-base/Config.in"
> +
> endif
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 22/84 RFC] package/perl: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:24 ` [Buildroot] [PATCH 22/84 RFC] package/perl: " Yann E. MORIN
2015-12-30 23:53 ` Arnout Vandecappelle
@ 2016-01-02 0:33 ` Arnout Vandecappelle
2016-01-02 10:10 ` Yann E. MORIN
1 sibling, 1 reply; 134+ messages in thread
From: Arnout Vandecappelle @ 2016-01-02 0:33 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:24, Yann E. MORIN wrote:
> Move the perl library/modules inclusion to the perl's Config.in.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/Config.in | 47 -----------------------------------------------
> package/perl/Config.in | 48 +++++++++++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 47 insertions(+), 48 deletions(-)
>
[snip]
> diff --git a/package/perl/Config.in b/package/perl/Config.in
> index cdd5aab..635a6f8 100644
> --- a/package/perl/Config.in
> +++ b/package/perl/Config.in
> @@ -1,4 +1,4 @@
> -config BR2_PACKAGE_PERL
> +menuconfig BR2_PACKAGE_PERL
> bool "perl"
> depends on BR2_USE_MMU # fork()
> help
> @@ -24,4 +24,50 @@ config BR2_PACKAGE_PERL_MODULES
> Leave empty for all modules (as far as the external libraries
> are available).
>
> +comment "Perl libraries/modules"
This comment looks pretty weird in xconfig, but OK in menuconfig and something
definitely needs to be put in there, so OK.
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 22/84 RFC] package/perl: use 'menuconfig' instead of 'config'+'menu'
2016-01-02 0:33 ` Arnout Vandecappelle
@ 2016-01-02 10:10 ` Yann E. MORIN
0 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2016-01-02 10:10 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2016-01-02 01:33 +0100, Arnout Vandecappelle spake thusly:
> On 25-12-15 22:24, Yann E. MORIN wrote:
> > Move the perl library/modules inclusion to the perl's Config.in.
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> > package/Config.in | 47 -----------------------------------------------
> > package/perl/Config.in | 48 +++++++++++++++++++++++++++++++++++++++++++++++-
> > 2 files changed, 47 insertions(+), 48 deletions(-)
> >
> [snip]
> > diff --git a/package/perl/Config.in b/package/perl/Config.in
> > index cdd5aab..635a6f8 100644
> > --- a/package/perl/Config.in
> > +++ b/package/perl/Config.in
> > @@ -1,4 +1,4 @@
> > -config BR2_PACKAGE_PERL
> > +menuconfig BR2_PACKAGE_PERL
> > bool "perl"
> > depends on BR2_USE_MMU # fork()
> > help
> > @@ -24,4 +24,50 @@ config BR2_PACKAGE_PERL_MODULES
> > Leave empty for all modules (as far as the external libraries
> > are available).
> >
> > +comment "Perl libraries/modules"
>
> This comment looks pretty weird in xconfig, but OK in menuconfig and something
> definitely needs to be put in there, so OK.
Hmm.. I never use xconfig, because I think xconfig already looks weird to
me. ;-) But indeed it looks weird. But the "custom modules selection"
looks weird as well (well, I guess all 'string' and 'int' look weird in
xconfig, and gconfig is only so slightly better).
What I'm a bit worried for xconfig and gconfig, is that, if we remove
the "Perl libraries/modules" comment, the "custom modules selection"
just above would seem to indicate that the custom modules are listed
below, which it is not since it is a string option, not a comment.
But Eh... Graybeard speaking... ;-)
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Thanks! I appreciate you re-reviewed the series! :-)
Regards,
Yann E. MORIN.
>
> Regards,
> Arnout
>
>
> [snip]
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 23/84 RFC] package/php: move list of extensions after interface selection
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (21 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 22/84 RFC] package/perl: " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 24/84 RFC] package/php: use 'menuconfig' instad of 'config'+'menu' Yann E. MORIN
` (62 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/php/Config.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/php/Config.in b/package/php/Config.in
index 32faa32..eee8d26 100644
--- a/package/php/Config.in
+++ b/package/php/Config.in
@@ -9,8 +9,6 @@ config BR2_PACKAGE_PHP
if BR2_PACKAGE_PHP
-source "package/php/Config.ext"
-
config BR2_PACKAGE_PHP_CLI
bool
@@ -66,4 +64,6 @@ config BR2_PACKAGE_PHP_SAPI_CLI_FPM
endchoice
+source "package/php/Config.ext"
+
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 24/84 RFC] package/php: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (22 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 23/84 RFC] package/php: move list of extensions after interface selection Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-30 23:57 ` Arnout Vandecappelle
2016-01-02 0:48 ` Arnout Vandecappelle
2015-12-25 21:24 ` [Buildroot] [PATCH 25/84 RFC] package/python: " Yann E. MORIN
` (61 subsequent siblings)
85 siblings, 2 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Move the external extensions selection into the bundled extensions'
Config.in.
Make the menu prompt a comment, reword it so that it is more in line
with the following comments.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/Config.in | 16 ----------------
package/php/Config.ext | 20 ++++++++++++++++++--
package/php/Config.in | 2 +-
3 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/package/Config.in b/package/Config.in
index d65730a..9b719e8 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -542,22 +542,6 @@ endif
source "package/nodejs/Config.in"
source "package/perl/Config.in"
source "package/php/Config.in"
-if BR2_PACKAGE_PHP
-if !BR2_STATIC_LIBS
-menu "External php extensions"
- source "package/php-geoip/Config.in"
- source "package/php-gnupg/Config.in"
- source "package/php-imagick/Config.in"
- source "package/php-memcached/Config.in"
- source "package/php-ssh2/Config.in"
- source "package/php-yaml/Config.in"
- source "package/php-zmq/Config.in"
-endmenu
-endif
-if BR2_STATIC_LIBS
-comment "External PHP extensions need a toolchain w/ dynamic library"
-endif
-endif
source "package/python/Config.in"
source "package/python3/Config.in"
if BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
diff --git a/package/php/Config.ext b/package/php/Config.ext
index 5324e79..92f4d6a 100644
--- a/package/php/Config.ext
+++ b/package/php/Config.ext
@@ -1,4 +1,4 @@
-menu "Extensions"
+comment "Generic extensions"
config BR2_PACKAGE_PHP_EXT_CALENDAR
bool "Calendar"
@@ -400,4 +400,20 @@ config BR2_PACKAGE_PHP_EXT_XSL
help
XSL transformation support
-endmenu
+if !BR2_STATIC_LIBS
+
+comment "External extensions"
+
+source "package/php-geoip/Config.in"
+source "package/php-gnupg/Config.in"
+source "package/php-imagick/Config.in"
+source "package/php-memcached/Config.in"
+source "package/php-ssh2/Config.in"
+source "package/php-yaml/Config.in"
+source "package/php-zmq/Config.in"
+
+endif # !STATIC_LIBS
+
+if BR2_STATIC_LIBs
+comment "External PHP extensions need a toolchain w/ dynamic library"
+endif
diff --git a/package/php/Config.in b/package/php/Config.in
index eee8d26..7e79179 100644
--- a/package/php/Config.in
+++ b/package/php/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_PHP
+menuconfig BR2_PACKAGE_PHP
bool "php"
help
PHP is a widely-used general-purpose scripting
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 24/84 RFC] package/php: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:24 ` [Buildroot] [PATCH 24/84 RFC] package/php: use 'menuconfig' instad of 'config'+'menu' Yann E. MORIN
@ 2015-12-30 23:57 ` Arnout Vandecappelle
2016-01-02 0:48 ` Arnout Vandecappelle
1 sibling, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-30 23:57 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:24, Yann E. MORIN wrote:
> Move the external extensions selection into the bundled extensions'
> Config.in.
>
> Make the menu prompt a comment, reword it so that it is more in line
> with the following comments.
Yet another NACK, and here you can see another reason why it's not good IMHO:
the internal extension have prompts like "XSL", while the external extensions
are called "php-yaml", which looks inconsistent.
Regards,
Arnout
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/Config.in | 16 ----------------
> package/php/Config.ext | 20 ++++++++++++++++++--
> package/php/Config.in | 2 +-
> 3 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/package/Config.in b/package/Config.in
> index d65730a..9b719e8 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -542,22 +542,6 @@ endif
> source "package/nodejs/Config.in"
> source "package/perl/Config.in"
> source "package/php/Config.in"
> -if BR2_PACKAGE_PHP
> -if !BR2_STATIC_LIBS
> -menu "External php extensions"
> - source "package/php-geoip/Config.in"
> - source "package/php-gnupg/Config.in"
> - source "package/php-imagick/Config.in"
> - source "package/php-memcached/Config.in"
> - source "package/php-ssh2/Config.in"
> - source "package/php-yaml/Config.in"
> - source "package/php-zmq/Config.in"
> -endmenu
> -endif
> -if BR2_STATIC_LIBS
> -comment "External PHP extensions need a toolchain w/ dynamic library"
> -endif
> -endif
> source "package/python/Config.in"
> source "package/python3/Config.in"
> if BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
> diff --git a/package/php/Config.ext b/package/php/Config.ext
> index 5324e79..92f4d6a 100644
> --- a/package/php/Config.ext
> +++ b/package/php/Config.ext
> @@ -1,4 +1,4 @@
> -menu "Extensions"
> +comment "Generic extensions"
>
> config BR2_PACKAGE_PHP_EXT_CALENDAR
> bool "Calendar"
> @@ -400,4 +400,20 @@ config BR2_PACKAGE_PHP_EXT_XSL
> help
> XSL transformation support
>
> -endmenu
> +if !BR2_STATIC_LIBS
> +
> +comment "External extensions"
> +
> +source "package/php-geoip/Config.in"
> +source "package/php-gnupg/Config.in"
> +source "package/php-imagick/Config.in"
> +source "package/php-memcached/Config.in"
> +source "package/php-ssh2/Config.in"
> +source "package/php-yaml/Config.in"
> +source "package/php-zmq/Config.in"
> +
> +endif # !STATIC_LIBS
> +
> +if BR2_STATIC_LIBs
> +comment "External PHP extensions need a toolchain w/ dynamic library"
> +endif
> diff --git a/package/php/Config.in b/package/php/Config.in
> index eee8d26..7e79179 100644
> --- a/package/php/Config.in
> +++ b/package/php/Config.in
> @@ -1,4 +1,4 @@
> -config BR2_PACKAGE_PHP
> +menuconfig BR2_PACKAGE_PHP
> bool "php"
> help
> PHP is a widely-used general-purpose scripting
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 24/84 RFC] package/php: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:24 ` [Buildroot] [PATCH 24/84 RFC] package/php: use 'menuconfig' instad of 'config'+'menu' Yann E. MORIN
2015-12-30 23:57 ` Arnout Vandecappelle
@ 2016-01-02 0:48 ` Arnout Vandecappelle
2016-01-02 10:28 ` Yann E. MORIN
1 sibling, 1 reply; 134+ messages in thread
From: Arnout Vandecappelle @ 2016-01-02 0:48 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:24, Yann E. MORIN wrote:
> Move the external extensions selection into the bundled extensions'
> Config.in.
>
> Make the menu prompt a comment, reword it so that it is more in line
> with the following comments.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
I still think it looks really weird that you have XSL and then php-geoip.
Perhaps we should consider letting go of the rule that the prompt should be the
exact package name, and instead make it plain geoip. But that's more churn...
Regards,
Arnout
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 24/84 RFC] package/php: use 'menuconfig' instad of 'config'+'menu'
2016-01-02 0:48 ` Arnout Vandecappelle
@ 2016-01-02 10:28 ` Yann E. MORIN
0 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2016-01-02 10:28 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2016-01-02 01:48 +0100, Arnout Vandecappelle spake thusly:
> On 25-12-15 22:24, Yann E. MORIN wrote:
> > Move the external extensions selection into the bundled extensions'
> > Config.in.
> >
> > Make the menu prompt a comment, reword it so that it is more in line
> > with the following comments.
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> I still think it looks really weird that you have XSL and then php-geoip.
Well, it looks a bit different, indeed. But I think it is a good thing,
since they are external extensions and thus stand out in the list.
> Perhaps we should consider letting go of the rule that the prompt should be the
> exact package name, and instead make it plain geoip. But that's more churn...
By 'the exact package name', did you mean 'the way we named it in
Buildroot' or 'the way upstream named it' ? Speaking about 'package'
can quickly get really confusing! ;-)
However, I think we should really use the way upstream names it,
whatever we call it in Buildroot.
But s you said, it's more churn, and we can work on it later. If needed.
Thanks!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 25/84 RFC] package/python: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (23 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 24/84 RFC] package/php: use 'menuconfig' instad of 'config'+'menu' Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 26/84 RFC] package/python3: " Yann E. MORIN
` (60 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/python/Config.in | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/package/python/Config.in b/package/python/Config.in
index fa83e77..40a2ef4 100644
--- a/package/python/Config.in
+++ b/package/python/Config.in
@@ -2,7 +2,7 @@ comment "python needs a toolchain w/ wchar, threads, dynamic library"
depends on BR2_USE_MMU
depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
-config BR2_PACKAGE_PYTHON
+menuconfig BR2_PACKAGE_PYTHON
bool "python"
depends on BR2_USE_WCHAR
# uses fork()
@@ -34,7 +34,7 @@ config BR2_PACKAGE_PYTHON_PY_PYC
endchoice
-menu "core python modules"
+comment "core python modules"
comment "The following modules are unusual or require extra libraries"
@@ -127,6 +127,4 @@ config BR2_PACKAGE_PYTHON_HASHLIB
help
hashlib support in Python
-endmenu
-
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 26/84 RFC] package/python3: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (24 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 25/84 RFC] package/python: " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 27/84 RFC] package/python{, 3}: move inclusion of external python modules Yann E. MORIN
` (59 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/python3/Config.in | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/package/python3/Config.in b/package/python3/Config.in
index 0f4fc88..aadc8b6 100644
--- a/package/python3/Config.in
+++ b/package/python3/Config.in
@@ -2,7 +2,7 @@ comment "python3 needs a toolchain w/ wchar, threads, dynamic library"
depends on BR2_USE_MMU
depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
-config BR2_PACKAGE_PYTHON3
+menuconfig BR2_PACKAGE_PYTHON3
bool "python3"
depends on !BR2_PACKAGE_PYTHON
depends on BR2_USE_WCHAR
@@ -35,7 +35,7 @@ config BR2_PACKAGE_PYTHON3_PY_PYC
endchoice
-menu "core python3 modules"
+comment "core python3 modules"
comment "The following modules are unusual or require extra libraries"
@@ -104,6 +104,4 @@ config BR2_PACKAGE_PYTHON3_ZLIB
help
zlib support in Python3
-endmenu
-
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 27/84 RFC] package/python{, 3}: move inclusion of external python modules
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (25 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 26/84 RFC] package/python3: " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-30 23:59 ` Arnout Vandecappelle
2016-01-02 0:54 ` Arnout Vandecappelle
2015-12-25 21:24 ` [Buildroot] [PATCH 28/84 RFC] package/sdl_image: use 'menuconfig' instead of 'config'+'menu' Yann E. MORIN
` (58 subsequent siblings)
85 siblings, 2 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Introduce a Config.ext for external python modules, that both python and
python include from there respective sub-menus.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/Config.in | 96 ----------------------------------------------
package/python/Config.ext | 96 ++++++++++++++++++++++++++++++++++++++++++++++
package/python/Config.in | 2 +
package/python3/Config.ext | 1 +
package/python3/Config.in | 2 +
5 files changed, 101 insertions(+), 96 deletions(-)
create mode 100644 package/python/Config.ext
create mode 120000 package/python3/Config.ext
diff --git a/package/Config.in b/package/Config.in
index 9b719e8..94ea060 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -544,102 +544,6 @@ endif
source "package/php/Config.in"
source "package/python/Config.in"
source "package/python3/Config.in"
-if BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
-menu "External python modules"
- source "package/python-alsaaudio/Config.in"
- source "package/python-backports-abc/Config.in"
- source "package/python-bottle/Config.in"
- source "package/python-can/Config.in"
- source "package/python-certifi/Config.in"
- source "package/python-cffi/Config.in"
- source "package/python-cheetah/Config.in"
- source "package/python-cherrypy/Config.in"
- source "package/python-coherence/Config.in"
- source "package/python-configobj/Config.in"
- source "package/python-configshell-fb/Config.in"
- source "package/python-crc16/Config.in"
- source "package/python-daemon/Config.in"
- source "package/python-dialog/Config.in"
- source "package/python-django/Config.in"
- source "package/python-docopt/Config.in"
- source "package/python-dpkt/Config.in"
- source "package/python-enum/Config.in"
- source "package/python-enum34/Config.in"
- source "package/python-flask/Config.in"
- source "package/python-flup/Config.in"
- source "package/python-gobject/Config.in"
- source "package/python-httplib2/Config.in"
- source "package/python-id3/Config.in"
- source "package/python-idna/Config.in"
- source "package/python-ipaddr/Config.in"
- source "package/python-ipaddress/Config.in"
- source "package/python-ipy/Config.in"
- source "package/python-ipython/Config.in"
- source "package/python-itsdangerous/Config.in"
- source "package/python-jinja2/Config.in"
- source "package/python-json-schema-validator/Config.in"
- source "package/python-keyring/Config.in"
- source "package/python-libconfig/Config.in"
- source "package/python-lxml/Config.in"
- source "package/python-mad/Config.in"
- source "package/python-mako/Config.in"
- source "package/python-markdown/Config.in"
- source "package/python-markupsafe/Config.in"
- source "package/python-meld3/Config.in"
- source "package/python-msgpack/Config.in"
- source "package/python-netifaces/Config.in"
- source "package/python-networkmanager/Config.in"
- source "package/python-nfc/Config.in"
- source "package/python-numpy/Config.in"
- source "package/python-pam/Config.in"
- source "package/python-posix-ipc/Config.in"
- source "package/python-protobuf/Config.in"
- source "package/python-psutil/Config.in"
- source "package/python-pyasn/Config.in"
- source "package/python-pycli/Config.in"
- source "package/python-pycrypto/Config.in"
- source "package/python-pydal/Config.in"
- source "package/python-pyftpdlib/Config.in"
- source "package/python-pygame/Config.in"
- source "package/python-pyinotify/Config.in"
- source "package/python-pyparsing/Config.in"
- source "package/python-pypcap/Config.in"
- source "package/python-pyqt/Config.in"
- source "package/python-pyratemp/Config.in"
- source "package/python-pyro/Config.in"
- source "package/python-pyroute2/Config.in"
- source "package/python-pysendfile/Config.in"
- source "package/python-pysmb/Config.in"
- source "package/python-pysnmp/Config.in"
- source "package/python-pysnmp-apps/Config.in"
- source "package/python-pysnmp-mibs/Config.in"
- source "package/python-pyudev/Config.in"
- source "package/python-pyusb/Config.in"
- source "package/python-pyxb/Config.in"
- source "package/python-pyxml/Config.in"
- source "package/python-pyyaml/Config.in"
- source "package/python-pyzmq/Config.in"
- source "package/python-requests/Config.in"
- source "package/python-rtslib-fb/Config.in"
- source "package/python-serial/Config.in"
- source "package/python-setuptools/Config.in"
- source "package/python-simplejson/Config.in"
- source "package/python-singledispatch/Config.in"
- source "package/python-sip/Config.in"
- source "package/python-six/Config.in"
- source "package/python-spidev/Config.in"
- source "package/python-thrift/Config.in"
- source "package/python-tornado/Config.in"
- source "package/python-twisted/Config.in"
- source "package/python-urwid/Config.in"
- source "package/python-versiontools/Config.in"
- source "package/python-web2py/Config.in"
- source "package/python-webpy/Config.in"
- source "package/python-werkzeug/Config.in"
- source "package/python-ws4py/Config.in"
- source "package/python-zope-interface/Config.in"
-endmenu
-endif
source "package/ruby/Config.in"
source "package/tcl/Config.in"
if BR2_PACKAGE_TCL
diff --git a/package/python/Config.ext b/package/python/Config.ext
new file mode 100644
index 0000000..7232222
--- /dev/null
+++ b/package/python/Config.ext
@@ -0,0 +1,96 @@
+# This file is included both from python and python3
+
+comment "External python modules"
+
+source "package/python-alsaaudio/Config.in"
+source "package/python-backports-abc/Config.in"
+source "package/python-bottle/Config.in"
+source "package/python-can/Config.in"
+source "package/python-certifi/Config.in"
+source "package/python-cffi/Config.in"
+source "package/python-cheetah/Config.in"
+source "package/python-cherrypy/Config.in"
+source "package/python-coherence/Config.in"
+source "package/python-configobj/Config.in"
+source "package/python-configshell-fb/Config.in"
+source "package/python-crc16/Config.in"
+source "package/python-daemon/Config.in"
+source "package/python-dialog/Config.in"
+source "package/python-django/Config.in"
+source "package/python-docopt/Config.in"
+source "package/python-dpkt/Config.in"
+source "package/python-enum/Config.in"
+source "package/python-enum34/Config.in"
+source "package/python-flask/Config.in"
+source "package/python-flup/Config.in"
+source "package/python-gobject/Config.in"
+source "package/python-httplib2/Config.in"
+source "package/python-id3/Config.in"
+source "package/python-idna/Config.in"
+source "package/python-ipaddr/Config.in"
+source "package/python-ipaddress/Config.in"
+source "package/python-ipy/Config.in"
+source "package/python-ipython/Config.in"
+source "package/python-itsdangerous/Config.in"
+source "package/python-jinja2/Config.in"
+source "package/python-json-schema-validator/Config.in"
+source "package/python-keyring/Config.in"
+source "package/python-libconfig/Config.in"
+source "package/python-lxml/Config.in"
+source "package/python-mad/Config.in"
+source "package/python-mako/Config.in"
+source "package/python-markdown/Config.in"
+source "package/python-markupsafe/Config.in"
+source "package/python-meld3/Config.in"
+source "package/python-msgpack/Config.in"
+source "package/python-netifaces/Config.in"
+source "package/python-networkmanager/Config.in"
+source "package/python-nfc/Config.in"
+source "package/python-numpy/Config.in"
+source "package/python-pam/Config.in"
+source "package/python-posix-ipc/Config.in"
+source "package/python-protobuf/Config.in"
+source "package/python-psutil/Config.in"
+source "package/python-pyasn/Config.in"
+source "package/python-pycli/Config.in"
+source "package/python-pycrypto/Config.in"
+source "package/python-pydal/Config.in"
+source "package/python-pyftpdlib/Config.in"
+source "package/python-pygame/Config.in"
+source "package/python-pyinotify/Config.in"
+source "package/python-pyparsing/Config.in"
+source "package/python-pypcap/Config.in"
+source "package/python-pyqt/Config.in"
+source "package/python-pyratemp/Config.in"
+source "package/python-pyro/Config.in"
+source "package/python-pyroute2/Config.in"
+source "package/python-pysendfile/Config.in"
+source "package/python-pysmb/Config.in"
+source "package/python-pysnmp/Config.in"
+source "package/python-pysnmp-apps/Config.in"
+source "package/python-pysnmp-mibs/Config.in"
+source "package/python-pyudev/Config.in"
+source "package/python-pyusb/Config.in"
+source "package/python-pyxb/Config.in"
+source "package/python-pyxml/Config.in"
+source "package/python-pyyaml/Config.in"
+source "package/python-pyzmq/Config.in"
+source "package/python-requests/Config.in"
+source "package/python-rtslib-fb/Config.in"
+source "package/python-serial/Config.in"
+source "package/python-setuptools/Config.in"
+source "package/python-simplejson/Config.in"
+source "package/python-singledispatch/Config.in"
+source "package/python-sip/Config.in"
+source "package/python-six/Config.in"
+source "package/python-spidev/Config.in"
+source "package/python-thrift/Config.in"
+source "package/python-tornado/Config.in"
+source "package/python-twisted/Config.in"
+source "package/python-urwid/Config.in"
+source "package/python-versiontools/Config.in"
+source "package/python-web2py/Config.in"
+source "package/python-webpy/Config.in"
+source "package/python-werkzeug/Config.in"
+source "package/python-ws4py/Config.in"
+source "package/python-zope-interface/Config.in"
diff --git a/package/python/Config.in b/package/python/Config.in
index 40a2ef4..6563cd6 100644
--- a/package/python/Config.in
+++ b/package/python/Config.in
@@ -127,4 +127,6 @@ config BR2_PACKAGE_PYTHON_HASHLIB
help
hashlib support in Python
+source "package/python/Config.ext"
+
endif
diff --git a/package/python3/Config.ext b/package/python3/Config.ext
new file mode 120000
index 0000000..1b3df59
--- /dev/null
+++ b/package/python3/Config.ext
@@ -0,0 +1 @@
+../python/Config.ext
\ No newline at end of file
diff --git a/package/python3/Config.in b/package/python3/Config.in
index aadc8b6..f221a54 100644
--- a/package/python3/Config.in
+++ b/package/python3/Config.in
@@ -104,4 +104,6 @@ config BR2_PACKAGE_PYTHON3_ZLIB
help
zlib support in Python3
+source "package/python3/Config.ext"
+
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 27/84 RFC] package/python{, 3}: move inclusion of external python modules
2015-12-25 21:24 ` [Buildroot] [PATCH 27/84 RFC] package/python{, 3}: move inclusion of external python modules Yann E. MORIN
@ 2015-12-30 23:59 ` Arnout Vandecappelle
2016-01-02 0:54 ` Arnout Vandecappelle
1 sibling, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-30 23:59 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:24, Yann E. MORIN wrote:
> Introduce a Config.ext for external python modules, that both python and
> python include from there respective sub-menus.
As mentioned before, NACK no this one.
Regards,
Arnout
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/Config.in | 96 ----------------------------------------------
> package/python/Config.ext | 96 ++++++++++++++++++++++++++++++++++++++++++++++
> package/python/Config.in | 2 +
> package/python3/Config.ext | 1 +
> package/python3/Config.in | 2 +
> 5 files changed, 101 insertions(+), 96 deletions(-)
> create mode 100644 package/python/Config.ext
> create mode 120000 package/python3/Config.ext
>
> diff --git a/package/Config.in b/package/Config.in
> index 9b719e8..94ea060 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -544,102 +544,6 @@ endif
> source "package/php/Config.in"
> source "package/python/Config.in"
> source "package/python3/Config.in"
> -if BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
> -menu "External python modules"
> - source "package/python-alsaaudio/Config.in"
> - source "package/python-backports-abc/Config.in"
> - source "package/python-bottle/Config.in"
> - source "package/python-can/Config.in"
> - source "package/python-certifi/Config.in"
> - source "package/python-cffi/Config.in"
> - source "package/python-cheetah/Config.in"
> - source "package/python-cherrypy/Config.in"
> - source "package/python-coherence/Config.in"
> - source "package/python-configobj/Config.in"
> - source "package/python-configshell-fb/Config.in"
> - source "package/python-crc16/Config.in"
> - source "package/python-daemon/Config.in"
> - source "package/python-dialog/Config.in"
> - source "package/python-django/Config.in"
> - source "package/python-docopt/Config.in"
> - source "package/python-dpkt/Config.in"
> - source "package/python-enum/Config.in"
> - source "package/python-enum34/Config.in"
> - source "package/python-flask/Config.in"
> - source "package/python-flup/Config.in"
> - source "package/python-gobject/Config.in"
> - source "package/python-httplib2/Config.in"
> - source "package/python-id3/Config.in"
> - source "package/python-idna/Config.in"
> - source "package/python-ipaddr/Config.in"
> - source "package/python-ipaddress/Config.in"
> - source "package/python-ipy/Config.in"
> - source "package/python-ipython/Config.in"
> - source "package/python-itsdangerous/Config.in"
> - source "package/python-jinja2/Config.in"
> - source "package/python-json-schema-validator/Config.in"
> - source "package/python-keyring/Config.in"
> - source "package/python-libconfig/Config.in"
> - source "package/python-lxml/Config.in"
> - source "package/python-mad/Config.in"
> - source "package/python-mako/Config.in"
> - source "package/python-markdown/Config.in"
> - source "package/python-markupsafe/Config.in"
> - source "package/python-meld3/Config.in"
> - source "package/python-msgpack/Config.in"
> - source "package/python-netifaces/Config.in"
> - source "package/python-networkmanager/Config.in"
> - source "package/python-nfc/Config.in"
> - source "package/python-numpy/Config.in"
> - source "package/python-pam/Config.in"
> - source "package/python-posix-ipc/Config.in"
> - source "package/python-protobuf/Config.in"
> - source "package/python-psutil/Config.in"
> - source "package/python-pyasn/Config.in"
> - source "package/python-pycli/Config.in"
> - source "package/python-pycrypto/Config.in"
> - source "package/python-pydal/Config.in"
> - source "package/python-pyftpdlib/Config.in"
> - source "package/python-pygame/Config.in"
> - source "package/python-pyinotify/Config.in"
> - source "package/python-pyparsing/Config.in"
> - source "package/python-pypcap/Config.in"
> - source "package/python-pyqt/Config.in"
> - source "package/python-pyratemp/Config.in"
> - source "package/python-pyro/Config.in"
> - source "package/python-pyroute2/Config.in"
> - source "package/python-pysendfile/Config.in"
> - source "package/python-pysmb/Config.in"
> - source "package/python-pysnmp/Config.in"
> - source "package/python-pysnmp-apps/Config.in"
> - source "package/python-pysnmp-mibs/Config.in"
> - source "package/python-pyudev/Config.in"
> - source "package/python-pyusb/Config.in"
> - source "package/python-pyxb/Config.in"
> - source "package/python-pyxml/Config.in"
> - source "package/python-pyyaml/Config.in"
> - source "package/python-pyzmq/Config.in"
> - source "package/python-requests/Config.in"
> - source "package/python-rtslib-fb/Config.in"
> - source "package/python-serial/Config.in"
> - source "package/python-setuptools/Config.in"
> - source "package/python-simplejson/Config.in"
> - source "package/python-singledispatch/Config.in"
> - source "package/python-sip/Config.in"
> - source "package/python-six/Config.in"
> - source "package/python-spidev/Config.in"
> - source "package/python-thrift/Config.in"
> - source "package/python-tornado/Config.in"
> - source "package/python-twisted/Config.in"
> - source "package/python-urwid/Config.in"
> - source "package/python-versiontools/Config.in"
> - source "package/python-web2py/Config.in"
> - source "package/python-webpy/Config.in"
> - source "package/python-werkzeug/Config.in"
> - source "package/python-ws4py/Config.in"
> - source "package/python-zope-interface/Config.in"
> -endmenu
> -endif
> source "package/ruby/Config.in"
> source "package/tcl/Config.in"
> if BR2_PACKAGE_TCL
> diff --git a/package/python/Config.ext b/package/python/Config.ext
> new file mode 100644
> index 0000000..7232222
> --- /dev/null
> +++ b/package/python/Config.ext
> @@ -0,0 +1,96 @@
> +# This file is included both from python and python3
> +
> +comment "External python modules"
> +
> +source "package/python-alsaaudio/Config.in"
> +source "package/python-backports-abc/Config.in"
> +source "package/python-bottle/Config.in"
> +source "package/python-can/Config.in"
> +source "package/python-certifi/Config.in"
> +source "package/python-cffi/Config.in"
> +source "package/python-cheetah/Config.in"
> +source "package/python-cherrypy/Config.in"
> +source "package/python-coherence/Config.in"
> +source "package/python-configobj/Config.in"
> +source "package/python-configshell-fb/Config.in"
> +source "package/python-crc16/Config.in"
> +source "package/python-daemon/Config.in"
> +source "package/python-dialog/Config.in"
> +source "package/python-django/Config.in"
> +source "package/python-docopt/Config.in"
> +source "package/python-dpkt/Config.in"
> +source "package/python-enum/Config.in"
> +source "package/python-enum34/Config.in"
> +source "package/python-flask/Config.in"
> +source "package/python-flup/Config.in"
> +source "package/python-gobject/Config.in"
> +source "package/python-httplib2/Config.in"
> +source "package/python-id3/Config.in"
> +source "package/python-idna/Config.in"
> +source "package/python-ipaddr/Config.in"
> +source "package/python-ipaddress/Config.in"
> +source "package/python-ipy/Config.in"
> +source "package/python-ipython/Config.in"
> +source "package/python-itsdangerous/Config.in"
> +source "package/python-jinja2/Config.in"
> +source "package/python-json-schema-validator/Config.in"
> +source "package/python-keyring/Config.in"
> +source "package/python-libconfig/Config.in"
> +source "package/python-lxml/Config.in"
> +source "package/python-mad/Config.in"
> +source "package/python-mako/Config.in"
> +source "package/python-markdown/Config.in"
> +source "package/python-markupsafe/Config.in"
> +source "package/python-meld3/Config.in"
> +source "package/python-msgpack/Config.in"
> +source "package/python-netifaces/Config.in"
> +source "package/python-networkmanager/Config.in"
> +source "package/python-nfc/Config.in"
> +source "package/python-numpy/Config.in"
> +source "package/python-pam/Config.in"
> +source "package/python-posix-ipc/Config.in"
> +source "package/python-protobuf/Config.in"
> +source "package/python-psutil/Config.in"
> +source "package/python-pyasn/Config.in"
> +source "package/python-pycli/Config.in"
> +source "package/python-pycrypto/Config.in"
> +source "package/python-pydal/Config.in"
> +source "package/python-pyftpdlib/Config.in"
> +source "package/python-pygame/Config.in"
> +source "package/python-pyinotify/Config.in"
> +source "package/python-pyparsing/Config.in"
> +source "package/python-pypcap/Config.in"
> +source "package/python-pyqt/Config.in"
> +source "package/python-pyratemp/Config.in"
> +source "package/python-pyro/Config.in"
> +source "package/python-pyroute2/Config.in"
> +source "package/python-pysendfile/Config.in"
> +source "package/python-pysmb/Config.in"
> +source "package/python-pysnmp/Config.in"
> +source "package/python-pysnmp-apps/Config.in"
> +source "package/python-pysnmp-mibs/Config.in"
> +source "package/python-pyudev/Config.in"
> +source "package/python-pyusb/Config.in"
> +source "package/python-pyxb/Config.in"
> +source "package/python-pyxml/Config.in"
> +source "package/python-pyyaml/Config.in"
> +source "package/python-pyzmq/Config.in"
> +source "package/python-requests/Config.in"
> +source "package/python-rtslib-fb/Config.in"
> +source "package/python-serial/Config.in"
> +source "package/python-setuptools/Config.in"
> +source "package/python-simplejson/Config.in"
> +source "package/python-singledispatch/Config.in"
> +source "package/python-sip/Config.in"
> +source "package/python-six/Config.in"
> +source "package/python-spidev/Config.in"
> +source "package/python-thrift/Config.in"
> +source "package/python-tornado/Config.in"
> +source "package/python-twisted/Config.in"
> +source "package/python-urwid/Config.in"
> +source "package/python-versiontools/Config.in"
> +source "package/python-web2py/Config.in"
> +source "package/python-webpy/Config.in"
> +source "package/python-werkzeug/Config.in"
> +source "package/python-ws4py/Config.in"
> +source "package/python-zope-interface/Config.in"
> diff --git a/package/python/Config.in b/package/python/Config.in
> index 40a2ef4..6563cd6 100644
> --- a/package/python/Config.in
> +++ b/package/python/Config.in
> @@ -127,4 +127,6 @@ config BR2_PACKAGE_PYTHON_HASHLIB
> help
> hashlib support in Python
>
> +source "package/python/Config.ext"
> +
> endif
> diff --git a/package/python3/Config.ext b/package/python3/Config.ext
> new file mode 120000
> index 0000000..1b3df59
> --- /dev/null
> +++ b/package/python3/Config.ext
> @@ -0,0 +1 @@
> +../python/Config.ext
> \ No newline at end of file
> diff --git a/package/python3/Config.in b/package/python3/Config.in
> index aadc8b6..f221a54 100644
> --- a/package/python3/Config.in
> +++ b/package/python3/Config.in
> @@ -104,4 +104,6 @@ config BR2_PACKAGE_PYTHON3_ZLIB
> help
> zlib support in Python3
>
> +source "package/python3/Config.ext"
> +
> endif
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 27/84 RFC] package/python{, 3}: move inclusion of external python modules
2015-12-25 21:24 ` [Buildroot] [PATCH 27/84 RFC] package/python{, 3}: move inclusion of external python modules Yann E. MORIN
2015-12-30 23:59 ` Arnout Vandecappelle
@ 2016-01-02 0:54 ` Arnout Vandecappelle
1 sibling, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2016-01-02 0:54 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:24, Yann E. MORIN wrote:
> Introduce a Config.ext for external python modules, that both python and
> python include from there respective sub-menus.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
> package/Config.in | 96 ----------------------------------------------
> package/python/Config.ext | 96 ++++++++++++++++++++++++++++++++++++++++++++++
> package/python/Config.in | 2 +
> package/python3/Config.ext | 1 +
> package/python3/Config.in | 2 +
> 5 files changed, 101 insertions(+), 96 deletions(-)
> create mode 100644 package/python/Config.ext
> create mode 120000 package/python3/Config.ext
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 28/84 RFC] package/sdl_image: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (26 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 27/84 RFC] package/python{, 3}: move inclusion of external python modules Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:24 ` [Buildroot] [PATCH 29/84 RFC] package/tcl: use 'menuconfig' instad " Yann E. MORIN
` (57 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/sdl_image/Config.in | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/package/sdl_image/Config.in b/package/sdl_image/Config.in
index 1b98066..0c4a018 100644
--- a/package/sdl_image/Config.in
+++ b/package/sdl_image/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_SDL_IMAGE
+menuconfig BR2_PACKAGE_SDL_IMAGE
bool "SDL_image"
depends on BR2_PACKAGE_SDL
help
@@ -10,8 +10,6 @@ config BR2_PACKAGE_SDL_IMAGE
if BR2_PACKAGE_SDL_IMAGE
-menu "SDL_image file format support"
-
config BR2_PACKAGE_SDL_IMAGE_BMP
bool "enable BMP file format support"
default y
@@ -56,6 +54,4 @@ config BR2_PACKAGE_SDL_IMAGE_XPM
config BR2_PACKAGE_SDL_IMAGE_XV
bool "enable XV file format support"
-endmenu
-
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 29/84 RFC] package/tcl: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (27 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 28/84 RFC] package/sdl_image: use 'menuconfig' instead of 'config'+'menu' Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-31 0:03 ` Arnout Vandecappelle
2016-01-02 0:55 ` Arnout Vandecappelle
2015-12-25 21:24 ` [Buildroot] [PATCH 30/84 RFC] package/tiff: " Yann E. MORIN
` (56 subsequent siblings)
85 siblings, 2 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Move inclusion of Tcl libraries/modules to Tcl's Config.in so that they
appear in Tcl's sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/Config.in | 6 ------
package/tcl/Config.in | 7 ++++++-
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/package/Config.in b/package/Config.in
index 94ea060..a191f43 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -546,12 +546,6 @@ endif
source "package/python3/Config.in"
source "package/ruby/Config.in"
source "package/tcl/Config.in"
-if BR2_PACKAGE_TCL
-menu "Tcl libraries/modules"
- source "package/expect/Config.in"
- source "package/tcllib/Config.in"
-endmenu
-endif
endmenu
menu "Libraries"
diff --git a/package/tcl/Config.in b/package/tcl/Config.in
index f1fa054..dacd1a8 100644
--- a/package/tcl/Config.in
+++ b/package/tcl/Config.in
@@ -2,7 +2,7 @@ comment "tcl needs a toolchain w/ threads, dynamic library"
depends on BR2_USE_MMU
depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
-config BR2_PACKAGE_TCL
+menuconfig BR2_PACKAGE_TCL
bool "tcl"
# fork()
depends on BR2_USE_MMU
@@ -36,4 +36,9 @@ config BR2_PACKAGE_TCL_SHLIB_ONLY
Saves ~14kb.
+comment "Tcl libraries/modules"
+
+source "package/expect/Config.in"
+source "package/tcllib/Config.in"
+
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 29/84 RFC] package/tcl: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:24 ` [Buildroot] [PATCH 29/84 RFC] package/tcl: use 'menuconfig' instad " Yann E. MORIN
@ 2015-12-31 0:03 ` Arnout Vandecappelle
2016-01-02 0:55 ` Arnout Vandecappelle
1 sibling, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-31 0:03 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:24, Yann E. MORIN wrote:
> Move inclusion of Tcl libraries/modules to Tcl's Config.in so that they
> appear in Tcl's sub-menu.
One more NACK :-)
Regards,
Arnout
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/Config.in | 6 ------
> package/tcl/Config.in | 7 ++++++-
> 2 files changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/package/Config.in b/package/Config.in
> index 94ea060..a191f43 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -546,12 +546,6 @@ endif
> source "package/python3/Config.in"
> source "package/ruby/Config.in"
> source "package/tcl/Config.in"
> -if BR2_PACKAGE_TCL
> -menu "Tcl libraries/modules"
> - source "package/expect/Config.in"
> - source "package/tcllib/Config.in"
> -endmenu
> -endif
> endmenu
>
> menu "Libraries"
> diff --git a/package/tcl/Config.in b/package/tcl/Config.in
> index f1fa054..dacd1a8 100644
> --- a/package/tcl/Config.in
> +++ b/package/tcl/Config.in
> @@ -2,7 +2,7 @@ comment "tcl needs a toolchain w/ threads, dynamic library"
> depends on BR2_USE_MMU
> depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
>
> -config BR2_PACKAGE_TCL
> +menuconfig BR2_PACKAGE_TCL
> bool "tcl"
> # fork()
> depends on BR2_USE_MMU
> @@ -36,4 +36,9 @@ config BR2_PACKAGE_TCL_SHLIB_ONLY
>
> Saves ~14kb.
>
> +comment "Tcl libraries/modules"
> +
> +source "package/expect/Config.in"
> +source "package/tcllib/Config.in"
> +
> endif
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 29/84 RFC] package/tcl: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:24 ` [Buildroot] [PATCH 29/84 RFC] package/tcl: use 'menuconfig' instad " Yann E. MORIN
2015-12-31 0:03 ` Arnout Vandecappelle
@ 2016-01-02 0:55 ` Arnout Vandecappelle
1 sibling, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2016-01-02 0:55 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:24, Yann E. MORIN wrote:
> Move inclusion of Tcl libraries/modules to Tcl's Config.in so that they
> appear in Tcl's sub-menu.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
> package/Config.in | 6 ------
> package/tcl/Config.in | 7 ++++++-
> 2 files changed, 6 insertions(+), 7 deletions(-)
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 30/84 RFC] package/tiff: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (28 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 29/84 RFC] package/tcl: use 'menuconfig' instad " Yann E. MORIN
@ 2015-12-25 21:24 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 31/84 RFC] package/udpcast: " Yann E. MORIN
` (55 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:24 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/tiff/Config.in | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/package/tiff/Config.in b/package/tiff/Config.in
index acb335c..66d37fd 100644
--- a/package/tiff/Config.in
+++ b/package/tiff/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_TIFF
+menuconfig BR2_PACKAGE_TIFF
bool "tiff"
help
Library for handling TIFF (Tag Image File Format) images.
@@ -6,7 +6,6 @@ config BR2_PACKAGE_TIFF
http://www.libtiff.org/
if BR2_PACKAGE_TIFF
-menu "tiff Options"
config BR2_PACKAGE_TIFF_CCITT
bool "CCITT Group 3 & 4 support"
@@ -58,7 +57,6 @@ config BR2_PACKAGE_TIFF_OLD_JPEG
config BR2_PACKAGE_TIFF_JBIG
bool "JBIG compression"
default y
-endmenu
config BR2_PACKAGE_TIFF_UTILITIES
bool "tiff utilities"
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 31/84 RFC] package/udpcast: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (29 preceding siblings ...)
2015-12-25 21:24 ` [Buildroot] [PATCH 30/84 RFC] package/tiff: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-31 0:08 ` Arnout Vandecappelle
2015-12-25 21:25 ` [Buildroot] [PATCH 32/84 RFC] package/gstreamer: include plugins from gstreamer's real Config.in Yann E. MORIN
` (54 subsequent siblings)
85 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
This is a bit overkill, as there is only two sub-items. However, this
commit is not about judging whether it makes sense or not to have a
sub-menu, but to cleanup the 'config'+'menu' situation.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/udpcast/Config.in | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/package/udpcast/Config.in b/package/udpcast/Config.in
index 0424db7..a61829a 100644
--- a/package/udpcast/Config.in
+++ b/package/udpcast/Config.in
@@ -2,7 +2,7 @@ comment "udpcast needs a toolchain w/ threads"
depends on BR2_USE_MMU
depends on !BR2_TOOLCHAIN_HAS_THREADS
-config BR2_PACKAGE_UDPCAST
+menuconfig BR2_PACKAGE_UDPCAST
bool "udpcast"
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_USE_MMU # fork()
@@ -14,8 +14,6 @@ config BR2_PACKAGE_UDPCAST
if BR2_PACKAGE_UDPCAST
-menu "udpcast tools selection"
-
config BR2_PACKAGE_UDPCAST_SENDER
bool "sender"
help
@@ -26,6 +24,4 @@ config BR2_PACKAGE_UDPCAST_RECEIVER
help
The udpcast receiver.
-endmenu
-
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 31/84 RFC] package/udpcast: use 'menuconfig' instad of 'config'+'menu'
2015-12-25 21:25 ` [Buildroot] [PATCH 31/84 RFC] package/udpcast: " Yann E. MORIN
@ 2015-12-31 0:08 ` Arnout Vandecappelle
2015-12-31 17:20 ` Yann E. MORIN
0 siblings, 1 reply; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-31 0:08 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:25, Yann E. MORIN wrote:
> This is a bit overkill, as there is only two sub-items. However, this
> commit is not about judging whether it makes sense or not to have a
> sub-menu, but to cleanup the 'config'+'menu' situation.
Well, you could just as well take this opportunity to replace it with indented
config options. You wrote yourself in your cover text that 5 entries would be
the arbitrary cut-off.
That said, it's acceptable to have this as an inbetween step as well.
Regards,
Arnout
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/udpcast/Config.in | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/package/udpcast/Config.in b/package/udpcast/Config.in
> index 0424db7..a61829a 100644
> --- a/package/udpcast/Config.in
> +++ b/package/udpcast/Config.in
> @@ -2,7 +2,7 @@ comment "udpcast needs a toolchain w/ threads"
> depends on BR2_USE_MMU
> depends on !BR2_TOOLCHAIN_HAS_THREADS
>
> -config BR2_PACKAGE_UDPCAST
> +menuconfig BR2_PACKAGE_UDPCAST
> bool "udpcast"
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on BR2_USE_MMU # fork()
> @@ -14,8 +14,6 @@ config BR2_PACKAGE_UDPCAST
>
> if BR2_PACKAGE_UDPCAST
>
> -menu "udpcast tools selection"
> -
> config BR2_PACKAGE_UDPCAST_SENDER
> bool "sender"
> help
> @@ -26,6 +24,4 @@ config BR2_PACKAGE_UDPCAST_RECEIVER
> help
> The udpcast receiver.
>
> -endmenu
> -
> endif
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 31/84 RFC] package/udpcast: use 'menuconfig' instad of 'config'+'menu'
2015-12-31 0:08 ` Arnout Vandecappelle
@ 2015-12-31 17:20 ` Yann E. MORIN
0 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-31 17:20 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2015-12-31 01:08 +0100, Arnout Vandecappelle spake thusly:
> On 25-12-15 22:25, Yann E. MORIN wrote:
> > This is a bit overkill, as there is only two sub-items. However, this
> > commit is not about judging whether it makes sense or not to have a
> > sub-menu, but to cleanup the 'config'+'menu' situation.
>
> Well, you could just as well take this opportunity to replace it with indented
> config options. You wrote yourself in your cover text that 5 entries would be
> the arbitrary cut-off.
>
> That said, it's acceptable to have this as an inbetween step as well.
Well, as I said in the commit, it's not about judging whether it
makessense or not, it;s just about changing the 'config'+'menu' into a
'menuconfig'.
However, yes, I can /fix/ it in the second part of the series, when the
'5 options or more' concept is introduced.
Regards,
Yann E. MORIN.
>
> Regards,
> Arnout
>
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> > package/udpcast/Config.in | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/package/udpcast/Config.in b/package/udpcast/Config.in
> > index 0424db7..a61829a 100644
> > --- a/package/udpcast/Config.in
> > +++ b/package/udpcast/Config.in
> > @@ -2,7 +2,7 @@ comment "udpcast needs a toolchain w/ threads"
> > depends on BR2_USE_MMU
> > depends on !BR2_TOOLCHAIN_HAS_THREADS
> >
> > -config BR2_PACKAGE_UDPCAST
> > +menuconfig BR2_PACKAGE_UDPCAST
> > bool "udpcast"
> > depends on BR2_TOOLCHAIN_HAS_THREADS
> > depends on BR2_USE_MMU # fork()
> > @@ -14,8 +14,6 @@ config BR2_PACKAGE_UDPCAST
> >
> > if BR2_PACKAGE_UDPCAST
> >
> > -menu "udpcast tools selection"
> > -
> > config BR2_PACKAGE_UDPCAST_SENDER
> > bool "sender"
> > help
> > @@ -26,6 +24,4 @@ config BR2_PACKAGE_UDPCAST_RECEIVER
> > help
> > The udpcast receiver.
> >
> > -endmenu
> > -
> > endif
> >
>
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 32/84 RFC] package/gstreamer: include plugins from gstreamer's real Config.in
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (30 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 31/84 RFC] package/udpcast: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-31 0:12 ` Arnout Vandecappelle
2015-12-25 21:25 ` [Buildroot] [PATCH 33/84 RFC] package/gstreamer: use 'menuconfig' instead of 'config'+'menu' Yann E. MORIN
` (53 subsequent siblings)
85 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
It is more logical to have a single if-clause, rather than repeat it in
another file, possiblty brealking indentation like it previously was.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/gstreamer/Config.in | 12 ------------
package/gstreamer/gstreamer/Config.in | 10 ++++++++++
2 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/package/gstreamer/Config.in b/package/gstreamer/Config.in
index c6292f4..476f838 100644
--- a/package/gstreamer/Config.in
+++ b/package/gstreamer/Config.in
@@ -1,14 +1,2 @@
# Gstreamer 0.10.x & Plugins
source "package/gstreamer/gstreamer/Config.in"
-
-if BR2_PACKAGE_GSTREAMER
-source "package/gstreamer/gst-plugins-base/Config.in"
-source "package/gstreamer/gst-plugins-good/Config.in"
-source "package/gstreamer/gst-plugins-bad/Config.in"
-source "package/gstreamer/gst-plugins-ugly/Config.in"
-source "package/gstreamer/gst-ffmpeg/Config.in"
-source "package/gstreamer/gst-dsp/Config.in"
-source "package/gstreamer/gst-fsl-plugins/Config.in"
-source "package/gstreamer/gst-omapfb/Config.in"
-source "package/gstreamer/gst-plugin-x170/Config.in"
-endif
diff --git a/package/gstreamer/gstreamer/Config.in b/package/gstreamer/gstreamer/Config.in
index eb1249a..aee48b1 100644
--- a/package/gstreamer/gstreamer/Config.in
+++ b/package/gstreamer/gstreamer/Config.in
@@ -33,4 +33,14 @@ config BR2_PACKAGE_GSTREAMER_PLUGIN_REGISTRY
Enable support for the GStreamer plugin registry. This may increase
the launch-time for a GStreamer application.
+source "package/gstreamer/gst-plugins-base/Config.in"
+source "package/gstreamer/gst-plugins-good/Config.in"
+source "package/gstreamer/gst-plugins-bad/Config.in"
+source "package/gstreamer/gst-plugins-ugly/Config.in"
+source "package/gstreamer/gst-ffmpeg/Config.in"
+source "package/gstreamer/gst-dsp/Config.in"
+source "package/gstreamer/gst-fsl-plugins/Config.in"
+source "package/gstreamer/gst-omapfb/Config.in"
+source "package/gstreamer/gst-plugin-x170/Config.in"
+
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 32/84 RFC] package/gstreamer: include plugins from gstreamer's real Config.in
2015-12-25 21:25 ` [Buildroot] [PATCH 32/84 RFC] package/gstreamer: include plugins from gstreamer's real Config.in Yann E. MORIN
@ 2015-12-31 0:12 ` Arnout Vandecappelle
2015-12-31 17:23 ` Yann E. MORIN
0 siblings, 1 reply; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-31 0:12 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:25, Yann E. MORIN wrote:
> It is more logical to have a single if-clause, rather than repeat it in
> another file, possiblty brealking indentation like it previously was.
I actually preferred the way it was indented before. Now there is no
distinction anymore between the gstreamer options and the additional plugin
packages. But I don't feel strongly about it.
Regards,
Arnout
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/gstreamer/Config.in | 12 ------------
> package/gstreamer/gstreamer/Config.in | 10 ++++++++++
> 2 files changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/package/gstreamer/Config.in b/package/gstreamer/Config.in
> index c6292f4..476f838 100644
> --- a/package/gstreamer/Config.in
> +++ b/package/gstreamer/Config.in
> @@ -1,14 +1,2 @@
> # Gstreamer 0.10.x & Plugins
> source "package/gstreamer/gstreamer/Config.in"
> -
> -if BR2_PACKAGE_GSTREAMER
> -source "package/gstreamer/gst-plugins-base/Config.in"
> -source "package/gstreamer/gst-plugins-good/Config.in"
> -source "package/gstreamer/gst-plugins-bad/Config.in"
> -source "package/gstreamer/gst-plugins-ugly/Config.in"
> -source "package/gstreamer/gst-ffmpeg/Config.in"
> -source "package/gstreamer/gst-dsp/Config.in"
> -source "package/gstreamer/gst-fsl-plugins/Config.in"
> -source "package/gstreamer/gst-omapfb/Config.in"
> -source "package/gstreamer/gst-plugin-x170/Config.in"
> -endif
> diff --git a/package/gstreamer/gstreamer/Config.in b/package/gstreamer/gstreamer/Config.in
> index eb1249a..aee48b1 100644
> --- a/package/gstreamer/gstreamer/Config.in
> +++ b/package/gstreamer/gstreamer/Config.in
> @@ -33,4 +33,14 @@ config BR2_PACKAGE_GSTREAMER_PLUGIN_REGISTRY
> Enable support for the GStreamer plugin registry. This may increase
> the launch-time for a GStreamer application.
>
> +source "package/gstreamer/gst-plugins-base/Config.in"
> +source "package/gstreamer/gst-plugins-good/Config.in"
> +source "package/gstreamer/gst-plugins-bad/Config.in"
> +source "package/gstreamer/gst-plugins-ugly/Config.in"
> +source "package/gstreamer/gst-ffmpeg/Config.in"
> +source "package/gstreamer/gst-dsp/Config.in"
> +source "package/gstreamer/gst-fsl-plugins/Config.in"
> +source "package/gstreamer/gst-omapfb/Config.in"
> +source "package/gstreamer/gst-plugin-x170/Config.in"
> +
> endif
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 32/84 RFC] package/gstreamer: include plugins from gstreamer's real Config.in
2015-12-31 0:12 ` Arnout Vandecappelle
@ 2015-12-31 17:23 ` Yann E. MORIN
2016-01-02 1:21 ` Arnout Vandecappelle
0 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-31 17:23 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2015-12-31 01:12 +0100, Arnout Vandecappelle spake thusly:
> On 25-12-15 22:25, Yann E. MORIN wrote:
> > It is more logical to have a single if-clause, rather than repeat it in
> > another file, possiblty brealking indentation like it previously was.
>
> I actually preferred the way it was indented before. Now there is no
> distinction anymore between the gstreamer options and the additional plugin
> packages.
Yes, that is on-purpose. The gstreamer plugins are really "sub-options"
(in the end-user experience) of gstreamer. That they are in fact
completely different packages is still irrelevant to him. ;-)
Regards,
Yann E. MORIN.
> But I don't feel strongly about it.
>
>
> Regards,
> Arnout
>
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> > package/gstreamer/Config.in | 12 ------------
> > package/gstreamer/gstreamer/Config.in | 10 ++++++++++
> > 2 files changed, 10 insertions(+), 12 deletions(-)
> >
> > diff --git a/package/gstreamer/Config.in b/package/gstreamer/Config.in
> > index c6292f4..476f838 100644
> > --- a/package/gstreamer/Config.in
> > +++ b/package/gstreamer/Config.in
> > @@ -1,14 +1,2 @@
> > # Gstreamer 0.10.x & Plugins
> > source "package/gstreamer/gstreamer/Config.in"
> > -
> > -if BR2_PACKAGE_GSTREAMER
> > -source "package/gstreamer/gst-plugins-base/Config.in"
> > -source "package/gstreamer/gst-plugins-good/Config.in"
> > -source "package/gstreamer/gst-plugins-bad/Config.in"
> > -source "package/gstreamer/gst-plugins-ugly/Config.in"
> > -source "package/gstreamer/gst-ffmpeg/Config.in"
> > -source "package/gstreamer/gst-dsp/Config.in"
> > -source "package/gstreamer/gst-fsl-plugins/Config.in"
> > -source "package/gstreamer/gst-omapfb/Config.in"
> > -source "package/gstreamer/gst-plugin-x170/Config.in"
> > -endif
> > diff --git a/package/gstreamer/gstreamer/Config.in b/package/gstreamer/gstreamer/Config.in
> > index eb1249a..aee48b1 100644
> > --- a/package/gstreamer/gstreamer/Config.in
> > +++ b/package/gstreamer/gstreamer/Config.in
> > @@ -33,4 +33,14 @@ config BR2_PACKAGE_GSTREAMER_PLUGIN_REGISTRY
> > Enable support for the GStreamer plugin registry. This may increase
> > the launch-time for a GStreamer application.
> >
> > +source "package/gstreamer/gst-plugins-base/Config.in"
> > +source "package/gstreamer/gst-plugins-good/Config.in"
> > +source "package/gstreamer/gst-plugins-bad/Config.in"
> > +source "package/gstreamer/gst-plugins-ugly/Config.in"
> > +source "package/gstreamer/gst-ffmpeg/Config.in"
> > +source "package/gstreamer/gst-dsp/Config.in"
> > +source "package/gstreamer/gst-fsl-plugins/Config.in"
> > +source "package/gstreamer/gst-omapfb/Config.in"
> > +source "package/gstreamer/gst-plugin-x170/Config.in"
> > +
> > endif
> >
>
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 32/84 RFC] package/gstreamer: include plugins from gstreamer's real Config.in
2015-12-31 17:23 ` Yann E. MORIN
@ 2016-01-02 1:21 ` Arnout Vandecappelle
2016-01-02 10:34 ` Yann E. MORIN
0 siblings, 1 reply; 134+ messages in thread
From: Arnout Vandecappelle @ 2016-01-02 1:21 UTC (permalink / raw)
To: buildroot
On 31-12-15 18:23, Yann E. MORIN wrote:
> Arnout, All,
>
> On 2015-12-31 01:12 +0100, Arnout Vandecappelle spake thusly:
>> On 25-12-15 22:25, Yann E. MORIN wrote:
>>> It is more logical to have a single if-clause, rather than repeat it in
>>> another file, possiblty brealking indentation like it previously was.
>>
>> I actually preferred the way it was indented before. Now there is no
>> distinction anymore between the gstreamer options and the additional plugin
>> packages.
>
> Yes, that is on-purpose. The gstreamer plugins are really "sub-options"
> (in the end-user experience) of gstreamer. That they are in fact
> completely different packages is still irrelevant to him. ;-)
Well, according to that reasoning the packages should not be shown and instead
only the plug-in list should be there. I don't think we're going to do that.
The reason I had less of a concern about gstreamer is because here most of them
are in fact pieces of the same project (like kodi, xorg, matchbox, etc). The
others (python, php, ...) are really external plugins. Of course there are also
some "external" plugins here, but even those tend to get absorbed by the
superproject eventually (like what happened with gst-omx for instance).
Still,
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
>
> Regards,
> Yann E. MORIN.
>
>> But I don't feel strongly about it.
>>
>>
>> Regards,
>> Arnout
>>
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 32/84 RFC] package/gstreamer: include plugins from gstreamer's real Config.in
2016-01-02 1:21 ` Arnout Vandecappelle
@ 2016-01-02 10:34 ` Yann E. MORIN
0 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2016-01-02 10:34 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2016-01-02 02:21 +0100, Arnout Vandecappelle spake thusly:
> On 31-12-15 18:23, Yann E. MORIN wrote:
> > Arnout, All,
> >
> > On 2015-12-31 01:12 +0100, Arnout Vandecappelle spake thusly:
> >> On 25-12-15 22:25, Yann E. MORIN wrote:
> >>> It is more logical to have a single if-clause, rather than repeat it in
> >>> another file, possiblty brealking indentation like it previously was.
> >>
> >> I actually preferred the way it was indented before. Now there is no
> >> distinction anymore between the gstreamer options and the additional plugin
> >> packages.
> >
> > Yes, that is on-purpose. The gstreamer plugins are really "sub-options"
> > (in the end-user experience) of gstreamer. That they are in fact
> > completely different packages is still irrelevant to him. ;-)
>
> Well, according to that reasoning the packages should not be shown and instead
> only the plug-in list should be there. I don't think we're going to do that.
No, especially since it is totally possible to use gstreamer even
without the base plugins, using only local (aka proprietary) plugins.
> The reason I had less of a concern about gstreamer is because here most of them
> are in fact pieces of the same project (like kodi, xorg, matchbox, etc).
OK, I understand now.
But for Kodi, not all the addons are managed by the "Kodi project". For
example, most if not all the PVR addons are completely separately
developped.
> The
> others (python, php, ...) are really external plugins. Of course there are also
> some "external" plugins here, but even those tend to get absorbed by the
> superproject eventually (like what happened with gst-omx for instance).
I now see what was the difference for you, thanks!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 33/84 RFC] package/gstreamer: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (31 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 32/84 RFC] package/gstreamer: include plugins from gstreamer's real Config.in Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-31 0:14 ` Arnout Vandecappelle
2015-12-25 21:25 ` [Buildroot] [PATCH 34/84 RFC] package/gstreamer1: include plugins from gstreamer1's real Config.in Yann E. MORIN
` (52 subsequent siblings)
85 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/gstreamer/gstreamer/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/gstreamer/gstreamer/Config.in b/package/gstreamer/gstreamer/Config.in
index aee48b1..cba8774 100644
--- a/package/gstreamer/gstreamer/Config.in
+++ b/package/gstreamer/gstreamer/Config.in
@@ -2,7 +2,7 @@ comment "gstreamer 0.10 needs a toolchain w/ wchar, threads"
depends on BR2_USE_MMU
depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
-config BR2_PACKAGE_GSTREAMER
+menuconfig BR2_PACKAGE_GSTREAMER
bool "gstreamer 0.10"
depends on BR2_USE_WCHAR # glib2
depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 33/84 RFC] package/gstreamer: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:25 ` [Buildroot] [PATCH 33/84 RFC] package/gstreamer: use 'menuconfig' instead of 'config'+'menu' Yann E. MORIN
@ 2015-12-31 0:14 ` Arnout Vandecappelle
2015-12-31 17:25 ` Yann E. MORIN
0 siblings, 1 reply; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-31 0:14 UTC (permalink / raw)
To: buildroot
Subject is wrong: there was no menu originally, you added it.
Again I don't really like it, but I don't feel so strongly about it as about
jquery etc.
Regards,
Arnout
On 25-12-15 22:25, Yann E. MORIN wrote:
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/gstreamer/gstreamer/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/gstreamer/gstreamer/Config.in b/package/gstreamer/gstreamer/Config.in
> index aee48b1..cba8774 100644
> --- a/package/gstreamer/gstreamer/Config.in
> +++ b/package/gstreamer/gstreamer/Config.in
> @@ -2,7 +2,7 @@ comment "gstreamer 0.10 needs a toolchain w/ wchar, threads"
> depends on BR2_USE_MMU
> depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
>
> -config BR2_PACKAGE_GSTREAMER
> +menuconfig BR2_PACKAGE_GSTREAMER
> bool "gstreamer 0.10"
> depends on BR2_USE_WCHAR # glib2
> depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 33/84 RFC] package/gstreamer: use 'menuconfig' instead of 'config'+'menu'
2015-12-31 0:14 ` Arnout Vandecappelle
@ 2015-12-31 17:25 ` Yann E. MORIN
0 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-31 17:25 UTC (permalink / raw)
To: buildroot
On 2015-12-31 01:14 +0100, Arnout Vandecappelle spake thusly:
> Subject is wrong: there was no menu originally, you added it.
>
> Again I don't really like it, but I don't feel so strongly about it as about
> jquery etc.
Then you got me confused. What's different for gstreamer from jquery,
that makes it acceptable for gstreamer and not jquery?
Really, I'm puzzled...
Regards,
Yann E. MORIN.
> Regards,
> Arnout
>
> On 25-12-15 22:25, Yann E. MORIN wrote:
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> > package/gstreamer/gstreamer/Config.in | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/gstreamer/gstreamer/Config.in b/package/gstreamer/gstreamer/Config.in
> > index aee48b1..cba8774 100644
> > --- a/package/gstreamer/gstreamer/Config.in
> > +++ b/package/gstreamer/gstreamer/Config.in
> > @@ -2,7 +2,7 @@ comment "gstreamer 0.10 needs a toolchain w/ wchar, threads"
> > depends on BR2_USE_MMU
> > depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> >
> > -config BR2_PACKAGE_GSTREAMER
> > +menuconfig BR2_PACKAGE_GSTREAMER
> > bool "gstreamer 0.10"
> > depends on BR2_USE_WCHAR # glib2
> > depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
> >
>
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 34/84 RFC] package/gstreamer1: include plugins from gstreamer1's real Config.in
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (32 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 33/84 RFC] package/gstreamer: use 'menuconfig' instead of 'config'+'menu' Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 35/84 RFC] package/gstreamer1: use 'menuconfig' instead of 'config'+'menu' Yann E. MORIN
` (51 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
It is more logical to have a single if-clause, rather than repeat it in
another file, possiblty brealking indentation like it previously was.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/gstreamer1/Config.in | 11 -----------
package/gstreamer1/gstreamer1/Config.in | 9 +++++++++
2 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/package/gstreamer1/Config.in b/package/gstreamer1/Config.in
index ea35ecc..ca3240f 100644
--- a/package/gstreamer1/Config.in
+++ b/package/gstreamer1/Config.in
@@ -1,13 +1,2 @@
# Gstreamer 1.x & Plugins
source "package/gstreamer1/gstreamer1/Config.in"
-
-if BR2_PACKAGE_GSTREAMER1
-source "package/gstreamer1/gst1-plugins-base/Config.in"
-source "package/gstreamer1/gst1-plugins-good/Config.in"
-source "package/gstreamer1/gst1-plugins-bad/Config.in"
-source "package/gstreamer1/gst1-plugins-ugly/Config.in"
-source "package/gstreamer1/gst1-imx/Config.in"
-source "package/gstreamer1/gst1-libav/Config.in"
-source "package/gstreamer1/gst1-validate/Config.in"
-source "package/gstreamer1/gst-omx/Config.in"
-endif
diff --git a/package/gstreamer1/gstreamer1/Config.in b/package/gstreamer1/gstreamer1/Config.in
index c13f041..fff8794 100644
--- a/package/gstreamer1/gstreamer1/Config.in
+++ b/package/gstreamer1/gstreamer1/Config.in
@@ -52,4 +52,13 @@ config BR2_PACKAGE_GSTREAMER1_INSTALL_TOOLS
Install the gst-launch and gst-inspect tools. This will take up
additional space on the target.
+source "package/gstreamer1/gst1-plugins-base/Config.in"
+source "package/gstreamer1/gst1-plugins-good/Config.in"
+source "package/gstreamer1/gst1-plugins-bad/Config.in"
+source "package/gstreamer1/gst1-plugins-ugly/Config.in"
+source "package/gstreamer1/gst1-imx/Config.in"
+source "package/gstreamer1/gst1-libav/Config.in"
+source "package/gstreamer1/gst1-validate/Config.in"
+source "package/gstreamer1/gst-omx/Config.in"
+
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 35/84 RFC] package/gstreamer1: use 'menuconfig' instead of 'config'+'menu'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (33 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 34/84 RFC] package/gstreamer1: include plugins from gstreamer1's real Config.in Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 36/84 RFC] docs/manual: slightly compactify a paragraph Yann E. MORIN
` (50 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/gstreamer1/gstreamer1/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/gstreamer1/gstreamer1/Config.in b/package/gstreamer1/gstreamer1/Config.in
index fff8794..a391324 100644
--- a/package/gstreamer1/gstreamer1/Config.in
+++ b/package/gstreamer1/gstreamer1/Config.in
@@ -2,7 +2,7 @@ comment "gstreamer 1.x needs a toolchain w/ wchar, threads"
depends on BR2_USE_MMU
depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
-config BR2_PACKAGE_GSTREAMER1
+menuconfig BR2_PACKAGE_GSTREAMER1
bool "gstreamer 1.x"
depends on BR2_USE_WCHAR # glib2
depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 36/84 RFC] docs/manual: slightly compactify a paragraph
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (34 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 35/84 RFC] package/gstreamer1: use 'menuconfig' instead of 'config'+'menu' Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 37/84 RFC] docs/manual: add ordering of kconfig options' attributes Yann E. MORIN
` (49 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
docs/manual/adding-packages-directory.txt | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
index 139123e..02a628d 100644
--- a/docs/manual/adding-packages-directory.txt
+++ b/docs/manual/adding-packages-directory.txt
@@ -39,12 +39,11 @@ itself should be indented with one tab and two spaces, lines should
not be longer than 72 columns, and it must mention the upstream URL
of the project.
-You can add other sub-options into a +if
-BR2_PACKAGE_LIBFOO...endif+ statement to configure particular things
-in your software. You can look at examples in other packages. The
-syntax of the +Config.in+ file is the same as the one for the kernel
-Kconfig file. The documentation for this syntax is available at
-http://kernel.org/doc/Documentation/kbuild/kconfig-language.txt[]
+You can add other sub-options into a +if BR2_PACKAGE_LIBFOO...endif+
+statement to configure particular things in your software. You can look at
+examples in other packages. The syntax of the +Config.in+ file is the same
+as the one for the kernel Kconfig file. The documentation for this syntax is
+available at http://kernel.org/doc/Documentation/kbuild/kconfig-language.txt[]
Finally you have to add your new +libfoo/Config.in+ to
+package/Config.in+ (or in a category subdirectory if you decided to
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 37/84 RFC] docs/manual: add ordering of kconfig options' attributes
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (35 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 36/84 RFC] docs/manual: slightly compactify a paragraph Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 38/84 RFC] docs/manual: add example about sub-options Yann E. MORIN
` (48 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
We want to ensure all packages follow the same coding style, so we add a
blurb about the order of kconfig options' attributes:
- first, the type and the prompt
- the default value if needed
- then dependencies of the 'depends on' category
- followed by dependencies of the 'select' form
- with eventually the help text
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
docs/manual/adding-packages-directory.txt | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
index 02a628d..faf967c 100644
--- a/docs/manual/adding-packages-directory.txt
+++ b/docs/manual/adding-packages-directory.txt
@@ -39,6 +39,15 @@ itself should be indented with one tab and two spaces, lines should
not be longer than 72 columns, and it must mention the upstream URL
of the project.
+As a convention specific to Buildroot, the ordering of the attributes
+is as follows:
+
+1. The type of option: +bool+, +string+... with the prompt
+2. If needed, the +default+ value
+3. Any dependency of the +depends on+ form
+4. Any depenency of the +select+ form
+5. The help keyword and help text.
+
You can add other sub-options into a +if BR2_PACKAGE_LIBFOO...endif+
statement to configure particular things in your software. You can look at
examples in other packages. The syntax of the +Config.in+ file is the same
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 38/84 RFC] docs/manual: add example about sub-options
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (36 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 37/84 RFC] docs/manual: add ordering of kconfig options' attributes Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-31 0:17 ` Arnout Vandecappelle
2015-12-25 21:25 ` [Buildroot] [PATCH 39/84 RFC] docs/manual: use 'menuconfig' when there are more than 5 sub-options Yann E. MORIN
` (47 subsequent siblings)
85 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
docs/manual/adding-packages-directory.txt | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
index faf967c..2b9e714 100644
--- a/docs/manual/adding-packages-directory.txt
+++ b/docs/manual/adding-packages-directory.txt
@@ -54,6 +54,31 @@ examples in other packages. The syntax of the +Config.in+ file is the same
as the one for the kernel Kconfig file. The documentation for this syntax is
available at http://kernel.org/doc/Documentation/kbuild/kconfig-language.txt[]
+For example:
+
+---------------------------
+config BR2_PACKAGE_LIBFOO
+ bool "libfoo"
+ help
+ This is a comment that explains what libfoo is.
+
+ http://foosoftware.org/libfoo/
+
+if BR2_PACKAGE_LIBFOO
+
+config BR2_PACKAGE_LIBFOO_BAR
+ bool "bar support"
+ help
+ This is a comment that briefly explains what
+ bar support is, if it's not obvious.
+
+endif # BR2_PACKAGE_LIBFOO
+---------------------------
+
+The sub-options will be cleanly indented below the main symbol when it
+is enabled, and will be properly hidden when the symbol is disabled.
+
+
Finally you have to add your new +libfoo/Config.in+ to
+package/Config.in+ (or in a category subdirectory if you decided to
put your package in one of the existing categories). The files
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 38/84 RFC] docs/manual: add example about sub-options
2015-12-25 21:25 ` [Buildroot] [PATCH 38/84 RFC] docs/manual: add example about sub-options Yann E. MORIN
@ 2015-12-31 0:17 ` Arnout Vandecappelle
2015-12-31 17:26 ` Yann E. MORIN
0 siblings, 1 reply; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-31 0:17 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:25, Yann E. MORIN wrote:
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> docs/manual/adding-packages-directory.txt | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
> index faf967c..2b9e714 100644
> --- a/docs/manual/adding-packages-directory.txt
> +++ b/docs/manual/adding-packages-directory.txt
> @@ -54,6 +54,31 @@ examples in other packages. The syntax of the +Config.in+ file is the same
> as the one for the kernel Kconfig file. The documentation for this syntax is
> available at http://kernel.org/doc/Documentation/kbuild/kconfig-language.txt[]
>
> +For example:
> +
> +---------------------------
> +config BR2_PACKAGE_LIBFOO
> + bool "libfoo"
> + help
> + This is a comment that explains what libfoo is.
> +
> + http://foosoftware.org/libfoo/
> +
> +if BR2_PACKAGE_LIBFOO
> +
> +config BR2_PACKAGE_LIBFOO_BAR
> + bool "bar support"
> + help
> + This is a comment that briefly explains what
> + bar support is, if it's not obvious.
This should be indented at 72 columns like we require in the real Config.in.
Regards,
Arnout
> +
> +endif # BR2_PACKAGE_LIBFOO
> +---------------------------
> +
> +The sub-options will be cleanly indented below the main symbol when it
> +is enabled, and will be properly hidden when the symbol is disabled.
> +
> +
> Finally you have to add your new +libfoo/Config.in+ to
> +package/Config.in+ (or in a category subdirectory if you decided to
> put your package in one of the existing categories). The files
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 38/84 RFC] docs/manual: add example about sub-options
2015-12-31 0:17 ` Arnout Vandecappelle
@ 2015-12-31 17:26 ` Yann E. MORIN
2016-01-02 1:23 ` Arnout Vandecappelle
0 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-31 17:26 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2015-12-31 01:17 +0100, Arnout Vandecappelle spake thusly:
> On 25-12-15 22:25, Yann E. MORIN wrote:
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> > docs/manual/adding-packages-directory.txt | 25 +++++++++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
> > index faf967c..2b9e714 100644
> > --- a/docs/manual/adding-packages-directory.txt
> > +++ b/docs/manual/adding-packages-directory.txt
> > @@ -54,6 +54,31 @@ examples in other packages. The syntax of the +Config.in+ file is the same
> > as the one for the kernel Kconfig file. The documentation for this syntax is
> > available at http://kernel.org/doc/Documentation/kbuild/kconfig-language.txt[]
> >
> > +For example:
> > +
> > +---------------------------
> > +config BR2_PACKAGE_LIBFOO
> > + bool "libfoo"
> > + help
> > + This is a comment that explains what libfoo is.
> > +
> > + http://foosoftware.org/libfoo/
> > +
> > +if BR2_PACKAGE_LIBFOO
> > +
> > +config BR2_PACKAGE_LIBFOO_BAR
> > + bool "bar support"
> > + help
> > + This is a comment that briefly explains what
> > + bar support is, if it's not obvious.
>
> This should be indented at 72 columns like we require in the real Config.in.
Yes, but in this case, the second line is really short, and in that case
I prefer (and usually tend to use) a shorter first line so the second
line is more than one or two words, it looks easier to read to me...
But I don't feel strongly about it either. I'll fix.
Regards,
Yann E. MORIN.
> Regards,
> Arnout
>
> > +
> > +endif # BR2_PACKAGE_LIBFOO
> > +---------------------------
> > +
> > +The sub-options will be cleanly indented below the main symbol when it
> > +is enabled, and will be properly hidden when the symbol is disabled.
> > +
> > +
> > Finally you have to add your new +libfoo/Config.in+ to
> > +package/Config.in+ (or in a category subdirectory if you decided to
> > put your package in one of the existing categories). The files
> >
>
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 38/84 RFC] docs/manual: add example about sub-options
2015-12-31 17:26 ` Yann E. MORIN
@ 2016-01-02 1:23 ` Arnout Vandecappelle
2016-01-02 10:35 ` Yann E. MORIN
0 siblings, 1 reply; 134+ messages in thread
From: Arnout Vandecappelle @ 2016-01-02 1:23 UTC (permalink / raw)
To: buildroot
On 31-12-15 18:26, Yann E. MORIN wrote:
> Arnout, All,
>
> On 2015-12-31 01:17 +0100, Arnout Vandecappelle spake thusly:
>> On 25-12-15 22:25, Yann E. MORIN wrote:
>>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>>> ---
>>> docs/manual/adding-packages-directory.txt | 25 +++++++++++++++++++++++++
>>> 1 file changed, 25 insertions(+)
>>>
>>> diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
>>> index faf967c..2b9e714 100644
>>> --- a/docs/manual/adding-packages-directory.txt
>>> +++ b/docs/manual/adding-packages-directory.txt
>>> @@ -54,6 +54,31 @@ examples in other packages. The syntax of the +Config.in+ file is the same
>>> as the one for the kernel Kconfig file. The documentation for this syntax is
>>> available at http://kernel.org/doc/Documentation/kbuild/kconfig-language.txt[]
>>>
>>> +For example:
>>> +
>>> +---------------------------
>>> +config BR2_PACKAGE_LIBFOO
>>> + bool "libfoo"
>>> + help
>>> + This is a comment that explains what libfoo is.
>>> +
>>> + http://foosoftware.org/libfoo/
>>> +
>>> +if BR2_PACKAGE_LIBFOO
>>> +
>>> +config BR2_PACKAGE_LIBFOO_BAR
>>> + bool "bar support"
>>> + help
>>> + This is a comment that briefly explains what
>>> + bar support is, if it's not obvious.
>>
>> This should be indented at 72 columns like we require in the real Config.in.
>
> Yes, but in this case, the second line is really short, and in that case
> I prefer (and usually tend to use) a shorter first line so the second
> line is more than one or two words, it looks easier to read to me...
Well, this is the manual, we're setting the example here, so not sticking to
the rule would be confusing IMHO.
Regards,
Arnout
>
> But I don't feel strongly about it either. I'll fix.
>
> Regards,
> Yann E. MORIN.
>
>> Regards,
>> Arnout
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 38/84 RFC] docs/manual: add example about sub-options
2016-01-02 1:23 ` Arnout Vandecappelle
@ 2016-01-02 10:35 ` Yann E. MORIN
0 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2016-01-02 10:35 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2016-01-02 02:23 +0100, Arnout Vandecappelle spake thusly:
> On 31-12-15 18:26, Yann E. MORIN wrote:
> > On 2015-12-31 01:17 +0100, Arnout Vandecappelle spake thusly:
> >> On 25-12-15 22:25, Yann E. MORIN wrote:
> >>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >>> ---
> >>> docs/manual/adding-packages-directory.txt | 25 +++++++++++++++++++++++++
> >>> 1 file changed, 25 insertions(+)
> >>>
> >>> diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
> >>> index faf967c..2b9e714 100644
> >>> --- a/docs/manual/adding-packages-directory.txt
> >>> +++ b/docs/manual/adding-packages-directory.txt
> >>> @@ -54,6 +54,31 @@ examples in other packages. The syntax of the +Config.in+ file is the same
> >>> as the one for the kernel Kconfig file. The documentation for this syntax is
> >>> available at http://kernel.org/doc/Documentation/kbuild/kconfig-language.txt[]
> >>>
> >>> +For example:
> >>> +
> >>> +---------------------------
> >>> +config BR2_PACKAGE_LIBFOO
> >>> + bool "libfoo"
> >>> + help
> >>> + This is a comment that explains what libfoo is.
> >>> +
> >>> + http://foosoftware.org/libfoo/
> >>> +
> >>> +if BR2_PACKAGE_LIBFOO
> >>> +
> >>> +config BR2_PACKAGE_LIBFOO_BAR
> >>> + bool "bar support"
> >>> + help
> >>> + This is a comment that briefly explains what
> >>> + bar support is, if it's not obvious.
> >>
> >> This should be indented at 72 columns like we require in the real Config.in.
> >
> > Yes, but in this case, the second line is really short, and in that case
> > I prefer (and usually tend to use) a shorter first line so the second
> > line is more than one or two words, it looks easier to read to me...
>
> Well, this is the manual, we're setting the example here, so not sticking to
> the rule would be confusing IMHO.
Agreed. I'll fix.
Thanks!
Regards,
Yann E. MORIN.
> Regards,
> Arnout
>
> >
> > But I don't feel strongly about it either. I'll fix.
> >
> > Regards,
> > Yann E. MORIN.
> >
> >> Regards,
> >> Arnout
> [snip]
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 39/84 RFC] docs/manual: use 'menuconfig' when there are more than 5 sub-options
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (37 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 38/84 RFC] docs/manual: add example about sub-options Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-31 0:21 ` Arnout Vandecappelle
2015-12-25 21:25 ` [Buildroot] [PATCH 40/84 RFC] package/valgrind: use 'menuconfig' Yann E. MORIN
` (46 subsequent siblings)
85 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
When a package has a lot of sub-options, the layout in menuconfig (the
mconf UI) is quickly getting messy.
Using 'menuconfig' (the kconfig keyword) will automatically create a
sub-menu, which provides a cleaner layout.
Document that, with 5 or more options, a 'menuconfig' should be used
instead of a simple 'config'.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
Note: 5 is arbitrary. We could tweak it to a bit more, but on small
terminals (the smallest supported is 80x24), there are only 10 lines
for the menu entries, so 5 looks like a good compromise. YMMV.
---
docs/manual/adding-packages-directory.txt | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
index 2b9e714..df3011b 100644
--- a/docs/manual/adding-packages-directory.txt
+++ b/docs/manual/adding-packages-directory.txt
@@ -79,6 +79,34 @@ The sub-options will be cleanly indented below the main symbol when it
is enabled, and will be properly hidden when the symbol is disabled.
+If your package has 5 or more options, then you should use +menuconfig+
+to define the main symbol; this will ensure that all the package's
+sub-options are automaticaly classified in a sub-menu:
+
+---------------------------
+menuconfig BR2_PACKAGE_LIBFOO
+ bool "libfoo"
+ help
+ This is a comment that explains what libfoo is.
+
+ http://foosoftware.org/libfoo/
+
+if BR2_PACKAGE_LIBFOO
+
+config BR2_PACKAGE_LIBFOO_BAR
+ bool "bar support"
+ help
+ This is a comment that briefly explains what
+ bar support is, if it's not obvious.
+
+endif # BR2_PACKAGE_LIBFOO
+---------------------------
+
+In any case, ensure that there is no +comment+ or other symbol in-between
+the main symbol (be it +config+ or +menuconfig+) and the +if+ clause,
+otherwise 'Kconfig' will not properly classify the sub-options.
+
+
Finally you have to add your new +libfoo/Config.in+ to
+package/Config.in+ (or in a category subdirectory if you decided to
put your package in one of the existing categories). The files
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 39/84 RFC] docs/manual: use 'menuconfig' when there are more than 5 sub-options
2015-12-25 21:25 ` [Buildroot] [PATCH 39/84 RFC] docs/manual: use 'menuconfig' when there are more than 5 sub-options Yann E. MORIN
@ 2015-12-31 0:21 ` Arnout Vandecappelle
0 siblings, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-31 0:21 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:25, Yann E. MORIN wrote:
> When a package has a lot of sub-options, the layout in menuconfig (the
> mconf UI) is quickly getting messy.
>
> Using 'menuconfig' (the kconfig keyword) will automatically create a
> sub-menu, which provides a cleaner layout.
>
> Document that, with 5 or more options, a 'menuconfig' should be used
> instead of a simple 'config'.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> ---
> Note: 5 is arbitrary. We could tweak it to a bit more, but on small
> terminals (the smallest supported is 80x24), there are only 10 lines
> for the menu entries, so 5 looks like a good compromise. YMMV.
> ---
> docs/manual/adding-packages-directory.txt | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
> index 2b9e714..df3011b 100644
> --- a/docs/manual/adding-packages-directory.txt
> +++ b/docs/manual/adding-packages-directory.txt
> @@ -79,6 +79,34 @@ The sub-options will be cleanly indented below the main symbol when it
> is enabled, and will be properly hidden when the symbol is disabled.
>
>
> +If your package has 5 or more options, then you should use +menuconfig+
> +to define the main symbol; this will ensure that all the package's
> +sub-options are automaticaly classified in a sub-menu:
> +
> +---------------------------
> +menuconfig BR2_PACKAGE_LIBFOO
> + bool "libfoo"
> + help
> + This is a comment that explains what libfoo is.
> +
> + http://foosoftware.org/libfoo/
> +
> +if BR2_PACKAGE_LIBFOO
> +
> +config BR2_PACKAGE_LIBFOO_BAR
> + bool "bar support"
> + help
> + This is a comment that briefly explains what
> + bar support is, if it's not obvious.
Again the wrapping.
Regards,
Arnout
> +
> +endif # BR2_PACKAGE_LIBFOO
> +---------------------------
> +
> +In any case, ensure that there is no +comment+ or other symbol in-between
> +the main symbol (be it +config+ or +menuconfig+) and the +if+ clause,
> +otherwise 'Kconfig' will not properly classify the sub-options.
> +
> +
> Finally you have to add your new +libfoo/Config.in+ to
> +package/Config.in+ (or in a category subdirectory if you decided to
> put your package in one of the existing categories). The files
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 40/84 RFC] package/valgrind: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (38 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 39/84 RFC] docs/manual: use 'menuconfig' when there are more than 5 sub-options Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 41/84 RFC] package/e2fsprogs: " Yann E. MORIN
` (45 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
Valgrind has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/valgrind/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
index 21b2608..ce5c3b4 100644
--- a/package/valgrind/Config.in
+++ b/package/valgrind/Config.in
@@ -1,7 +1,7 @@
comment "valgrind needs a toolchain w/ dynamic library"
depends on BR2_STATIC_LIBS
-config BR2_PACKAGE_VALGRIND
+menuconfig BR2_PACKAGE_VALGRIND
bool "valgrind"
depends on BR2_ARM_CPU_ARMV7A || BR2_i386 || \
BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 41/84 RFC] package/e2fsprogs: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (39 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 40/84 RFC] package/valgrind: use 'menuconfig' Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 42/84 RFC] package/mtd: " Yann E. MORIN
` (44 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
e2fsprogs has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/e2fsprogs/Config.in | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/package/e2fsprogs/Config.in b/package/e2fsprogs/Config.in
index ad33983..dd426b0 100644
--- a/package/e2fsprogs/Config.in
+++ b/package/e2fsprogs/Config.in
@@ -1,5 +1,4 @@
-
-config BR2_PACKAGE_E2FSPROGS
+menuconfig BR2_PACKAGE_E2FSPROGS
bool "e2fsprogs"
depends on BR2_USE_WCHAR # util-linux
depends on BR2_USE_MMU # util-linux/libblkid
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 42/84 RFC] package/mtd: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (40 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 41/84 RFC] package/e2fsprogs: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 43/84 RFC] package/squashfs: " Yann E. MORIN
` (43 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
mtd has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/mtd/Config.in | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/package/mtd/Config.in b/package/mtd/Config.in
index 6e4346f..5add9c1 100644
--- a/package/mtd/Config.in
+++ b/package/mtd/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_MTD
+menuconfig BR2_PACKAGE_MTD
bool "mtd, jffs2 and ubi/ubifs tools"
help
Build mtd, jffs2 and ubi/ubifs tools
@@ -6,7 +6,6 @@ config BR2_PACKAGE_MTD
http://www.linux-mtd.infradead.org/
if BR2_PACKAGE_MTD
-comment "MTD tools selection"
config BR2_PACKAGE_MTD_DOCFDISK
bool "docfdisk"
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 43/84 RFC] package/squashfs: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (41 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 42/84 RFC] package/mtd: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 44/84 RFC] package/dejavu: " Yann E. MORIN
` (42 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
squashfs has 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/squashfs/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/squashfs/Config.in b/package/squashfs/Config.in
index 70c0fc9..cec57f9 100644
--- a/package/squashfs/Config.in
+++ b/package/squashfs/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_SQUASHFS
+menuconfig BR2_PACKAGE_SQUASHFS
bool "squashfs"
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_USE_MMU # fork()
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 44/84 RFC] package/dejavu: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (42 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 43/84 RFC] package/squashfs: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 45/84 RFC] package/google-material-design-icons: " Yann E. MORIN
` (41 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
dejavu has 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/dejavu/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/dejavu/Config.in b/package/dejavu/Config.in
index 5d21e56..8e114f0 100644
--- a/package/dejavu/Config.in
+++ b/package/dejavu/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_DEJAVU
+menuconfig BR2_PACKAGE_DEJAVU
bool "DejaVu fonts"
help
The DejaVu fonts are a font family based on the Vera Fonts.
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 45/84 RFC] package/google-material-design-icons: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (43 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 44/84 RFC] package/dejavu: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 46/84 RFC] package/directfb: " Yann E. MORIN
` (40 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
google-material-design-icons has more than 5 options, so use a
'menuconfig' to group the options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/google-material-design-icons/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/google-material-design-icons/Config.in b/package/google-material-design-icons/Config.in
index a200429..d7be363 100644
--- a/package/google-material-design-icons/Config.in
+++ b/package/google-material-design-icons/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_GOOGLE_MATERIAL_DESIGN_ICONS
+menuconfig BR2_PACKAGE_GOOGLE_MATERIAL_DESIGN_ICONS
bool "google-material-design-icons"
help
Material design icons are the official icon set from Google that
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 46/84 RFC] package/directfb: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (44 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 45/84 RFC] package/google-material-design-icons: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2016-01-02 1:30 ` Arnout Vandecappelle
2015-12-25 21:25 ` [Buildroot] [PATCH 47/84 RFC] package/efl: " Yann E. MORIN
` (39 subsequent siblings)
85 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
directfb has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/directfb/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/directfb/Config.in b/package/directfb/Config.in
index 73425d3..6a233dc 100644
--- a/package/directfb/Config.in
+++ b/package/directfb/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_DIRECTFB
+menuconfig BR2_PACKAGE_DIRECTFB
bool "directfb"
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_INSTALL_LIBSTDCPP
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 46/84 RFC] package/directfb: use 'menuconfig'
2015-12-25 21:25 ` [Buildroot] [PATCH 46/84 RFC] package/directfb: " Yann E. MORIN
@ 2016-01-02 1:30 ` Arnout Vandecappelle
2016-01-02 11:03 ` Yann E. MORIN
0 siblings, 1 reply; 134+ messages in thread
From: Arnout Vandecappelle @ 2016-01-02 1:30 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:25, Yann E. MORIN wrote:
> directfb has more than 5 options, so use a 'menuconfig' to group the
> options in an sub-menu.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/directfb/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/directfb/Config.in b/package/directfb/Config.in
> index 73425d3..6a233dc 100644
> --- a/package/directfb/Config.in
> +++ b/package/directfb/Config.in
> @@ -1,4 +1,4 @@
> -config BR2_PACKAGE_DIRECTFB
> +menuconfig BR2_PACKAGE_DIRECTFB
> bool "directfb"
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on BR2_INSTALL_LIBSTDCPP
>
Maybe directfb-examples should be moved into this menu as well?
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 46/84 RFC] package/directfb: use 'menuconfig'
2016-01-02 1:30 ` Arnout Vandecappelle
@ 2016-01-02 11:03 ` Yann E. MORIN
0 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2016-01-02 11:03 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2016-01-02 02:30 +0100, Arnout Vandecappelle spake thusly:
> On 25-12-15 22:25, Yann E. MORIN wrote:
> > directfb has more than 5 options, so use a 'menuconfig' to group the
> > options in an sub-menu.
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> > package/directfb/Config.in | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/directfb/Config.in b/package/directfb/Config.in
> > index 73425d3..6a233dc 100644
> > --- a/package/directfb/Config.in
> > +++ b/package/directfb/Config.in
> > @@ -1,4 +1,4 @@
> > -config BR2_PACKAGE_DIRECTFB
> > +menuconfig BR2_PACKAGE_DIRECTFB
> > bool "directfb"
> > depends on BR2_TOOLCHAIN_HAS_THREADS
> > depends on BR2_INSTALL_LIBSTDCPP
>
> Maybe directfb-examples should be moved into this menu as well?
I was not sure about that one.
directfb-examples is a separate package that buids _on top_ of directfb;
it does not provide additional features like addons or modules that can
be 'dynamically loaded' at runtime (like gst plugins or php mdules or
perl addons or...).
IMHO it's a bit like enlightenment and EFL: enlightenment is only one
package that can _use_ EFL and does not enhance EFL.
But since they are example for DirectFB, it probably does not nmake
sense to have it on the final target, and they would probably be used
only during development, so could belong to the directfb sub-menu.
Anyway, I'll leave it out for now, we can move it later if people
prefer.
Thanks! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 47/84 RFC] package/efl: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (45 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 46/84 RFC] package/directfb: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 48/84 RFC] package/sdl: " Yann E. MORIN
` (38 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
EFL has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/efl/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/efl/Config.in b/package/efl/Config.in
index fd3498e..f93c1c1 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_EFL
+menuconfig BR2_PACKAGE_EFL
bool "efl"
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_PACKAGE_HAS_UDEV # libudev
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 48/84 RFC] package/sdl: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (46 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 47/84 RFC] package/efl: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 49/84 RFC] package/sdl: include SDL external libraries from sdl's Config.in Yann E. MORIN
` (37 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
SDL has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/sdl/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/sdl/Config.in b/package/sdl/Config.in
index 65ac8a2..e0a4437 100644
--- a/package/sdl/Config.in
+++ b/package/sdl/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_SDL
+menuconfig BR2_PACKAGE_SDL
bool "SDL"
help
Simple DirectMedia Layer - SDL is a library that allows
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 49/84 RFC] package/sdl: include SDL external libraries from sdl's Config.in
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (47 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 48/84 RFC] package/sdl: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 50/84 RFC] package/sdl_*: remove redundant dependency Yann E. MORIN
` (36 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/Config.in | 6 ------
package/sdl/Config.in | 9 +++++++++
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/package/Config.in b/package/Config.in
index a191f43..3edbf49 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -263,12 +263,6 @@ endif
source "package/ocrad/Config.in"
source "package/psplash/Config.in"
source "package/sdl/Config.in"
- source "package/sdl_gfx/Config.in"
- source "package/sdl_image/Config.in"
- source "package/sdl_mixer/Config.in"
- source "package/sdl_net/Config.in"
- source "package/sdl_sound/Config.in"
- source "package/sdl_ttf/Config.in"
source "package/sdl2/Config.in"
comment "Other GUIs"
diff --git a/package/sdl/Config.in b/package/sdl/Config.in
index e0a4437..bba089c 100644
--- a/package/sdl/Config.in
+++ b/package/sdl/Config.in
@@ -27,4 +27,13 @@ config BR2_PACKAGE_SDL_X11
select BR2_PACKAGE_XLIB_LIBX11
select BR2_PACKAGE_XLIB_LIBXEXT
+comment "External libraries"
+
+source "package/sdl_gfx/Config.in"
+source "package/sdl_image/Config.in"
+source "package/sdl_mixer/Config.in"
+source "package/sdl_net/Config.in"
+source "package/sdl_sound/Config.in"
+source "package/sdl_ttf/Config.in"
+
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 50/84 RFC] package/sdl_*: remove redundant dependency
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (48 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 49/84 RFC] package/sdl: include SDL external libraries from sdl's Config.in Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 51/84 RFC] package/lm-sensors: use 'menuconfig' Yann E. MORIN
` (35 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
Now that those packages are directly included in an if-SDL clause, there
is no need to expressly depend on SDL.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/sdl_gfx/Config.in | 1 -
package/sdl_image/Config.in | 1 -
package/sdl_mixer/Config.in | 1 -
package/sdl_net/Config.in | 1 -
package/sdl_sound/Config.in | 1 -
package/sdl_ttf/Config.in | 1 -
6 files changed, 6 deletions(-)
diff --git a/package/sdl_gfx/Config.in b/package/sdl_gfx/Config.in
index b5d5cac..0f4518b 100644
--- a/package/sdl_gfx/Config.in
+++ b/package/sdl_gfx/Config.in
@@ -1,6 +1,5 @@
config BR2_PACKAGE_SDL_GFX
bool "SDL_gfx"
- depends on BR2_PACKAGE_SDL
help
The SDL_gfx library is an extension to the SDL library which
provides basic antialiased drawing routines such as lines,
diff --git a/package/sdl_image/Config.in b/package/sdl_image/Config.in
index 0c4a018..d9278d7 100644
--- a/package/sdl_image/Config.in
+++ b/package/sdl_image/Config.in
@@ -1,6 +1,5 @@
menuconfig BR2_PACKAGE_SDL_IMAGE
bool "SDL_image"
- depends on BR2_PACKAGE_SDL
help
SDL_image is an image file loading library. It loads images
as SDL surfaces, and supports the following formats:
diff --git a/package/sdl_mixer/Config.in b/package/sdl_mixer/Config.in
index 42dfe63..8d558ed 100644
--- a/package/sdl_mixer/Config.in
+++ b/package/sdl_mixer/Config.in
@@ -1,6 +1,5 @@
config BR2_PACKAGE_SDL_MIXER
bool "SDL_mixer"
- depends on BR2_PACKAGE_SDL
help
SDL_mixer is a sample multi-channel audio mixer library.
It supports any number of simultaneously playing channels of
diff --git a/package/sdl_net/Config.in b/package/sdl_net/Config.in
index 2001d23..6fddba5 100644
--- a/package/sdl_net/Config.in
+++ b/package/sdl_net/Config.in
@@ -1,6 +1,5 @@
config BR2_PACKAGE_SDL_NET
bool "SDL_net"
- depends on BR2_PACKAGE_SDL
help
SDL_net is a small, low-level, cross-platform network library, that
can be used with the Simple DirectMedia Layer library (SDL).
diff --git a/package/sdl_sound/Config.in b/package/sdl_sound/Config.in
index 6da1985..723f9ac 100644
--- a/package/sdl_sound/Config.in
+++ b/package/sdl_sound/Config.in
@@ -1,6 +1,5 @@
config BR2_PACKAGE_SDL_SOUND
bool "SDL_sound"
- depends on BR2_PACKAGE_SDL
select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
help
SDL_sound is a library that handles the decoding of several
diff --git a/package/sdl_ttf/Config.in b/package/sdl_ttf/Config.in
index efc92e5..be56139 100644
--- a/package/sdl_ttf/Config.in
+++ b/package/sdl_ttf/Config.in
@@ -1,6 +1,5 @@
config BR2_PACKAGE_SDL_TTF
bool "SDL_TTF"
- depends on BR2_PACKAGE_SDL
select BR2_PACKAGE_FREETYPE
help
SDL_ttf is a sample TrueType font library. It allows you to
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 51/84 RFC] package/lm-sensors: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (49 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 50/84 RFC] package/sdl_*: remove redundant dependency Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 52/84 RFC] package/openocd: " Yann E. MORIN
` (34 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
lm-sensors has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/lm-sensors/Config.in | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/package/lm-sensors/Config.in b/package/lm-sensors/Config.in
index 7065c4c..e6dd085 100644
--- a/package/lm-sensors/Config.in
+++ b/package/lm-sensors/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_LM_SENSORS
+menuconfig BR2_PACKAGE_LM_SENSORS
bool "lm-sensors"
help
Lm-sensors is a hardware health monitoring package for
@@ -9,7 +9,6 @@ config BR2_PACKAGE_LM_SENSORS
http://www.lm-sensors.org/
if BR2_PACKAGE_LM_SENSORS
-comment "lm-sensors tools"
config BR2_PACKAGE_LM_SENSORS_SENSORS
bool "sensors"
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 52/84 RFC] package/openocd: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (50 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 51/84 RFC] package/lm-sensors: use 'menuconfig' Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 53/84 RFC] package/erlang: include Erlang libraries from erlang's Config.in Yann E. MORIN
` (33 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
openocd has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/openocd/Config.in | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/package/openocd/Config.in b/package/openocd/Config.in
index d84aac1..212ce67 100644
--- a/package/openocd/Config.in
+++ b/package/openocd/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_OPENOCD
+menuconfig BR2_PACKAGE_OPENOCD
bool "openocd"
help
OpenOCD - Open On-Chip Debugger
@@ -7,8 +7,6 @@ config BR2_PACKAGE_OPENOCD
if BR2_PACKAGE_OPENOCD
-comment "Adapters"
-
config BR2_PACKAGE_OPENOCD_FTDI
bool "MPSSE mode of FTDI based devices"
select BR2_PACKAGE_LIBUSB
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 53/84 RFC] package/erlang: include Erlang libraries from erlang's Config.in
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (51 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 52/84 RFC] package/openocd: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 54/84 RFC] package/lua{, jit}: move inclusion of external libraries/modules Yann E. MORIN
` (32 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
erlang now has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/Config.in | 16 ----------------
package/erlang/Config.in | 17 ++++++++++++++++-
2 files changed, 16 insertions(+), 17 deletions(-)
diff --git a/package/Config.in b/package/Config.in
index 3edbf49..14c3c2b1 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -458,22 +458,6 @@ endmenu
menu "Interpreter languages and scripting"
source "package/enscript/Config.in"
source "package/erlang/Config.in"
-if BR2_PACKAGE_ERLANG
-menu "Erlang libraries/modules"
- source "package/erlang-goldrush/Config.in"
- source "package/erlang-lager/Config.in"
- source "package/erlang-p1-cache-tab/Config.in"
- source "package/erlang-p1-iconv/Config.in"
- source "package/erlang-p1-sip/Config.in"
- source "package/erlang-p1-stringprep/Config.in"
- source "package/erlang-p1-stun/Config.in"
- source "package/erlang-p1-tls/Config.in"
- source "package/erlang-p1-utils/Config.in"
- source "package/erlang-p1-xml/Config.in"
- source "package/erlang-p1-yaml/Config.in"
- source "package/erlang-p1-zlib/Config.in"
-endmenu
-endif
source "package/gauche/Config.in"
source "package/guile/Config.in"
source "package/haserl/Config.in"
diff --git a/package/erlang/Config.in b/package/erlang/Config.in
index 0ec01bb..f6da256 100644
--- a/package/erlang/Config.in
+++ b/package/erlang/Config.in
@@ -3,7 +3,7 @@ comment "erlang needs a toolchain w/ dynamic library"
depends on BR2_PACKAGE_LIBATOMIC_ARCH_SUPPORTS
depends on BR2_STATIC_LIBS
-config BR2_PACKAGE_ERLANG
+menuconfig BR2_PACKAGE_ERLANG
bool "erlang"
depends on BR2_USE_MMU # fork()
depends on !BR2_STATIC_LIBS
@@ -37,4 +37,19 @@ config BR2_PACKAGE_ERLANG_MEGACO
size so if you do not need it then it is recommended not to
enable it.
+comment "Erlang libraries/modules"
+
+source "package/erlang-goldrush/Config.in"
+source "package/erlang-lager/Config.in"
+source "package/erlang-p1-cache-tab/Config.in"
+source "package/erlang-p1-iconv/Config.in"
+source "package/erlang-p1-sip/Config.in"
+source "package/erlang-p1-stringprep/Config.in"
+source "package/erlang-p1-stun/Config.in"
+source "package/erlang-p1-tls/Config.in"
+source "package/erlang-p1-utils/Config.in"
+source "package/erlang-p1-xml/Config.in"
+source "package/erlang-p1-yaml/Config.in"
+source "package/erlang-p1-zlib/Config.in"
+
endif # BR2_PACKAGE_ERLANG
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 54/84 RFC] package/lua{, jit}: move inclusion of external libraries/modules
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (52 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 53/84 RFC] package/erlang: include Erlang libraries from erlang's Config.in Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 55/84 RFC] package/sqlite: use 'menuconfig' Yann E. MORIN
` (31 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
Introduce a Config.ext for external Lua external libraries/modules, that
both lua and luajit include from their respective sub-menus.
lua and luajit now have more than 5 options, so use a 'menuconfig' to
group the options in sub-menus.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/Config.in | 46 --------------------------------------------
package/lua/Config.ext | 49 +++++++++++++++++++++++++++++++++++++++++++++++
package/lua/Config.in | 4 +++-
package/luajit/Config.ext | 1 +
package/luajit/Config.in | 4 +++-
5 files changed, 56 insertions(+), 48 deletions(-)
create mode 100644 package/lua/Config.ext
create mode 120000 package/luajit/Config.ext
diff --git a/package/Config.in b/package/Config.in
index 14c3c2b1..ce148c0 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -466,52 +466,6 @@ menu "Interpreter languages and scripting"
source "package/lua/Config.in"
source "package/luainterpreter/Config.in"
source "package/luajit/Config.in"
-if BR2_PACKAGE_HAS_LUAINTERPRETER && !BR2_STATIC_LIBS
-# lua modules are dynamically loaded, so not available on static builds
-menu "Lua libraries/modules"
- source "package/cgilua/Config.in"
- source "package/copas/Config.in"
- source "package/cosmo/Config.in"
- source "package/coxpcall/Config.in"
- source "package/dado/Config.in"
- source "package/lbase64/Config.in"
- source "package/ljlinenoise/Config.in"
- source "package/ljsyscall/Config.in"
- source "package/lpeg/Config.in"
- source "package/lpty/Config.in"
- source "package/lrandom/Config.in"
- source "package/lsqlite3/Config.in"
- source "package/lua-cjson/Config.in"
- source "package/lua-coat/Config.in"
- source "package/lua-coatpersistent/Config.in"
- source "package/lua-csnappy/Config.in"
- source "package/lua-ev/Config.in"
- source "package/lua-iconv/Config.in"
- source "package/lua-messagepack/Config.in"
- source "package/lua-msgpack-native/Config.in"
- source "package/lua-periphery/Config.in"
- source "package/lua-testmore/Config.in"
- source "package/luabitop/Config.in"
- source "package/luacrypto/Config.in"
- source "package/luaexpat/Config.in"
- source "package/luaexpatutils/Config.in"
- source "package/luafilesystem/Config.in"
- source "package/luajson/Config.in"
- source "package/lualogging/Config.in"
- source "package/luaposix/Config.in"
- source "package/luasec/Config.in"
- source "package/luasocket/Config.in"
- source "package/luasql-sqlite3/Config.in"
- source "package/lunit/Config.in"
- source "package/luv/Config.in"
- source "package/luvi/Config.in"
- source "package/lzlib/Config.in"
- source "package/orbit/Config.in"
- source "package/rings/Config.in"
- source "package/wsapi/Config.in"
- source "package/xavante/Config.in"
-endmenu
-endif
source "package/lutok/Config.in"
source "package/micropython/Config.in"
source "package/micropython-lib/Config.in"
diff --git a/package/lua/Config.ext b/package/lua/Config.ext
new file mode 100644
index 0000000..4215e41
--- /dev/null
+++ b/package/lua/Config.ext
@@ -0,0 +1,49 @@
+# This file is included both from lua and luajit
+
+if !BR2_STATIC_LIBS
+
+comment "Lua libraries/modules"
+
+source "package/cgilua/Config.in"
+source "package/copas/Config.in"
+source "package/cosmo/Config.in"
+source "package/coxpcall/Config.in"
+source "package/dado/Config.in"
+source "package/lbase64/Config.in"
+source "package/ljlinenoise/Config.in"
+source "package/ljsyscall/Config.in"
+source "package/lpeg/Config.in"
+source "package/lpty/Config.in"
+source "package/lrandom/Config.in"
+source "package/lsqlite3/Config.in"
+source "package/lua-cjson/Config.in"
+source "package/lua-coat/Config.in"
+source "package/lua-coatpersistent/Config.in"
+source "package/lua-csnappy/Config.in"
+source "package/lua-ev/Config.in"
+source "package/lua-iconv/Config.in"
+source "package/lua-messagepack/Config.in"
+source "package/lua-msgpack-native/Config.in"
+source "package/lua-periphery/Config.in"
+source "package/lua-testmore/Config.in"
+source "package/luabitop/Config.in"
+source "package/luacrypto/Config.in"
+source "package/luaexpat/Config.in"
+source "package/luaexpatutils/Config.in"
+source "package/luafilesystem/Config.in"
+source "package/luajson/Config.in"
+source "package/lualogging/Config.in"
+source "package/luaposix/Config.in"
+source "package/luasec/Config.in"
+source "package/luasocket/Config.in"
+source "package/luasql-sqlite3/Config.in"
+source "package/lunit/Config.in"
+source "package/luv/Config.in"
+source "package/luvi/Config.in"
+source "package/lzlib/Config.in"
+source "package/orbit/Config.in"
+source "package/rings/Config.in"
+source "package/wsapi/Config.in"
+source "package/xavante/Config.in"
+
+endif # !static
diff --git a/package/lua/Config.in b/package/lua/Config.in
index d9cd1dd..65b624d 100644
--- a/package/lua/Config.in
+++ b/package/lua/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_LUA
+menuconfig BR2_PACKAGE_LUA
bool "lua"
select BR2_PACKAGE_HAS_LUAINTERPRETER
help
@@ -68,4 +68,6 @@ config BR2_PACKAGE_LUA_LINENOISE
endchoice
+source "package/lua/Config.ext"
+
endif
diff --git a/package/luajit/Config.ext b/package/luajit/Config.ext
new file mode 120000
index 0000000..62d6109
--- /dev/null
+++ b/package/luajit/Config.ext
@@ -0,0 +1 @@
+../lua/Config.ext
\ No newline at end of file
diff --git a/package/luajit/Config.in b/package/luajit/Config.in
index 8ce528b..4916b21 100644
--- a/package/luajit/Config.in
+++ b/package/luajit/Config.in
@@ -5,7 +5,7 @@ config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
BR2_powerpc || BR2_arm || BR2_armeb || \
((BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT)
-config BR2_PACKAGE_LUAJIT
+menuconfig BR2_PACKAGE_LUAJIT
bool "luajit"
select BR2_PACKAGE_HAS_LUAINTERPRETER
depends on !BR2_STATIC_LIBS # dlopen
@@ -32,6 +32,8 @@ config BR2_PACKAGE_PROVIDES_LUAINTERPRETER
config BR2_PACKAGE_LUAINTERPRETER_ABI_VERSION
default "5.1"
+source "package/luajit/Config.ext"
+
endif
comment "luajit needs a toolchain w/ dynamic library"
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 55/84 RFC] package/sqlite: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (53 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 54/84 RFC] package/lua{, jit}: move inclusion of external libraries/modules Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 56/84 RFC] package/cairo: " Yann E. MORIN
` (30 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
sqlite has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/sqlite/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/sqlite/Config.in b/package/sqlite/Config.in
index 7ea9eb1..605495f 100644
--- a/package/sqlite/Config.in
+++ b/package/sqlite/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_SQLITE
+menuconfig BR2_PACKAGE_SQLITE
bool "sqlite"
help
SQLite is a small C library that implements a self-contained,
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 56/84 RFC] package/cairo: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (54 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 55/84 RFC] package/sqlite: use 'menuconfig' Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 57/84 RFC] package/imlib2: " Yann E. MORIN
` (29 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
cairo has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/cairo/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/cairo/Config.in b/package/cairo/Config.in
index 38570d6..3525abc 100644
--- a/package/cairo/Config.in
+++ b/package/cairo/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_CAIRO
+menuconfig BR2_PACKAGE_CAIRO
bool "cairo"
depends on BR2_ARCH_HAS_ATOMICS
select BR2_PACKAGE_PIXMAN
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 57/84 RFC] package/imlib2: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (55 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 56/84 RFC] package/cairo: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 58/84 RFC] package/libiio: " Yann E. MORIN
` (28 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
imlib2 has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/imlib2/Config.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/imlib2/Config.in b/package/imlib2/Config.in
index 7aac074..0b10623 100644
--- a/package/imlib2/Config.in
+++ b/package/imlib2/Config.in
@@ -1,7 +1,7 @@
comment "imlib2 needs a toolchain w/ dynamic library"
depends on BR2_STATIC_LIBS
-config BR2_PACKAGE_IMLIB2
+menuconfig BR2_PACKAGE_IMLIB2
bool "imlib2"
select BR2_PACKAGE_FREETYPE
depends on !BR2_STATIC_LIBS # dlopen()
@@ -39,4 +39,5 @@ config BR2_PACKAGE_IMLIB2_X
depends on BR2_PACKAGE_XORG7
select BR2_PACKAGE_XLIB_LIBXEXT
select BR2_PACKAGE_XLIB_LIBX11
+
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 58/84 RFC] package/libiio: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (56 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 57/84 RFC] package/imlib2: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 59/84 RFC] package/flot: " Yann E. MORIN
` (27 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
libiio has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/libiio/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/libiio/Config.in b/package/libiio/Config.in
index 99da4c1..7112fc5 100644
--- a/package/libiio/Config.in
+++ b/package/libiio/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_LIBIIO
+menuconfig BR2_PACKAGE_LIBIIO
bool "libiio"
select BR2_PACKAGE_LIBIIO_LOCAL_BACKEND if !BR2_PACKAGE_LIBIIO_NETWORK_BACKEND
help
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 59/84 RFC] package/flot: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (57 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 58/84 RFC] package/libiio: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 60/84 RFC] package/boost: " Yann E. MORIN
` (26 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
flot has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/flot/Config.in | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/package/flot/Config.in b/package/flot/Config.in
index 4c0d3ec..0037ff2 100644
--- a/package/flot/Config.in
+++ b/package/flot/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_FLOT
+menuconfig BR2_PACKAGE_FLOT
bool "flot"
select BR2_PACKAGE_JQUERY
help
@@ -18,8 +18,6 @@ config BR2_PACKAGE_FLOT
if BR2_PACKAGE_FLOT
-comment "flot plugins"
-
config BR2_PACKAGE_FLOT_CANVAS
bool "canvas"
help
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 60/84 RFC] package/boost: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (58 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 59/84 RFC] package/flot: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 61/84 RFC] package/poco: " Yann E. MORIN
` (25 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
boost has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/boost/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/boost/Config.in b/package/boost/Config.in
index 03935e8..c000773 100644
--- a/package/boost/Config.in
+++ b/package/boost/Config.in
@@ -5,7 +5,7 @@ config BR2_PACKAGE_BOOST_ARCH_SUPPORTS
bool
default y if !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII
-config BR2_PACKAGE_BOOST
+menuconfig BR2_PACKAGE_BOOST
bool "boost"
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 61/84 RFC] package/poco: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (59 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 60/84 RFC] package/boost: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 62/84 RFC] package/ncurses: " Yann E. MORIN
` (24 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
poco has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/poco/Config.in | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/package/poco/Config.in b/package/poco/Config.in
index dfdc8d1..1e7ca21 100644
--- a/package/poco/Config.in
+++ b/package/poco/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_POCO
+menuconfig BR2_PACKAGE_POCO
bool "poco"
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_USE_WCHAR
@@ -15,8 +15,6 @@ config BR2_PACKAGE_POCO
if BR2_PACKAGE_POCO
-comment "poco components"
-
config BR2_PACKAGE_POCO_XML
bool "xml"
select BR2_PACKAGE_EXPAT
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 62/84 RFC] package/ncurses: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (60 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 61/84 RFC] package/poco: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 63/84 RFC] package/dovecot: " Yann E. MORIN
` (23 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
ncurses has 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/ncurses/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/ncurses/Config.in b/package/ncurses/Config.in
index 44713f9..0887b33 100644
--- a/package/ncurses/Config.in
+++ b/package/ncurses/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_NCURSES
+menuconfig BR2_PACKAGE_NCURSES
bool "ncurses"
help
The Ncurses (new curses) library is a free software emulation of
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 63/84 RFC] package/dovecot: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (61 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 62/84 RFC] package/ncurses: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 64/84 RFC] package/gnuradio: " Yann E. MORIN
` (22 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
dovecot has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/dovecot/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/dovecot/Config.in b/package/dovecot/Config.in
index 3baae6e..5b35286 100644
--- a/package/dovecot/Config.in
+++ b/package/dovecot/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_DOVECOT
+menuconfig BR2_PACKAGE_DOVECOT
bool "dovecot"
depends on !BR2_STATIC_LIBS
depends on BR2_USE_MMU # fork()
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 64/84 RFC] package/gnuradio: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (62 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 63/84 RFC] package/dovecot: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 65/84 RFC] package/gnuradio: split long omment Yann E. MORIN
` (21 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
gnuradio has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/gnuradio/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
index 603532c..f2c884b 100644
--- a/package/gnuradio/Config.in
+++ b/package/gnuradio/Config.in
@@ -4,7 +4,7 @@ comment "gnuradio needs a toolchain w/ C++, NPTL, wchar, dynamic library"
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
!BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
-config BR2_PACKAGE_GNURADIO
+menuconfig BR2_PACKAGE_GNURADIO
bool "gnuradio"
depends on BR2_INSTALL_LIBSTDCPP
depends on !BR2_STATIC_LIBS
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 65/84 RFC] package/gnuradio: split long omment
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (63 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 64/84 RFC] package/gnuradio: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2016-01-02 21:44 ` Arnout Vandecappelle
2016-01-11 7:42 ` gwenhael.goavec
2015-12-25 21:25 ` [Buildroot] [PATCH 66/84 RFC] package/connman: use 'menuconfig' Yann E. MORIN
` (20 subsequent siblings)
85 siblings, 2 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
It does not fit even is a wider-than-normal terminal.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/gnuradio/Config.in | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
index f2c884b..d502b06 100644
--- a/package/gnuradio/Config.in
+++ b/package/gnuradio/Config.in
@@ -58,8 +58,11 @@ config BR2_PACKAGE_GNURADIO_UTILS
help
Misc python utilities
-comment "gr-fft, -filter, -analog, -channels, -digital, -trellis, -pager depends fftw's single precision"
- depends on !BR2_PACKAGE_FFTW_PRECISION_SINGLE
+if !BR2_PACKAGE_FFTW_PRECISION_SINGLE
+comment "gr-fft, gr-filter, gr-analog, gr-channels,"
+comment "gr-digital, gr-trellis and gr-pager all"
+comment "depend on fftw's single precision"
+endif
if BR2_PACKAGE_FFTW_PRECISION_SINGLE
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 65/84 RFC] package/gnuradio: split long omment
2015-12-25 21:25 ` [Buildroot] [PATCH 65/84 RFC] package/gnuradio: split long omment Yann E. MORIN
@ 2016-01-02 21:44 ` Arnout Vandecappelle
2016-01-11 7:42 ` gwenhael.goavec
1 sibling, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2016-01-02 21:44 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:25, Yann E. MORIN wrote:
> It does not fit even is a wider-than-normal terminal.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/gnuradio/Config.in | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
> index f2c884b..d502b06 100644
> --- a/package/gnuradio/Config.in
> +++ b/package/gnuradio/Config.in
> @@ -58,8 +58,11 @@ config BR2_PACKAGE_GNURADIO_UTILS
> help
> Misc python utilities
>
> -comment "gr-fft, -filter, -analog, -channels, -digital, -trellis, -pager depends fftw's single precision"
> - depends on !BR2_PACKAGE_FFTW_PRECISION_SINGLE
> +if !BR2_PACKAGE_FFTW_PRECISION_SINGLE
> +comment "gr-fft, gr-filter, gr-analog, gr-channels,"
> +comment "gr-digital, gr-trellis and gr-pager all"
> +comment "depend on fftw's single precision"
This would perhaps be a good occasion to also correct the sentence into
something like "single precision implementation".
Also, it would be prettier if the excess space were filled up with spaces so
the *** lines up, like we do in Config.in.legacy.
Regards,
Arnout
> +endif
>
> if BR2_PACKAGE_FFTW_PRECISION_SINGLE
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 65/84 RFC] package/gnuradio: split long omment
2015-12-25 21:25 ` [Buildroot] [PATCH 65/84 RFC] package/gnuradio: split long omment Yann E. MORIN
2016-01-02 21:44 ` Arnout Vandecappelle
@ 2016-01-11 7:42 ` gwenhael.goavec
1 sibling, 0 replies; 134+ messages in thread
From: gwenhael.goavec @ 2016-01-11 7:42 UTC (permalink / raw)
To: buildroot
Hello,
Any news?
Gwen
On Fri, 25 Dec 2015 22:25:34 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> It does not fit even is a wider-than-normal terminal.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/gnuradio/Config.in | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
> index f2c884b..d502b06 100644
> --- a/package/gnuradio/Config.in
> +++ b/package/gnuradio/Config.in
> @@ -58,8 +58,11 @@ config BR2_PACKAGE_GNURADIO_UTILS
> help
> Misc python utilities
>
> -comment "gr-fft, -filter, -analog, -channels, -digital, -trellis,
> -pager depends fftw's single precision"
> - depends on !BR2_PACKAGE_FFTW_PRECISION_SINGLE
> +if !BR2_PACKAGE_FFTW_PRECISION_SINGLE
> +comment "gr-fft, gr-filter, gr-analog, gr-channels,"
> +comment "gr-digital, gr-trellis and gr-pager all"
> +comment "depend on fftw's single precision"
> +endif
>
> if BR2_PACKAGE_FFTW_PRECISION_SINGLE
>
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 66/84 RFC] package/connman: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (64 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 65/84 RFC] package/gnuradio: split long omment Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 67/84 RFC] package/dnsmasq: " Yann E. MORIN
` (19 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
connman has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/connman/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/connman/Config.in b/package/connman/Config.in
index 655db86..2434385 100644
--- a/package/connman/Config.in
+++ b/package/connman/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_CONNMAN
+menuconfig BR2_PACKAGE_CONNMAN
bool "connman"
select BR2_PACKAGE_DBUS
select BR2_PACKAGE_LIBGLIB2
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 67/84 RFC] package/dnsmasq: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (65 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 66/84 RFC] package/connman: use 'menuconfig' Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 68/84 RFC] package/dropbear: " Yann E. MORIN
` (18 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
dnsmasq has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/dnsmasq/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/dnsmasq/Config.in b/package/dnsmasq/Config.in
index b4f34b8..d78c0be 100644
--- a/package/dnsmasq/Config.in
+++ b/package/dnsmasq/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_DNSMASQ
+menuconfig BR2_PACKAGE_DNSMASQ
bool "dnsmasq"
help
A lightweight DNS and DHCP server. It is intended to provide
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 68/84 RFC] package/dropbear: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (66 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 67/84 RFC] package/dnsmasq: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 69/84 RFC] package/igh-ethercat: " Yann E. MORIN
` (17 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
dropbear has 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/dropbear/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/dropbear/Config.in b/package/dropbear/Config.in
index c14c654..6db549f 100644
--- a/package/dropbear/Config.in
+++ b/package/dropbear/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_DROPBEAR
+menuconfig BR2_PACKAGE_DROPBEAR
bool "dropbear"
select BR2_PACKAGE_ZLIB if !BR2_PACKAGE_DROPBEAR_SMALL
help
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 69/84 RFC] package/igh-ethercat: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (67 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 68/84 RFC] package/dropbear: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 70/84 RFC] package/ipsec-tools: " Yann E. MORIN
` (16 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
igh-ethercat has 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/igh-ethercat/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/igh-ethercat/Config.in b/package/igh-ethercat/Config.in
index e600ef5..696e550 100644
--- a/package/igh-ethercat/Config.in
+++ b/package/igh-ethercat/Config.in
@@ -1,7 +1,7 @@
comment "igh-ethercat needs a Linux kernel to be built"
depends on !BR2_LINUX_KERNEL
-config BR2_PACKAGE_IGH_ETHERCAT
+menuconfig BR2_PACKAGE_IGH_ETHERCAT
bool "igh-ethercat"
depends on BR2_LINUX_KERNEL
help
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 70/84 RFC] package/ipsec-tools: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (68 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 69/84 RFC] package/igh-ethercat: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 71/84 RFC] package/lftp: " Yann E. MORIN
` (15 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
ipsec-tools has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/ipsec-tools/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/ipsec-tools/Config.in b/package/ipsec-tools/Config.in
index 4af4095..7309e8d 100644
--- a/package/ipsec-tools/Config.in
+++ b/package/ipsec-tools/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_IPSEC_TOOLS
+menuconfig BR2_PACKAGE_IPSEC_TOOLS
bool "ipsec-tools"
select BR2_PACKAGE_OPENSSL
select BR2_PACKAGE_FLEX
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 71/84 RFC] package/lftp: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (69 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 70/84 RFC] package/ipsec-tools: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 72/84 RFC] package/lighttpd: " Yann E. MORIN
` (14 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
lftp has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/lftp/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/lftp/Config.in b/package/lftp/Config.in
index fb4ac13..b83a256 100644
--- a/package/lftp/Config.in
+++ b/package/lftp/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_LFTP
+menuconfig BR2_PACKAGE_LFTP
bool "lftp"
depends on BR2_USE_WCHAR
depends on BR2_INSTALL_LIBSTDCPP
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 72/84 RFC] package/lighttpd: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (70 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 71/84 RFC] package/lftp: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 73/84 RFC] package/ndisc6: " Yann E. MORIN
` (13 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
lighttpd has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/lighttpd/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/lighttpd/Config.in b/package/lighttpd/Config.in
index f62ccb9..6672ec1 100644
--- a/package/lighttpd/Config.in
+++ b/package/lighttpd/Config.in
@@ -2,7 +2,7 @@ comment "lighttpd needs a toolchain w/ dynamic library"
depends on BR2_USE_MMU
depends on BR2_STATIC_LIBS
-config BR2_PACKAGE_LIGHTTPD
+menuconfig BR2_PACKAGE_LIGHTTPD
bool "lighttpd"
depends on BR2_USE_MMU # fork()
depends on !BR2_STATIC_LIBS
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 73/84 RFC] package/ndisc6: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (71 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 72/84 RFC] package/lighttpd: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 74/84 RFC] package/netsnmp: " Yann E. MORIN
` (12 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
ndisc6 has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/ndisc6/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/ndisc6/Config.in b/package/ndisc6/Config.in
index 321bfbc..966ec91 100644
--- a/package/ndisc6/Config.in
+++ b/package/ndisc6/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_NDISC6
+menuconfig BR2_PACKAGE_NDISC6
bool "ndisc6 tools"
depends on BR2_USE_MMU # fork()
select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 74/84 RFC] package/netsnmp: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (72 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 73/84 RFC] package/ndisc6: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 75/84 RFC] package/ntp: " Yann E. MORIN
` (11 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
netsnmp has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/netsnmp/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/netsnmp/Config.in b/package/netsnmp/Config.in
index 57cc6b9..3cef6f3 100644
--- a/package/netsnmp/Config.in
+++ b/package/netsnmp/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_NETSNMP
+menuconfig BR2_PACKAGE_NETSNMP
bool "netsnmp"
depends on BR2_USE_MMU # fork()
help
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 75/84 RFC] package/ntp: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (73 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 74/84 RFC] package/netsnmp: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 76/84 RFC] package/openobex: " Yann E. MORIN
` (10 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
ntp has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/ntp/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/ntp/Config.in b/package/ntp/Config.in
index 1763225..2b8ecc9 100644
--- a/package/ntp/Config.in
+++ b/package/ntp/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_NTP
+menuconfig BR2_PACKAGE_NTP
bool "ntp"
select BR2_PACKAGE_LIBEVENT
help
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 76/84 RFC] package/openobex: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (74 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 75/84 RFC] package/ntp: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 77/84 RFC] package/quagga: " Yann E. MORIN
` (9 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
openobex has 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/openobex/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/openobex/Config.in b/package/openobex/Config.in
index 5f606fe..d2fd95f 100644
--- a/package/openobex/Config.in
+++ b/package/openobex/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_OPENOBEX
+menuconfig BR2_PACKAGE_OPENOBEX
bool "openobex"
help
Free open source implementation of the Object Exchange (OBEX)
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 77/84 RFC] package/quagga: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (75 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 76/84 RFC] package/openobex: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 78/84 RFC] package/transmission: " Yann E. MORIN
` (8 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
quagga has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/quagga/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/quagga/Config.in b/package/quagga/Config.in
index 89ff6f2..9a23947 100644
--- a/package/quagga/Config.in
+++ b/package/quagga/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_QUAGGA
+menuconfig BR2_PACKAGE_QUAGGA
bool "quagga"
depends on BR2_USE_MMU # fork()
help
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 78/84 RFC] package/transmission: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (76 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 77/84 RFC] package/quagga: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 79/84 RFC] package/wpa-supplicant: " Yann E. MORIN
` (7 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
transmission has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/transmission/Config.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/transmission/Config.in b/package/transmission/Config.in
index b47c36f..92928c7 100644
--- a/package/transmission/Config.in
+++ b/package/transmission/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_TRANSMISSION
+menuconfig BR2_PACKAGE_TRANSMISSION
bool "transmission"
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_USE_MMU # fork()
@@ -45,6 +45,7 @@ config BR2_PACKAGE_TRANSMISSION_GTK
comment "transmission-gtk needs a toolchain w/ locale"
depends on BR2_PACKAGE_LIBGTK2 && !BR2_ENABLE_LOCALE
+
endif
comment "transmission needs a toolchain w/ threads"
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 79/84 RFC] package/wpa-supplicant: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (77 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 78/84 RFC] package/transmission: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 80/84 RFC] boot/at91bootstrap3: " Yann E. MORIN
` (6 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
wpa-supplicant has more than 5 options, so use a 'menuconfig' to group the
options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/wpa_supplicant/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in
index f4c4167..26009c6 100644
--- a/package/wpa_supplicant/Config.in
+++ b/package/wpa_supplicant/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_WPA_SUPPLICANT
+menuconfig BR2_PACKAGE_WPA_SUPPLICANT
bool "wpa_supplicant"
depends on BR2_USE_MMU # fork()
help
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 80/84 RFC] boot/at91bootstrap3: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (78 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 79/84 RFC] package/wpa-supplicant: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2016-01-02 21:56 ` Arnout Vandecappelle
2015-12-25 21:25 ` [Buildroot] [PATCH 81/84 RFC] boot/barebox: " Yann E. MORIN
` (5 subsequent siblings)
85 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
at91bootstrap3 has more than 5 options, so use a 'menuconfig' to
group the options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
boot/at91bootstrap3/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/boot/at91bootstrap3/Config.in b/boot/at91bootstrap3/Config.in
index b8ebe80..6f4050c 100644
--- a/boot/at91bootstrap3/Config.in
+++ b/boot/at91bootstrap3/Config.in
@@ -1,4 +1,4 @@
-config BR2_TARGET_AT91BOOTSTRAP3
+menuconfig BR2_TARGET_AT91BOOTSTRAP3
depends on BR2_arm926t || BR2_cortex_a5
bool "AT91 Bootstrap 3"
help
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 80/84 RFC] boot/at91bootstrap3: use 'menuconfig'
2015-12-25 21:25 ` [Buildroot] [PATCH 80/84 RFC] boot/at91bootstrap3: " Yann E. MORIN
@ 2016-01-02 21:56 ` Arnout Vandecappelle
0 siblings, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2016-01-02 21:56 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:25, Yann E. MORIN wrote:
> at91bootstrap3 has more than 5 options, so use a 'menuconfig' to
> group the options in an sub-menu.
It's a bit weird that at91bootstrap3 has a menu and at91bootstrap doesn't, but OK.
Regards,
Arnout
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> boot/at91bootstrap3/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/boot/at91bootstrap3/Config.in b/boot/at91bootstrap3/Config.in
> index b8ebe80..6f4050c 100644
> --- a/boot/at91bootstrap3/Config.in
> +++ b/boot/at91bootstrap3/Config.in
> @@ -1,4 +1,4 @@
> -config BR2_TARGET_AT91BOOTSTRAP3
> +menuconfig BR2_TARGET_AT91BOOTSTRAP3
> depends on BR2_arm926t || BR2_cortex_a5
> bool "AT91 Bootstrap 3"
> help
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 81/84 RFC] boot/barebox: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (79 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 80/84 RFC] boot/at91bootstrap3: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 82/84 RFC] boot/grub: " Yann E. MORIN
` (4 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
barebox has more than 5 options, so use a 'menuconfig' to
group the options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
boot/barebox/Config.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/boot/barebox/Config.in b/boot/barebox/Config.in
index 207d9b2..f48ddc4 100644
--- a/boot/barebox/Config.in
+++ b/boot/barebox/Config.in
@@ -1,4 +1,4 @@
-config BR2_TARGET_BAREBOX
+menuconfig BR2_TARGET_BAREBOX
bool "Barebox"
help
The Barebox bootloader, formerly known as U-Boot v2.
@@ -6,6 +6,7 @@ config BR2_TARGET_BAREBOX
http://www.barebox.org
if BR2_TARGET_BAREBOX
+
choice
prompt "version"
help
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 82/84 RFC] boot/grub: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (80 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 81/84 RFC] boot/barebox: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2016-01-02 22:09 ` Arnout Vandecappelle
2015-12-25 21:25 ` [Buildroot] [PATCH 83/84 RFC] boot/mxs-bootlets: " Yann E. MORIN
` (3 subsequent siblings)
85 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
grub has more than 5 options, so use a 'menuconfig' to
group the options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
boot/grub/Config.in | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/boot/grub/Config.in b/boot/grub/Config.in
index 4db8642..3ae688f 100644
--- a/boot/grub/Config.in
+++ b/boot/grub/Config.in
@@ -1,4 +1,4 @@
-config BR2_TARGET_GRUB
+menuconfig BR2_TARGET_GRUB
bool "grub"
depends on BR2_i386 || BR2_x86_64
select BR2_HOSTARCH_NEEDS_IA32_COMPILER
@@ -52,7 +52,7 @@ config BR2_TARGET_GRUB_DISKLESS
help
enable diskless support
-menu "filesystem drivers"
+comment "Filesystem drivers"
config BR2_TARGET_GRUB_FS_EXT2
bool "ext2"
@@ -86,9 +86,7 @@ config BR2_TARGET_GRUB_FS_XFS
help
Enable support for the XFS filesystem in Grub.
-endmenu
-
-menu "network drivers"
+comment "Network drivers"
config BR2_TARGET_GRUB_3c595
bool "3Com595 driver"
@@ -195,6 +193,4 @@ config BR2_TARGET_GRUB_w89c840
help
enable Winbond W89c840 driver
-endmenu
-
endif # BR2_TARGET_GRUB
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 82/84 RFC] boot/grub: use 'menuconfig'
2015-12-25 21:25 ` [Buildroot] [PATCH 82/84 RFC] boot/grub: " Yann E. MORIN
@ 2016-01-02 22:09 ` Arnout Vandecappelle
0 siblings, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2016-01-02 22:09 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:25, Yann E. MORIN wrote:
> grub has more than 5 options, so use a 'menuconfig' to
> group the options in an sub-menu.
Again, weird that grub has a menu and grub2 doesn't. Perhaps we should give
grub2 a menu as well.
Regards,
Arnout
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> boot/grub/Config.in | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/boot/grub/Config.in b/boot/grub/Config.in
> index 4db8642..3ae688f 100644
> --- a/boot/grub/Config.in
> +++ b/boot/grub/Config.in
> @@ -1,4 +1,4 @@
> -config BR2_TARGET_GRUB
> +menuconfig BR2_TARGET_GRUB
> bool "grub"
> depends on BR2_i386 || BR2_x86_64
> select BR2_HOSTARCH_NEEDS_IA32_COMPILER
> @@ -52,7 +52,7 @@ config BR2_TARGET_GRUB_DISKLESS
> help
> enable diskless support
>
> -menu "filesystem drivers"
> +comment "Filesystem drivers"
>
> config BR2_TARGET_GRUB_FS_EXT2
> bool "ext2"
> @@ -86,9 +86,7 @@ config BR2_TARGET_GRUB_FS_XFS
> help
> Enable support for the XFS filesystem in Grub.
>
> -endmenu
> -
> -menu "network drivers"
> +comment "Network drivers"
>
> config BR2_TARGET_GRUB_3c595
> bool "3Com595 driver"
> @@ -195,6 +193,4 @@ config BR2_TARGET_GRUB_w89c840
> help
> enable Winbond W89c840 driver
>
> -endmenu
> -
> endif # BR2_TARGET_GRUB
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 83/84 RFC] boot/mxs-bootlets: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (81 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 82/84 RFC] boot/grub: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-25 21:25 ` [Buildroot] [PATCH 84/84 RFC] boot/uboot: " Yann E. MORIN
` (2 subsequent siblings)
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
mxs-bootlets has 5 options, so use a 'menuconfig' to
group the options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
boot/mxs-bootlets/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/boot/mxs-bootlets/Config.in b/boot/mxs-bootlets/Config.in
index 4bb07a0..2712d8d 100644
--- a/boot/mxs-bootlets/Config.in
+++ b/boot/mxs-bootlets/Config.in
@@ -1,4 +1,4 @@
-config BR2_TARGET_MXS_BOOTLETS
+menuconfig BR2_TARGET_MXS_BOOTLETS
bool "mxs-bootlets"
depends on BR2_arm
help
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 84/84 RFC] boot/uboot: use 'menuconfig'
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (82 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 83/84 RFC] boot/mxs-bootlets: " Yann E. MORIN
@ 2015-12-25 21:25 ` Yann E. MORIN
2015-12-28 16:59 ` [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Thomas Petazzoni
2015-12-31 0:23 ` Arnout Vandecappelle
85 siblings, 0 replies; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-25 21:25 UTC (permalink / raw)
To: buildroot
uboot has more than 5 options, so use a 'menuconfig' to
group the options in an sub-menu.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
boot/uboot/Config.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
index b75006b..a4b2372 100644
--- a/boot/uboot/Config.in
+++ b/boot/uboot/Config.in
@@ -1,9 +1,10 @@
-config BR2_TARGET_UBOOT
+menuconfig BR2_TARGET_UBOOT
bool "U-Boot"
help
Build "Das U-Boot" Boot Monitor
if BR2_TARGET_UBOOT
+
choice
prompt "Build system"
default BR2_TARGET_UBOOT_BUILD_SYSTEM_LEGACY
--
1.9.1
^ permalink raw reply related [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig)
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (83 preceding siblings ...)
2015-12-25 21:25 ` [Buildroot] [PATCH 84/84 RFC] boot/uboot: " Yann E. MORIN
@ 2015-12-28 16:59 ` Thomas Petazzoni
2015-12-31 0:23 ` Arnout Vandecappelle
85 siblings, 0 replies; 134+ messages in thread
From: Thomas Petazzoni @ 2015-12-28 16:59 UTC (permalink / raw)
To: buildroot
Yann,
On Fri, 25 Dec 2015 22:25:48 +0100, Yann E. MORIN wrote:
> - patches 1-6: re-order comments to fix indentation of sub-options;
> this can probably be applied without too much discussion, as it is
> really only a cleanup;
I've applied those 6 initial patches, after fixing some really minor
typos in the commit log (mainly "lie" -> "like").
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig)
2015-12-25 21:25 [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Yann E. MORIN
` (84 preceding siblings ...)
2015-12-28 16:59 ` [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig) Thomas Petazzoni
@ 2015-12-31 0:23 ` Arnout Vandecappelle
2015-12-31 17:28 ` Yann E. MORIN
85 siblings, 1 reply; 134+ messages in thread
From: Arnout Vandecappelle @ 2015-12-31 0:23 UTC (permalink / raw)
To: buildroot
On 25-12-15 22:25, Yann E. MORIN wrote:
> Hello All!
>
> This RFC series is a proposal to cleanup the layout of the menuconfig
> UI. Although it looks to be pretty long (84 patches), it really is only
> three different changes :
>
> - patches 1-6: re-order comments to fix indentation of sub-options;
> this can probably be applied without too much discussion, as it is
> really only a cleanup;
>
> - patches 7-35: changes use of 'config'+'menu' into a 'menuconfig'
> (the Kconfig keywords) to automatically arrange the sub-options into
> sub-menus;
>
> - patches 36-84: document that packages with 5 or more options should
> use sub-menus (with 'menuconfig') to store their sub-options
> (patches 36-39); it then changes a lot of packages accordingly
> (patches 40-84).
I reviewed and tested patches 7-39, you can add my
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
to the ones where I didn't have comments. I didn't bother adding Acks everywhere
because it's anyway not going to be picked up by Patchwork.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread* [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig)
2015-12-31 0:23 ` Arnout Vandecappelle
@ 2015-12-31 17:28 ` Yann E. MORIN
2016-01-02 1:47 ` Arnout Vandecappelle
0 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2015-12-31 17:28 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2015-12-31 01:23 +0100, Arnout Vandecappelle spake thusly:
> On 25-12-15 22:25, Yann E. MORIN wrote:
> > Hello All!
> >
> > This RFC series is a proposal to cleanup the layout of the menuconfig
> > UI. Although it looks to be pretty long (84 patches), it really is only
> > three different changes :
> >
> > - patches 1-6: re-order comments to fix indentation of sub-options;
> > this can probably be applied without too much discussion, as it is
> > really only a cleanup;
> >
> > - patches 7-35: changes use of 'config'+'menu' into a 'menuconfig'
> > (the Kconfig keywords) to automatically arrange the sub-options into
> > sub-menus;
> >
> > - patches 36-84: document that packages with 5 or more options should
> > use sub-menus (with 'menuconfig') to store their sub-options
> > (patches 36-39); it then changes a lot of packages accordingly
> > (patches 40-84).
>
> I reviewed and tested patches 7-39, you can add my
>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Thank you for the review. I know by experience that reviewing long
series can be tedious, so: thanks!
> to the ones where I didn't have comments. I didn't bother adding Acks everywhere
> because it's anyway not going to be picked up by Patchwork.
Yep, I sent the series as an RFC, just to "feel the temperature of the
water".
Thanks! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig)
2015-12-31 17:28 ` Yann E. MORIN
@ 2016-01-02 1:47 ` Arnout Vandecappelle
2016-01-02 11:09 ` Yann E. MORIN
0 siblings, 1 reply; 134+ messages in thread
From: Arnout Vandecappelle @ 2016-01-02 1:47 UTC (permalink / raw)
To: buildroot
On 31-12-15 18:28, Yann E. MORIN wrote:
> Arnout, All,
>
> On 2015-12-31 01:23 +0100, Arnout Vandecappelle spake thusly:
>> On 25-12-15 22:25, Yann E. MORIN wrote:
>>> Hello All!
>>>
>>> This RFC series is a proposal to cleanup the layout of the menuconfig
>>> UI. Although it looks to be pretty long (84 patches), it really is only
>>> three different changes :
>>>
>>> - patches 1-6: re-order comments to fix indentation of sub-options;
>>> this can probably be applied without too much discussion, as it is
>>> really only a cleanup;
>>>
>>> - patches 7-35: changes use of 'config'+'menu' into a 'menuconfig'
>>> (the Kconfig keywords) to automatically arrange the sub-options into
>>> sub-menus;
>>>
>>> - patches 36-84: document that packages with 5 or more options should
>>> use sub-menus (with 'menuconfig') to store their sub-options
>>> (patches 36-39); it then changes a lot of packages accordingly
>>> (patches 40-84).
>>
>> I reviewed and tested patches 7-39, you can add my
>>
>> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> Thank you for the review. I know by experience that reviewing long
> series can be tedious, so: thanks!
You can now ack up to and including 58 (libiio).
>
>> to the ones where I didn't have comments. I didn't bother adding Acks everywhere
>> because it's anyway not going to be picked up by Patchwork.
>
> Yep, I sent the series as an RFC, just to "feel the temperature of the
> water".
For actual submission, perhaps squash a little here and there. Although in fact
they're not really squashable, except perhaps 41-84 but that would be a pretty
big patch.
Regards,
Arnout
>
> Thanks! :-)
>
> Regards,
> Yann E. MORIN.
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig)
2016-01-02 1:47 ` Arnout Vandecappelle
@ 2016-01-02 11:09 ` Yann E. MORIN
2016-01-02 22:11 ` Arnout Vandecappelle
0 siblings, 1 reply; 134+ messages in thread
From: Yann E. MORIN @ 2016-01-02 11:09 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2016-01-02 02:47 +0100, Arnout Vandecappelle spake thusly:
> On 31-12-15 18:28, Yann E. MORIN wrote:
> > On 2015-12-31 01:23 +0100, Arnout Vandecappelle spake thusly:
> >> On 25-12-15 22:25, Yann E. MORIN wrote:
> >>> Hello All!
> >>>
> >>> This RFC series is a proposal to cleanup the layout of the menuconfig
> >>> UI. Although it looks to be pretty long (84 patches), it really is only
> >>> three different changes :
> >>>
> >>> - patches 1-6: re-order comments to fix indentation of sub-options;
> >>> this can probably be applied without too much discussion, as it is
> >>> really only a cleanup;
> >>>
> >>> - patches 7-35: changes use of 'config'+'menu' into a 'menuconfig'
> >>> (the Kconfig keywords) to automatically arrange the sub-options into
> >>> sub-menus;
> >>>
> >>> - patches 36-84: document that packages with 5 or more options should
> >>> use sub-menus (with 'menuconfig') to store their sub-options
> >>> (patches 36-39); it then changes a lot of packages accordingly
> >>> (patches 40-84).
> >>
> >> I reviewed and tested patches 7-39, you can add my
> >>
> >> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> >
> > Thank you for the review. I know by experience that reviewing long
> > series can be tedious, so: thanks!
>
> You can now ack up to and including 58 (libiio).
Great! Thank you very much for having had another look! :-)
(I'll add your ACKs after fixing the little nits here and there you
already commented on, like comments to drop...)
> >> to the ones where I didn't have comments. I didn't bother adding Acks everywhere
> >> because it's anyway not going to be picked up by Patchwork.
> >
> > Yep, I sent the series as an RFC, just to "feel the temperature of the
> > water".
>
> For actual submission, perhaps squash a little here and there. Although in fact
> they're not really squashable, except perhaps 41-84 but that would be a pretty
> big patch.
Well, and what about my commit count? ;-]
But yeah, I don't think we could squash it, at least during the review. I
think it is easier to review a lot of little patches rather than a bit
one even if the changes are simple.
Thanks!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 134+ messages in thread
* [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig)
2016-01-02 11:09 ` Yann E. MORIN
@ 2016-01-02 22:11 ` Arnout Vandecappelle
0 siblings, 0 replies; 134+ messages in thread
From: Arnout Vandecappelle @ 2016-01-02 22:11 UTC (permalink / raw)
To: buildroot
On 02-01-16 12:09, Yann E. MORIN wrote:
> Arnout, All,
>
> On 2016-01-02 02:47 +0100, Arnout Vandecappelle spake thusly:
>> On 31-12-15 18:28, Yann E. MORIN wrote:
>>> On 2015-12-31 01:23 +0100, Arnout Vandecappelle spake thusly:
>>>> On 25-12-15 22:25, Yann E. MORIN wrote:
>>>>> Hello All!
>>>>>
>>>>> This RFC series is a proposal to cleanup the layout of the menuconfig
>>>>> UI. Although it looks to be pretty long (84 patches), it really is only
>>>>> three different changes :
>>>>>
>>>>> - patches 1-6: re-order comments to fix indentation of sub-options;
>>>>> this can probably be applied without too much discussion, as it is
>>>>> really only a cleanup;
>>>>>
>>>>> - patches 7-35: changes use of 'config'+'menu' into a 'menuconfig'
>>>>> (the Kconfig keywords) to automatically arrange the sub-options into
>>>>> sub-menus;
>>>>>
>>>>> - patches 36-84: document that packages with 5 or more options should
>>>>> use sub-menus (with 'menuconfig') to store their sub-options
>>>>> (patches 36-39); it then changes a lot of packages accordingly
>>>>> (patches 40-84).
>>>>
>>>> I reviewed and tested patches 7-39, you can add my
>>>>
>>>> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>>>
>>> Thank you for the review. I know by experience that reviewing long
>>> series can be tedious, so: thanks!
>>
>> You can now ack up to and including 58 (libiio).
>
> Great! Thank you very much for having had another look! :-)
>
> (I'll add your ACKs after fixing the little nits here and there you
> already commented on, like comments to drop...)
>
And finally, for patches 59-84:
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Thanks for this series, Yann!
Regards,
Arnout
>>>> to the ones where I didn't have comments. I didn't bother adding Acks everywhere
>>>> because it's anyway not going to be picked up by Patchwork.
>>>
>>> Yep, I sent the series as an RFC, just to "feel the temperature of the
>>> water".
>>
>> For actual submission, perhaps squash a little here and there. Although in fact
>> they're not really squashable, except perhaps 41-84 but that would be a pretty
>> big patch.
>
> Well, and what about my commit count? ;-]
>
> But yeah, I don't think we could squash it, at least during the review. I
> think it is easier to review a lot of little patches rather than a bit
> one even if the changes are simple.
>
> Thanks!
>
> Regards,
> Yann E. MORIN.
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 134+ messages in thread