[Buildroot] [PATCH 1/2] Disable gcc-4.8.x + binutils-2.26 + MIPS combination

[Buildroot] [PATCH 1/2] Disable gcc-4.8.x + binutils-2.26 + MIPS combination

[Vicente Olivert Riera]

For the same reason as we disabled it for binutils-2.25 before.

See 2fda0dd7d491e6e926ace1cd09ad2fb241356232 for details.

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/gcc/Config.in.host | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host
index 4845708..513899e 100644
--- a/package/gcc/Config.in.host
+++ b/package/gcc/Config.in.host
@@ -42,8 +42,9 @@ choice
 		depends on !BR2_cortex_a12 && !BR2_cortex_a17
 		# Broken or unsupported PPC cores
 		depends on !BR2_powerpc_power8
-		# gcc-4.8.x + binutils-2.25 is broken for MIPS
-		depends on !((BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el) && BR2_BINUTILS_VERSION_2_25_X)
+		# gcc-4.8.x + binutils >= 2.25 is broken for MIPS
+		depends on !((BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el) && \
+			   (BR2_BINUTILS_VERSION_2_25_X || BR2_BINUTILS_VERSION_2_26_X))
 		# Unsupported for MIPS R6
 		depends on !BR2_mips_32r6 && !BR2_mips_64r6
 		select BR2_GCC_NEEDS_MPC
-- 
2.4.10

[Buildroot] [PATCH 2/2] valgrind: disable for MIPS soft-float when using binutils >= 2.25

[Vicente Olivert Riera]

As stated here [1], recent changes on the MIPS binutils sources have
made it necessary for GCC to pass the -msoft-float to the assembler. Due
to that, valgrind fails to build for MIPS soft-float when using a
version of GCC >= 4.9 and binutils >= 2.25 because its using some
hard-float instructions.

The combination of GCC-4.8.x and binutils >= 2.25 is not possible as its
disabled in package/gcc/Config.in.host.

1: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg00905.html

Fixes:
  http://autobuild.buildroot.net/results/5f5/5f576c7f8d56058a19ed0e7ff4b1ec620bcafb65/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/valgrind/Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
index 21b2608..c9c71a6 100644
--- a/package/valgrind/Config.in
+++ b/package/valgrind/Config.in
@@ -8,6 +8,8 @@ config BR2_PACKAGE_VALGRIND
 		   BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
 		   BR2_x86_64
 	depends on !BR2_STATIC_LIBS
+	depends on !(BR2_MIPS_SOFT_FLOAT && (BR2_BINUTILS_VERSION_2_25_X || \
+		   BR2_BINUTILS_VERSION_2_26_X))
 	help
 	  Tool for debugging and profiling Linux programs.
 
-- 
2.4.10

[Buildroot] [PATCH 2/2] valgrind: disable for MIPS soft-float when using binutils >= 2.25

[Thomas Petazzoni]

Dear Vicente Olivert Riera,

On Tue, 15 Mar 2016 11:28:30 +0000, Vicente Olivert Riera wrote:
> As stated here [1], recent changes on the MIPS binutils sources have
> made it necessary for GCC to pass the -msoft-float to the assembler. Due
> to that, valgrind fails to build for MIPS soft-float when using a
> version of GCC >= 4.9 and binutils >= 2.25 because its using some
> hard-float instructions.

So I think we should just add "depends on !BR2_MIPS_SOFT_FLOAT.

If your use case is broken with the more recent versions of the tools,
and will continue to be broken for the newer versions of them, we
should IMO just disable completely the support on MIPS soft-float.

Of course, that's my own opinion, others might disagree.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 2/2] valgrind: disable for MIPS soft-float when using binutils >= 2.25

[Waldemar Brodkorb]

Hi,
Vicente Olivert Riera wrote,

> As stated here [1], recent changes on the MIPS binutils sources have
> made it necessary for GCC to pass the -msoft-float to the assembler. Due
> to that, valgrind fails to build for MIPS soft-float when using a
> version of GCC >= 4.9 and binutils >= 2.25 because its using some
> hard-float instructions.
> 
> The combination of GCC-4.8.x and binutils >= 2.25 is not possible as its
> disabled in package/gcc/Config.in.host.
> 
> 1: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg00905.html
> 
> Fixes:
>   http://autobuild.buildroot.net/results/5f5/5f576c7f8d56058a19ed0e7ff4b1ec620bcafb65/
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  package/valgrind/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
> index 21b2608..c9c71a6 100644
> --- a/package/valgrind/Config.in
> +++ b/package/valgrind/Config.in
> @@ -8,6 +8,8 @@ config BR2_PACKAGE_VALGRIND
>  		   BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
>  		   BR2_x86_64
>  	depends on !BR2_STATIC_LIBS
> +	depends on !(BR2_MIPS_SOFT_FLOAT && (BR2_BINUTILS_VERSION_2_25_X || \
> +		   BR2_BINUTILS_VERSION_2_26_X))

I would rather like to come up with a fix for valgrind in the next
days. Some parts are in svn trunk and need to be backported. 
Some parts I will use from OpenWrt and a small patch from me.

I cook up a patch soon.

best regards
 Waldemar

[Buildroot] [PATCH 2/2] valgrind: disable for MIPS soft-float when using binutils >= 2.25

[Waldemar Brodkorb]

Hi,
Waldemar Brodkorb wrote,

> Hi,
> Vicente Olivert Riera wrote,
> 
> > As stated here [1], recent changes on the MIPS binutils sources have
> > made it necessary for GCC to pass the -msoft-float to the assembler. Due
> > to that, valgrind fails to build for MIPS soft-float when using a
> > version of GCC >= 4.9 and binutils >= 2.25 because its using some
> > hard-float instructions.
> > 
> > The combination of GCC-4.8.x and binutils >= 2.25 is not possible as its
> > disabled in package/gcc/Config.in.host.
> > 
> > 1: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg00905.html
> > 
> > Fixes:
> >   http://autobuild.buildroot.net/results/5f5/5f576c7f8d56058a19ed0e7ff4b1ec620bcafb65/
> > 
> > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> > ---
> >  package/valgrind/Config.in | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
> > index 21b2608..c9c71a6 100644
> > --- a/package/valgrind/Config.in
> > +++ b/package/valgrind/Config.in
> > @@ -8,6 +8,8 @@ config BR2_PACKAGE_VALGRIND
> >  		   BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
> >  		   BR2_x86_64
> >  	depends on !BR2_STATIC_LIBS
> > +	depends on !(BR2_MIPS_SOFT_FLOAT && (BR2_BINUTILS_VERSION_2_25_X || \
> > +		   BR2_BINUTILS_VERSION_2_26_X))
> 
> I would rather like to come up with a fix for valgrind in the next
> days. Some parts are in svn trunk and need to be backported. 
> Some parts I will use from OpenWrt and a small patch from me.
> 
> I cook up a patch soon.

Okay, I give up for now. I even can't make valgrind work for mips
hard-float combo. Still investigating, but it might take longer.

mips64 seems broken, too. Better disable for now.

best regards
 Waldemar

[Buildroot] [PATCH 1/2] Disable gcc-4.8.x + binutils-2.26 + MIPS combination

[Thomas Petazzoni]

Vicente,

On Tue, 15 Mar 2016 11:28:29 +0000, Vicente Olivert Riera wrote:
> For the same reason as we disabled it for binutils-2.25 before.
> 
> See 2fda0dd7d491e6e926ace1cd09ad2fb241356232 for details.
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  package/gcc/Config.in.host | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host
> index 4845708..513899e 100644
> --- a/package/gcc/Config.in.host
> +++ b/package/gcc/Config.in.host
> @@ -42,8 +42,9 @@ choice
>  		depends on !BR2_cortex_a12 && !BR2_cortex_a17
>  		# Broken or unsupported PPC cores
>  		depends on !BR2_powerpc_power8
> -		# gcc-4.8.x + binutils-2.25 is broken for MIPS
> -		depends on !((BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el) && BR2_BINUTILS_VERSION_2_25_X)
> +		# gcc-4.8.x + binutils >= 2.25 is broken for MIPS
> +		depends on !((BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el) && \
> +			   (BR2_BINUTILS_VERSION_2_25_X || BR2_BINUTILS_VERSION_2_26_X))

If neither binutils 2.25 nor binutils 2.26 are working, which binutils
version is working? Only the older 2.24 ?

If that's the case, then I would probably just mark gcc 4.8 as not
usable on MIPS, especially since it's broken with the new binutils
versions.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/2] Disable gcc-4.8.x + binutils-2.26 + MIPS combination

[Vicente Olivert Riera]

Hi Thomas,

On 15/03/16 13:36, Thomas Petazzoni wrote:
> Vicente,
> 
> On Tue, 15 Mar 2016 11:28:29 +0000, Vicente Olivert Riera wrote:
>> For the same reason as we disabled it for binutils-2.25 before.
>>
>> See 2fda0dd7d491e6e926ace1cd09ad2fb241356232 for details.
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> ---
>>  package/gcc/Config.in.host | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host
>> index 4845708..513899e 100644
>> --- a/package/gcc/Config.in.host
>> +++ b/package/gcc/Config.in.host
>> @@ -42,8 +42,9 @@ choice
>>  		depends on !BR2_cortex_a12 && !BR2_cortex_a17
>>  		# Broken or unsupported PPC cores
>>  		depends on !BR2_powerpc_power8
>> -		# gcc-4.8.x + binutils-2.25 is broken for MIPS
>> -		depends on !((BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el) && BR2_BINUTILS_VERSION_2_25_X)
>> +		# gcc-4.8.x + binutils >= 2.25 is broken for MIPS
>> +		depends on !((BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el) && \
>> +			   (BR2_BINUTILS_VERSION_2_25_X || BR2_BINUTILS_VERSION_2_26_X))
> 
> If neither binutils 2.25 nor binutils 2.26 are working, which binutils
> version is working? Only the older 2.24 ?

The combination (gcc < 4.9) + (binutils < 2.25) are OK. Currently in
Buildroot we can combine gcc-4.8 with binutils 2.23.2 and 2.24.

Regards,

Vincent.

> If that's the case, then I would probably just mark gcc 4.8 as not
> usable on MIPS, especially since it's broken with the new binutils
> versions.
> 
> Best regards,
> 
> Thomas
>