* [Buildroot] [PATCH next] tpm2-abrmd: fix build without stack smashing protection (SSP)
@ 2018-11-21 17:43 Carlos Santos
2018-11-21 20:06 ` Thomas Petazzoni
2018-12-03 12:28 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Carlos Santos @ 2018-11-21 17:43 UTC (permalink / raw)
To: buildroot
The configuration environment setup that disables SSP if the toolchain
does not support it must be updated after the bump to version 2.0.3.
Fixes:
http://autobuild.buildroot.net/results/bd9005eeb24678aa530179a80bbc99b2176f8559
http://autobuild.buildroot.net/results/feff61dcb481a94f5f030117830984c5e09727ea
Signed-off-by: Carlos Santos <casantos@datacom.com.br>
---
package/tpm2-abrmd/tpm2-abrmd.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/tpm2-abrmd/tpm2-abrmd.mk b/package/tpm2-abrmd/tpm2-abrmd.mk
index a4d9cfb384..74cc66ba20 100644
--- a/package/tpm2-abrmd/tpm2-abrmd.mk
+++ b/package/tpm2-abrmd/tpm2-abrmd.mk
@@ -13,7 +13,7 @@ TPM2_ABRMD_DEPENDENCIES = dbus libglib2 tpm2-tss host-pkgconf
# configure.ac doesn't contain a link test, so it doesn't detect when
# libssp is missing.
-TPM2_ABRMD_CONF_ENV = ax_cv_check_cflags___fstack_protector_all=$(if $(BR2_TOOLCHAIN_HAS_SSP),yes,no)
+TPM2_ABRMD_CONF_ENV = ax_cv_check_cflags___________Werror_______fstack_protector_all=$(if $(BR2_TOOLCHAIN_HAS_SSP),yes,no)
TPM2_ABRMD_CONF_OPTS += \
--with-systemdsystemunitdir=$(if $(BR2_INIT_SYSTEMD),/usr/lib/systemd/system,no) \
--
2.19.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH next] tpm2-abrmd: fix build without stack smashing protection (SSP)
2018-11-21 17:43 [Buildroot] [PATCH next] tpm2-abrmd: fix build without stack smashing protection (SSP) Carlos Santos
@ 2018-11-21 20:06 ` Thomas Petazzoni
2018-11-22 1:46 ` Carlos Santos
2018-12-03 12:28 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2018-11-21 20:06 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 21 Nov 2018 15:43:37 -0200, Carlos Santos wrote:
> The configuration environment setup that disables SSP if the toolchain
> does not support it must be updated after the bump to version 2.0.3.
>
> Fixes:
> http://autobuild.buildroot.net/results/bd9005eeb24678aa530179a80bbc99b2176f8559
> http://autobuild.buildroot.net/results/feff61dcb481a94f5f030117830984c5e09727ea
>
> Signed-off-by: Carlos Santos <casantos@datacom.com.br>
> ---
> package/tpm2-abrmd/tpm2-abrmd.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/tpm2-abrmd/tpm2-abrmd.mk b/package/tpm2-abrmd/tpm2-abrmd.mk
> index a4d9cfb384..74cc66ba20 100644
> --- a/package/tpm2-abrmd/tpm2-abrmd.mk
> +++ b/package/tpm2-abrmd/tpm2-abrmd.mk
> @@ -13,7 +13,7 @@ TPM2_ABRMD_DEPENDENCIES = dbus libglib2 tpm2-tss host-pkgconf
>
> # configure.ac doesn't contain a link test, so it doesn't detect when
> # libssp is missing.
> -TPM2_ABRMD_CONF_ENV = ax_cv_check_cflags___fstack_protector_all=$(if $(BR2_TOOLCHAIN_HAS_SSP),yes,no)
> +TPM2_ABRMD_CONF_ENV = ax_cv_check_cflags___________Werror_______fstack_protector_all=$(if $(BR2_TOOLCHAIN_HAS_SSP),yes,no)
It's a bit annoying to fix this once in a while, what about the
following change instead:
diff --git a/m4/flags.m4 b/m4/flags.m4
index 1b01198..59b6d5b 100644
--- a/m4/flags.m4
+++ b/m4/flags.m4
@@ -5,7 +5,7 @@ dnl mandatory (configure will fail).
dnl $1: C compiler flag to add to EXTRA_CFLAGS.
dnl $2: Set to "required" to cause configure failure if flag not supported..
AC_DEFUN([AX_ADD_COMPILER_FLAG],[
- AX_CHECK_COMPILE_FLAG([$1],[
+ AX_CHECK_LINK_FLAG([$1],[
EXTRA_CFLAGS="$EXTRA_CFLAGS $1"
AC_SUBST([EXTRA_CFLAGS])],[
AS_IF([test x$2 != xrequired],[
(entirely untested). It could be submitted upstream.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH next] tpm2-abrmd: fix build without stack smashing protection (SSP)
2018-11-21 20:06 ` Thomas Petazzoni
@ 2018-11-22 1:46 ` Carlos Santos
2018-11-23 14:01 ` Carlos Santos
0 siblings, 1 reply; 6+ messages in thread
From: Carlos Santos @ 2018-11-22 1:46 UTC (permalink / raw)
To: buildroot
> From: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
> To: "DATACOM" <casantos@datacom.com.br>
> Cc: "buildroot" <buildroot@buildroot.org>
> Sent: Quarta-feira, 21 de novembro de 2018 18:06:52
> Subject: Re: [Buildroot] [PATCH next] tpm2-abrmd: fix build without stack smashing protection (SSP)
> Hello,
>
> On Wed, 21 Nov 2018 15:43:37 -0200, Carlos Santos wrote:
>> The configuration environment setup that disables SSP if the toolchain
>> does not support it must be updated after the bump to version 2.0.3.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/bd9005eeb24678aa530179a80bbc99b2176f8559
>> http://autobuild.buildroot.net/results/feff61dcb481a94f5f030117830984c5e09727ea
>>
>> Signed-off-by: Carlos Santos <casantos@datacom.com.br>
>> ---
>> package/tpm2-abrmd/tpm2-abrmd.mk | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/package/tpm2-abrmd/tpm2-abrmd.mk b/package/tpm2-abrmd/tpm2-abrmd.mk
>> index a4d9cfb384..74cc66ba20 100644
>> --- a/package/tpm2-abrmd/tpm2-abrmd.mk
>> +++ b/package/tpm2-abrmd/tpm2-abrmd.mk
>> @@ -13,7 +13,7 @@ TPM2_ABRMD_DEPENDENCIES = dbus libglib2 tpm2-tss host-pkgconf
>>
>> # configure.ac doesn't contain a link test, so it doesn't detect when
>> # libssp is missing.
>> -TPM2_ABRMD_CONF_ENV = ax_cv_check_cflags___fstack_protector_all=$(if
>> $(BR2_TOOLCHAIN_HAS_SSP),yes,no)
>> +TPM2_ABRMD_CONF_ENV =
>> ax_cv_check_cflags___________Werror_______fstack_protector_all=$(if
>> $(BR2_TOOLCHAIN_HAS_SSP),yes,no)
>
> It's a bit annoying to fix this once in a while, what about the
> following change instead:
>
> diff --git a/m4/flags.m4 b/m4/flags.m4
> index 1b01198..59b6d5b 100644
> --- a/m4/flags.m4
> +++ b/m4/flags.m4
> @@ -5,7 +5,7 @@ dnl mandatory (configure will fail).
> dnl $1: C compiler flag to add to EXTRA_CFLAGS.
> dnl $2: Set to "required" to cause configure failure if flag not supported..
> AC_DEFUN([AX_ADD_COMPILER_FLAG],[
> - AX_CHECK_COMPILE_FLAG([$1],[
> + AX_CHECK_LINK_FLAG([$1],[
> EXTRA_CFLAGS="$EXTRA_CFLAGS $1"
> AC_SUBST([EXTRA_CFLAGS])],[
> AS_IF([test x$2 != xrequired],[
>
> (entirely untested). It could be submitted upstream.
I can forward your suggestion upstream but for the moment I'd keep
the CONF_ENV approach.
Patching flags.m4 would require AUTORECONF, which in its turn would
require adding host-autoconf-archive as a build dependency. So more
dependencies, a larger build to time and exactly the same result.
--
Carlos Santos (Casantos) - DATACOM, P&D
?Marched towards the enemy, spear upright, armed with the certainty
that only the ignorant can have.? ? Epitaph of a volunteer
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH next] tpm2-abrmd: fix build without stack smashing protection (SSP)
2018-11-22 1:46 ` Carlos Santos
@ 2018-11-23 14:01 ` Carlos Santos
2018-11-28 10:43 ` Carlos Santos
0 siblings, 1 reply; 6+ messages in thread
From: Carlos Santos @ 2018-11-23 14:01 UTC (permalink / raw)
To: buildroot
> From: "DATACOM" <casantos@datacom.com.br>
> To: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
> Cc: "buildroot" <buildroot@buildroot.org>
> Sent: Quarta-feira, 21 de novembro de 2018 23:46:58
> Subject: Re: [Buildroot] [PATCH next] tpm2-abrmd: fix build without stack smashing protection (SSP)
>> From: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
>> To: "DATACOM" <casantos@datacom.com.br>
>> Cc: "buildroot" <buildroot@buildroot.org>
>> Sent: Quarta-feira, 21 de novembro de 2018 18:06:52
>> Subject: Re: [Buildroot] [PATCH next] tpm2-abrmd: fix build without stack
>> smashing protection (SSP)
>
>> Hello,
>>
>> On Wed, 21 Nov 2018 15:43:37 -0200, Carlos Santos wrote:
>>> The configuration environment setup that disables SSP if the toolchain
>>> does not support it must be updated after the bump to version 2.0.3.
>>>
>>> Fixes:
>>> http://autobuild.buildroot.net/results/bd9005eeb24678aa530179a80bbc99b2176f8559
>>> http://autobuild.buildroot.net/results/feff61dcb481a94f5f030117830984c5e09727ea
>>>
>>> Signed-off-by: Carlos Santos <casantos@datacom.com.br>
>>> ---
>>> package/tpm2-abrmd/tpm2-abrmd.mk | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/package/tpm2-abrmd/tpm2-abrmd.mk b/package/tpm2-abrmd/tpm2-abrmd.mk
>>> index a4d9cfb384..74cc66ba20 100644
>>> --- a/package/tpm2-abrmd/tpm2-abrmd.mk
>>> +++ b/package/tpm2-abrmd/tpm2-abrmd.mk
>>> @@ -13,7 +13,7 @@ TPM2_ABRMD_DEPENDENCIES = dbus libglib2 tpm2-tss host-pkgconf
>>>
>>> # configure.ac doesn't contain a link test, so it doesn't detect when
>>> # libssp is missing.
>>> -TPM2_ABRMD_CONF_ENV = ax_cv_check_cflags___fstack_protector_all=$(if
>>> $(BR2_TOOLCHAIN_HAS_SSP),yes,no)
>>> +TPM2_ABRMD_CONF_ENV =
>>> ax_cv_check_cflags___________Werror_______fstack_protector_all=$(if
>>> $(BR2_TOOLCHAIN_HAS_SSP),yes,no)
>>
>> It's a bit annoying to fix this once in a while, what about the
>> following change instead:
>>
>> diff --git a/m4/flags.m4 b/m4/flags.m4
>> index 1b01198..59b6d5b 100644
>> --- a/m4/flags.m4
>> +++ b/m4/flags.m4
>> @@ -5,7 +5,7 @@ dnl mandatory (configure will fail).
>> dnl $1: C compiler flag to add to EXTRA_CFLAGS.
>> dnl $2: Set to "required" to cause configure failure if flag not supported..
>> AC_DEFUN([AX_ADD_COMPILER_FLAG],[
>> - AX_CHECK_COMPILE_FLAG([$1],[
>> + AX_CHECK_LINK_FLAG([$1],[
>> EXTRA_CFLAGS="$EXTRA_CFLAGS $1"
>> AC_SUBST([EXTRA_CFLAGS])],[
>> AS_IF([test x$2 != xrequired],[
>>
>> (entirely untested). It could be submitted upstream.
>
> I can forward your suggestion upstream but for the moment I'd keep
> the CONF_ENV approach.
>
> Patching flags.m4 would require AUTORECONF, which in its turn would
> require adding host-autoconf-archive as a build dependency. So more
> dependencies, a larger build to time and exactly the same result.
Pull request created:
https://github.com/tpm2-software/tpm2-abrmd/pull/556
--
Carlos Santos (Casantos) - DATACOM, P&D
?Marched towards the enemy, spear upright, armed with the certainty
that only the ignorant can have.? ? Epitaph of a volunteer
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH next] tpm2-abrmd: fix build without stack smashing protection (SSP)
2018-11-23 14:01 ` Carlos Santos
@ 2018-11-28 10:43 ` Carlos Santos
0 siblings, 0 replies; 6+ messages in thread
From: Carlos Santos @ 2018-11-28 10:43 UTC (permalink / raw)
To: buildroot
> From: "DATACOM" <casantos@datacom.com.br>
> To: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
> Cc: "buildroot" <buildroot@buildroot.org>
> Sent: Sexta-feira, 23 de novembro de 2018 12:01:24
> Subject: Re: [Buildroot] [PATCH next] tpm2-abrmd: fix build without stack smashing protection (SSP)
>> From: "DATACOM" <casantos@datacom.com.br>
>> To: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
>> Cc: "buildroot" <buildroot@buildroot.org>
>> Sent: Quarta-feira, 21 de novembro de 2018 23:46:58
>> Subject: Re: [Buildroot] [PATCH next] tpm2-abrmd: fix build without stack
>> smashing protection (SSP)
>
>>> From: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
>>> To: "DATACOM" <casantos@datacom.com.br>
>>> Cc: "buildroot" <buildroot@buildroot.org>
>>> Sent: Quarta-feira, 21 de novembro de 2018 18:06:52
>>> Subject: Re: [Buildroot] [PATCH next] tpm2-abrmd: fix build without stack
>>> smashing protection (SSP)
>>
>>> Hello,
>>>
>>> On Wed, 21 Nov 2018 15:43:37 -0200, Carlos Santos wrote:
>>>> The configuration environment setup that disables SSP if the toolchain
>>>> does not support it must be updated after the bump to version 2.0.3.
>>>>
>>>> Fixes:
>>>> http://autobuild.buildroot.net/results/bd9005eeb24678aa530179a80bbc99b2176f8559
>>>> http://autobuild.buildroot.net/results/feff61dcb481a94f5f030117830984c5e09727ea
>>>>
>>>> Signed-off-by: Carlos Santos <casantos@datacom.com.br>
>>>> ---
>>>> package/tpm2-abrmd/tpm2-abrmd.mk | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/package/tpm2-abrmd/tpm2-abrmd.mk b/package/tpm2-abrmd/tpm2-abrmd.mk
>>>> index a4d9cfb384..74cc66ba20 100644
>>>> --- a/package/tpm2-abrmd/tpm2-abrmd.mk
>>>> +++ b/package/tpm2-abrmd/tpm2-abrmd.mk
>>>> @@ -13,7 +13,7 @@ TPM2_ABRMD_DEPENDENCIES = dbus libglib2 tpm2-tss host-pkgconf
>>>>
>>>> # configure.ac doesn't contain a link test, so it doesn't detect when
>>>> # libssp is missing.
>>>> -TPM2_ABRMD_CONF_ENV = ax_cv_check_cflags___fstack_protector_all=$(if
>>>> $(BR2_TOOLCHAIN_HAS_SSP),yes,no)
>>>> +TPM2_ABRMD_CONF_ENV =
>>>> ax_cv_check_cflags___________Werror_______fstack_protector_all=$(if
>>>> $(BR2_TOOLCHAIN_HAS_SSP),yes,no)
>>>
>>> It's a bit annoying to fix this once in a while, what about the
>>> following change instead:
>>>
>>> diff --git a/m4/flags.m4 b/m4/flags.m4
>>> index 1b01198..59b6d5b 100644
>>> --- a/m4/flags.m4
>>> +++ b/m4/flags.m4
>>> @@ -5,7 +5,7 @@ dnl mandatory (configure will fail).
>>> dnl $1: C compiler flag to add to EXTRA_CFLAGS.
>>> dnl $2: Set to "required" to cause configure failure if flag not supported..
>>> AC_DEFUN([AX_ADD_COMPILER_FLAG],[
>>> - AX_CHECK_COMPILE_FLAG([$1],[
>>> + AX_CHECK_LINK_FLAG([$1],[
>>> EXTRA_CFLAGS="$EXTRA_CFLAGS $1"
>>> AC_SUBST([EXTRA_CFLAGS])],[
>>> AS_IF([test x$2 != xrequired],[
>>>
>>> (entirely untested). It could be submitted upstream.
>>
>> I can forward your suggestion upstream but for the moment I'd keep
>> the CONF_ENV approach.
>>
>> Patching flags.m4 would require AUTORECONF, which in its turn would
>> require adding host-autoconf-archive as a build dependency. So more
>> dependencies, a larger build to time and exactly the same result.
>
> Pull request created:
>
> https://github.com/tpm2-software/tpm2-abrmd/pull/556
Thomas, could you please accept this patch while we wait for a verdict
from upstream on my PR? It is currently blocked by a build error whose
solution depends on a subsequent PR:
https://github.com/tpm2-software/tpm2-abrmd/pull/557
--
Carlos Santos (Casantos) - DATACOM, P&D
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH next] tpm2-abrmd: fix build without stack smashing protection (SSP)
2018-11-21 17:43 [Buildroot] [PATCH next] tpm2-abrmd: fix build without stack smashing protection (SSP) Carlos Santos
2018-11-21 20:06 ` Thomas Petazzoni
@ 2018-12-03 12:28 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2018-12-03 12:28 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 21 Nov 2018 15:43:37 -0200, Carlos Santos wrote:
> The configuration environment setup that disables SSP if the toolchain
> does not support it must be updated after the bump to version 2.0.3.
>
> Fixes:
> http://autobuild.buildroot.net/results/bd9005eeb24678aa530179a80bbc99b2176f8559
> http://autobuild.buildroot.net/results/feff61dcb481a94f5f030117830984c5e09727ea
>
> Signed-off-by: Carlos Santos <casantos@datacom.com.br>
> ---
> package/tpm2-abrmd/tpm2-abrmd.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-03 12:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-21 17:43 [Buildroot] [PATCH next] tpm2-abrmd: fix build without stack smashing protection (SSP) Carlos Santos
2018-11-21 20:06 ` Thomas Petazzoni
2018-11-22 1:46 ` Carlos Santos
2018-11-23 14:01 ` Carlos Santos
2018-11-28 10:43 ` Carlos Santos
2018-12-03 12:28 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox