[Buildroot] [PATCH 1/1] package/faad2: force arm mode instead of Thumb mode

[Buildroot] [PATCH 1/1] package/faad2: force arm mode instead of Thumb mode

[Fabrice Fontaine]

Fix the following build failure in Thumb mode:

/tmp/ccfzn6FH.s:36: Error: selected processor does not support `smull r2,r3,r1,r0' in Thumb mode

Fixes:
 - http://autobuild.buildroot.org/results/838808b4751244ee01cde6b8261212b49e511a32

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/faad2/faad2.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/faad2/faad2.mk b/package/faad2/faad2.mk
index 686e5045c0..0e66ebc8e1 100644
--- a/package/faad2/faad2.mk
+++ b/package/faad2/faad2.mk
@@ -12,4 +12,11 @@ FAAD2_CPE_ID_VENDOR = audiocoding
 FAAD2_CPE_ID_PRODUCT = freeware_advanced_audio_decoder_2
 FAAD2_INSTALL_STAGING = YES
 
+# faad2 has some assembly function that are not present in thumb1 mode:
+# Error: selected processor does not support `smull r2,r3,r1,r0' in Thumb mode
+# so, we desactivate thumb mode
+ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y)
+FAAD2_CONF_OPTS += -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -marm"
+endif
+
 $(eval $(cmake-package))
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/faad2: force arm mode instead of Thumb mode

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fix the following build failure in Thumb mode:
 > /tmp/ccfzn6FH.s:36: Error: selected processor does not support `smull r2,r3,r1,r0' in Thumb mode

 > Fixes:
 >  - http://autobuild.buildroot.org/results/838808b4751244ee01cde6b8261212b49e511a32

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > ---
 >  package/faad2/faad2.mk | 7 +++++++
 >  1 file changed, 7 insertions(+)

 > diff --git a/package/faad2/faad2.mk b/package/faad2/faad2.mk
 > index 686e5045c0..0e66ebc8e1 100644
 > --- a/package/faad2/faad2.mk
 > +++ b/package/faad2/faad2.mk
 > @@ -12,4 +12,11 @@ FAAD2_CPE_ID_VENDOR = audiocoding
 >  FAAD2_CPE_ID_PRODUCT = freeware_advanced_audio_decoder_2
 >  FAAD2_INSTALL_STAGING = YES
 
 > +# faad2 has some assembly function that are not present in thumb1 mode:
 > +# Error: selected processor does not support `smull r2,r3,r1,r0' in Thumb mode
 > +# so, we desactivate thumb mode
 > +ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y)
 > +FAAD2_CONF_OPTS += -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -marm"
 > +endif

Committed after rewording this slightly, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/faad2: force arm mode instead of Thumb mode

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fix the following build failure in Thumb mode:
 > /tmp/ccfzn6FH.s:36: Error: selected processor does not support `smull r2,r3,r1,r0' in Thumb mode

 > Fixes:
 >  - http://autobuild.buildroot.org/results/838808b4751244ee01cde6b8261212b49e511a32

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2023.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot