From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] uboot-tools: requires host gcc 4.7+
Date: Fri, 10 Aug 2018 08:43:25 +0300 [thread overview]
Message-ID: <8736vmbwua.fsf@tkos.co.il> (raw)
In-Reply-To: <20180808150458.v3onrufmufhe67su@sapphire.tkos.co.il>
Hi Peter,
Baruch Siach writes:
> On Wed, Aug 08, 2018 at 04:55:06PM +0200, Peter Korsgaard wrote:
>> >>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
>> >> > config BR2_PACKAGE_UBOOT_TOOLS
>> >> > bool "u-boot tools"
>> >> > + depends on BR2_HOST_GCC_AT_LEAST_4_7 # -std=gnu11
>> >>
>> >> What about host-uboot-tools?
>>
>> > The only config symbols that builds host-uboot-tools is
>> > BR2_PACKAGE_XVISOR_CREATE_UBOOT_IMAGE. So we should make it depend on
>> > BR2_HOST_GCC_AT_LEAST_4_7, right?
>>
>> > AFAIU, there is no way to directly make host packages depend on Kconfig
>> > symbols.
>>
>> Ehh, but we do have a Config.in.host / BR2_PACKAGE_HOST_UBOOT_TOOLS, and
>> a number of places where it is selected?
>
> I see. I'll run another build just to verify that -std=gnu11 is used in
> host-uboot-tools, and send another patch.
It turns out that host-uboot-tools is not affected. That's because we
force host CFLAGS in HOST_UBOOT_TOOLS_MAKE_OPTS. I posted a patch that
does the same for uboot-tools, and marked this patch as Rejected.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
prev parent reply other threads:[~2018-08-10 5:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 4:38 [Buildroot] [PATCH] uboot-tools: requires host gcc 4.7+ Baruch Siach
2018-08-08 14:30 ` Peter Korsgaard
2018-08-08 14:39 ` Baruch Siach
2018-08-08 14:55 ` Peter Korsgaard
2018-08-08 15:04 ` Baruch Siach
2018-08-10 5:43 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736vmbwua.fsf@tkos.co.il \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox