* [Buildroot] [PATCH] uboot-tools: requires host gcc 4.7+
@ 2018-08-07 4:38 Baruch Siach
2018-08-08 14:30 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2018-08-07 4:38 UTC (permalink / raw)
To: buildroot
U-Boot now adds -std=gnu11 when building its build utilities, like
fixdep. This option is only supported since gcc version 4.7.
https://gcc.gnu.org/gcc-4.7/changes.html
Fixes:
http://autobuild.buildroot.net/results/ea0/ea09b614a3c10d494939d9551c0c3bfca4626ece/
http://autobuild.buildroot.net/results/f8e/f8efd9af4d86c51fe4f5afe44db9abf9adc5718f/
http://autobuild.buildroot.net/results/c0a/c0ab35c3cb46f84863fe20c0ee92ecc2379578b6/
Cc: Matt Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/uboot-tools/Config.in | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/uboot-tools/Config.in b/package/uboot-tools/Config.in
index 63a058e8562a..78a8b66c4d97 100644
--- a/package/uboot-tools/Config.in
+++ b/package/uboot-tools/Config.in
@@ -1,10 +1,14 @@
config BR2_PACKAGE_UBOOT_TOOLS
bool "u-boot tools"
+ depends on BR2_HOST_GCC_AT_LEAST_4_7 # -std=gnu11
help
Companion tools for Das U-Boot bootloader.
http://www.denx.de/wiki/U-Boot/WebHome
+comment "u-boot tools needs host gcc >= 4.7"
+ depends on !BR2_HOST_GCC_AT_LEAST_4_7
+
if BR2_PACKAGE_UBOOT_TOOLS
config BR2_PACKAGE_UBOOT_TOOLS_FIT_SUPPORT
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] uboot-tools: requires host gcc 4.7+
2018-08-07 4:38 [Buildroot] [PATCH] uboot-tools: requires host gcc 4.7+ Baruch Siach
@ 2018-08-08 14:30 ` Peter Korsgaard
2018-08-08 14:39 ` Baruch Siach
0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2018-08-08 14:30 UTC (permalink / raw)
To: buildroot
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> U-Boot now adds -std=gnu11 when building its build utilities, like
> fixdep. This option is only supported since gcc version 4.7.
> https://gcc.gnu.org/gcc-4.7/changes.html
> Fixes:
> http://autobuild.buildroot.net/results/ea0/ea09b614a3c10d494939d9551c0c3bfca4626ece/
> http://autobuild.buildroot.net/results/f8e/f8efd9af4d86c51fe4f5afe44db9abf9adc5718f/
> http://autobuild.buildroot.net/results/c0a/c0ab35c3cb46f84863fe20c0ee92ecc2379578b6/
> Cc: Matt Weber <matthew.weber@rockwellcollins.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/uboot-tools/Config.in | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/package/uboot-tools/Config.in b/package/uboot-tools/Config.in
> index 63a058e8562a..78a8b66c4d97 100644
> --- a/package/uboot-tools/Config.in
> +++ b/package/uboot-tools/Config.in
> @@ -1,10 +1,14 @@
> config BR2_PACKAGE_UBOOT_TOOLS
> bool "u-boot tools"
> + depends on BR2_HOST_GCC_AT_LEAST_4_7 # -std=gnu11
What about host-uboot-tools?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] uboot-tools: requires host gcc 4.7+
2018-08-08 14:30 ` Peter Korsgaard
@ 2018-08-08 14:39 ` Baruch Siach
2018-08-08 14:55 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2018-08-08 14:39 UTC (permalink / raw)
To: buildroot
Hi Peter,
On Wed, Aug 08, 2018 at 04:30:21PM +0200, Peter Korsgaard wrote:
> >>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
>
> > U-Boot now adds -std=gnu11 when building its build utilities, like
> > fixdep. This option is only supported since gcc version 4.7.
>
> > https://gcc.gnu.org/gcc-4.7/changes.html
>
> > Fixes:
> > http://autobuild.buildroot.net/results/ea0/ea09b614a3c10d494939d9551c0c3bfca4626ece/
> > http://autobuild.buildroot.net/results/f8e/f8efd9af4d86c51fe4f5afe44db9abf9adc5718f/
> > http://autobuild.buildroot.net/results/c0a/c0ab35c3cb46f84863fe20c0ee92ecc2379578b6/
>
> > Cc: Matt Weber <matthew.weber@rockwellcollins.com>
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> > package/uboot-tools/Config.in | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> > diff --git a/package/uboot-tools/Config.in b/package/uboot-tools/Config.in
> > index 63a058e8562a..78a8b66c4d97 100644
> > --- a/package/uboot-tools/Config.in
> > +++ b/package/uboot-tools/Config.in
> > @@ -1,10 +1,14 @@
> > config BR2_PACKAGE_UBOOT_TOOLS
> > bool "u-boot tools"
> > + depends on BR2_HOST_GCC_AT_LEAST_4_7 # -std=gnu11
>
> What about host-uboot-tools?
The only config symbols that builds host-uboot-tools is
BR2_PACKAGE_XVISOR_CREATE_UBOOT_IMAGE. So we should make it depend on
BR2_HOST_GCC_AT_LEAST_4_7, right?
AFAIU, there is no way to directly make host packages depend on Kconfig
symbols.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH] uboot-tools: requires host gcc 4.7+
2018-08-08 14:39 ` Baruch Siach
@ 2018-08-08 14:55 ` Peter Korsgaard
2018-08-08 15:04 ` Baruch Siach
0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2018-08-08 14:55 UTC (permalink / raw)
To: buildroot
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
Hi,
>> > config BR2_PACKAGE_UBOOT_TOOLS
>> > bool "u-boot tools"
>> > + depends on BR2_HOST_GCC_AT_LEAST_4_7 # -std=gnu11
>>
>> What about host-uboot-tools?
> The only config symbols that builds host-uboot-tools is
> BR2_PACKAGE_XVISOR_CREATE_UBOOT_IMAGE. So we should make it depend on
> BR2_HOST_GCC_AT_LEAST_4_7, right?
> AFAIU, there is no way to directly make host packages depend on Kconfig
> symbols.
Ehh, but we do have a Config.in.host / BR2_PACKAGE_HOST_UBOOT_TOOLS, and
a number of places where it is selected?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] uboot-tools: requires host gcc 4.7+
2018-08-08 14:55 ` Peter Korsgaard
@ 2018-08-08 15:04 ` Baruch Siach
2018-08-10 5:43 ` Baruch Siach
0 siblings, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2018-08-08 15:04 UTC (permalink / raw)
To: buildroot
Hi Peter,
On Wed, Aug 08, 2018 at 04:55:06PM +0200, Peter Korsgaard wrote:
> >>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> >> > config BR2_PACKAGE_UBOOT_TOOLS
> >> > bool "u-boot tools"
> >> > + depends on BR2_HOST_GCC_AT_LEAST_4_7 # -std=gnu11
> >>
> >> What about host-uboot-tools?
>
> > The only config symbols that builds host-uboot-tools is
> > BR2_PACKAGE_XVISOR_CREATE_UBOOT_IMAGE. So we should make it depend on
> > BR2_HOST_GCC_AT_LEAST_4_7, right?
>
> > AFAIU, there is no way to directly make host packages depend on Kconfig
> > symbols.
>
> Ehh, but we do have a Config.in.host / BR2_PACKAGE_HOST_UBOOT_TOOLS, and
> a number of places where it is selected?
I see. I'll run another build just to verify that -std=gnu11 is used in
host-uboot-tools, and send another patch.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH] uboot-tools: requires host gcc 4.7+
2018-08-08 15:04 ` Baruch Siach
@ 2018-08-10 5:43 ` Baruch Siach
0 siblings, 0 replies; 6+ messages in thread
From: Baruch Siach @ 2018-08-10 5:43 UTC (permalink / raw)
To: buildroot
Hi Peter,
Baruch Siach writes:
> On Wed, Aug 08, 2018 at 04:55:06PM +0200, Peter Korsgaard wrote:
>> >>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
>> >> > config BR2_PACKAGE_UBOOT_TOOLS
>> >> > bool "u-boot tools"
>> >> > + depends on BR2_HOST_GCC_AT_LEAST_4_7 # -std=gnu11
>> >>
>> >> What about host-uboot-tools?
>>
>> > The only config symbols that builds host-uboot-tools is
>> > BR2_PACKAGE_XVISOR_CREATE_UBOOT_IMAGE. So we should make it depend on
>> > BR2_HOST_GCC_AT_LEAST_4_7, right?
>>
>> > AFAIU, there is no way to directly make host packages depend on Kconfig
>> > symbols.
>>
>> Ehh, but we do have a Config.in.host / BR2_PACKAGE_HOST_UBOOT_TOOLS, and
>> a number of places where it is selected?
>
> I see. I'll run another build just to verify that -std=gnu11 is used in
> host-uboot-tools, and send another patch.
It turns out that host-uboot-tools is not affected. That's because we
force host CFLAGS in HOST_UBOOT_TOOLS_MAKE_OPTS. I posted a patch that
does the same for uboot-tools, and marked this patch as Rejected.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-08-10 5:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-07 4:38 [Buildroot] [PATCH] uboot-tools: requires host gcc 4.7+ Baruch Siach
2018-08-08 14:30 ` Peter Korsgaard
2018-08-08 14:39 ` Baruch Siach
2018-08-08 14:55 ` Peter Korsgaard
2018-08-08 15:04 ` Baruch Siach
2018-08-10 5:43 ` Baruch Siach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox