[Buildroot] [PATCH 1/1] package/gkrellm: link with -latomic if needed

[Buildroot] [PATCH 1/1] package/gkrellm: link with -latomic if needed

[Bernd Kuhls]

Fixes:
http://autobuild.buildroot.net/results/5df/5dffba341cfe5e4d41b3c88e58d92b0747318c07/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/gkrellm/gkrellm.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/package/gkrellm/gkrellm.mk b/package/gkrellm/gkrellm.mk
index 2a68722663..c9748eb084 100644
--- a/package/gkrellm/gkrellm.mk
+++ b/package/gkrellm/gkrellm.mk
@@ -12,7 +12,13 @@ GKRELLM_LICENSE_FILES = COPYING COPYRIGHT
 GKRELLM_DEPENDENCIES = host-pkgconf libglib2 $(TARGET_NLS_DEPENDENCIES)
 GKRELLM_BUILD_OPTS = \
 	STRIP="" \
-	SYS_LIBS=$(TARGET_NLS_LIBS)
+	SYS_LIBS="$(GKRELLM_SYS_LIBS)"
+
+GKRELLM_SYS_LIBS=$(TARGET_NLS_LIBS)
+
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+GKRELLM_SYS_LIBS += -latomic
+endif
 
 ifeq ($(BR2_PACKAGE_LM_SENSORS),y)
 GKRELLM_DEPENDENCIES += lm-sensors
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/gkrellm: link with -latomic if needed

[Thomas Petazzoni via buildroot]

Hello Bernd,

On Sun, 18 Jun 2023 14:32:14 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Fixes:
> http://autobuild.buildroot.net/results/5df/5dffba341cfe5e4d41b3c88e58d92b0747318c07/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/gkrellm/gkrellm.mk | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/package/gkrellm/gkrellm.mk b/package/gkrellm/gkrellm.mk
> index 2a68722663..c9748eb084 100644
> --- a/package/gkrellm/gkrellm.mk
> +++ b/package/gkrellm/gkrellm.mk
> @@ -12,7 +12,13 @@ GKRELLM_LICENSE_FILES = COPYING COPYRIGHT
>  GKRELLM_DEPENDENCIES = host-pkgconf libglib2 $(TARGET_NLS_DEPENDENCIES)
>  GKRELLM_BUILD_OPTS = \
>  	STRIP="" \
> -	SYS_LIBS=$(TARGET_NLS_LIBS)
> +	SYS_LIBS="$(GKRELLM_SYS_LIBS)"
> +
> +GKRELLM_SYS_LIBS=$(TARGET_NLS_LIBS)

Spaces around = needed (fixed when applying).

I've applied, even though I don't think this is the best fix. Indeed,
gkrellm uses pkg-config to detect glib2 and to get its compile/link
flags. So the -latomic should be coming from the glib2 .pc file,
instead of having to be propagated manually to all users of glib2.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/gkrellm: link with -latomic if needed

[Peter Korsgaard]

>>>>> "Bernd" == Bernd Kuhls <bernd@kuhls.net> writes:

 > Fixes:
 > http://autobuild.buildroot.net/results/5df/5dffba341cfe5e4d41b3c88e58d92b0747318c07/

 > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Committed to 2023.02.x and 2023.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot