[Buildroot] [PATCH 4/4] Fix externals-deps and source-check when building out of tree

[Buildroot] [PATCH 4/4] Fix externals-deps and source-check when building out of tree

[Will Wagner]

Signed-off-by: Will Wagner <will_wagner@carallon.com>
---
 Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index 291badf..7345beb 100644
--- a/Makefile
+++ b/Makefile
@@ -432,10 +432,10 @@ endif
 source: $(TARGETS_SOURCE) $(HOST_SOURCE)
 
 _source-check:
-	$(MAKE) SPIDER=--spider source
+	$(MAKE) O=$(O) SPIDER=--spider source
 
 external-deps:
-	@$(MAKE) -Bs BR2_WGET=$(TOPDIR)/toolchain/wget-show-external-deps.sh \
+	@$(MAKE) O=$(O) -Bs BR2_WGET=$(TOPDIR)/toolchain/wget-show-external-deps.sh \
 		SPIDER=--spider source
 
 show-targets:
@@ -558,7 +558,7 @@ defconfig: $(BUILD_DIR)/buildroot-config/conf
 
 # check if download URLs are outdated
 source-check: allyesconfig
-	$(MAKE) _source-check
+	$(MAKE) O=$(O) _source-check
 
 endif # ifeq ($(BR2_HAVE_DOT_CONFIG),y)
 
-- 
1.7.1

[Buildroot] [PATCH 4/4] Fix externals-deps and source-check when building out of tree

[Peter Korsgaard]

>>>>> "Will" == Will Wagner <will_wagner@carallon.com> writes:

 Will> Signed-off-by: Will Wagner <will_wagner@carallon.com>
 Will> ---
 Will>  Makefile |    6 +++---
 Will>  1 files changed, 3 insertions(+), 3 deletions(-)

 Will> diff --git a/Makefile b/Makefile
 Will> index 291badf..7345beb 100644
 Will> --- a/Makefile
 Will> +++ b/Makefile
 Will> @@ -432,10 +432,10 @@ endif
 Will>  source: $(TARGETS_SOURCE) $(HOST_SOURCE)
 
 Will>  _source-check:
 Will> -	$(MAKE) SPIDER=--spider source
 Will> +	$(MAKE) O=$(O) SPIDER=--spider source

No that then breaks the build for ! O=<dir> builds. I've committed a
slightly different fix that works for both situations.

I see your patch is named 4/4, but I don't see any other patches from
you around that day - Was that just a mistake or did they get lost
somehow?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 4/4] Fix externals-deps and source-check when building out of tree

[William Wagner]

  On 29/08/2010 22:28, Peter Korsgaard wrote:
>
>   Will>  Signed-off-by: Will Wagner<will_wagner@carallon.com>
>   Will>  ---
>   Will>   Makefile |    6 +++---
>   Will>   1 files changed, 3 insertions(+), 3 deletions(-)
>
>   Will>  diff --git a/Makefile b/Makefile
>   Will>  index 291badf..7345beb 100644
>   Will>  --- a/Makefile
>   Will>  +++ b/Makefile
>   Will>  @@ -432,10 +432,10 @@ endif
>   Will>   source: $(TARGETS_SOURCE) $(HOST_SOURCE)
>
>   Will>   _source-check:
>   Will>  -	$(MAKE) SPIDER=--spider source
>   Will>  +	$(MAKE) O=$(O) SPIDER=--spider source
>
> No that then breaks the build for ! O=<dir>  builds. I've committed a
> slightly different fix that works for both situations.

Ok, I'll take a look at your fix to see what I did wrong!

> I see your patch is named 4/4, but I don't see any other patches from
> you around that day - Was that just a mistake or did they get lost
> somehow?
>
Was putting together some other patches for new packages, thought I'd 
send them after this release. Still not quite got the hang of git 
send-email.

Thanks
Will

-- 
------------------------------------------------------------------------
Will Wagner                                     will_wagner at carallon.com
Development Manager                      Office Tel: +44 (0)20 7371 2032
Carallon Ltd, Studio G20, Shepherds Building, Rockley Rd, London W14 0DA
------------------------------------------------------------------------

[Buildroot] [PATCH 4/4] Fix externals-deps and source-check when building out of tree

[Peter Korsgaard]

>>>>> "William" == William Wagner <will_wagner@carallon.com> writes:

Hi,

 William> Ok, I'll take a look at your fix to see what I did wrong!

The problem is that if you always pass O=<dir>, then it will look in
output/.config instead of ./.config when the user isn't using O=<dir>

 >> I see your patch is named 4/4, but I don't see any other patches from
 >> you around that day - Was that just a mistake or did they get lost
 >> somehow?
 >> 
 William> Was putting together some other patches for new packages, thought I'd
 William> send them after this release. Still not quite got the hang of git
 William> send-email.

Ok.

-- 
Bye, Peter Korsgaard