* [Buildroot] [PATCH] Makefile: unexport 'PLATFORM' and 'OS' environment variables
@ 2019-02-05 11:03 Thomas De Schampheleire
2019-02-05 13:25 ` Peter Korsgaard
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas De Schampheleire @ 2019-02-05 11:03 UTC (permalink / raw)
To: buildroot
From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Some package builds may fail when environment variables are present with the
same names as make variables in a package. This is a bigger problem for
environment variables with generic names, like 'PLATFORM' and 'OS'.
'PLATFORM' is for example a problem for host-acl.
Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
---
Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile b/Makefile
index 355a404e04..50a9f623b2 100644
--- a/Makefile
+++ b/Makefile
@@ -419,6 +419,8 @@ unexport TERMINFO
unexport MACHINE
unexport O
unexport GCC_COLORS
+unexport PLATFORM
+unexport OS
GNU_HOST_NAME := $(shell support/gnuconfig/config.guess)
--
2.19.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] Makefile: unexport 'PLATFORM' and 'OS' environment variables
2019-02-05 11:03 [Buildroot] [PATCH] Makefile: unexport 'PLATFORM' and 'OS' environment variables Thomas De Schampheleire
@ 2019-02-05 13:25 ` Peter Korsgaard
2019-02-05 14:22 ` Peter Korsgaard
2019-02-18 16:15 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2019-02-05 13:25 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:
> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> Some package builds may fail when environment variables are present with the
> same names as make variables in a package. This is a bigger problem for
> environment variables with generic names, like 'PLATFORM' and 'OS'.
> 'PLATFORM' is for example a problem for host-acl.
I'm OK with the patch, but what is the error exactly for host-acl? I
don't seem to see any reference to the string 'PLATFORM' in host-acl:
make host-acl-patch
grep -rs PLATFORM build/host-acl-2.2.53
build/host-acl-2.2.53/build-aux/ltmain.sh: v.dwPlatformId == VER_PLATFORM_WIN32_NT;
build/host-acl-2.2.53/build-aux/ltmain.sh.orig: v.dwPlatformId == VER_PLATFORM_WIN32_NT;
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] Makefile: unexport 'PLATFORM' and 'OS' environment variables
2019-02-05 11:03 [Buildroot] [PATCH] Makefile: unexport 'PLATFORM' and 'OS' environment variables Thomas De Schampheleire
2019-02-05 13:25 ` Peter Korsgaard
@ 2019-02-05 14:22 ` Peter Korsgaard
2019-02-18 16:15 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2019-02-05 14:22 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:
> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> Some package builds may fail when environment variables are present with the
> same names as make variables in a package. This is a bigger problem for
> environment variables with generic names, like 'PLATFORM' and 'OS'.
> 'PLATFORM' is for example a problem for host-acl.
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] Makefile: unexport 'PLATFORM' and 'OS' environment variables
2019-02-05 11:03 [Buildroot] [PATCH] Makefile: unexport 'PLATFORM' and 'OS' environment variables Thomas De Schampheleire
2019-02-05 13:25 ` Peter Korsgaard
2019-02-05 14:22 ` Peter Korsgaard
@ 2019-02-18 16:15 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2019-02-18 16:15 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:
> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> Some package builds may fail when environment variables are present with the
> same names as make variables in a package. This is a bigger problem for
> environment variables with generic names, like 'PLATFORM' and 'OS'.
> 'PLATFORM' is for example a problem for host-acl.
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Committed to 2018.02.x and 2018.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-18 16:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-05 11:03 [Buildroot] [PATCH] Makefile: unexport 'PLATFORM' and 'OS' environment variables Thomas De Schampheleire
2019-02-05 13:25 ` Peter Korsgaard
2019-02-05 14:22 ` Peter Korsgaard
2019-02-18 16:15 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox