* [Buildroot] [PATCH 1/1] package/petitboot: fix NLS build
@ 2024-01-20 17:28 Fabrice Fontaine
2024-01-20 17:37 ` Laurent Vivier
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2024-01-20 17:28 UTC (permalink / raw)
To: buildroot; +Cc: Laurent Vivier, Fabrice Fontaine
Fix the following NLS build failure on musl raised commit
bf9583a50276f52edbc37d9f85df5f2cc7fdb5dc:
/home/autobuild/autobuild/instance-4/output-1/host/lib/gcc/mips64el-buildroot-linux-musl/13.2.0/../../../../mips64el-buildroot-linux-musl/bin/ld: discover/pb_discover-pb-discover.o: undefined reference to symbol 'libintl_textdomain'
Fixes:
- http://autobuild.buildroot.org/results/6d440d96e811674041b5a1fdae96d4c377824c2a
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/petitboot/petitboot.mk | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/package/petitboot/petitboot.mk b/package/petitboot/petitboot.mk
index c4eb20b44d..2087f01b09 100644
--- a/package/petitboot/petitboot.mk
+++ b/package/petitboot/petitboot.mk
@@ -7,10 +7,18 @@
PETITBOOT_VERSION = 1.14
PETITBOOT_SOURCE = petitboot-v$(PETITBOOT_VERSION).tar.gz
PETITBOOT_SITE = https://github.com/open-power/petitboot/releases/download/v$(PETITBOOT_VERSION)
-PETITBOOT_DEPENDENCIES = elfutils ncurses udev host-bison host-flex lvm2
+PETITBOOT_DEPENDENCIES = \
+ elfutils \
+ ncurses \
+ udev \
+ host-bison \
+ host-flex \
+ lvm2 \
+ $(TARGET_NLS_DEPENDENCIES)
PETITBOOT_LICENSE = GPL-2.0
PETITBOOT_LICENSE_FILES = COPYING
+PETITBOOT_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)"
PETITBOOT_CONF_OPTS = \
--enable-crypt \
--enable-platform-auto \
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/petitboot: fix NLS build
2024-01-20 17:28 [Buildroot] [PATCH 1/1] package/petitboot: fix NLS build Fabrice Fontaine
@ 2024-01-20 17:37 ` Laurent Vivier
2024-01-20 17:46 ` Fabrice Fontaine
2024-01-20 23:13 ` Yann E. MORIN
2024-02-04 9:04 ` Peter Korsgaard
2 siblings, 1 reply; 6+ messages in thread
From: Laurent Vivier @ 2024-01-20 17:37 UTC (permalink / raw)
To: Fabrice Fontaine, buildroot
Le 20/01/2024 à 18:28, Fabrice Fontaine a écrit :
> Fix the following NLS build failure on musl raised commit
> bf9583a50276f52edbc37d9f85df5f2cc7fdb5dc:
>
> /home/autobuild/autobuild/instance-4/output-1/host/lib/gcc/mips64el-buildroot-linux-musl/13.2.0/../../../../mips64el-buildroot-linux-musl/bin/ld: discover/pb_discover-pb-discover.o: undefined reference to symbol 'libintl_textdomain'
>
> Fixes:
> - http://autobuild.buildroot.org/results/6d440d96e811674041b5a1fdae96d4c377824c2a
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/petitboot/petitboot.mk | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/package/petitboot/petitboot.mk b/package/petitboot/petitboot.mk
> index c4eb20b44d..2087f01b09 100644
> --- a/package/petitboot/petitboot.mk
> +++ b/package/petitboot/petitboot.mk
> @@ -7,10 +7,18 @@
> PETITBOOT_VERSION = 1.14
> PETITBOOT_SOURCE = petitboot-v$(PETITBOOT_VERSION).tar.gz
> PETITBOOT_SITE = https://github.com/open-power/petitboot/releases/download/v$(PETITBOOT_VERSION)
> -PETITBOOT_DEPENDENCIES = elfutils ncurses udev host-bison host-flex lvm2
> +PETITBOOT_DEPENDENCIES = \
> + elfutils \
> + ncurses \
> + udev \
> + host-bison \
> + host-flex \
> + lvm2 \
> + $(TARGET_NLS_DEPENDENCIES)
> PETITBOOT_LICENSE = GPL-2.0
> PETITBOOT_LICENSE_FILES = COPYING
>
> +PETITBOOT_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)"
should it be
PETITBOOT_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) LIBS=$(TARGET_NLS_LIBS)
?
Thanks,
Laurent
> PETITBOOT_CONF_OPTS = \
> --enable-crypt \
> --enable-platform-auto \
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/petitboot: fix NLS build
2024-01-20 17:37 ` Laurent Vivier
@ 2024-01-20 17:46 ` Fabrice Fontaine
2024-01-20 18:48 ` Laurent Vivier
0 siblings, 1 reply; 6+ messages in thread
From: Fabrice Fontaine @ 2024-01-20 17:46 UTC (permalink / raw)
To: Laurent Vivier; +Cc: buildroot
Le sam. 20 janv. 2024 à 18:37, Laurent Vivier <laurent@vivier.eu> a écrit :
>
> Le 20/01/2024 à 18:28, Fabrice Fontaine a écrit :
> > Fix the following NLS build failure on musl raised commit
> > bf9583a50276f52edbc37d9f85df5f2cc7fdb5dc:
> >
> > /home/autobuild/autobuild/instance-4/output-1/host/lib/gcc/mips64el-buildroot-linux-musl/13.2.0/../../../../mips64el-buildroot-linux-musl/bin/ld: discover/pb_discover-pb-discover.o: undefined reference to symbol 'libintl_textdomain'
> >
> > Fixes:
> > - http://autobuild.buildroot.org/results/6d440d96e811674041b5a1fdae96d4c377824c2a
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > package/petitboot/petitboot.mk | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/package/petitboot/petitboot.mk b/package/petitboot/petitboot.mk
> > index c4eb20b44d..2087f01b09 100644
> > --- a/package/petitboot/petitboot.mk
> > +++ b/package/petitboot/petitboot.mk
> > @@ -7,10 +7,18 @@
> > PETITBOOT_VERSION = 1.14
> > PETITBOOT_SOURCE = petitboot-v$(PETITBOOT_VERSION).tar.gz
> > PETITBOOT_SITE = https://github.com/open-power/petitboot/releases/download/v$(PETITBOOT_VERSION)
> > -PETITBOOT_DEPENDENCIES = elfutils ncurses udev host-bison host-flex lvm2
> > +PETITBOOT_DEPENDENCIES = \
> > + elfutils \
> > + ncurses \
> > + udev \
> > + host-bison \
> > + host-flex \
> > + lvm2 \
> > + $(TARGET_NLS_DEPENDENCIES)
> > PETITBOOT_LICENSE = GPL-2.0
> > PETITBOOT_LICENSE_FILES = COPYING
> >
> > +PETITBOOT_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)"
>
> should it be
>
> PETITBOOT_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) LIBS=$(TARGET_NLS_LIBS)
No, setting LIBS to TARGET_NLS_LIBS will raise the following build failure:
GEN discover/grub2/grub2-parser.ro
/home/fabrice/buildroot/output/host/bin/mips64el-buildroot-linux-musl-ld:
cannot find -lintl: file format not recognized
I assume that this build failure is raised because petitboot also
builds host tools such as grub2-parser.ro which can't find a -lintl
library compatible with the host.
>
> ?
>
> Thanks,
> Laurent
>
> > PETITBOOT_CONF_OPTS = \
> > --enable-crypt \
> > --enable-platform-auto \
>
Best Regards,
Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/petitboot: fix NLS build
2024-01-20 17:46 ` Fabrice Fontaine
@ 2024-01-20 18:48 ` Laurent Vivier
0 siblings, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2024-01-20 18:48 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
Le 20/01/2024 à 18:46, Fabrice Fontaine a écrit :
> Le sam. 20 janv. 2024 à 18:37, Laurent Vivier <laurent@vivier.eu> a écrit :
>>
>> Le 20/01/2024 à 18:28, Fabrice Fontaine a écrit :
>>> Fix the following NLS build failure on musl raised commit
>>> bf9583a50276f52edbc37d9f85df5f2cc7fdb5dc:
>>>
>>> /home/autobuild/autobuild/instance-4/output-1/host/lib/gcc/mips64el-buildroot-linux-musl/13.2.0/../../../../mips64el-buildroot-linux-musl/bin/ld: discover/pb_discover-pb-discover.o: undefined reference to symbol 'libintl_textdomain'
>>>
>>> Fixes:
>>> - http://autobuild.buildroot.org/results/6d440d96e811674041b5a1fdae96d4c377824c2a
>>>
>>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>>> ---
>>> package/petitboot/petitboot.mk | 10 +++++++++-
>>> 1 file changed, 9 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/package/petitboot/petitboot.mk b/package/petitboot/petitboot.mk
>>> index c4eb20b44d..2087f01b09 100644
>>> --- a/package/petitboot/petitboot.mk
>>> +++ b/package/petitboot/petitboot.mk
>>> @@ -7,10 +7,18 @@
>>> PETITBOOT_VERSION = 1.14
>>> PETITBOOT_SOURCE = petitboot-v$(PETITBOOT_VERSION).tar.gz
>>> PETITBOOT_SITE = https://github.com/open-power/petitboot/releases/download/v$(PETITBOOT_VERSION)
>>> -PETITBOOT_DEPENDENCIES = elfutils ncurses udev host-bison host-flex lvm2
>>> +PETITBOOT_DEPENDENCIES = \
>>> + elfutils \
>>> + ncurses \
>>> + udev \
>>> + host-bison \
>>> + host-flex \
>>> + lvm2 \
>>> + $(TARGET_NLS_DEPENDENCIES)
>>> PETITBOOT_LICENSE = GPL-2.0
>>> PETITBOOT_LICENSE_FILES = COPYING
>>>
>>> +PETITBOOT_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)"
>>
>> should it be
>>
>> PETITBOOT_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) LIBS=$(TARGET_NLS_LIBS)
>
> No, setting LIBS to TARGET_NLS_LIBS will raise the following build failure:
>
> GEN discover/grub2/grub2-parser.ro
> /home/fabrice/buildroot/output/host/bin/mips64el-buildroot-linux-musl-ld:
> cannot find -lintl: file format not recognized
>
> I assume that this build failure is raised because petitboot also
> builds host tools such as grub2-parser.ro which can't find a -lintl
> library compatible with the host.
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/petitboot: fix NLS build
2024-01-20 17:28 [Buildroot] [PATCH 1/1] package/petitboot: fix NLS build Fabrice Fontaine
2024-01-20 17:37 ` Laurent Vivier
@ 2024-01-20 23:13 ` Yann E. MORIN
2024-02-04 9:04 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2024-01-20 23:13 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Laurent Vivier, buildroot
Fabrice, All,
On 2024-01-20 18:28 +0100, Fabrice Fontaine spake thusly:
> Fix the following NLS build failure on musl raised commit
> bf9583a50276f52edbc37d9f85df5f2cc7fdb5dc:
>
> /home/autobuild/autobuild/instance-4/output-1/host/lib/gcc/mips64el-buildroot-linux-musl/13.2.0/../../../../mips64el-buildroot-linux-musl/bin/ld: discover/pb_discover-pb-discover.o: undefined reference to symbol 'libintl_textdomain'
>
> Fixes:
> - http://autobuild.buildroot.org/results/6d440d96e811674041b5a1fdae96d4c377824c2a
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/petitboot/petitboot.mk | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/package/petitboot/petitboot.mk b/package/petitboot/petitboot.mk
> index c4eb20b44d..2087f01b09 100644
> --- a/package/petitboot/petitboot.mk
> +++ b/package/petitboot/petitboot.mk
> @@ -7,10 +7,18 @@
> PETITBOOT_VERSION = 1.14
> PETITBOOT_SOURCE = petitboot-v$(PETITBOOT_VERSION).tar.gz
> PETITBOOT_SITE = https://github.com/open-power/petitboot/releases/download/v$(PETITBOOT_VERSION)
> -PETITBOOT_DEPENDENCIES = elfutils ncurses udev host-bison host-flex lvm2
> +PETITBOOT_DEPENDENCIES = \
> + elfutils \
> + ncurses \
> + udev \
> + host-bison \
> + host-flex \
> + lvm2 \
> + $(TARGET_NLS_DEPENDENCIES)
> PETITBOOT_LICENSE = GPL-2.0
> PETITBOOT_LICENSE_FILES = COPYING
>
> +PETITBOOT_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)"
> PETITBOOT_CONF_OPTS = \
> --enable-crypt \
> --enable-platform-auto \
> --
> 2.43.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/petitboot: fix NLS build
2024-01-20 17:28 [Buildroot] [PATCH 1/1] package/petitboot: fix NLS build Fabrice Fontaine
2024-01-20 17:37 ` Laurent Vivier
2024-01-20 23:13 ` Yann E. MORIN
@ 2024-02-04 9:04 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2024-02-04 9:04 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Laurent Vivier, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Fix the following NLS build failure on musl raised commit
> bf9583a50276f52edbc37d9f85df5f2cc7fdb5dc:
> /home/autobuild/autobuild/instance-4/output-1/host/lib/gcc/mips64el-buildroot-linux-musl/13.2.0/../../../../mips64el-buildroot-linux-musl/bin/ld:
> discover/pb_discover-pb-discover.o: undefined reference to symbol
> 'libintl_textdomain'
> Fixes:
> - http://autobuild.buildroot.org/results/6d440d96e811674041b5a1fdae96d4c377824c2a
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2023.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-02-04 9:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-20 17:28 [Buildroot] [PATCH 1/1] package/petitboot: fix NLS build Fabrice Fontaine
2024-01-20 17:37 ` Laurent Vivier
2024-01-20 17:46 ` Fabrice Fontaine
2024-01-20 18:48 ` Laurent Vivier
2024-01-20 23:13 ` Yann E. MORIN
2024-02-04 9:04 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox