[Buildroot] [PATCH] package/host-gdb: disable source-highlight

[Buildroot] [PATCH] package/host-gdb: disable source-highlight

[Bartosz Bilas]

This is the follow-up commit to the 4de60e4 which disables
sourcehighlight dependency for the target GDB package.
Do the same for the host variant to be sure that this
won't be picked up from the host system.

Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
---
 package/gdb/gdb.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
index cee7b37bcd..d9bfb39a41 100644
--- a/package/gdb/gdb.mk
+++ b/package/gdb/gdb.mk
@@ -255,7 +255,8 @@ HOST_GDB_CONF_OPTS = \
 	--with-system-zlib \
 	--with-curses \
 	--without-mpfr \
-	$(GDB_DISABLE_BINUTILS_CONF_OPTS)
+	$(GDB_DISABLE_BINUTILS_CONF_OPTS) \
+	--disable-source-highlight
 
 ifeq ($(BR2_PACKAGE_HOST_GDB_TUI),y)
 HOST_GDB_CONF_OPTS += --enable-tui
-- 
2.41.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/host-gdb: disable source-highlight

[Yann E. MORIN]

Bartosz, All,

On 2023-08-18 08:35 +0200, Bartosz Bilas spake thusly:
> This is the follow-up commit to the 4de60e4 which disables
> sourcehighlight dependency for the target GDB package.
> Do the same for the host variant to be sure that this
> won't be picked up from the host system.
> 
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
> ---
>  package/gdb/gdb.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
> index cee7b37bcd..d9bfb39a41 100644
> --- a/package/gdb/gdb.mk
> +++ b/package/gdb/gdb.mk
> @@ -255,7 +255,8 @@ HOST_GDB_CONF_OPTS = \
>  	--with-system-zlib \
>  	--with-curses \
>  	--without-mpfr \
> -	$(GDB_DISABLE_BINUTILS_CONF_OPTS)
> +	$(GDB_DISABLE_BINUTILS_CONF_OPTS) \
> +	--disable-source-highlight

We like it better (but do not have clear rules bouat it) when the
unconditional options are passed first, and conditional ones last.

So I've inverted the order, and applied to master, thanks.

Regards,
Yann E. MORIN.

>  ifeq ($(BR2_PACKAGE_HOST_GDB_TUI),y)
>  HOST_GDB_CONF_OPTS += --enable-tui
> -- 
> 2.41.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/host-gdb: disable source-highlight

[Peter Korsgaard]

>>>>> "Bartosz" == Bartosz Bilas <b.bilas@grinn-global.com> writes:

 > This is the follow-up commit to the 4de60e4 which disables
 > sourcehighlight dependency for the target GDB package.
 > Do the same for the host variant to be sure that this
 > won't be picked up from the host system.

 > Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>

Committed to 2023.02.x and 2023.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot