Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] Add sysstat tools
@ 2009-10-09 13:48 Lionel Landwerlin
  2009-10-09 19:55 ` Lionel Landwerlin
  0 siblings, 1 reply; 6+ messages in thread
From: Lionel Landwerlin @ 2009-10-09 13:48 UTC (permalink / raw)
  To: buildroot


Signed-off-by: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
---
 package/Config.in                                  |    2 +
 package/sysstat/Config.in                          |    7 +++
 .../sysstat-9.0.5-Add-install-strip-rule.patch     |   54 ++++++++++++++++++++
 package/sysstat/sysstat.mk                         |   24 +++++++++
 4 files changed, 87 insertions(+), 0 deletions(-)
 create mode 100644 package/sysstat/Config.in
 create mode 100644 package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch
 create mode 100644 package/sysstat/sysstat.mk

diff --git a/package/Config.in b/package/Config.in
index c78fd31..f260ae4 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -270,6 +270,7 @@ if !BR2_PACKAGE_BUSYBOX_HIDE_OTHERS
 source "package/sfdisk/Config.in"
 endif
 source "package/smartmontools/Config.in"
+source "package/sysstat/Config.in"
 if !BR2_PACKAGE_BUSYBOX_HIDE_OTHERS
 # mdev
 source "package/udev/Config.in"
@@ -338,6 +339,7 @@ source "package/libglib12/Config.in"
 source "package/libglib2/Config.in"
 source "package/libgtk12/Config.in"
 source "package/libgtk2/Config.in"
+source "package/eina/Config.in"
 source "package/gtk2-engines/Config.in"
 source "package/gtk2-themes/Config.in"
 source "package/libsexy/Config.in"
diff --git a/package/sysstat/Config.in b/package/sysstat/Config.in
new file mode 100644
index 0000000..71bafc7
--- /dev/null
+++ b/package/sysstat/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_SYSSTAT
+	bool "sysstat"
+	help
+	  System performance tools for the Linux operating system...
+
+	  http://pagesperso-orange.fr/sebastien.godard/
+	  ftp://ibiblio.org/pub/Linux/system/status/
diff --git a/package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch b/package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch
new file mode 100644
index 0000000..afe335f
--- /dev/null
+++ b/package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch
@@ -0,0 +1,54 @@
+From ca95fbc6f26ab4601fe4e99ca530c9bf3b5df5aa Mon Sep 17 00:00:00 2001
+From: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
+Date: Fri, 9 Oct 2009 00:01:47 +0200
+Subject: [PATCH] Add install-strip rule
+
+Signed-off-by: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
+---
+ Makefile.in |   23 ++++++++++++++++++++++-
+ 1 files changed, 22 insertions(+), 1 deletions(-)
+
+diff --git a/Makefile.in b/Makefile.in
+index a54446b..6f1a0a8 100644
+--- a/Makefile.in
++++ b/Makefile.in
+@@ -81,7 +81,7 @@ ifndef ZIP
+ ZIP = @ZIP@
+ endif
+ 
+-# Settings 
++# Settings
+ NLS = @NLS@
+ ifeq ($(NLS),y)
+ REQUIRE_NLS = -DUSE_NLS -DPACKAGE=\"$(PACKAGE)\" -DLOCALEDIR=\"$(NLS_DIR)\"
+@@ -309,6 +309,27 @@ ifdef REQUIRE_NLS
+ 	$(INSTALL_DATA) nls/zh_TW.gmo $(DESTDIR)$(NLS_DIR)/zh_TW/LC_MESSAGES/$(PACKAGE).mo
+ endif
+ 
++install-strip: all sa1 sa2 contrib/isag/isag
++	mkdir -p $(DESTDIR)$(SA_LIB_DIR)
++	mkdir -p $(DESTDIR)$(SA_DIR)
++ifeq ($(CLEAN_SA_DIR),y)
++	find $(DESTDIR)$(SA_DIR) \( -name 'sar??' -o -name 'sa??' -o -name 'sar??.gz' -o -name 'sa??.gz' \) \
++		-exec rm -f {} \;
++	-rmdir --ignore-fail-on-non-empty $(DESTDIR)$(SA_DIR)/[0-9]?????
++endif
++	mkdir -p $(DESTDIR)$(BIN_DIR)
++	mkdir -p $(DESTDIR)$(SYSCONFIG_DIR)
++	$(INSTALL_BIN) sa1 $(DESTDIR)$(SA_LIB_DIR)
++	$(INSTALL_BIN) sa2 $(DESTDIR)$(SA_LIB_DIR)
++	$(INSTALL_BIN) sadc $(DESTDIR)$(SA_LIB_DIR)
++	$(INSTALL_BIN) sar $(DESTDIR)$(BIN_DIR)
++	$(INSTALL_BIN) sadf $(DESTDIR)$(BIN_DIR)
++	$(INSTALL_BIN) iostat $(DESTDIR)$(BIN_DIR)
++	$(INSTALL_BIN) mpstat $(DESTDIR)$(BIN_DIR)
++	$(INSTALL_BIN) pidstat $(DESTDIR)$(BIN_DIR)
++	$(INSTALL_DATA) sysstat.ioconf $(DESTDIR)$(SYSCONFIG_DIR)
++	$(INSTALL_DATA) sysstat.sysconfig $(DESTDIR)$(SYSCONFIG_DIR)/sysstat
++
+ install_base: all sa1 sa2 sysstat.sysconfig install_man install_nls \
+ 	contrib/isag/isag
+ 	mkdir -p $(DESTDIR)$(SA_LIB_DIR)
+-- 
+1.6.4.3
+
diff --git a/package/sysstat/sysstat.mk b/package/sysstat/sysstat.mk
new file mode 100644
index 0000000..cd8919f
--- /dev/null
+++ b/package/sysstat/sysstat.mk
@@ -0,0 +1,24 @@
+#############################################################
+#
+# sysstat
+#
+#############################################################
+
+SYSSTAT_VERSION = 9.0.5
+SYSSTAT_SOURCE = sysstat-$(SYSSTAT_VERSION).tar.bz2
+SYSSTAT_SITE = http://pagesperso-orange.fr/sebastien.godard/
+SYSSTAT_AUTORECONF = NO
+SYSSTAT_LIBTOOL_PATCH = NO
+SYSSTAT_INSTALL_STAGING = YES
+SYSSTAT_INSTALL_TARGET = YES
+
+SYSSTAT_DEPENDENCIES = uclibc
+
+# Should --disable-man-group ... WTF ?
+SYSSTAT_CONF_OPT = --enable-man-group
+
+EXPAT_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) \
+			INSTALL_ISAG=n \
+			INSTALL_DOC=n
+
+$(eval $(call AUTOTARGETS,package,sysstat))
-- 
1.6.4.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] Add sysstat tools
  2009-10-09 13:48 [Buildroot] [PATCH] Add sysstat tools Lionel Landwerlin
@ 2009-10-09 19:55 ` Lionel Landwerlin
  2009-10-18 14:05   ` Lionel Landwerlin
  0 siblings, 1 reply; 6+ messages in thread
From: Lionel Landwerlin @ 2009-10-09 19:55 UTC (permalink / raw)
  To: buildroot

Well... I mixed some patch with another and ...

Here the good one :

--

Add sysstat tools

Signed-off-by: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
---
 package/Config.in                                  |    1 +
 package/sysstat/Config.in                          |    7 +++
 .../sysstat-9.0.5-Add-install-strip-rule.patch     |   54 ++++++++++++++++++++
 package/sysstat/sysstat.mk                         |   24 +++++++++
 4 files changed, 86 insertions(+), 0 deletions(-)
 create mode 100644 package/sysstat/Config.in
 create mode 100644 package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch
 create mode 100644 package/sysstat/sysstat.mk

diff --git a/package/Config.in b/package/Config.in
index c78fd31..13c845e 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -270,6 +270,7 @@ if !BR2_PACKAGE_BUSYBOX_HIDE_OTHERS
 source "package/sfdisk/Config.in"
 endif
 source "package/smartmontools/Config.in"
+source "package/sysstat/Config.in"
 if !BR2_PACKAGE_BUSYBOX_HIDE_OTHERS
 # mdev
 source "package/udev/Config.in"
diff --git a/package/sysstat/Config.in b/package/sysstat/Config.in
new file mode 100644
index 0000000..71bafc7
--- /dev/null
+++ b/package/sysstat/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_SYSSTAT
+	bool "sysstat"
+	help
+	  System performance tools for the Linux operating system...
+
+	  http://pagesperso-orange.fr/sebastien.godard/
+	  ftp://ibiblio.org/pub/Linux/system/status/
diff --git a/package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch b/package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch
new file mode 100644
index 0000000..afe335f
--- /dev/null
+++ b/package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch
@@ -0,0 +1,54 @@
+From ca95fbc6f26ab4601fe4e99ca530c9bf3b5df5aa Mon Sep 17 00:00:00 2001
+From: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
+Date: Fri, 9 Oct 2009 00:01:47 +0200
+Subject: [PATCH] Add install-strip rule
+
+Signed-off-by: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
+---
+ Makefile.in |   23 ++++++++++++++++++++++-
+ 1 files changed, 22 insertions(+), 1 deletions(-)
+
+diff --git a/Makefile.in b/Makefile.in
+index a54446b..6f1a0a8 100644
+--- a/Makefile.in
++++ b/Makefile.in
+@@ -81,7 +81,7 @@ ifndef ZIP
+ ZIP = @ZIP@
+ endif
+ 
+-# Settings 
++# Settings
+ NLS = @NLS@
+ ifeq ($(NLS),y)
+ REQUIRE_NLS = -DUSE_NLS -DPACKAGE=\"$(PACKAGE)\" -DLOCALEDIR=\"$(NLS_DIR)\"
+@@ -309,6 +309,27 @@ ifdef REQUIRE_NLS
+ 	$(INSTALL_DATA) nls/zh_TW.gmo $(DESTDIR)$(NLS_DIR)/zh_TW/LC_MESSAGES/$(PACKAGE).mo
+ endif
+ 
++install-strip: all sa1 sa2 contrib/isag/isag
++	mkdir -p $(DESTDIR)$(SA_LIB_DIR)
++	mkdir -p $(DESTDIR)$(SA_DIR)
++ifeq ($(CLEAN_SA_DIR),y)
++	find $(DESTDIR)$(SA_DIR) \( -name 'sar??' -o -name 'sa??' -o -name 'sar??.gz' -o -name 'sa??.gz' \) \
++		-exec rm -f {} \;
++	-rmdir --ignore-fail-on-non-empty $(DESTDIR)$(SA_DIR)/[0-9]?????
++endif
++	mkdir -p $(DESTDIR)$(BIN_DIR)
++	mkdir -p $(DESTDIR)$(SYSCONFIG_DIR)
++	$(INSTALL_BIN) sa1 $(DESTDIR)$(SA_LIB_DIR)
++	$(INSTALL_BIN) sa2 $(DESTDIR)$(SA_LIB_DIR)
++	$(INSTALL_BIN) sadc $(DESTDIR)$(SA_LIB_DIR)
++	$(INSTALL_BIN) sar $(DESTDIR)$(BIN_DIR)
++	$(INSTALL_BIN) sadf $(DESTDIR)$(BIN_DIR)
++	$(INSTALL_BIN) iostat $(DESTDIR)$(BIN_DIR)
++	$(INSTALL_BIN) mpstat $(DESTDIR)$(BIN_DIR)
++	$(INSTALL_BIN) pidstat $(DESTDIR)$(BIN_DIR)
++	$(INSTALL_DATA) sysstat.ioconf $(DESTDIR)$(SYSCONFIG_DIR)
++	$(INSTALL_DATA) sysstat.sysconfig $(DESTDIR)$(SYSCONFIG_DIR)/sysstat
++
+ install_base: all sa1 sa2 sysstat.sysconfig install_man install_nls \
+ 	contrib/isag/isag
+ 	mkdir -p $(DESTDIR)$(SA_LIB_DIR)
+-- 
+1.6.4.3
+
diff --git a/package/sysstat/sysstat.mk b/package/sysstat/sysstat.mk
new file mode 100644
index 0000000..cd8919f
--- /dev/null
+++ b/package/sysstat/sysstat.mk
@@ -0,0 +1,24 @@
+#############################################################
+#
+# sysstat
+#
+#############################################################
+
+SYSSTAT_VERSION = 9.0.5
+SYSSTAT_SOURCE = sysstat-$(SYSSTAT_VERSION).tar.bz2
+SYSSTAT_SITE = http://pagesperso-orange.fr/sebastien.godard/
+SYSSTAT_AUTORECONF = NO
+SYSSTAT_LIBTOOL_PATCH = NO
+SYSSTAT_INSTALL_STAGING = YES
+SYSSTAT_INSTALL_TARGET = YES
+
+SYSSTAT_DEPENDENCIES = uclibc
+
+# Should --disable-man-group ... WTF ?
+SYSSTAT_CONF_OPT = --enable-man-group
+
+EXPAT_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) \
+			INSTALL_ISAG=n \
+			INSTALL_DOC=n
+
+$(eval $(call AUTOTARGETS,package,sysstat))
-- 
1.6.4.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] Add sysstat tools
  2009-10-09 19:55 ` Lionel Landwerlin
@ 2009-10-18 14:05   ` Lionel Landwerlin
  2009-10-18 15:47     ` Bernhard Reutner-Fischer
  0 siblings, 1 reply; 6+ messages in thread
From: Lionel Landwerlin @ 2009-10-18 14:05 UTC (permalink / raw)
  To: buildroot

ping ?

Maybe I should add some informations about this package.

The sysstat package provides a great tool named sar, which gives
informations about cpu consumption in user/system context, as well as
number of page faults per seconds, or number of blocks read from
devices, etc...
It's a good tool to tune performances on a system/cpu with software
managed TLB (sh, mips or ppc).


Le vendredi 09 octobre 2009 ? 21:55 +0200, Lionel Landwerlin a ?crit :
> Well... I mixed some patch with another and ...
> 
> Here the good one :
> 
> --
> 
> Add sysstat tools
> 
> Signed-off-by: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
> ---
>  package/Config.in                                  |    1 +
>  package/sysstat/Config.in                          |    7 +++
>  .../sysstat-9.0.5-Add-install-strip-rule.patch     |   54 ++++++++++++++++++++
>  package/sysstat/sysstat.mk                         |   24 +++++++++
>  4 files changed, 86 insertions(+), 0 deletions(-)
>  create mode 100644 package/sysstat/Config.in
>  create mode 100644 package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch
>  create mode 100644 package/sysstat/sysstat.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index c78fd31..13c845e 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -270,6 +270,7 @@ if !BR2_PACKAGE_BUSYBOX_HIDE_OTHERS
>  source "package/sfdisk/Config.in"
>  endif
>  source "package/smartmontools/Config.in"
> +source "package/sysstat/Config.in"
>  if !BR2_PACKAGE_BUSYBOX_HIDE_OTHERS
>  # mdev
>  source "package/udev/Config.in"
> diff --git a/package/sysstat/Config.in b/package/sysstat/Config.in
> new file mode 100644
> index 0000000..71bafc7
> --- /dev/null
> +++ b/package/sysstat/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_SYSSTAT
> +	bool "sysstat"
> +	help
> +	  System performance tools for the Linux operating system...
> +
> +	  http://pagesperso-orange.fr/sebastien.godard/
> +	  ftp://ibiblio.org/pub/Linux/system/status/
> diff --git a/package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch b/package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch
> new file mode 100644
> index 0000000..afe335f
> --- /dev/null
> +++ b/package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch
> @@ -0,0 +1,54 @@
> +From ca95fbc6f26ab4601fe4e99ca530c9bf3b5df5aa Mon Sep 17 00:00:00 2001
> +From: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
> +Date: Fri, 9 Oct 2009 00:01:47 +0200
> +Subject: [PATCH] Add install-strip rule
> +
> +Signed-off-by: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
> +---
> + Makefile.in |   23 ++++++++++++++++++++++-
> + 1 files changed, 22 insertions(+), 1 deletions(-)
> +
> +diff --git a/Makefile.in b/Makefile.in
> +index a54446b..6f1a0a8 100644
> +--- a/Makefile.in
> ++++ b/Makefile.in
> +@@ -81,7 +81,7 @@ ifndef ZIP
> + ZIP = @ZIP@
> + endif
> + 
> +-# Settings 
> ++# Settings
> + NLS = @NLS@
> + ifeq ($(NLS),y)
> + REQUIRE_NLS = -DUSE_NLS -DPACKAGE=\"$(PACKAGE)\" -DLOCALEDIR=\"$(NLS_DIR)\"
> +@@ -309,6 +309,27 @@ ifdef REQUIRE_NLS
> + 	$(INSTALL_DATA) nls/zh_TW.gmo $(DESTDIR)$(NLS_DIR)/zh_TW/LC_MESSAGES/$(PACKAGE).mo
> + endif
> + 
> ++install-strip: all sa1 sa2 contrib/isag/isag
> ++	mkdir -p $(DESTDIR)$(SA_LIB_DIR)
> ++	mkdir -p $(DESTDIR)$(SA_DIR)
> ++ifeq ($(CLEAN_SA_DIR),y)
> ++	find $(DESTDIR)$(SA_DIR) \( -name 'sar??' -o -name 'sa??' -o -name 'sar??.gz' -o -name 'sa??.gz' \) \
> ++		-exec rm -f {} \;
> ++	-rmdir --ignore-fail-on-non-empty $(DESTDIR)$(SA_DIR)/[0-9]?????
> ++endif
> ++	mkdir -p $(DESTDIR)$(BIN_DIR)
> ++	mkdir -p $(DESTDIR)$(SYSCONFIG_DIR)
> ++	$(INSTALL_BIN) sa1 $(DESTDIR)$(SA_LIB_DIR)
> ++	$(INSTALL_BIN) sa2 $(DESTDIR)$(SA_LIB_DIR)
> ++	$(INSTALL_BIN) sadc $(DESTDIR)$(SA_LIB_DIR)
> ++	$(INSTALL_BIN) sar $(DESTDIR)$(BIN_DIR)
> ++	$(INSTALL_BIN) sadf $(DESTDIR)$(BIN_DIR)
> ++	$(INSTALL_BIN) iostat $(DESTDIR)$(BIN_DIR)
> ++	$(INSTALL_BIN) mpstat $(DESTDIR)$(BIN_DIR)
> ++	$(INSTALL_BIN) pidstat $(DESTDIR)$(BIN_DIR)
> ++	$(INSTALL_DATA) sysstat.ioconf $(DESTDIR)$(SYSCONFIG_DIR)
> ++	$(INSTALL_DATA) sysstat.sysconfig $(DESTDIR)$(SYSCONFIG_DIR)/sysstat
> ++
> + install_base: all sa1 sa2 sysstat.sysconfig install_man install_nls \
> + 	contrib/isag/isag
> + 	mkdir -p $(DESTDIR)$(SA_LIB_DIR)
> +-- 
> +1.6.4.3
> +
> diff --git a/package/sysstat/sysstat.mk b/package/sysstat/sysstat.mk
> new file mode 100644
> index 0000000..cd8919f
> --- /dev/null
> +++ b/package/sysstat/sysstat.mk
> @@ -0,0 +1,24 @@
> +#############################################################
> +#
> +# sysstat
> +#
> +#############################################################
> +
> +SYSSTAT_VERSION = 9.0.5
> +SYSSTAT_SOURCE = sysstat-$(SYSSTAT_VERSION).tar.bz2
> +SYSSTAT_SITE = http://pagesperso-orange.fr/sebastien.godard/
> +SYSSTAT_AUTORECONF = NO
> +SYSSTAT_LIBTOOL_PATCH = NO
> +SYSSTAT_INSTALL_STAGING = YES
> +SYSSTAT_INSTALL_TARGET = YES
> +
> +SYSSTAT_DEPENDENCIES = uclibc
> +
> +# Should --disable-man-group ... WTF ?
> +SYSSTAT_CONF_OPT = --enable-man-group
> +
> +EXPAT_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) \
> +			INSTALL_ISAG=n \
> +			INSTALL_DOC=n
> +
> +$(eval $(call AUTOTARGETS,package,sysstat))

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] Add sysstat tools
  2009-10-18 14:05   ` Lionel Landwerlin
@ 2009-10-18 15:47     ` Bernhard Reutner-Fischer
  2009-10-18 19:03       ` Lionel Landwerlin
  0 siblings, 1 reply; 6+ messages in thread
From: Bernhard Reutner-Fischer @ 2009-10-18 15:47 UTC (permalink / raw)
  To: buildroot

On Sun, Oct 18, 2009 at 04:05:45PM +0200, Lionel Landwerlin wrote:
>ping ?
>
>Maybe I should add some informations about this package.
>
>The sysstat package provides a great tool named sar, which gives
>informations about cpu consumption in user/system context, as well as
>number of page faults per seconds, or number of blocks read from
>devices, etc...
>It's a good tool to tune performances on a system/cpu with software
>managed TLB (sh, mips or ppc).

>> --- /dev/null
>> +++ b/package/sysstat/Config.in
>> @@ -0,0 +1,7 @@
>> +config BR2_PACKAGE_SYSSTAT
>> +	bool "sysstat"
>> +	help
>> +	  System performance tools for the Linux operating system...

too many dots. Perhaps put your expanded description in here too.

>> diff --git a/package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch b/package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch
>> new file mode 100644
>> index 0000000..afe335f
>> --- /dev/null
>> +++ b/package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch

You sent this to upstream already, yes?

>> diff --git a/package/sysstat/sysstat.mk b/package/sysstat/sysstat.mk
>> new file mode 100644
>> index 0000000..cd8919f
>> --- /dev/null
>> +++ b/package/sysstat/sysstat.mk
>> @@ -0,0 +1,24 @@
>> +#############################################################
>> +#
>> +# sysstat
>> +#
>> +#############################################################
>> +
>> +SYSSTAT_VERSION = 9.0.5
>> +SYSSTAT_SOURCE = sysstat-$(SYSSTAT_VERSION).tar.bz2
>> +SYSSTAT_SITE = http://pagesperso-orange.fr/sebastien.godard/
>> +SYSSTAT_AUTORECONF = NO
>> +SYSSTAT_LIBTOOL_PATCH = NO
>> +SYSSTAT_INSTALL_STAGING = YES
>> +SYSSTAT_INSTALL_TARGET = YES
>> +
>> +SYSSTAT_DEPENDENCIES = uclibc

Every mention of uclibc as dependency of package/* is wrong (since
uclibc and the cross compiler et al are already deps for any target
package).
>> +
>> +# Should --disable-man-group ... WTF ?
>> +SYSSTAT_CONF_OPT = --enable-man-group
>> +
>> +EXPAT_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) \
>> +			INSTALL_ISAG=n \
>> +			INSTALL_DOC=n

what's ISAG ?
INSTALL_DOC would be yes if BR2_HAVE_DOCUMENTATION.
$(if $(BR2_HAVE_DOCUMENTATION),,INSTALL_DOC=n)

thanks,

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] Add sysstat tools
  2009-10-18 15:47     ` Bernhard Reutner-Fischer
@ 2009-10-18 19:03       ` Lionel Landwerlin
  2009-10-20 21:11         ` Peter Korsgaard
  0 siblings, 1 reply; 6+ messages in thread
From: Lionel Landwerlin @ 2009-10-18 19:03 UTC (permalink / raw)
  To: buildroot

Hi Bernhard,

Thanks a lot for reviewing my patch. I made some correction following
your review :

      * The description has been completed (from the sysstat website).
      * I rebased my patch on the last git revision and the
        install-strip rule doesn't seem required anymore, so I removed
        the patch.
      * Removed dependency on uclibc.
      * Filled INSTALL_DOC according to BR2_HAVE_DOCUMENTATION.
      * And last, INSTALL_ISAG is set to 'n' to avoid the isag script
        installation which is a postprocessing script depending on
        tcl/tk.

Maybe later I will add the rules for host installation, but it doesn't
look like a high priority to me.

Here is a new patch :

[PATCH] Add sysstat tools

Signed-off-by: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
---
 package/Config.in          |    3 ++-
 package/sysstat/Config.in  |   40 ++++++++++++++++++++++++++++++++++++++++
 package/sysstat/sysstat.mk |   26 ++++++++++++++++++++++++++
 3 files changed, 68 insertions(+), 1 deletions(-)
 create mode 100644 package/sysstat/Config.in
 create mode 100644 package/sysstat/sysstat.mk

diff --git a/package/Config.in b/package/Config.in
index ff7fc3d..aa02d2b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -270,7 +270,8 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/sfdisk/Config.in"
 endif
 source "package/smartmontools/Config.in"
-if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
+source "package/sysstat/Config.in"
+if BR2_PACKAGE_BUSYBOX_HIDE_OTHERS
 # mdev
 source "package/udev/Config.in"
 endif
diff --git a/package/sysstat/Config.in b/package/sysstat/Config.in
new file mode 100644
index 0000000..7e3c707
--- /dev/null
+++ b/package/sysstat/Config.in
@@ -0,0 +1,40 @@
+config BR2_PACKAGE_SYSSTAT
+	bool "sysstat"
+	help
+          The sysstat utilities are a collection of performance
+          monitoring tools for Linux. These include sar, sadf, mpstat,
+          iostat, pidstat and sa tools.
+
+          Some Features :
+
+           * Input / Output and transfer rate statistics (global, per
+             device, per partition, per network filesystem and per
+             Linux task / PID)
+           * CPU statistics (global, per CPU and per Linux task /
+             PID), including support for virtualization architectures
+           * Memory and swap space utilization statistics
+           * Virtual memory, paging and fault statistics
+           * Per-task (per-PID) memory and page fault statistics
+           * Global CPU and page fault statistics for tasks and all
+             their children
+           * Process creation activity
+           * Interrupt statistics (global, per CPU and per interrupt,
+             including potential APIC interrupt sources)
+           * Extensive network statistics: network interface activity
+             (number of packets and kB received and transmitted per
+             second, etc.) including failures from network devices;
+             network traffic statistics for IP, TCP, ICMP and UDP
+             protocols based on SNMPv2 standards; support for
+             IPv6-related protocols.
+           * NFS server and client activity
+           * Socket statistics
+           * Run queue and system load statistics
+           * Kernel internal tables utilization statistics
+           * System and per Linux task switching activity
+           * Swapping statistics
+           * TTY device activity
+           * Power management statistics
+
+
+	  http://pagesperso-orange.fr/sebastien.godard/
+	  ftp://ibiblio.org/pub/Linux/system/status/
diff --git a/package/sysstat/sysstat.mk b/package/sysstat/sysstat.mk
new file mode 100644
index 0000000..a1be274
--- /dev/null
+++ b/package/sysstat/sysstat.mk
@@ -0,0 +1,26 @@
+#############################################################
+#
+# sysstat
+#
+#############################################################
+
+SYSSTAT_VERSION = 9.0.5
+SYSSTAT_SOURCE = sysstat-$(SYSSTAT_VERSION).tar.bz2
+SYSSTAT_SITE = http://pagesperso-orange.fr/sebastien.godard/
+SYSSTAT_AUTORECONF = NO
+SYSSTAT_LIBTOOL_PATCH = NO
+SYSSTAT_INSTALL_STAGING = YES
+SYSSTAT_INSTALL_TARGET = YES
+
+# Should be --disable-man-group, it might be a little mistake in the
+# configure.in script.
+SYSSTAT_CONF_OPT = --enable-man-group
+ifneq ($(BR2_HAVE_DOCUMENTATION),y)
+SYSSTAT_CONF_OPT += --disable-documentation
+endif
+
+# The isag tool is a post processing script that depends on tcl/tk
+# among other things. So we don't install it.
+SYSSTAT_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) INSTALL_ISAG=n
+
+$(eval $(call AUTOTARGETS,package,sysstat))
-- 
1.6.4.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] Add sysstat tools
  2009-10-18 19:03       ` Lionel Landwerlin
@ 2009-10-20 21:11         ` Peter Korsgaard
  0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2009-10-20 21:11 UTC (permalink / raw)
  To: buildroot

>>>>> "Lionel" == Lionel Landwerlin <lionel.landwerlin@openwide.fr> writes:

 Lionel> Hi Bernhard,
 Lionel> Thanks a lot for reviewing my patch. I made some correction following
 Lionel> your review :

 Lionel>       * The description has been completed (from the sysstat website).
 Lionel>       * I rebased my patch on the last git revision and the
 Lionel>         install-strip rule doesn't seem required anymore, so I removed
 Lionel>         the patch.
 Lionel>       * Removed dependency on uclibc.
 Lionel>       * Filled INSTALL_DOC according to BR2_HAVE_DOCUMENTATION.
 Lionel>       * And last, INSTALL_ISAG is set to 'n' to avoid the isag script
 Lionel>         installation which is a postprocessing script depending on
 Lionel>         tcl/tk.

Thanks, committed. There were still a few minor issues, but I've fixed
those myself.

 Lionel> Maybe later I will add the rules for host installation, but it doesn't
 Lionel> look like a high priority to me.

 Lionel> Here is a new patch :

 Lionel> [PATCH] Add sysstat tools

 Lionel> Signed-off-by: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
 Lionel> ---
 Lionel>  package/Config.in          |    3 ++-
 Lionel>  package/sysstat/Config.in  |   40 ++++++++++++++++++++++++++++++++++++++++
 Lionel>  package/sysstat/sysstat.mk |   26 ++++++++++++++++++++++++++
 Lionel>  3 files changed, 68 insertions(+), 1 deletions(-)
 Lionel>  create mode 100644 package/sysstat/Config.in
 Lionel>  create mode 100644 package/sysstat/sysstat.mk

 Lionel> diff --git a/package/Config.in b/package/Config.in
 Lionel> index ff7fc3d..aa02d2b 100644
 Lionel> --- a/package/Config.in
 Lionel> +++ b/package/Config.in
 Lionel> @@ -270,7 +270,8 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 Lionel>  source "package/sfdisk/Config.in"
 Lionel>  endif
 Lionel>  source "package/smartmontools/Config.in"
 Lionel> -if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 Lionel> +source "package/sysstat/Config.in"
 Lionel> +if BR2_PACKAGE_BUSYBOX_HIDE_OTHERS

Don't change SHOW_OTHERS to HIDE_OTHERS.

 Lionel> +
 Lionel> +	  http://pagesperso-orange.fr/sebastien.godard/
 Lionel> +	  ftp://ibiblio.org/pub/Linux/system/status/


One URL should be enough.


 Lionel> +SYSSTAT_SOURCE = sysstat-$(SYSSTAT_VERSION).tar.bz2
 Lionel> +SYSSTAT_SITE = http://pagesperso-orange.fr/sebastien.godard/
 Lionel> +SYSSTAT_AUTORECONF = NO
 Lionel> +SYSSTAT_LIBTOOL_PATCH = NO
 Lionel> +SYSSTAT_INSTALL_STAGING = YES


sysstat is a collection of programs, not a library - So there afaik
isn't any reason to install into staging.


 Lionel> +SYSSTAT_INSTALL_TARGET = YES
 Lionel> +
 Lionel> +# Should be --disable-man-group, it might be a little mistake in the
 Lionel> +# configure.in script.
 Lionel> +SYSSTAT_CONF_OPT = --enable-man-group
 Lionel> +ifneq ($(BR2_HAVE_DOCUMENTATION),y)
 Lionel> +SYSSTAT_CONF_OPT += --disable-documentation
 Lionel> +endif
 Lionel> +
 Lionel> +# The isag tool is a post processing script that depends on tcl/tk
 Lionel> +# among other things. So we don't install it.
 Lionel> +SYSSTAT_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) INSTALL_ISAG=n

You are forgetting to add a make target (E.G. install), so nothing will
get installed.


-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2009-10-20 21:11 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-09 13:48 [Buildroot] [PATCH] Add sysstat tools Lionel Landwerlin
2009-10-09 19:55 ` Lionel Landwerlin
2009-10-18 14:05   ` Lionel Landwerlin
2009-10-18 15:47     ` Bernhard Reutner-Fischer
2009-10-18 19:03       ` Lionel Landwerlin
2009-10-20 21:11         ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox