* [Buildroot] [PATCHv2] e2fsprogs: Install libraries to staging
@ 2013-11-28 17:53 Daniel Nyström
2013-11-28 18:23 ` Thomas Petazzoni
2014-01-22 13:08 ` Gustavo Zacarias
0 siblings, 2 replies; 6+ messages in thread
From: Daniel Nyström @ 2013-11-28 17:53 UTC (permalink / raw)
To: buildroot
Signed-off-by: Daniel Nystr?m <daniel.nystrom@timeterminal.se>
---
package/e2fsprogs/e2fsprogs.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/e2fsprogs/e2fsprogs.mk b/package/e2fsprogs/e2fsprogs.mk
index 0670c74..31e671b 100644
--- a/package/e2fsprogs/e2fsprogs.mk
+++ b/package/e2fsprogs/e2fsprogs.mk
@@ -8,6 +8,8 @@ E2FSPROGS_VERSION = 1.42.8
E2FSPROGS_SITE = http://downloads.sourceforge.net/project/e2fsprogs/e2fsprogs/v$(E2FSPROGS_VERSION)
E2FSPROGS_LICENSE = GPLv2, libuuid BSD-3c, libss and libet MIT-like with advertising clause
E2FSPROGS_LICENSE_FILES = COPYING lib/uuid/COPYING lib/ss/mit-sipb-copyright.h lib/et/internal.h
+E2FSPROGS_INSTALL_STAGING = YES
+E2FSPROGS_INSTALL_STAGING_OPT = DESTDIR=$(STAGING_DIR) install-libs
E2FSPROGS_CONF_OPT = \
--disable-tls \
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCHv2] e2fsprogs: Install libraries to staging
2013-11-28 17:53 [Buildroot] [PATCHv2] e2fsprogs: Install libraries to staging Daniel Nyström
@ 2013-11-28 18:23 ` Thomas Petazzoni
2013-11-30 21:26 ` Arnout Vandecappelle
2014-01-22 13:13 ` Gustavo Zacarias
2014-01-22 13:08 ` Gustavo Zacarias
1 sibling, 2 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2013-11-28 18:23 UTC (permalink / raw)
To: buildroot
Dear Daniel Nystr?m,
On Thu, 28 Nov 2013 18:53:57 +0100, Daniel Nystr?m wrote:
> Signed-off-by: Daniel Nystr?m <daniel.nystrom@timeterminal.se>
> ---
> package/e2fsprogs/e2fsprogs.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/e2fsprogs/e2fsprogs.mk b/package/e2fsprogs/e2fsprogs.mk
> index 0670c74..31e671b 100644
> --- a/package/e2fsprogs/e2fsprogs.mk
> +++ b/package/e2fsprogs/e2fsprogs.mk
> @@ -8,6 +8,8 @@ E2FSPROGS_VERSION = 1.42.8
> E2FSPROGS_SITE = http://downloads.sourceforge.net/project/e2fsprogs/e2fsprogs/v$(E2FSPROGS_VERSION)
> E2FSPROGS_LICENSE = GPLv2, libuuid BSD-3c, libss and libet MIT-like with advertising clause
> E2FSPROGS_LICENSE_FILES = COPYING lib/uuid/COPYING lib/ss/mit-sipb-copyright.h lib/et/internal.h
> +E2FSPROGS_INSTALL_STAGING = YES
> +E2FSPROGS_INSTALL_STAGING_OPT = DESTDIR=$(STAGING_DIR) install-libs
I must say I'd like to know *why* the normal "install" rule does not
install the .pc file. It seems to install everything else, including
the libraries, but not the .pc file, for some reason.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCHv2] e2fsprogs: Install libraries to staging
2013-11-28 18:23 ` Thomas Petazzoni
@ 2013-11-30 21:26 ` Arnout Vandecappelle
2014-01-22 13:13 ` Gustavo Zacarias
1 sibling, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2013-11-30 21:26 UTC (permalink / raw)
To: buildroot
On 28/11/13 19:23, Thomas Petazzoni wrote:
> Dear Daniel Nystr?m,
>
> On Thu, 28 Nov 2013 18:53:57 +0100, Daniel Nystr?m wrote:
>> Signed-off-by: Daniel Nystr?m <daniel.nystrom@timeterminal.se>
>> ---
>> package/e2fsprogs/e2fsprogs.mk | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/package/e2fsprogs/e2fsprogs.mk b/package/e2fsprogs/e2fsprogs.mk
>> index 0670c74..31e671b 100644
>> --- a/package/e2fsprogs/e2fsprogs.mk
>> +++ b/package/e2fsprogs/e2fsprogs.mk
>> @@ -8,6 +8,8 @@ E2FSPROGS_VERSION = 1.42.8
>> E2FSPROGS_SITE = http://downloads.sourceforge.net/project/e2fsprogs/e2fsprogs/v$(E2FSPROGS_VERSION)
>> E2FSPROGS_LICENSE = GPLv2, libuuid BSD-3c, libss and libet MIT-like with advertising clause
>> E2FSPROGS_LICENSE_FILES = COPYING lib/uuid/COPYING lib/ss/mit-sipb-copyright.h lib/et/internal.h
>> +E2FSPROGS_INSTALL_STAGING = YES
>> +E2FSPROGS_INSTALL_STAGING_OPT = DESTDIR=$(STAGING_DIR) install-libs
>
> I must say I'd like to know *why* the normal "install" rule does not
> install the .pc file. It seems to install everything else, including
> the libraries, but not the .pc file, for some reason.
I would actually prefer an (upstreamable) patch to e2fsprogs that fixes
the install rule, rather than overriding the install commands.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCHv2] e2fsprogs: Install libraries to staging
2013-11-28 17:53 [Buildroot] [PATCHv2] e2fsprogs: Install libraries to staging Daniel Nyström
2013-11-28 18:23 ` Thomas Petazzoni
@ 2014-01-22 13:08 ` Gustavo Zacarias
2014-01-22 20:45 ` Peter Korsgaard
1 sibling, 1 reply; 6+ messages in thread
From: Gustavo Zacarias @ 2014-01-22 13:08 UTC (permalink / raw)
To: buildroot
On 11/28/2013 02:53 PM, Daniel Nystr?m wrote:
> Signed-off-by: Daniel Nystr?m <daniel.nystrom@timeterminal.se>
Acked-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCHv2] e2fsprogs: Install libraries to staging
2013-11-28 18:23 ` Thomas Petazzoni
2013-11-30 21:26 ` Arnout Vandecappelle
@ 2014-01-22 13:13 ` Gustavo Zacarias
1 sibling, 0 replies; 6+ messages in thread
From: Gustavo Zacarias @ 2014-01-22 13:13 UTC (permalink / raw)
To: buildroot
On 11/28/2013 03:23 PM, Thomas Petazzoni wrote:
>> +E2FSPROGS_INSTALL_STAGING = YES
>> +E2FSPROGS_INSTALL_STAGING_OPT = DESTDIR=$(STAGING_DIR) install-libs
>
> I must say I'd like to know *why* the normal "install" rule does not
> install the .pc file. It seems to install everything else, including
> the libraries, but not the .pc file, for some reason.
Fair enough, when calling install in the toplevel Makefile.in calling
install-libs has some conditions:
if test ! -d e2fsck && test ! -d debugfs && test ! -d misc && test ! -d
ext2ed ; then $(MAKE) install-libs ; fi
Since those directories exist install-libs is never called internally,
just install-shlibs-recursive which doesn't install the pc files.
My $.02 guess is that rule was written for e2fsprogs-libs which is the
recommended way to get the libs (blkid/et/quota/ss/uuid) since it lacks
those directories and has the same condition on the toplevel Makefile.in
It might be worth analyzing if we want to split, some distros do it that
way and it would reduce build times a bit in some scenarios.
Regards.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCHv2] e2fsprogs: Install libraries to staging
2014-01-22 13:08 ` Gustavo Zacarias
@ 2014-01-22 20:45 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2014-01-22 20:45 UTC (permalink / raw)
To: buildroot
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:
> On 11/28/2013 02:53 PM, Daniel Nystr?m wrote:
>> Signed-off-by: Daniel Nystr?m <daniel.nystrom@timeterminal.se>
> Acked-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-01-22 20:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-28 17:53 [Buildroot] [PATCHv2] e2fsprogs: Install libraries to staging Daniel Nyström
2013-11-28 18:23 ` Thomas Petazzoni
2013-11-30 21:26 ` Arnout Vandecappelle
2014-01-22 13:13 ` Gustavo Zacarias
2014-01-22 13:08 ` Gustavo Zacarias
2014-01-22 20:45 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox