[Buildroot] [PATCH] fix broken path in arm_toolchain_defconfig

[Buildroot] [PATCH] fix broken path in arm_toolchain_defconfig

[Chih-Min Chao]

The path of device_table.txt in arm_toolchain_defconfig is broken.
The patch fix it and use target/generic/device_table.txt as default setting
Please see the attached
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100514/16ccf5a8/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: arm_toolchain_defconfig.patch
Type: text/x-patch
Size: 688 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100514/16ccf5a8/attachment.bin>

[Buildroot] [PATCH] fix broken path in arm_toolchain_defconfig

[Thomas Petazzoni]

On Fri, 14 May 2010 16:12:05 +0800
Chih-Min Chao <cmchao@gmail.com> wrote:

> The path of device_table.txt in arm_toolchain_defconfig is broken.
> The patch fix it and use target/generic/device_table.txt as default setting

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

You forgot the Signed-off-by line in the commit log, however.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] fix broken path in arm_toolchain_defconfig

[Chih-Min Chao]

On Wed, May 19, 2010 at 7:34 PM, Thomas Petazzoni <
thomas.petazzoni@free-electrons.com> wrote:

> On Fri, 14 May 2010 16:12:05 +0800
> Chih-Min Chao <cmchao@gmail.com> wrote:
>
> > The path of device_table.txt in arm_toolchain_defconfig is broken.
> > The patch fix it and use target/generic/device_table.txt as default
> setting
>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> You forgot the Signed-off-by line in the commit log, however.
> Thomas
>

So, should I generate the patch by "git format-patch --signoff
revision_range" ??
If the answer is yes, the attached is the reformat patch with sign-off-by
information


> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100521/43b03fe3/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix-device_table.txt-path-in-arm_toolchain_defconfig.patch
Type: text/x-patch
Size: 873 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100521/43b03fe3/attachment.bin>

[Buildroot] [PATCH] fix broken path in arm_toolchain_defconfig

[Thomas Petazzoni]

On Fri, 21 May 2010 15:12:13 +0800
Chih-Min Chao <cmchao@gmail.com> wrote:

> So, should I generate the patch by "git format-patch --signoff
> revision_range" ??

It is usually at commit time that the signed-off line is added, by
doing :

  git commit -s

instead of just

  git commit

Typical very basic work-flow :

 # Assuming you are on master

 # Create a new branch for your work and switch to this branch
 git checkout -b mywork

 # Hack hack hack

 # Commit your work (supposing you want to all changes in a single
 # commit, which may or may not be appropriate)
 git commit -a -s

 # Format the patch (or patches)
 git format-patch master

 # Send the patch
 git send-email --to buildroot at uclibc.org *.patch

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] fix broken path in arm_toolchain_defconfig

[Peter Korsgaard]

>>>>> "Chih-Min" == Chih-Min Chao <cmchao@gmail.com> writes:


 Chih-Min> So, should I generate the patch by "git format-patch --signoff? revision_range"
 Chih-Min> ??
 Chih-Min> If the answer is yes, the attached is the reformat patch with sign-off-by
 Chih-Min> information

Committed, thanks!
-- 
Bye, Peter Korsgaard