Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] svn commit: trunk/buildroot/package/webkit
@ 2008-04-24 13:22 ninevoltz at uclibc.org
  0 siblings, 0 replies; 17+ messages in thread
From: ninevoltz at uclibc.org @ 2008-04-24 13:22 UTC (permalink / raw)
  To: buildroot

Author: ninevoltz
Date: 2008-04-24 06:22:34 -0700 (Thu, 24 Apr 2008)
New Revision: 21837

Log:
update webkit version

Modified:
   trunk/buildroot/package/webkit/webkit.mk


Changeset:
Modified: trunk/buildroot/package/webkit/webkit.mk
===================================================================
--- trunk/buildroot/package/webkit/webkit.mk	2008-04-24 13:22:14 UTC (rev 21836)
+++ trunk/buildroot/package/webkit/webkit.mk	2008-04-24 13:22:34 UTC (rev 21837)
@@ -3,7 +3,7 @@
 # webkit
 #
 #############################################################
-WEBKIT_VERSION = r30574
+WEBKIT_VERSION = r31321
 WEBKIT_SOURCE = WebKit-$(WEBKIT_VERSION).tar.bz2
 WEBKIT_SITE = http://nightly.webkit.org/files/trunk/src/
 

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/webkit
@ 2009-01-23 17:49 ulf at uclibc.org
  2009-01-27  0:27 ` Hamish Moffatt
  0 siblings, 1 reply; 17+ messages in thread
From: ulf at uclibc.org @ 2009-01-23 17:49 UTC (permalink / raw)
  To: buildroot

Author: ulf
Date: 2009-01-23 17:49:07 +0000 (Fri, 23 Jan 2009)
New Revision: 24983

Log:
Disable webkit (with comment) if X is not available

Modified:
   trunk/buildroot/package/webkit/Config.in


Changeset:
Modified: trunk/buildroot/package/webkit/Config.in
===================================================================
--- trunk/buildroot/package/webkit/Config.in	2009-01-23 17:48:49 UTC (rev 24982)
+++ trunk/buildroot/package/webkit/Config.in	2009-01-23 17:49:07 UTC (rev 24983)
@@ -1,13 +1,18 @@
 config BR2_PACKAGE_WEBKIT
 	bool "webkit"
-	select BR2_PACKAGE_LIBGTK2
 	select BR2_PACKAGE_ICU
 	select BR2_PACKAGE_CURL
 	select BR2_PACKAGE_LIBXML2
 	select BR2_PACKAGE_LIBXSLT
+	select BR2_PACKAGE_LIBGTK2
 	select BR2_PACKAGE_SQLITE
+	depends on !BR2_PACKAGE_XSERVER_none
 	help
 		WebKit is an open source, standards compliant web browser engine.
+		It runs on top of X-Windows
 
 		http://webkit.org/
 
+comment "webkit       - disabled (requires X-Windows)"
+	depends on BR2_PACKAGE_XSERVER_none
+

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/webkit
  2009-01-23 17:49 ulf at uclibc.org
@ 2009-01-27  0:27 ` Hamish Moffatt
  2009-01-27  8:25   ` Daniel Laird
  0 siblings, 1 reply; 17+ messages in thread
From: Hamish Moffatt @ 2009-01-27  0:27 UTC (permalink / raw)
  To: buildroot

On Fri, Jan 23, 2009 at 05:49:08PM +0000, ulf at uclibc.org wrote:
> Author: ulf
> Date: 2009-01-23 17:49:07 +0000 (Fri, 23 Jan 2009)
> New Revision: 24983
> 
> Log:
> Disable webkit (with comment) if X is not available
> 
> Modified:
>    trunk/buildroot/package/webkit/Config.in
> 
> 
> Changeset:
> Modified: trunk/buildroot/package/webkit/Config.in
> ===================================================================
> --- trunk/buildroot/package/webkit/Config.in	2009-01-23 17:48:49 UTC (rev 24982)
> +++ trunk/buildroot/package/webkit/Config.in	2009-01-23 17:49:07 UTC (rev 24983)
> @@ -1,13 +1,18 @@
>  config BR2_PACKAGE_WEBKIT
>  	bool "webkit"
> -	select BR2_PACKAGE_LIBGTK2
>  	select BR2_PACKAGE_ICU
>  	select BR2_PACKAGE_CURL
>  	select BR2_PACKAGE_LIBXML2
>  	select BR2_PACKAGE_LIBXSLT
> +	select BR2_PACKAGE_LIBGTK2
>  	select BR2_PACKAGE_SQLITE
> +	depends on !BR2_PACKAGE_XSERVER_none

That's not a good test of X availability. You should check for X
libraries only, as the X server may be remote.

Hamish
-- 
Hamish Moffatt VK3SB <hamish@debian.org> <hamish@cloud.net.au>

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/webkit
  2009-01-27  0:27 ` Hamish Moffatt
@ 2009-01-27  8:25   ` Daniel Laird
  2009-01-27  8:57     ` Peter Korsgaard
  0 siblings, 1 reply; 17+ messages in thread
From: Daniel Laird @ 2009-01-27  8:25 UTC (permalink / raw)
  To: buildroot


Webkit does not rely on X either, I have building just on top of GTK and DirectFB.

Although I do have a slightly newer version of webkit running.

Daniel Laird


> Date: Tue, 27 Jan 2009 11:27:32 +1100
> From: hamish at cloud.net.au
> To: buildroot at busybox.net; buildroot at uclibc.org
> Subject: Re: [Buildroot] svn commit: trunk/buildroot/package/webkit
> 
> On Fri, Jan 23, 2009 at 05:49:08PM +0000, ulf at uclibc.org wrote:
> > Author: ulf
> > Date: 2009-01-23 17:49:07 +0000 (Fri, 23 Jan 2009)
> > New Revision: 24983
> > 
> > Log:
> > Disable webkit (with comment) if X is not available
> > 
> > Modified:
> >    trunk/buildroot/package/webkit/Config.in
> > 
> > 
> > Changeset:
> > Modified: trunk/buildroot/package/webkit/Config.in
> > ===================================================================
> > --- trunk/buildroot/package/webkit/Config.in	2009-01-23 17:48:49 UTC (rev 24982)
> > +++ trunk/buildroot/package/webkit/Config.in	2009-01-23 17:49:07 UTC (rev 24983)
> > @@ -1,13 +1,18 @@
> >  config BR2_PACKAGE_WEBKIT
> >  	bool "webkit"
> > -	select BR2_PACKAGE_LIBGTK2
> >  	select BR2_PACKAGE_ICU
> >  	select BR2_PACKAGE_CURL
> >  	select BR2_PACKAGE_LIBXML2
> >  	select BR2_PACKAGE_LIBXSLT
> > +	select BR2_PACKAGE_LIBGTK2
> >  	select BR2_PACKAGE_SQLITE
> > +	depends on !BR2_PACKAGE_XSERVER_none
> 
> That's not a good test of X availability. You should check for X
> libraries only, as the X server may be remote.
> 
> Hamish
> -- 
> Hamish Moffatt VK3SB <hamish@debian.org> <hamish@cloud.net.au>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

_________________________________________________________________
Check out the new and improved services from Windows Live. Learn more! 
http://clk.atdmt.com/UKM/go/132630768/direct/01/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.busybox.net/pipermail/buildroot/attachments/20090127/7d978ab8/attachment.htm 

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/webkit
  2009-01-27  8:25   ` Daniel Laird
@ 2009-01-27  8:57     ` Peter Korsgaard
  2009-01-27 10:15       ` Daniel James Laird
  0 siblings, 1 reply; 17+ messages in thread
From: Peter Korsgaard @ 2009-01-27  8:57 UTC (permalink / raw)
  To: buildroot

>>>>> "Daniel" == Daniel Laird <danieljlaird@hotmail.com> writes:

 Daniel> Webkit does not rely on X either, I have building just on top
 Daniel> of GTK and DirectFB.

Ahh ok. Will you fix the Kconfig stuff or should I?

 Daniel> Although I do have a slightly newer version of webkit running.

Please update the package *AFTER* the release.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/webkit
  2009-01-27  8:57     ` Peter Korsgaard
@ 2009-01-27 10:15       ` Daniel James Laird
  2009-01-27 15:06         ` Peter Korsgaard
  0 siblings, 1 reply; 17+ messages in thread
From: Daniel James Laird @ 2009-01-27 10:15 UTC (permalink / raw)
  To: buildroot

Feel free to remove the X dependency,
I was intending to update webkit after release......

Cheers
Dan

-----Original Message-----
From: Peter Korsgaard [mailto:jacmet at gmail.com] On Behalf Of Peter Korsgaard
Sent: 2009 Jan 27 08:57
To: Daniel Laird
Cc: hamish at cloud.net.au; buildroot at busybox.net; buildroot at uclibc.org
Subject: Re: [Buildroot] svn commit: trunk/buildroot/package/webkit

>>>>> "Daniel" == Daniel Laird <danieljlaird@hotmail.com> writes:

 Daniel> Webkit does not rely on X either, I have building just on top
 Daniel> of GTK and DirectFB.

Ahh ok. Will you fix the Kconfig stuff or should I?

 Daniel> Although I do have a slightly newer version of webkit running.

Please update the package *AFTER* the release.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/webkit
@ 2009-01-27 15:02 jacmet at uclibc.org
  0 siblings, 0 replies; 17+ messages in thread
From: jacmet at uclibc.org @ 2009-01-27 15:02 UTC (permalink / raw)
  To: buildroot

Author: jacmet
Date: 2009-01-27 15:02:13 +0000 (Tue, 27 Jan 2009)
New Revision: 25075

Log:
webkit: revert r24983 (Disable webkit (with comment) if X is not available)

Webkit doesn't need X.

Modified:
   trunk/buildroot/package/webkit/Config.in


Changeset:
Modified: trunk/buildroot/package/webkit/Config.in
===================================================================
--- trunk/buildroot/package/webkit/Config.in	2009-01-27 12:56:33 UTC (rev 25074)
+++ trunk/buildroot/package/webkit/Config.in	2009-01-27 15:02:13 UTC (rev 25075)
@@ -1,18 +1,13 @@
 config BR2_PACKAGE_WEBKIT
 	bool "webkit"
+	select BR2_PACKAGE_LIBGTK2
 	select BR2_PACKAGE_ICU
 	select BR2_PACKAGE_CURL
 	select BR2_PACKAGE_LIBXML2
 	select BR2_PACKAGE_LIBXSLT
-	select BR2_PACKAGE_LIBGTK2
 	select BR2_PACKAGE_SQLITE
-	depends on !BR2_PACKAGE_XSERVER_none
 	help
 		WebKit is an open source, standards compliant web browser engine.
-		It runs on top of X-Windows
 
 		http://webkit.org/
 
-comment "webkit       - disabled (requires X-Windows)"
-	depends on BR2_PACKAGE_XSERVER_none
-

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/webkit
@ 2009-01-27 15:02 jacmet at uclibc.org
  0 siblings, 0 replies; 17+ messages in thread
From: jacmet at uclibc.org @ 2009-01-27 15:02 UTC (permalink / raw)
  To: buildroot

Author: jacmet
Date: 2009-01-27 15:02:40 +0000 (Tue, 27 Jan 2009)
New Revision: 25080

Log:
webkit: don't depend on X server

Modified:
   trunk/buildroot/package/webkit/webkit.mk


Changeset:
Modified: trunk/buildroot/package/webkit/webkit.mk
===================================================================
--- trunk/buildroot/package/webkit/webkit.mk	2009-01-27 15:02:34 UTC (rev 25079)
+++ trunk/buildroot/package/webkit/webkit.mk	2009-01-27 15:02:40 UTC (rev 25080)
@@ -12,7 +12,7 @@
 WEBKIT_INSTALL_STAGING_OPT = DESTDIR=$(STAGING_DIR) install
 
 WEBKIT_AUTORECONF = YES
-WEBKIT_DEPENDENCIES = icu curl libxml2 libxslt xserver_xorg-server libgtk2 sqlite
+WEBKIT_DEPENDENCIES = icu curl libxml2 libxslt libgtk2 sqlite
 WEBKIT_MAKE_OPT = GLIB_GENMARSHAL=$(HOST_GLIB)/bin/glib-genmarshal GLIB_MKENUMS=$(HOST_GLIB)/bin/glib-mkenums
 
 $(eval $(call AUTOTARGETS,package,webkit))

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/webkit
  2009-01-27 10:15       ` Daniel James Laird
@ 2009-01-27 15:06         ` Peter Korsgaard
  0 siblings, 0 replies; 17+ messages in thread
From: Peter Korsgaard @ 2009-01-27 15:06 UTC (permalink / raw)
  To: buildroot

>>>>> "Daniel" == Daniel James Laird <daniel.j.laird@nxp.com> writes:

 Daniel> Feel free to remove the X dependency,
 Daniel> I was intending to update webkit after release......

Done. Are you able to compile it with gcc 4.3.2? The version we have
in svn seems to die for me with:

./WebCore/bridge/npapi.h:252: error: expected ';' before '*' token
./WebCore/bridge/npapi.h:253: error: 'Colormap' does not name a type
./WebCore/bridge/npapi.h:452: error: 'XEvent' does not name a type
./WebCore/bridge/npapi.h:473: error: 'Region' does not name a type
./WebCore/bridge/npapi.h:705: error: 'NPRegion' has not been declared
In file included from ./WebCore/bridge/npruntime_internal.h:29,
                 from ./WebCore/plugins/PluginPackage.h:35,
                 from ./WebCore/plugins/PluginDatabase.h:31,
                 from WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:37:
./WebCore/plugins/npfunctions.h:57: error: 'NPRegion' has not been declared

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/webkit
@ 2009-01-27 15:10 jacmet at uclibc.org
  2009-01-28  7:10 ` Hans-Christian Egtvedt
  0 siblings, 1 reply; 17+ messages in thread
From: jacmet at uclibc.org @ 2009-01-27 15:10 UTC (permalink / raw)
  To: buildroot

Author: jacmet
Date: 2009-01-27 15:10:08 +0000 (Tue, 27 Jan 2009)
New Revision: 25081

Log:
webkit: depend on C++ + wchar support in toolkit, as icu needs it

Modified:
   trunk/buildroot/package/webkit/Config.in


Changeset:
Modified: trunk/buildroot/package/webkit/Config.in
===================================================================
--- trunk/buildroot/package/webkit/Config.in	2009-01-27 15:02:40 UTC (rev 25080)
+++ trunk/buildroot/package/webkit/Config.in	2009-01-27 15:10:08 UTC (rev 25081)
@@ -1,5 +1,7 @@
 config BR2_PACKAGE_WEBKIT
 	bool "webkit"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_USE_WCHAR
 	select BR2_PACKAGE_LIBGTK2
 	select BR2_PACKAGE_ICU
 	select BR2_PACKAGE_CURL
@@ -11,3 +13,5 @@
 
 		http://webkit.org/
 
+comment "webkit requires a toolchain with C++ support and WCHAR enabled"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/webkit
  2009-01-27 15:10 [Buildroot] svn commit: trunk/buildroot/package/webkit jacmet at uclibc.org
@ 2009-01-28  7:10 ` Hans-Christian Egtvedt
  2009-01-28  7:58   ` Peter Korsgaard
  0 siblings, 1 reply; 17+ messages in thread
From: Hans-Christian Egtvedt @ 2009-01-28  7:10 UTC (permalink / raw)
  To: buildroot

On Tue, 27 Jan 2009 15:10:09 +0000 (UTC)
jacmet at uclibc.org wrote:

<snipp>

> --- trunk/buildroot/package/webkit/Config.in	2009-01-27
> 15:02:40 UTC (rev 25080) +++
> trunk/buildroot/package/webkit/Config.in	2009-01-27 15:10:08
> UTC (rev 25081) @@ -1,5 +1,7 @@ config BR2_PACKAGE_WEBKIT
>  	bool "webkit"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_USE_WCHAR

Do you need C++/WCHAR for webkit as well, or only icu? If it is only
icu then should not kconfig take care of this dependency since
selecting icu package will not be possible?

>  	select BR2_PACKAGE_LIBGTK2
>  	select BR2_PACKAGE_ICU
>  	select BR2_PACKAGE_CURL
> @@ -11,3 +13,5 @@
>  
>  		http://webkit.org/
>  
> +comment "webkit requires a toolchain with C++ support and WCHAR
> enabled"
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
> 

And then make a depends on package icu instead?

-- 
Best regards,
Hans-Christian Egtvedt

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/webkit
  2009-01-28  7:10 ` Hans-Christian Egtvedt
@ 2009-01-28  7:58   ` Peter Korsgaard
  2009-01-28  8:06     ` Hans-Christian Egtvedt
  0 siblings, 1 reply; 17+ messages in thread
From: Peter Korsgaard @ 2009-01-28  7:58 UTC (permalink / raw)
  To: buildroot

>>>>> "Hans-Christian" == Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> writes:

Hi,

 >> --- trunk/buildroot/package/webkit/Config.in	2009-01-27
 >> 15:02:40 UTC (rev 25080) +++
 >> trunk/buildroot/package/webkit/Config.in	2009-01-27 15:10:08
 >> UTC (rev 25081) @@ -1,5 +1,7 @@ config BR2_PACKAGE_WEBKIT
 >> bool "webkit"
 >> +	depends on BR2_INSTALL_LIBSTDCPP
 >> +	depends on BR2_USE_WCHAR

 Hans-Christian> Do you need C++/WCHAR for webkit as well, or only
 Hans-Christian> icu? If it is only icu then should not kconfig take
 Hans-Christian> care of this dependency since selecting icu package
 Hans-Christian> will not be possible?

Well, you could certainly argue that it should, but the fact is that
Kconfig doesn't take dependencies into consideration when it handles
selects, E.G. nothing stops you from select'ing a package with
unforfilled deps.

Webkit is furthermore C++ code, so that part is atleast correct.

 >> select BR2_PACKAGE_LIBGTK2
 >> select BR2_PACKAGE_ICU
 >> select BR2_PACKAGE_CURL
 >> @@ -11,3 +13,5 @@
 >> 
 >> http://webkit.org/
 >> 
 >> +comment "webkit requires a toolchain with C++ support and WCHAR
 >> enabled"
 >> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
 >> 

 Hans-Christian> And then make a depends on package icu instead?

No, I don't think hiding applications until you by accident manages to
enable all the required libraries is a good idea.

Applications should select their library dependencies and depend (with
a comment) on toolchain features.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/webkit
  2009-01-28  7:58   ` Peter Korsgaard
@ 2009-01-28  8:06     ` Hans-Christian Egtvedt
  2009-01-28  8:14       ` Peter Korsgaard
  0 siblings, 1 reply; 17+ messages in thread
From: Hans-Christian Egtvedt @ 2009-01-28  8:06 UTC (permalink / raw)
  To: buildroot

On Wed, 28 Jan 2009 08:58:09 +0100
Peter Korsgaard <jacmet@uclibc.org> wrote:

> >>>>> "Hans-Christian" == Hans-Christian Egtvedt
> >>>>> <hans-christian.egtvedt@atmel.com> writes:
> 
> Hi,
> 
>  >> --- trunk/buildroot/package/webkit/Config.in	2009-01-27
>  >> 15:02:40 UTC (rev 25080) +++
>  >> trunk/buildroot/package/webkit/Config.in	2009-01-27
>  >> 15:10:08 UTC (rev 25081) @@ -1,5 +1,7 @@ config BR2_PACKAGE_WEBKIT
>  >> bool "webkit"
>  >> +	depends on BR2_INSTALL_LIBSTDCPP
>  >> +	depends on BR2_USE_WCHAR
> 
>  Hans-Christian> Do you need C++/WCHAR for webkit as well, or only
>  Hans-Christian> icu? If it is only icu then should not kconfig take
>  Hans-Christian> care of this dependency since selecting icu package
>  Hans-Christian> will not be possible?
> 
> Well, you could certainly argue that it should, but the fact is that
> Kconfig doesn't take dependencies into consideration when it handles
> selects, E.G. nothing stops you from select'ing a package with
> unforfilled deps.
> 

Ah, then the depends on makes sense. There should be some comment about
why WCHAR is a dependency since webkit seems to not need it.

> Webkit is furthermore C++ code, so that part is atleast correct.
> 

Okay

>  >> select BR2_PACKAGE_LIBGTK2
>  >> select BR2_PACKAGE_ICU
>  >> select BR2_PACKAGE_CURL
>  >> @@ -11,3 +13,5 @@
>  >> 
>  >> http://webkit.org/
>  >> 
>  >> +comment "webkit requires a toolchain with C++ support and WCHAR
>  >> enabled"
>  >> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
>  >> 
> 
>  Hans-Christian> And then make a depends on package icu instead?
> 
> No, I don't think hiding applications until you by accident manages to
> enable all the required libraries is a good idea.
> 
> Applications should select their library dependencies and depend (with
> a comment) on toolchain features.
> 

Then I agree that it has to be done like this.

-- 
Best regards,
Hans-Christian Egtvedt

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/webkit
  2009-01-28  8:06     ` Hans-Christian Egtvedt
@ 2009-01-28  8:14       ` Peter Korsgaard
  2009-01-28  8:19         ` Hans-Christian Egtvedt
  0 siblings, 1 reply; 17+ messages in thread
From: Peter Korsgaard @ 2009-01-28  8:14 UTC (permalink / raw)
  To: buildroot

>>>>> "Hans-Christian" == Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> writes:

Hi,

 Hans-Christian> Ah, then the depends on makes sense. There should be
 Hans-Christian> some comment about why WCHAR is a dependency since
 Hans-Christian> webkit seems to not need it.

Sure? Ever tried compiling it without WCHAR? ;)

But yes, we could note that the wchar dependency is because it does
unicode stuff using the icu library.

Notice that I can't actually get webkit to build, atleast not with gcc
4.3.2 (We my mail to Daniel yesterday), so maybe we should bump the
version before the release.

 >> Applications should select their library dependencies and depend (with
 >> a comment) on toolchain features.

 Hans-Christian> Then I agree that it has to be done like this.

Ok, good.


-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/webkit
  2009-01-28  8:14       ` Peter Korsgaard
@ 2009-01-28  8:19         ` Hans-Christian Egtvedt
  2009-01-28  8:30           ` Peter Korsgaard
  0 siblings, 1 reply; 17+ messages in thread
From: Hans-Christian Egtvedt @ 2009-01-28  8:19 UTC (permalink / raw)
  To: buildroot

On Wed, 28 Jan 2009 09:14:28 +0100
Peter Korsgaard <jacmet@uclibc.org> wrote:

>  Hans-Christian> Ah, then the depends on makes sense. There should be
>  Hans-Christian> some comment about why WCHAR is a dependency since
>  Hans-Christian> webkit seems to not need it.
> 
> Sure? Ever tried compiling it without WCHAR? ;)
> 

Qt uses webkit, and AFAIK compiles without WCHAR enabled.

> But yes, we could note that the wchar dependency is because it does
> unicode stuff using the icu library.
> 
> Notice that I can't actually get webkit to build, atleast not with gcc
> 4.3.2 (We my mail to Daniel yesterday), so maybe we should bump the
> version before the release.
> 

FWIW webkit in Qt 4.5 builds with the AVR32 toolchain (gcc 4.2.2 +
vendor patch).

-- 
Best regards,
Hans-Christian Egtvedt

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/webkit
  2009-01-28  8:19         ` Hans-Christian Egtvedt
@ 2009-01-28  8:30           ` Peter Korsgaard
  2009-01-28  8:39             ` Hans-Christian Egtvedt
  0 siblings, 1 reply; 17+ messages in thread
From: Peter Korsgaard @ 2009-01-28  8:30 UTC (permalink / raw)
  To: buildroot

>>>>> "Hans-Christian" == Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> writes:

 >> Sure? Ever tried compiling it without WCHAR? ;)
 >> 

 Hans-Christian> Qt uses webkit, and AFAIK compiles without WCHAR enabled.

How? Without using libicu? I know close to nothing about webkit.

 Hans-Christian> FWIW webkit in Qt 4.5 builds with the AVR32 toolchain
 Hans-Christian> (gcc 4.2.2 + vendor patch).

The webkit version we have in BR (some svn nightly) most likely also
built at some time, but I know from other C++ projects that gcc 4.3.x
cleaned up quite some stuff and got more strict.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] svn commit: trunk/buildroot/package/webkit
  2009-01-28  8:30           ` Peter Korsgaard
@ 2009-01-28  8:39             ` Hans-Christian Egtvedt
  0 siblings, 0 replies; 17+ messages in thread
From: Hans-Christian Egtvedt @ 2009-01-28  8:39 UTC (permalink / raw)
  To: buildroot

On Wed, 28 Jan 2009 09:30:29 +0100
Peter Korsgaard <jacmet@uclibc.org> wrote:

> >>>>> "Hans-Christian" == Hans-Christian Egtvedt
> >>>>> <hans-christian.egtvedt@atmel.com> writes:
> 
>  >> Sure? Ever tried compiling it without WCHAR? ;)
>  >> 
> 
>  Hans-Christian> Qt uses webkit, and AFAIK compiles without WCHAR
> enabled.
> 
> How? Without using libicu? I know close to nothing about webkit.
> 

I dunno, black Qt fuu I guess.

cat qt-embedded-linux-opensource-src-4.4.3/src/3rdparty/webkit/VERSION
This is a snapshot of the Qt port of WebKit from

        git://code.staikos.net/webkit

The commit imported was from the

        origin/qtwebkit-merged-into-qt-4-4 branch/tag

and has the sha1 checksum

        bf04f19228d9968ede068745fd4ec4902c9f9786

>  Hans-Christian> FWIW webkit in Qt 4.5 builds with the AVR32 toolchain
>  Hans-Christian> (gcc 4.2.2 + vendor patch).
> 
> The webkit version we have in BR (some svn nightly) most likely also
> built at some time, but I know from other C++ projects that gcc 4.3.x
> cleaned up quite some stuff and got more strict.
> 

Ah, okay, explains why 4.2.x does not have a problem.

-- 
Best regards,
Hans-Christian Egtvedt

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2009-01-28  8:39 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-27 15:10 [Buildroot] svn commit: trunk/buildroot/package/webkit jacmet at uclibc.org
2009-01-28  7:10 ` Hans-Christian Egtvedt
2009-01-28  7:58   ` Peter Korsgaard
2009-01-28  8:06     ` Hans-Christian Egtvedt
2009-01-28  8:14       ` Peter Korsgaard
2009-01-28  8:19         ` Hans-Christian Egtvedt
2009-01-28  8:30           ` Peter Korsgaard
2009-01-28  8:39             ` Hans-Christian Egtvedt
  -- strict thread matches above, loose matches on Subject: below --
2009-01-27 15:02 jacmet at uclibc.org
2009-01-27 15:02 jacmet at uclibc.org
2009-01-23 17:49 ulf at uclibc.org
2009-01-27  0:27 ` Hamish Moffatt
2009-01-27  8:25   ` Daniel Laird
2009-01-27  8:57     ` Peter Korsgaard
2009-01-27 10:15       ` Daniel James Laird
2009-01-27 15:06         ` Peter Korsgaard
2008-04-24 13:22 ninevoltz at uclibc.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox