[Buildroot] [PATCH] package/esp-hosted: fix build failure on s390x

[Buildroot] [PATCH] package/esp-hosted: fix build failure on s390x

[Giulio Benetti]

s390x doesn't support Wi-Fi on Linux so let's disable the package for such
architecture.

Fixes:
http://autobuild.buildroot.net/results/f52e8a14330ff281a7096baa47f387f8c1859345

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/esp-hosted/Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/esp-hosted/Config.in b/package/esp-hosted/Config.in
index 43c802fa44..42e1afa8c5 100644
--- a/package/esp-hosted/Config.in
+++ b/package/esp-hosted/Config.in
@@ -1,8 +1,10 @@
 comment "esp-hosted needs a Linux kernel to be built"
+	depends on !BR2_s390x
 	depends on !BR2_LINUX_KERNEL
 
 config BR2_PACKAGE_ESP_HOSTED
 	bool "esp-hosted"
+	depends on !BR2_s390x
 	depends on BR2_LINUX_KERNEL
 	help
 	  This package builds and installs the Linux kernel driver for
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/esp-hosted: fix build failure on s390x

[Arnout Vandecappelle via buildroot]

On 21/09/2023 13:10, Giulio Benetti wrote:
> s390x doesn't support Wi-Fi on Linux so let's disable the package for such
> architecture.
> 
> Fixes:
> http://autobuild.buildroot.net/results/f52e8a14330ff281a7096baa47f387f8c1859345
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/esp-hosted/Config.in | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/package/esp-hosted/Config.in b/package/esp-hosted/Config.in
> index 43c802fa44..42e1afa8c5 100644
> --- a/package/esp-hosted/Config.in
> +++ b/package/esp-hosted/Config.in
> @@ -1,8 +1,10 @@
>   comment "esp-hosted needs a Linux kernel to be built"
> +	depends on !BR2_s390x
>   	depends on !BR2_LINUX_KERNEL
>   
>   config BR2_PACKAGE_ESP_HOSTED
>   	bool "esp-hosted"
> +	depends on !BR2_s390x
>   	depends on BR2_LINUX_KERNEL
>   	help
>   	  This package builds and installs the Linux kernel driver for
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/esp-hosted: fix build failure on s390x

[Yann E. MORIN]

guilio, All,

On 2023-09-21 13:10 +0200, Giulio Benetti spake thusly:
> s390x doesn't support Wi-Fi on Linux so let's disable the package for such
> architecture.

So, your tile is wrong: it is not *fixing* a build failure of the package;
it excludes it for s390x.

But too late, it's already applied..


Regards,
Yann E. MORIN.

> Fixes:
> http://autobuild.buildroot.net/results/f52e8a14330ff281a7096baa47f387f8c1859345
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/esp-hosted/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/esp-hosted/Config.in b/package/esp-hosted/Config.in
> index 43c802fa44..42e1afa8c5 100644
> --- a/package/esp-hosted/Config.in
> +++ b/package/esp-hosted/Config.in
> @@ -1,8 +1,10 @@
>  comment "esp-hosted needs a Linux kernel to be built"
> +	depends on !BR2_s390x
>  	depends on !BR2_LINUX_KERNEL
>  
>  config BR2_PACKAGE_ESP_HOSTED
>  	bool "esp-hosted"
> +	depends on !BR2_s390x
>  	depends on BR2_LINUX_KERNEL
>  	help
>  	  This package builds and installs the Linux kernel driver for
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/esp-hosted: fix build failure on s390x

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > s390x doesn't support Wi-Fi on Linux so let's disable the package for such
 > architecture.

 > Fixes:
 > http://autobuild.buildroot.net/results/f52e8a14330ff281a7096baa47f387f8c1859345

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Committed to 2023.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot